Re: #9794: inset-modify tabular commands are incorrectly disabled

On 01/28/2016 07:11 AM, Kornel Benko wrote: > Am Donnerstag, 28. Januar 2016 um 13:03:02, schrieb Jean-Marc Lasgouttes > >> Le 27/01/2016 18:55, Guillaume Munch a écrit : >>> I > have found the motivation to re-do the format increase and the patches >>> are now committed. >>

Re: #9794: inset-modify tabular commands are incorrectly disabled

Kornel Benko wrote: > Am Donnerstag, 28. Januar 2016 um 13:03:02, schrieb Jean-Marc Lasgouttes > >> Le 27/01/2016 18:55, Guillaume Munch a écrit : >> > I have found the motivation to re-do the format increase and the >> > patches are now committed. >> >> Congratulation for

Re: #9794: inset-modify tabular commands are incorrectly disabled

Am Donnerstag, 28. Januar 2016 um 13:03:02, schrieb Jean-Marc Lasgouttes > Le 27/01/2016 18:55, Guillaume Munch a écrit : > > I have found the motivation to re-do the format increase and the patches > > are now committed. > > Congratulation for your persistence. +1 > JMarc

Re: #9794: inset-modify tabular commands are incorrectly disabled

Le 27/01/2016 18:55, Guillaume Munch a écrit : I have found the motivation to re-do the format increase and the patches are now committed. Congratulation for your persistence. JMarc

Re: #9794: inset-modify tabular commands are incorrectly disabled

Le 26/01/2016 09:50, Jean-Marc Lasgouttes a écrit : Le 25/01/2016 21:17, Guillaume Munch a écrit : I had done this at first but then I thought that the difference in properties at-point/not-at-point could result in differences. By reading it again, with hindsight, of course this makes no

Re: #9794: inset-modify tabular commands are incorrectly disabled

Le 25/01/2016 21:17, Guillaume Munch a écrit : I had done this at first but then I thought that the difference in properties at-point/not-at-point could result in differences. By reading it again, with hindsight, of course this makes no difference, so I will be happy to get rid of the trick

Re: #9794: inset-modify tabular commands are incorrectly disabled

Le 11/01/2016 18:54, Guillaume Munch a écrit : Attached takes all comments into account. I hope the additional explanations help. OK, let's go through the patches again. I am sorry this is taking so much time. 0001: a few remarks/questions: - I still do not understand why the dialog,

Re: #9794: inset-modify tabular commands are incorrectly disabled

Le 25/01/2016 15:04, Jean-Marc Lasgouttes a écrit : Le 11/01/2016 18:54, Guillaume Munch a écrit : Attached takes all comments into account. I hope the additional explanations help. OK, let's go through the patches again. I am sorry this is taking so much time. 0001: a few remarks/questions:

Re: #9794: inset-modify tabular commands are incorrectly disabled

Dear list, We need to reach a conclusion on this to open the way for beta. It seems we have come a long way on this series of patches so it would be nice to know whether people who have participated in the discussion and asked for modifications let us know whether they intend to let me go ahead

Re: #9794: inset-modify tabular commands are incorrectly disabled

Scott Kostyshak wrote: > > Scott, you might want to look over changes in LFUNs API in LyXAction.cpp > > during 2.2dev cycle if we meant this conversion seriously. > > Which conversion? I don't understand. What specifically should I look > at? I would say check git log -p LyXAction.cpp during 2.2

Re: #9794: inset-modify tabular commands are incorrectly disabled

On Mon, Jan 18, 2016 at 01:45:58PM -0800, Pavel Sanda wrote: > Scott Kostyshak wrote: > > > Scott, you might want to look over changes in LFUNs API in LyXAction.cpp > > > during 2.2dev cycle if we meant this conversion seriously. > > > > Which conversion? I don't understand. What specifically

Re: #9794: inset-modify tabular commands are incorrectly disabled

On Wed, Jan 13, 2016 at 03:23:12PM -0800, Pavel Sanda wrote: > Guillaume Munch wrote: > Scott, you might want to look over changes in LFUNs API in LyXAction.cpp > during 2.2dev cycle if we meant this conversion seriously. Which conversion? I don't understand. What specifically should I look at?

Re: #9794: inset-modify tabular commands are incorrectly disabled

Le 14/01/2016 20:56, Georg Baum a écrit : Georg Baum wrote: Guillaume Munch wrote: Le 11/01/2016 14:23, Jean-Marc Lasgouttes a écrit : 0004: not my area of expertise Then I rely on Georg for this one. I already wrote that the lyx2lyx and prefs2prefs changes are OK, so you have my +1

Re: #9794: inset-modify tabular commands are incorrectly disabled

Guillaume Munch wrote: > Le 11/01/2016 14:23, Jean-Marc Lasgouttes a écrit : > >> 0004: not my area of expertise > > Then I rely on Georg for this one. I already wrote that the lyx2lyx and prefs2prefs changes are OK, so you have my +1 for this one. Georg

Re: #9794: inset-modify tabular commands are incorrectly disabled

Georg Baum wrote: > Guillaume Munch wrote: > >> Le 11/01/2016 14:23, Jean-Marc Lasgouttes a écrit : >> >>> 0004: not my area of expertise >> >> Then I rely on Georg for this one. > > I already wrote that the lyx2lyx and prefs2prefs changes are OK, so you > have my +1 for this one. To

Re: #9794: inset-modify tabular commands are incorrectly disabled

Guillaume Munch wrote: > Le 12/01/2016 01:42, Pavel Sanda a écrit : >> Guillaume Munch wrote: >>> Actually yes I am documenting a new rule, but it isn't mine. The new >>> rule requires a LFUN format increment and a LyX format increment >> >> Do you have by chance link to LFUN format increment

Re: #9794: inset-modify tabular commands are incorrectly disabled

Le 12/01/2016 01:42, Pavel Sanda a écrit : Guillaume Munch wrote: Actually yes I am documenting a new rule, but it isn't mine. The new rule requires a LFUN format increment and a LyX format increment Do you have by chance link to LFUN format increment discussion at hand? (I have no clue what

Re: #9794: inset-modify tabular commands are incorrectly disabled

Guillaume Munch wrote: > Actually yes I am documenting a new rule, but it isn't mine. The new > rule requires a LFUN format increment and a LyX format increment Do you have by chance link to LFUN format increment discussion at hand? (I have no clue what is meant by LFUN format number). P

Re: #9794: inset-modify tabular commands are incorrectly disabled

On Mon, Jan 11, 2016 at 06:12:01PM +, Guillaume Munch wrote: > the LyX format. There is an agreement from Georg, Jean-Marc and Richard; > and I did not see any opposition to this rule during the discussion of > this requirement for my patch. Please go ahead then. Thanks for being so careful.

Re: #9794: inset-modify tabular commands are incorrectly disabled

Le 08/01/2016 23:22, Guillaume Munch a écrit : Thank you, waiting for Jean-Marc's opinion then. A few comments on the patches. I was not able to apply them using "git am" I am not sure how they were produced. 0001: * fix the log title (.sh, not .py) 0002: * be careful to update the

Re: #9794: inset-modify tabular commands are incorrectly disabled

Le 08/01/2016 22:26, Scott Kostyshak a écrit : On Fri, Jan 08, 2016 at 11:06:04PM +0100, Georg Baum wrote: Guillaume Munch wrote: Also, because it took me a while to figure out where the bind and ui format was defined. Nothing was documented. (Is there a maintainer for Development.lyx who

Re: #9794: inset-modify tabular commands are incorrectly disabled

Guillaume Munch wrote: > So I can chmod +x all the scripts? This cannot harm, so +1 from me (for every script in development/tools/). Georg

Re: #9794: inset-modify tabular commands are incorrectly disabled

Le 08/01/2016 08:01, Guillaume Munch a écrit : Ok, this is what I did. The last patch contains a minor rephrasing that I did not try to compile before showing it to you, because it was straightforward and unrelated to anything we had discussed (isTable is now defined as a whitelist and not

Re: #9794: inset-modify tabular commands are incorrectly disabled

On Fri, Jan 08, 2016 at 11:06:04PM +0100, Georg Baum wrote: > Guillaume Munch wrote: > > Also, because it took me a while to > > figure out where the bind and ui format was defined. Nothing was > > documented. (Is there a maintainer for Development.lyx who will validate > > the CT'd changes?) >

Re: #9794: inset-modify tabular commands are incorrectly disabled

Le 08/01/2016 22:06, Georg Baum a écrit : It cannot see anything wrong. There is no maintainer for Development.lyx. Because of that and since it is not supposed to be translated you don't need CT for this document IMHO. Ok Looks good (lyx2lyx and prefs2prefs, I did not follow the original

Re: #9794: inset-modify tabular commands are incorrectly disabled

Guillaume Munch wrote: > > To be honest, I did not even know that this existed until recently > because there was no UI for it. This requirement seems very > abstract to me. But I have updated Development.lyx to reflect the > new policy to be sure everybody else is going to respect it. Feel free

Re: #9794: inset-modify tabular commands are incorrectly disabled

Le 08/01/2016 21:47, Georg Baum a écrit : Is there a reason why the scripts do not have exec permissions? I guess it is lazyness. I would not spend any time in non-python scripts, but convert them to python if problems occur. So I can chmod +x all the scripts? Guillaume

Re: #9794: inset-modify tabular commands are incorrectly disabled

Guillaume Munch wrote: > So I can chmod +x all the scripts? Looks like good idea. P

Re: #9794: inset-modify tabular commands are incorrectly disabled

Guillaume Munch wrote: > Le 07/01/2016 22:09, Guillaume Munch a écrit : >> Le 03/01/2016 09:46, Georg Baum a écrit : >>> We have a script for updating the docs, examples and templates >>> (development/tools/updatedocs.py), and one for updating the ui and bind >>> files

Re: #9794: inset-modify tabular commands are incorrectly disabled

Le 07/01/2016 22:09, Guillaume Munch a écrit : Le 03/01/2016 09:46, Georg Baum a écrit : We have a script for updating the docs, examples and templates (development/tools/updatedocs.py), and one for updating the ui and bind files (development/tools/updatelfuns.sh). Or did you man something

Re: #9794: inset-modify tabular commands are incorrectly disabled

Le 03/01/2016 09:46, Georg Baum a écrit : We have a script for updating the docs, examples and templates (development/tools/updatedocs.py), and one for updating the ui and bind files (development/tools/updatelfuns.sh). Or did you man something else? Is there a reason why the scripts do not

Re: #9794: inset-modify tabular commands are incorrectly disabled

Guillaume Munch wrote: > The Python code in prefs2prefs_lfuns.lyx is going to be > > def conv_tabular_features(line): > line = simple_renaming(line, "inset-modify tabular from-dialog", > "inset-modify tabular") > return simple_renaming(line, "inset-modify tabular", "tabular-feature") > > > If

Re: #9794: inset-modify tabular commands are incorrectly disabled

Le 03/01/2016 23:57, Guillaume Munch a écrit : Le 03/01/2016 22:26, Richard Heck a écrit : If you want to update it programmatically, I thought this was your and Jean-Marc's idea. My only interest in this is making sure that things are done in the correct way. Yes, this is a suggestion that

Re: #9794: inset-modify tabular commands are incorrectly disabled

Ticket Tracker a écrit : #9794: inset-modify tabular commands are incorrectly disabled -+- Reporter: gadmm| Owner: lasgouttes Type: defect | Status: new

Re: #9794: inset-modify tabular commands are incorrectly disabled

>>> Le 29/12/2015 00:27, LyX Ticket Tracker a écrit : >>>> #9794: inset-modify tabular commands are incorrectly disabled >>>> -+- >>>>Reporter: gadmm

Re: #9794: inset-modify tabular commands are incorrectly disabled

Guillaume Munch wrote: > Regarding http://www.lyx.org/trac/ticket/9794, I had two questions below > before making the requested changes: > > Le 29/12/2015 00:27, LyX Ticket Tracker a écrit : >> #9794: inset-modify tabular commands are in

Re: #9794: inset-modify tabular commands are incorrectly disabled

On 01/03/2016 04:46 AM, Georg Baum wrote: > Guillaume Munch wrote: > >> Regarding http://www.lyx.org/trac/ticket/9794, I had two questions below >> before making the requested changes: >> >> Le 29/12/2015 00:27, LyX Ticket Tracker a écrit : >>> #9794: inset-

Re: #9794: inset-modify tabular commands are incorrectly disabled

Le 03/01/2016 09:46, Georg Baum a écrit : Guillaume Munch wrote: Regarding http://www.lyx.org/trac/ticket/9794, I had two questions below before making the requested changes: Le 29/12/2015 00:27, LyX Ticket Tracker a écrit : #9794: inset-modify tabular commands are incorrectly disabled

Re: #9794: inset-modify tabular commands are incorrectly disabled

Regarding http://www.lyx.org/trac/ticket/9794, I had two questions below before making the requested changes: Le 29/12/2015 00:27, LyX Ticket Tracker a écrit : #9794: inset-modify tabular commands are incorrectly disabled