Re: [RFC] doc: Proposal for LTE/IMS API.

Hi Rémi, >> - The QoS information is presented as an array of QoS settings with >>   an associated list IP Packet Filters. Only the QoS data for >>   connection context of type IMS will be reported. >> >>   The assumption is that QoS is only going to be used by IMS applications. >>   Initially I w

RE: SMS agent interface

Hello Marcel, I just checked, patches cleanly apply, compile and link with the current HEAD. Just let me to know if there will be any problem to apply them. Thanks! Regards, Oleg From: ofono-boun...@ofono.org [ofono-boun...@ofono.org] on behalf of ext M

[RFC] voicecallmanager-api: call related SS signals (proposal)

Here is a proposal for expanding VoiceCallManager's DBus interface with call related Supplementary Services signals. The implementation would be based on the functionality provided by the SSN atom (handling the CSSU codes). --- doc/voicecallmanager-api.txt | 54 +++

Re: [RFC] voicecallmanager-api: call related SS signals (proposal)

On Thursday 27 January 2011 12:20:50 ext Andras Domokos, you wrote: > Here is a proposal for expanding VoiceCallManager's DBus interface with > call related Supplementary Services signals. > The implementation would be based on the functionality provided by the SSN > atom (handling the CSSU codes).

[PATCH] n900: fix set online

Invalid MTC_STATE_REQ messages were sent, causing failures in going online. --- plugins/n900.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/n900.c b/plugins/n900.c index 5b3a496..3d27b58 100644 --- a/plugins/n900.c +++ b/plugins/n900.c @@ -448,7 +448,7 @@ stati

Re: [PATCH] n900: fix set online

Hi Kai, 2011/1/27 Kai Vehmanen : > Invalid MTC_STATE_REQ messages were sent, causing failures in going > online. > --- >  plugins/n900.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) Pushed, thanks! Cheers, Aki ___ ofono mailing list of

Re: Ofono has too tight limits for SIM lock code lengths

Hi Denis, On Thu, 2011-01-20 at 19:35 +0200, Denis Kenzior wrote: > The first option sounds reasonable to me as a first attempt. Care to > submit a proposal? > This seems to do the trick --- include/sim.h |1 + src/call-barring.c | 14 -- src/call-meter.c |4 ++--

Re: [RFC] voicecallmanager-api: call related SS signals (proposal)

Hi Andras, > Here is a proposal for expanding VoiceCallManager's DBus interface with > call related Supplementary Services signals. > The implementation would be based on the functionality provided by the SSN > atom (handling the CSSU codes). > > --- > doc/voicecallmanager-api.txt | 54 > ++

Re: Ofono has too tight limits for SIM lock code lengths

Hi Jussi, > --- > include/sim.h |1 + > src/call-barring.c | 14 -- > src/call-meter.c |4 ++-- > src/common.c | 29 - > src/common.h | 11 +++ > src/ofono.h|3 +++ > src/sim.c | 13 +++

Re: [RFC] doc: Proposal for LTE/IMS API.

Hi Sjur, > doc/ims-api.txt | 119 > +++ > 1 files changed, 119 insertions(+), 0 deletions(-) > create mode 100644 doc/ims-api.txt > > diff --git a/doc/ims-api.txt b/doc/ims-api.txt > new file mode 100644 > index 000..865413f > --- /dev/n

Re: [PATCH 6/9] oFono smsagent enhancements to permit more flexible parameter set to be dispatched.

Hi Oleg, > src/smsagent.h |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/src/smsagent.h b/src/smsagent.h > index 39513d6..348d36d 100644 > --- a/src/smsagent.h > +++ b/src/smsagent.h > @@ -31,6 +31,8 @@ typedef void (*sms_agent_dispatch_cb)(struct sms_agent > *

[PATCH 0/3] EF-SPN API to sim-atom

Hello Here is an asynchronous implementation of SIM Service Provider Name (EF-SPN) getter API. The trick is to delay setting sim ready until spn reading is finished. Patch to use the new API in netreg is included. --Jukka Jukka Saunamaki (3): sim: add ofono_sim_get_spn API header s

[PATCH 1/3] sim: add ofono_sim_get_spn API header

--- include/sim.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/sim.h b/include/sim.h index 5e3ba5b..7e573fd 100644 --- a/include/sim.h +++ b/include/sim.h @@ -180,6 +180,8 @@ void *ofono_sim_get_data(struct ofono_sim *sim); const char *ofono_sim_get_imsi(struc

[PATCH 3/3] netreg: use ofono_sim_get_spn()

--- src/network.c | 46 +++--- 1 files changed, 7 insertions(+), 39 deletions(-) diff --git a/src/network.c b/src/network.c index b5450ee..f602db4 100644 --- a/src/network.c +++ b/src/network.c @@ -1507,51 +1507,21 @@ static void sim_spdi_read_cb(int ok,

[PATCH 2/3] sim: add ofono_sim_get_spn API implementation

--- src/sim.c | 73 - 1 files changed, 72 insertions(+), 1 deletions(-) diff --git a/src/sim.c b/src/sim.c index 3c5db90..2c09c11 100644 --- a/src/sim.c +++ b/src/sim.c @@ -80,6 +80,8 @@ struct ofono_sim { char *imsi; c

RE: [RFC] doc: Proposal for LTE/IMS API.

Hi, On 27 Jan 2011, Marcel Holtmann wrote: >> +array{dict,array{dict}} QosFilters [readonly, optional] >> + >> +Information about the QoSes and associated Packet >> +Filters for the Default PDN and it's dedicated bearers. >> +

Re: [RFC] doc: Proposal for LTE/IMS API.

Hi Kai, >>> +            array{dict,array{dict}} QosFilters [readonly, optional] >>> + >>> +                    Information about the QoSes and associated Packet >>> +                    Filters for the Default PDN and it's dedicated bearers. >>> +                    It is organized as a list of Q

Re: [PATCH 1/3] sim: add ofono_sim_get_spn API header

Hi Jukka, > include/sim.h |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/sim.h b/include/sim.h > index 5e3ba5b..7e573fd 100644 > --- a/include/sim.h > +++ b/include/sim.h > @@ -180,6 +180,8 @@ void *ofono_sim_get_data(struct ofono_sim *sim); > const char

Re: [PATCH 1/3] sim: add ofono_sim_get_spn API header

Hi On Thu, 2011-01-27 at 14:56 +0100, ext Marcel Holtmann wrote: > > +const char *ofono_sim_get_spn(struct ofono_sim *sim); > > +unsigned char ofono_sim_get_spn_dc(struct ofono_sim *sim); > > what is the spn_dc for? We are converting everything into UTF-8 anyway > and that should be sufficient.

Re: Ofono has too tight limits for SIM lock code lengths

Hi Marcel, On Thu, 2011-01-27 at 15:09 +0200, Marcel Holtmann wrote: > so every single enum has kept some sort of proper namespacing. And I > would really prefer to not break this for ofono_sim_password_type. I suppose u are talking about parameter name here? and OFONO_PASSWORD_PIN_TYPE_NET is s

RE: [PATCH 6/9] oFono smsagent enhancements to permit more flexible parameter set to be dispatched.

Hello Marcel, That's in order to include the uuid (so we can correlate sms_send_pending and sms_send_status). Possibly, in order to include some other parameters, without affecting the other users of the sms_agent_dispatch_datagram(). Please take a look into the messaging_agent_sms_send_pending

[PATCH v2 0/4] bluetooth: Add bluetooth server support

It watches Bluetooth adapter property changes and adds SDP record to listen client connection request. It supports multiple adapters, servers and client connections. Use of GSList instead of GHashTable to store adapter path and address as we need to get address from adapter or vice-versa (during a

[PATCH 1/4] bluetooth: only use bluetooth_refcount in bluetooth_ref/bluetooth_unref

--- plugins/bluetooth.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 93dd7a1..e59bd31 100644 --- a/plugins/bluetooth.c +++ b/plugins/bluetooth.c @@ -505,7 +505,7 @@ static guint adapter_added_watch; static gu

[PATCH 2/4] bluetooth: use GSList instead of GHashTable to store adapter path/address

--- plugins/bluetooth.c | 86 +++--- 1 files changed, 74 insertions(+), 12 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index e59bd31..4da662a 100644 --- a/plugins/bluetooth.c +++ b/plugins/bluetooth.c @@ -39,9 +39,14 @@ stat

[PATCH 3/4] bluetooth: Add bluetooth server support

--- Makefile.am |1 + plugins/bluetooth.c | 340 +++ plugins/bluetooth.h |9 ++ 3 files changed, 350 insertions(+), 0 deletions(-) diff --git a/Makefile.am b/Makefile.am index 9b77e63..c0efe28 100644 --- a/Makefile.am +++ b/Makefile

[PATCH 4/4] bluetooth: add Bluetooth service authorization support

--- plugins/bluetooth.c | 136 +++--- 1 files changed, 127 insertions(+), 9 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 86d4c25..7e4dbc1 100644 --- a/plugins/bluetooth.c +++ b/plugins/bluetooth.c @@ -44,6 +44,8 @@ static G

Re: [PATCH 1/4] bluetooth: only use bluetooth_refcount in bluetooth_ref/bluetooth_unref

Hi Fred, > plugins/bluetooth.c | 14 +- > 1 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c > index 93dd7a1..e59bd31 100644 > --- a/plugins/bluetooth.c > +++ b/plugins/bluetooth.c > @@ -505,7 +505,7 @@ static guint adapter_a

Re: [PATCH 2/4] bluetooth: use GSList instead of GHashTable to store adapter path/address

Hi Fred, > plugins/bluetooth.c | 86 +++--- > 1 files changed, 74 insertions(+), 12 deletions(-) > > diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c > index e59bd31..4da662a 100644 > --- a/plugins/bluetooth.c > +++ b/plugins/bluetooth.c > @@ -

Re: [PATCH 2/4] bluetooth: use GSList instead of GHashTable to store adapter path/address

Le 27/01/2011 16:13, Marcel Holtmann a écrit : Hi Fred, plugins/bluetooth.c | 86 +++--- 1 files changed, 74 insertions(+), 12 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index e59bd31..4da662a 100644 --- a/plugins/blueto

Re: [PATCH 2/4] bluetooth: use GSList instead of GHashTable to store adapter path/address

Hi Fred, > >> plugins/bluetooth.c | 86 > >> +++--- > >> 1 files changed, 74 insertions(+), 12 deletions(-) > >> > >> diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c > >> index e59bd31..4da662a 100644 > >> --- a/plugins/bluetooth.c > >> +++

Re: [PATCH 1/4] bluetooth: only use bluetooth_refcount in bluetooth_ref/bluetooth_unref

Le 27/01/2011 16:12, Marcel Holtmann a écrit : Hi Fred, plugins/bluetooth.c | 14 +- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index 93dd7a1..e59bd31 100644 --- a/plugins/bluetooth.c +++ b/plugins/bluetooth.c @@ -50

Re: [PATCH 2/4] bluetooth: use GSList instead of GHashTable to store adapter path/address

Le 27/01/2011 16:24, Marcel Holtmann a écrit : Hi Fred, plugins/bluetooth.c | 86 +++--- 1 files changed, 74 insertions(+), 12 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index e59bd31..4da662a 100644 --- a/plugins/blue

Re: SAT support in oFono

On 01/24/2011 04:10 PM, Marcel Holtmann wrote: Hi Lasse, I am checking what is the level of SAT/STK support in ofono and have a couple of questions. The current implementation contains support for basic STK commands, like menus, inputs, calls, sms and so on. In TODO, there is only REFRESH co

Re: [RFC] voicecallmanager-api: call related SS signals (proposal)

Hi Marcel, On 01/27/2011 03:07 PM, ext Marcel Holtmann wrote: Hi Andras, Here is a proposal for expanding VoiceCallManager's DBus interface with call related Supplementary Services signals. The implementation would be based on the functionality provided by the SSN atom (handling the CSSU codes

Re: [RFC] voicecallmanager-api: call related SS signals (proposal)

Hi Andras, > This becomes a problem when there are multiple calls since it is not > possible to determine to which call instance the indication is referring > to. > This raises the question where/how to show this type of properties? Have you seen the thread from Pekka's previous attempt to defin

Re: SAT support in oFono

Hi Philippe, > We have checked with Jeewaka what are the conditions related to the STK > events 'User activity', 'idle screen available' and 'language selection'. > It appears that whatever is the release, once the device is supporting a > display and a keypad, those events are mandatory for GCF.

Re: [PATCH 1/4] bluetooth: only use bluetooth_refcount in bluetooth_ref/bluetooth_unref

* Frederic Danis [2011-01-27 16:25:16 +0100]: > Le 27/01/2011 16:12, Marcel Holtmann a écrit : > > Hi Fred, > > > >> plugins/bluetooth.c | 14 +- > >> 1 files changed, 9 insertions(+), 5 deletions(-) > >> > >> diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c > >> index 93dd

Re: [PATCH 1/4] bluetooth: only use bluetooth_refcount in bluetooth_ref/bluetooth_unref

Hi Gustavo, > > >> plugins/bluetooth.c | 14 +- > > >> 1 files changed, 9 insertions(+), 5 deletions(-) > > >> > > >> diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c > > >> index 93dd7a1..e59bd31 100644 > > >> --- a/plugins/bluetooth.c > > >> +++ b/plugins/bluetooth.c > > >

Re: [PATCH 2/4] bluetooth: use GSList instead of GHashTable to store adapter path/address

Hi Frederic, * Frederic Danis [2011-01-27 16:35:49 +0100]: > Le 27/01/2011 16:24, Marcel Holtmann a écrit : > > Hi Fred, > > > plugins/bluetooth.c | 86 > +++--- > 1 files changed, 74 insertions(+), 12 deletions(-) > >

Re: [PATCH 3/4] bluetooth: Add bluetooth server support

Hi Frédéric, * Frédéric Danis [2011-01-27 16:05:39 +0100]: > --- > Makefile.am |1 + > plugins/bluetooth.c | 340 > +++ > plugins/bluetooth.h |9 ++ > 3 files changed, 350 insertions(+), 0 deletions(-) > > diff --git a/Makefile.

Re: [PATCH 3/4] bluetooth: Add bluetooth server support

Le 27/01/2011 17:26, Gustavo F. Padovan a écrit : Hi Frédéric, * Frédéric Danis [2011-01-27 16:05:39 +0100]: --- Makefile.am |1 + plugins/bluetooth.c | 340 +++ plugins/bluetooth.h |9 ++ 3 files changed, 350 insertions(+)

Re: [RFC] doc: Proposal for LTE/IMS API.

Hi Sjur, 2011/1/26 Sjur Brændeland : > Features: > - The QoS information is presented as an array of QoS settings with >  an associated list IP Packet Filters. Only the QoS data for >  connection context of type IMS will be reported. > >  The assumption is that QoS is only going to be used by IMS

Re: [RFC] doc: Proposal for LTE/IMS API.

Hi Pekka, >> Features: >> - The QoS information is presented as an array of QoS settings with >>  an associated list IP Packet Filters. Only the QoS data for >>  connection context of type IMS will be reported. >> >>  The assumption is that QoS is only going to be used by IMS applications. >>  Ini

Re: [RFC] doc: Proposal for LTE/IMS API.

Hi Sjur, 2011/1/27 Sjur Brændeland : >> I think we need these in ConnectionContext, or perhaps a separate >> DedicatedContext interface would be better. > > Yes, as I mentioned earlier I considered this as well. But do you see other > scenarios than IMS where the NW will set up Dedicated Bearers?

RE: [RFC] doc: Proposal for LTE/IMS API.

Hi Pekka, Sjur, > I think we need these in ConnectionContext, or perhaps a separate > DedicatedContext interface would be better. The structure of QoS TFT > > Also the PcscfAddresses should be part of the Settings or Settings6 > in ConnectionContext. > I prepared a patched in this way sometime

[sim-auth PATCHv2 3/3] Add doc/gba-authentication.txt

From: Pekka Pessi --- Makefile.am|4 +- doc/gba-authentication.txt | 67 2 files changed, 69 insertions(+), 2 deletions(-) create mode 100644 doc/gba-authentication.txt diff --git a/Makefile.am b/Makefile.am index 65b488a..462b

[sim-auth PATCHv2 2/3] Add GBA_U to SIM authentication API

From: Pekka Pessi --- doc/sim-authentication-api.txt | 90 1 files changed, 90 insertions(+), 0 deletions(-) diff --git a/doc/sim-authentication-api.txt b/doc/sim-authentication-api.txt index 27090e7..2db80bb 100644 --- a/doc/sim-authentication-api.txt

[sim-auth PATCHv2 1/3] Add doc/sim-authentication-api.txt

From: Pekka Pessi The authentication suites include SIM authentication (basic A8 authentication used with GSM) and AKA authentication on USIM. The SIM and AKA can be used to implement EAP, AKA Digest and GBA authentication algorithms. --- Makefile.am|1 + doc/sim-authent

[PATCH v2 0/3] Persist TX SMS messages

Differences from previous version: - Now we don't re-encode the SMS to a PDU when storing it to disk - Sms' ref is not incremented - When restoring sms pdus, directories and files that do not match the expected names are filtered out I've tested this patch series using phonesim by calling exit(

[PATCH v2 3/3] sms: restore pending tx messages from backup

Based on patch from: Kristen Carlson Accardi --- src/ofono.h |1 + src/sms.c | 67 + src/smsutil.c | 185 + src/smsutil.h |8 +++ 4 files changed, 261 insertions(+), 0 deletions(-) diff --git a/src/ofono

[PATCH v2 2/3] sms: delete sent sms messages from backup

Based on patch from Kristen Carlson Accardi --- src/sms.c |8 src/smsutil.c | 47 +++ src/smsutil.h |7 +++ 3 files changed, 62 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index 87283d3..2fe67c8 100644 --

[PATCH v2 1/3] sms: store pending tx pdus on disk

Based on patch from Kristen Carlson Accardi --- src/sms.c | 21 + src/smsutil.c | 28 src/smsutil.h |4 3 files changed, 53 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index 7224bdf..87283d3 100644 --- a/src/s

[PATCH] build: Do not fail when systemd is not installed

Use --with-systemdsystemunitdir instead of --enabled-systemd so it's possible to enable systemd even if systemd is not installed. --- configure.ac | 18 +++--- 1 files changed, 7 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index b034ff0..20a1fc6 100644 --

[PATCH v3 0/2] bluetooth: Add bluetooth server support

It watches Bluetooth adapter property changes and adds SDP record to listen client connection request. It supports multiple adapters, servers and client connections. Frédéric Danis (2): bluetooth: Add bluetooth server support bluetooth: add Bluetooth service authorization support Makefile.am

[PATCH 2/2] bluetooth: add Bluetooth service authorization support

--- plugins/bluetooth.c | 133 +++ 1 files changed, 124 insertions(+), 9 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index c766205..1a17441 100644 --- a/plugins/bluetooth.c +++ b/plugins/bluetooth.c @@ -44,6 +44,8 @@ static

[PATCH 1/2] bluetooth: Add bluetooth server support

--- Makefile.am |1 + plugins/bluetooth.c | 317 +-- plugins/bluetooth.h |9 ++ 3 files changed, 316 insertions(+), 11 deletions(-) diff --git a/Makefile.am b/Makefile.am index 9b77e63..c0efe28 100644 --- a/Makefile.am +++ b/Makefil

RE: [PATCH 6/9] oFono smsagent enhancements to permit more flexible parameter set to be dispatched.

Hi Oleg, so first things first, please no top posting on this mailing list. > That's in order to include the uuid (so we can correlate sms_send_pending and > sms_send_status). Possibly, in order to include some other parameters, > without affecting the other users of the sms_agent_dispatch_data

[PATCH v3 2/3] sms: delete sent sms messages from backup

Based on patch from Kristen Carlson Accardi --- src/sms.c |8 src/smsutil.c | 47 +++ src/smsutil.h |6 ++ 3 files changed, 61 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index 87283d3..2fe67c8 100644 ---

[PATCH v3 0/3] Persist TX SMS messages

Third version. It includes some changes suggested by Denis: - Get rid of the oldpath field in struct txq_backup_entry - Store the encoded uuid in struct txq_backup_entry - Use SMS_MSGID_FMT to get the file name - Some more cleanups Lucas De Marchi (3): sms: store pending tx pdus on disk sms:

[PATCH v3 1/3] sms: store pending tx pdus on disk

Based on patch from Kristen Carlson Accardi --- src/sms.c | 21 + src/smsutil.c | 29 + src/smsutil.h |4 3 files changed, 54 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index 7224bdf..87283d3 100644 --- a/src/

[PATCH v3 3/3] sms: restore pending tx messages from backup

Based on patch from: Kristen Carlson Accardi --- src/ofono.h |1 + src/sms.c | 62 +++ src/smsutil.c | 181 + src/smsutil.h |7 ++ 4 files changed, 251 insertions(+), 0 deletions(-) diff --git a/src/ofono.h

[PATCH] smsutil: do not allow larger file names

If file name had anything in the name after addr-msgid, it would be parsed as well. This is not what we want, since there could be temporary files lying around. --- src/smsutil.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 3a54fe

[PATCH] Enable Dell 5540 AGPS interface

--- plugins/udev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/udev.c b/plugins/udev.c index 202b225..ce1efe6 100644 --- a/plugins/udev.c +++ b/plugins/udev.c @@ -135,7 +135,7 @@ static void add_mbm(struct ofono_modem *modem, devnode = udev_dev

[PATCH] Enable hs 2330 MBM modem

--- plugins/udev.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/plugins/udev.c b/plugins/udev.c index 202b225..810049a 100644 --- a/plugins/udev.c +++ b/plugins/udev.c @@ -123,6 +123,7 @@ static void add_mbm(struct ofono_modem *modem, g_str_ha

Hi, use qtdbus to access Ofono method

Hi, Has anybody used qtdbus to access Ofono interface? I have faced some problem on it, the qdbusinterface create OK, but when call the ofono api, it will note the signature doesn't exist. please give me some info or show me and example. Thanks. B.R Chengyong Xie

Re: Hi, use qtdbus to access Ofono method

Hi On Fri, 2011-01-28 at 13:47 +0800, cy xie wrote: > Has anybody used qtdbus to access Ofono interface? > I have faced some problem on it, the qdbusinterface create OK, but > when call the ofono api, it will note the signature doesn't exist. > please give me some info or show me and example.

Re: Hi, use qtdbus to access Ofono method

get it, thanks very much:) 2011/1/28 Jukka Saunamaki > Hi > > On Fri, 2011-01-28 at 13:47 +0800, cy xie wrote: > > Has anybody used qtdbus to access Ofono interface? > > I have faced some problem on it, the qdbusinterface create OK, but > > when call the ofono api, it will note the signatur