Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v3]

2022-03-23 Thread Scott Palmer
On Mar 23, 2022, at 8:20 AM, Kevin Rushforth wrote: > > On Tue, 22 Mar 2022 08:54:45 GMT, Johan Vos wrote: > >> I wonder if we can add some simple resources that allow testing the >> different protocols on different platforms? > > I can't think of a good way to do that, especially for this

Re: Question about fatal JavaFX crashes

2022-03-18 Thread Scott Palmer
I wonder, could you do the opposite and force compilation to trigger the bug more consistently? Scott > On Mar 18, 2022, at 2:03 PM, Philip Race wrote: > > I have at least seen JIT compiler crashes like this in other unrelated > cases .. > > in theory you can use an option like > >

Re: Mention of the CSS properties in JavaDocs

2022-02-13 Thread Scott Palmer
Would it be a custom doclet that was part of the OpenJFX project and require no changes to the javadoc tool? Scott > On Feb 12, 2022, at 9:52 AM, Kevin Rushforth > wrote: > > While something like this could be handy, I doubt that adding this much > knowledge of JavaFX into the javadoc tool

Re: AVIF ImageProvider registering

2022-01-27 Thread Scott Palmer
That link should be https://github.com/lanthale/LibHeifFX > On Jan 27, 2022, at 6:02 AM, Clemens Lanthaler > wrote: > > Hello everyone, > > as some of you already know I have created the project LibHeifFX > (github.com/lanthaler/libheiffx) for adding

Re: WebView missing resource

2022-01-24 Thread Scott Palmer
f not already filed). > > Thanks. > > -- Kevin > > > On 1/22/2022 8:10 PM, Scott Palmer wrote: >> Is this an issue with WebView, my code, both? >> >> Exception in thread "JavaFX Application Thread" >> java.util.MissingRes

WebView missing resource

2022-01-22 Thread Scott Palmer
Is this an issue with WebView, my code, both? Exception in thread "JavaFX Application Thread" java.util.MissingResourceException: Can't find resource for bundle java.util.PropertyResourceBundle, key blockedPluginByContentSecurityPolicyText at

Re: Circling back to a new layout algorithm

2021-11-12 Thread Scott Palmer
> On Nov 12, 2021, at 7:48 PM, Kevin Rushforth > wrote: > > I think this will be a good improvement to implement to the JavaFX layout > algorithm. I see that you filed JDK-8276671 [1] to track this enhancement. > > As noted, the main concern will be making sure we don't break existing >

Re: Mnemonic Parsing doesn't appear to work properly

2021-10-29 Thread Scott Palmer
dd an "onAction" to the Checkbox that prints something on the >>> console, you can see the mnemonic working, but the Checkbox is still not >>> toggled. >>> >>> I checked the mnemonic parsing code, and if you run it in isolation, it >>> find

Mnemonic Parsing doesn't appear to work properly

2021-10-29 Thread Scott Palmer
I looked in the bug database and while there are lots of bugs reported against the mnemonic parsing, they claim to be fixed. After noticing something peculiar on a control in my app (it was showing a file path and I hadn't disabled the mnemonic parsing) I did some tests. The documentation is

Re: JavaFX 17 Maven Artifacts

2021-09-10 Thread Scott Palmer
I still think having .jmod files available from an artifact repository would be helpful. I’ve deployed them from the SDK to my local Artifactory repo for my own builds. Using Gradle I create a JRE with jlink if needed for running debug/tests during development, or I use an OpenJDK

Re: RFR: 8270107: Open source FXMediaPlayer test app

2021-08-29 Thread Scott Palmer
On Fri, 27 Aug 2021 22:06:31 GMT, Alexander Matveev wrote: > - Added FXMediaPlayer test application. > - This app uses all media APIs and very handy in verifying media builds > during development. > - It can be compiled and run by running "ant" and "ant run" in >

Re: Enhancements for JavaFX 18

2021-08-04 Thread Scott Palmer
+1 to that. I would also like to see some progress with system tray support and microphone & webcam access. Scott > On Aug 4, 2021, at 7:07 AM, Jeanette Winzenburg > wrote: > >  > my suggestion would be the longstanding commit-edit-on-focus-lost - solved by > an enhancement to the

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-24 Thread Scott Palmer
On Thu, 24 Jun 2021 22:25:53 GMT, Kevin Rushforth wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8223717: javafx printing: Support Specifying Print to File in the API > >

Re: [External] : Re: Convenience factories for Border and Background

2021-06-08 Thread Scott Palmer
+1 for having a variant that takes a width. Colour, width, and radius are the main parameters I need, so a variant that takes all three would help: Border.stroke(Paint p, double width, double radii) (Though to be honest for my larger projects most of the time this stuff is set in a style

Re: RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-05-14 Thread Scott Palmer
On Thu, 13 May 2021 21:55:59 GMT, Kevin Rushforth wrote: >> This PR fixes the gradle deprecation warnings described in >> [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates >> the JavaFX build to use gradle 7.0.1 as described in >>

Re: Add method to save a JavaFX image to file without the use of SwingFXUtils?

2021-05-04 Thread Scott Palmer
An overhaul to ImageIO that isn’t dependent on any UI framework, but rather accesses raw image data via arrays or ByteBuffer (or even the new foreign MemoryAccess stuff?) would help. For specific UI framework types, BufferedImage and JavaFX Image, they just need the plumbing to get the raw

Re: [External] : Re: Consistent baseline layout algorithm

2021-04-16 Thread Scott Palmer
“ I've changed the default alignment for Label to TOP_LEFT (the default alignment of the base class Labeled is CENTER_LEFT).” How can you do that without breaking things? Even though it may be uncommon to set minHeight or prefHeight, that isn’t the point. It still breaks existing code. Scott

Re: [External] : Re: Consistent baseline layout algorithm

2021-04-02 Thread Scott Palmer
I haven’t done much in terms of custom controls, but I do see this issue a lot in my primary application. It would be nice to have it fixed as the layout looks rather sloppy without it. Any time I see the layout “correct” itself when I interact with a control or tweak the size of a window it

Re: list digest

2020-12-22 Thread Scott Palmer
You might consider supplying your own sortPolicy (see sortPolicyProperty ). It could remove your "total" object, call the DEFAULT_SORT_POLICY

Re: Taskbar API from JavaFX Window?

2020-11-02 Thread Scott Palmer
ass in for the setWindowProgressState window > argument? It requires a java.awt.Window? > > On Sun, Nov 1, 2020 at 5:48 PM Scott Palmer wrote: > >> They work fine. Just remember to use the Swing/AWT event thread to call >> them. >> >> Scott >> >>

Re: Taskbar API from JavaFX Window?

2020-11-01 Thread Scott Palmer
They work fine. Just remember to use the Swing/AWT event thread to call them. Scott > On Nov 1, 2020, at 8:39 PM, Will Iverson wrote: > > Looking at native desktop integration with JavaFX. As I was exploring, I > noticed that the java.awt.Taskbar API does not appear to be available for >

Re: Tray Icon?

2020-07-31 Thread Scott Palmer
app. Scott > On Jul 31, 2020, at 7:34 PM, Scott Palmer wrote: > >  No you can’t. System tray support is something else, not an application > icon in the start bar or doc. > > Scott > >> On Jul 31, 2020, at 6:02 PM, Michael Paus wrote: >> >> You

Re: Tray Icon?

2020-07-31 Thread Scott Palmer
No you can’t. System tray support is something else, not an application icon in the start bar or doc. Scott > On Jul 31, 2020, at 6:02 PM, Michael Paus wrote: > > You can add such an icon to your JavaFX app if you bundle it with the > jpackage tool distributed with JDK 14+ > >> Am

Re: How to create a fat jar for my JavaFX program?

2020-07-20 Thread Scott Palmer
Michael > > Am 20.07.20 um 19:25 schrieb Davide Perini: >> Unfortunantly so few dependencies supports Java Modules this day, so fat JAR >> is the only way I can do it. >> >> Thanks >> >> Il 20/07/2020 02.50, Scott Palmer ha scritto: >>> The

Re: How to create a fat jar for my JavaFX program?

2020-07-19 Thread Scott Palmer
The JavaFX classes are there, but what about the native libraries? A fat jar isn’t a good way to distribute a Java application these days. Now you should probably be using jpackage and/or jlink to bundle your application classes with a runtime suitable for running the application. Scott > On

Re: MacOS Big Sur and OpenJFX on Arm Macs

2020-07-01 Thread Scott Palmer
JavaFX already runs on some Arm-based devices like the Raspberry Pi, so I expect an Arm-based port for new Macs won’t be that big of a job (relatively speaking) Hopefully by that time there will be a Metal-base rendering pipeline as well. The Metal-based pipeline for Swing seems to be coming

Re: Font rendering issue on macOS - cut off characters

2020-05-25 Thread Scott Palmer
> Can anyone say if they definitely see it on a built-in retina display too ? Yes. It is present on the built-in Retina display on my mid-2015 MacBook Pro running Catalina 10.15.5 beta. I looked quickly using Java 8. Scott > On May 25, 2020, at 2:48 PM, Philip Race wrote: > > Mmm .. it

Re: Windows Installation Instructions, All DLL Files Missing

2020-04-17 Thread Scott Palmer
I use jlink and jpackage to distribute JavaFX applications. You suggest there will be a problem if you use jlink, but it will work if you include the needed javafx modules. The .jmod files contain the necessary native libraries and jlink will build a JRE that has the DLLs in the right place for

Re: Alternatives for JDK-8185886: Improve scrolling performance of TableView and TreeTableView

2020-04-03 Thread Scott Palmer
Assuming testing and performance/memory analysis leads to the conclusion that the risks are worth it, would it make sense to do both? Would we get a greater benefit from the combined effects? Or is the incremental improvement of including the second fix (whichever it may be) no longer

Re: Seeking help with latest master ...

2020-03-31 Thread Scott Palmer
> Could not resolve all dependencies for configuration ':apps:lucene'. > Multiple build operations failed. java.lang.ExceptionInInitializerError java.lang.NoClassDefFoundError: Could not initialize class sun.security.ssl.SSLContextImpl$TLSContext

Re: RFR: 8236753: Animations do not play backwards after being stopped

2020-01-14 Thread Scott Palmer
> On Jan 14, 2020, at 11:50 AM, Ambarish Rapte wrote: > > On Fri, 10 Jan 2020 00:39:53 GMT, Kevin Rushforth wrote: > >>> I'll review this next week. This seems a fine candidate for openjfx14, so >>> it (along with a couple other pending reviews that can be for 14) will be a >>> good test

RFR: 8236648: javadoc warning on Text::tabSizeProperty method

2020-01-06 Thread Scott Palmer
Implemented suggested fix to address javadoc warning. - Commits: - bd81a902: 8236648: javadoc warning on Text::tabSizeProperty method Changes: https://git.openjdk.java.net/jfx/pull/78/files Webrev: https://webrevs.openjdk.java.net/jfx/78/webrev.00 Issue:

Re: [Rev 04] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-21 Thread Scott Palmer
On Sat, 21 Dec 2019 03:03:57 GMT, Scott Palmer wrote: >> Interesting. I was only running the tests in graphics (gradle >> :graphics:test) as when I run all the tests I always get this failure >> (unrelated to anything I've changed): >&

Re: [Rev 04] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-20 Thread Scott Palmer
On Sat, 21 Dec 2019 02:50:54 GMT, Scott Palmer wrote: >> The fix looks good now. There is one problem in the test (in >> `StubTextLayout`) that needs to be fixed. > > Interesting. I was only running the tests in graphics (gradle > :graphics:test) as when I run all t

Re: [Rev 06] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-20 Thread Scott Palmer
> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to > both. TextFlow's tab size overrides that of contained Text nodes. The pull request has been updated with 1 additional commit. - Added commits: - 78ddf12e: 8130738: Fixed test issue with

Re: [Rev 04] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-20 Thread Scott Palmer
On Fri, 20 Dec 2019 23:43:53 GMT, Kevin Rushforth wrote: >> The pull request has been updated with 1 additional commit. > > The fix looks good now. There is one problem in the test (in > `StubTextLayout`) that needs to be fixed. Interesting. I was only running the tests in graphics (gradle

Re: [Rev 03] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-20 Thread Scott Palmer
On Fri, 20 Dec 2019 00:19:43 GMT, Kevin Rushforth wrote: >> I was thinking of deferring the `apps/toys` demo to avoid any delays in >> getting the new API into JavaFX 14. I have something for it, I just don't >> want any feedback on it to hold up the review of this issue. Is there >>

apps/toys HelloTextFlow renders incorrectly on macOS 10.15

2019-12-19 Thread Scott Palmer
As follow up to JDK-8130738 I was thinking about adding a new panel to HelloTextFlow to show adjusting the tabSize rather than making a new ‘toy’. However I noticed rendering issues right away. When you select text, parts of the text seem to paint white-on-white .. proportional to the amount

Re: [Rev 03] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-19 Thread Scott Palmer
On Thu, 12 Dec 2019 21:51:56 GMT, Nir Lisker wrote: >> The pull request has been updated with 1 additional commit. > > I was thinking of deferring the `apps/toys` demo to avoid any delays in getting the new API into JavaFX 14. I have something for it, I just don't want any feedback on it

Re: Skara - bot sending can-be-integrated message prematurely?

2019-12-17 Thread Scott Palmer
Perhaps the language in the message should be tweaked? Maybe use, “This change can be integrated if there are no further review requirements.“ Scott > On Dec 17, 2019, at 4:57 PM, Kevin Rushforth > wrote: > > Yes, other projects have multiple review requirements. And similar to > JavaFX,

Re: [Rev 05] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-14 Thread Scott Palmer
> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to > both. TextFlow's tab size overrides that of contained Text nodes. The pull request has been updated with 1 additional commit. - Added commits: - f846ad6d: 8130738: Add tabSize property to Text and

Re: [Rev 04] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-14 Thread Scott Palmer
On Sat, 14 Dec 2019 16:38:25 GMT, Kevin Rushforth wrote: >> TextFlow isn't mentioned in the JavaDoc for any of the other Text properties >> where the same rule applies. Perhaps that should be remedied with a >> follow-up task? > > A follow-up issue would be fine. I've created

Re: [Rev 03] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-12 Thread Scott Palmer
On Fri, 13 Dec 2019 01:29:47 GMT, Phil Race wrote: >> The terms "tab character" or "horizontal tab" refer to the ASCII tab >> character itself. Since a tab character isn't a fixed number of spaces, >> changing it to "size of a tab character" could be misleading. I'd be fine >> with another

Re: [Rev 04] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-12 Thread Scott Palmer
On Thu, 12 Dec 2019 22:02:14 GMT, Nir Lisker wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java line > 494: > >> 493: * Values less than 1 are treated as 1. This value overrides the >> 494:

Re: [Rev 03] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-12 Thread Scott Palmer
On Thu, 12 Dec 2019 21:41:12 GMT, Nir Lisker wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1883: > >> 1882: } >> 1883: @Override protected void

Re: [Rev 03] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-12 Thread Scott Palmer
On Thu, 12 Dec 2019 21:29:06 GMT, Nir Lisker wrote: >> The pull request has been updated with 1 additional commit. > > modules/javafx.graphics/src/main/java/javafx/scene/text/Text.java line 1450: > >> 1449: private static final CssMetaData TAB_SIZE = >> 1450: new

Re: [Rev 03] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-12 Thread Scott Palmer
On Thu, 12 Dec 2019 19:48:37 GMT, Scott Palmer wrote: >> In that case, I recommend just doing the API get/set tests for `TextFlow` >> without creating a `Scene` or `Stage`. This won't need anything from the >> `StubToolkit`. > > In my attempts to address the iss

Re: [Rev 04] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-12 Thread Scott Palmer
> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to > both. TextFlow's tab size overrides that of contained Text nodes. The pull request has been updated with 1 additional commit. - Added commits: - f99a3aa9: 8130738: Add tabSize property to Text and

Re: [Rev 03] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-12 Thread Scott Palmer
On Wed, 11 Dec 2019 01:22:54 GMT, Kevin Rushforth wrote: >> The unit tests that were already added to `TextTest.java` cover the new >> methods on Text, but not in every combination. I'll add a couple more to >> ensure all combinations are covered. `TextFlow` has no existing unit tests >>

Re: [Rev 03] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-11 Thread Scott Palmer
> On Dec 10, 2019, at 8:23 PM, Kevin Rushforth wrote: ... > > I think a new `TextFlowTest.java` would be a good place for those tests. My first attempt at unit tests for TextFlow are failing. I believe the StubTextLayout is not equipped to handle TextFlow. This may be a bigger job… This

Re: [Rev 03] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-12-10 Thread Scott Palmer
On Tue, 10 Dec 2019 23:51:48 GMT, Kevin Rushforth wrote: >>> Should this PR also add a tabSize property to controls such as TextArea? Or >>> should that be a different PR after this one is merged? >> >> This would need to be a new enhancement and would first need to be discussed >> on the

Re: [Rev 03] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-11-27 Thread Scott Palmer
The pull request has been updated with additional changes. Added commits: - af959665: 8130738: Add tabSize property to Text and TextFlow Changes: - all: https://git.openjdk.java.net/jfx/pull/32/files - new: https://git.openjdk.java.net/jfx/pull/32/files/254c40de..af959665

Re: RFR: 8130738: Add tabSize property to Text and TextFlow

2019-11-26 Thread Scott Palmer
On Tue, 26 Nov 2019 18:48:38 GMT, Kevin Rushforth wrote: > On Tue, 26 Nov 2019 18:40:10 GMT, Scott Palmer wrote: > >> On Thu, 7 Nov 2019 14:56:58 GMT, Kevin Rushforth wrote: >> >>> On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer wrote: >>> >>>

Re: RFR: 8130738: TextFlow's tab width is static

2019-11-26 Thread Scott Palmer
On Thu, 7 Nov 2019 14:56:58 GMT, Kevin Rushforth wrote: > On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer wrote: > >> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute >> to both. TextFlow's tab size overrides that of co

Re: [Rev 02] RFR: 8130738: TextFlow's tab width is static

2019-11-26 Thread Scott Palmer
The pull request has been updated with a complete new set of changes (possibly due to a rebase). Commits: - 254c40de: Merge remote-tracking branch 'upstream/master' - a670c4f8: 8130738: TextFlow's tab width is static - 68d221c7: 8130738: TextFlow's tab width is static

Typo in native-glass/win/OleUtils.h checkJavaException

2019-11-20 Thread Scott Palmer
I discovered this by accident while trying to figure out where a certain console message was coming from while debugging. I saw this printed to the console when testing my (broken) code: Java Messsge:com/openalpr/jni/AlprException Note the typo in "Messsge" (the class name that follows is

Re: RFR: 8130738: TextFlow's tab width is static

2019-11-07 Thread Scott Palmer
things go wrong in that case (everything after a tab appears at x offset 0). I've created the CSR, hopefully I did it correctly. https://bugs.openjdk.java.net/browse/JDK-8233810 Scott On Thu, Nov 7, 2019 at 9:57 AM Kevin Rushforth wrote: > On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer >

Re: RFR: 8130738: TextFlow's tab width is static

2019-11-07 Thread Scott Palmer
. Scott > On Nov 6, 2019, at 11:23 PM, David Grieve wrote: > > What happens if you do text.tabSizeProperty().setValue(null) ? > >> -Original Message- >> From: openjfx-dev On Behalf Of >> Scott Palmer >> Sent: Wednesday, November 6, 2019 11:12 AM >> T

Re: [Rev 01] RFR: 8130738: TextFlow's tab width is static

2019-11-07 Thread Scott Palmer
The pull request has been updated with additional changes. Added commits: - a670c4f8: 8130738: TextFlow's tab width is static Changes: - all: https://git.openjdk.java.net/jfx/pull/32/files - new: https://git.openjdk.java.net/jfx/pull/32/files/68d221c7..a670c4f8 Webrevs:

RFR: 8130738: TextFlow's tab width is static

2019-11-06 Thread Scott Palmer
Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to both. TextFlow's tab size overrides that of contained Text nodes. Commits: - 68d221c7: 8130738: TextFlow's tab width is static Changes: https://git.openjdk.java.net/jfx/pull/32/files Webrev:

Re: JDK-8130738 TextFlow's tab width is static

2019-11-05 Thread Scott Palmer
TextFlow, linewrapping or not ... > complex text and simple text too. > Perhaps complex text should be tested anyway, although I've been > assuming that we are handling > tab spacing outside of that but didn't verify it. > > -phil. > > > > > -- Kevin >

Re: Problem with gradle ...

2019-10-31 Thread Scott Palmer
The wrapper script works just like the gradle command but uses the gradle version specified by the project. See https://docs.gradle.org/current/userguide/gradle_wrapper.html > On Oct 31, 2019, at 9:58 AM, Jeanette Winzenburg >

Build Problem on macOS with OpenJDK 13 and Gradle 6.0-rc-1

2019-10-24 Thread Scott Palmer
I’m getting this: * What went wrong: Execution failed for task ':swt:compileJava'. > Could not resolve all files for configuration ':swt:compileClasspath'. > Could not find :org.eclipse.swt.cocoa.macosx.x86_64_3.105.3.v20170228-0512:. Searched in the following locations: -

OpenJFX.io points to old repo

2019-10-19 Thread Scott Palmer
The Let's do it! " link at https://openjfx.io still points to https://github.com/javafxports/openjdk-jfx instead of https://github.com/openjdk/jfx Scott

Re: JDK-8130738 TextFlow's tab width is static

2019-10-17 Thread Scott Palmer
I think what we’ve settled on fits CSS for the web. I agree we shouldn’t deviate from that if possible. Scott > On Oct 17, 2019, at 5:30 PM, Pedro Duque Vieira > wrote: > > Hi, > > Kevin asked for developers opinions on this issue, just thought I'd leave > my own. > > Didn't have time to

Re: JDK-8130738 TextFlow's tab width is static

2019-10-17 Thread Scott Palmer
or-font-size > > Although I am sure there are more authoratative sources than that. > > -phil. > > On 10/17/19 11:22 AM, Scott Palmer wrote: >> So do we go ahead and implement tabSize without the CSS support? I’m not >> sure the CSS property should be added

Re: JDK-8130738 TextFlow's tab width is static

2019-10-17 Thread Scott Palmer
ble rather than int. We > do this for most attributes to leave the door open for fractional values. I > don't know why anyone would want a tab that was 5.7 spaces, but if we ever > were to add a tabUnits property, I could easily see wanting fractional values > for some units. > > --

Re: JDK-8130738 TextFlow's tab width is static

2019-10-17 Thread Scott Palmer
hich use Text nodes. Something like a CSS property may be the way to go if >> you wanted that. >> Text has a nested class StyleableProperties for CSS properties with which it >> plays nice : font, underline, strikethrough, text-alignment >> >> So creating an fx-tabWidt

Re: The thing about JAR files

2019-10-17 Thread Scott Palmer
What’s in the jar manifest? How did you create the Java 12 runtime? Scott > On Oct 17, 2019, at 6:09 AM, AmnoJeeuw wrote: > > Has anyone notices that the JAR files produced, eclipse in my case, in > javafx 12+ applications do not run with an error that reads > java -jar app.jar > > Error

Re: JDK-8130738 TextFlow's tab width is static

2019-09-30 Thread Scott Palmer
23, 2019, at 3:57 PM, Scott Palmer wrote: > > My current work is here > https://github.com/javafxports/openjdk-jfx/compare/develop...swpalmer:jdk-8130738?expand=1 > > <https://github.com/javafxports/openjdk-jfx/compare/develop...swpalmer:jdk-8130738?expand=1> > >

Re: JDK-8130738 TextFlow's tab width is static

2019-09-23 Thread Scott Palmer
unning the Prism layout code, so I’m not sure how that gets tested. I made it work with StubTextLayout for now. Regards, Scott > On Sep 20, 2019, at 12:57 PM, Scott Palmer wrote: > > Thanks Kevin. > > My current implementation appears to be working for TextFlow and Text, with >

Use of Hashtable in Prism

2019-09-23 Thread Scott Palmer
I just noticed that NetBeans is warning me about use of an “obsolete collection” in PrismTextLayout.java. Is there a reason this isn’t using HashMap or ConcurrentHashMap ? Scott

JDK-8130738 TextFlow's tab width is static

2019-09-18 Thread Scott Palmer
I would like to implement this feature, being able to adjust the tab size in a TextFlow or Text node (JDK-8130738 ). It involves new public API, so I want to start a discussion about it here. (My motivation is that RichTextFX suggests an

Heads up - Building with Gradle 5.6.2 leaves .property files out of jars

2019-09-18 Thread Scott Palmer
I know that the supported Gradle version is 5.3, but I decided to try with the version of Gradle I had installed (5.6.2) and things appeared to be working. Until I got a message about QuantumMessagesBundle not found when I tried to run my test app. Eventually I narrowed it down to the build with

LocalDateTimeStringConverterTest failing

2019-09-16 Thread Scott Palmer
I was looking into working on an issue but before I got very far I ran into this test failing. I'm building on macOS. I've tried with OpenJDK 11.0.2 and OpenJDK 12.0.2. gradle :base:test results in: > Task :base:test test.javafx.util.converter.LocalDateTimeStringConverterTest >

Anyone testing on macOS 10.15 betas?

2019-09-12 Thread Scott Palmer
My JavaFX app using JavaFX 13 on OpenJDK 12.0.2 crashes every time I close my main window. I’m not 100% sure if it is a JavaFX issue, but just in case here’s a stack trace. I see libglass.dylib, though it is a few frames away from the crash point.: Thread 0 Crashed:: Dispatch queue:

RFR: 8185937 - Spinner with Double/Integer value factory ignores up/down arrow keys

2019-07-05 Thread Scott Palmer
Please review the fix for JDK-8185937 - Spinner with Double/Integer value factory ignores up/down arrow keys https://bugs.openjdk.java.net/browse/JDK-8185937 https://github.com/javafxports/openjdk-jfx/pull/517

Fix for JDK-8185937 Up/Down keys don't work as expected for an editable Spinner

2019-07-04 Thread Scott Palmer
I’ve added my potential fix as a comment to the issue at https://bugs.openjdk.java.net/browse/JDK-8185937 Scott

Re: GStreamer

2019-05-19 Thread Scott Palmer
It’s been 11 years… https://bugs.openjdk.java.net/browse/JDK-8091063 The gstreamer integration should have been a pluggable module into the media framework from the beginning. I would love to see that corrected. Refactoring towards a more

JMODs and Arm support

2019-04-30 Thread Scott Palmer
I noticed that there is a download on openjfx.io for an 11.0.2 Arm SDK, but no JMOD download for Arm. Nor is there any 64-bit Arm download, making it a bit of an outlier since there are no 32-bit binaries for the other platforms. (The website should probably label this

Re: JDK-8193445 Performance Test (CSS applied redundantly)

2019-01-17 Thread Scott Palmer
> On Jan 17, 2019, at 3:23 PM, Tom Schindl wrote: > > Sorry to hi-jack but: > >> Performance improvements and a JNI mechanism to get at native window handles >> are the first two items on my wish list. Though extendable media support >> could potentially beat out the window handle thing..

Re: JDK-8193445 Performance Test (CSS applied redundantly)

2019-01-17 Thread Scott Palmer
JDK-8183100 is a fixed issue. But it basically undid the fix for https://bugs.openjdk.java.net/browse/JDK-8151756 I think you mean to ask when JDK-8193445 might be addressed. I too would like to see the performance return, and actually I’m

Re: OpenJFX JMOD Files

2018-12-10 Thread Scott Palmer
> Am Sonntag, den 09.12.2018, 20:36 +0100 schrieb Johan Vos: >> > I got the use case. I think it should be possible, although in general >> > uploading to the OSS sonatype repository requires uploading jars for the >> > classes, sources and javadoc. There is no procedure yet (afaik) for >> > uploading mods, but we can see if that works. >> > >> > - Johan >> > >> > On Fri, Dec 7, 2018 at 11:20 PM Scott Palmer wrote: >> > >> > > Is there a reason not to make the jmod files available as artifacts on >> > > Maven Central? >>

OpenJFX JMOD Files

2018-12-07 Thread Scott Palmer
Is there a reason not to make the jmod files available as artifacts on Maven Central? The idea being that I can then use dependency management in my Gradle script and not require the extra setup and configuration of a JavaFX SDK - yet still be able to use the jmod files as input to jlink. I

Re: JavaFX Media module crashes jdeps

2018-12-03 Thread Scott Palmer
900 > > It's on my list to fix for openjfx12. > > -- Kevin > > > On 12/3/2018 9:27 AM, Kevin Rushforth wrote: > > I guess you are running into: > > > > https://bugs.openjdk.java.net/browse/JDK-8211887 > > > > -- Kevin > > > > On 12/3/2018

JavaFX Media module crashes jdeps

2018-12-03 Thread Scott Palmer
I use a Gradle script to run jdeps to get a module list for jlink. This command line (excuse the long paths into the Gradle cache): jdeps --print-module-deps --module-path

Re: JDK-8193445 Performance Test

2018-11-07 Thread Scott Palmer
> On Nov 7, 2018, at 8:37 AM, David Grieve wrote: > > ... > > Reapplying CSS to a Node but not its children could cause a problem if there > are styles in the parent or the parent's parents that affect the children. It > seems like bypassing children in reapplyCSS is bound to cause a

Re: Filling the Packager gap

2018-09-26 Thread Scott Palmer
Does jlink work for non-modular stuff? The last time I tried it complained to me too. I guess it gives up because it can’t automatically figure out module dependencies. The error below shows jlink is what is complaining. Scott > On Sep 26, 2018, at 3:44 PM, Kevin Rushforth > wrote: > >

Re: NativeLibLoader - installLibraryFromResource - RuntimeImage

2018-07-27 Thread Scott Palmer
> On Jul 27, 2018, at 10:49 AM, Kevin Rushforth > wrote: > > Those are all excellent points. This suggests we might want to adopt a > general policy of "the current OpenJFX dev works with the latest released > OpenJDK plus the current OpenJDK under development" is the better way to go. >

Re: JavaFX 11 snapshots in maven sonatype

2018-07-08 Thread Scott Palmer
If separate Gradle processes produce the artifacts, there is probably a way to bring them together and (re-)publish them together in yet another project. Scott > On Jul 8, 2018, at 8:38 AM, Johan Vos wrote: > > I don't think that will help, as the artifacts for the different platforms > are

Re: Support additional video codec and container format

2018-06-25 Thread Scott Palmer
I don't want Oracle to add any of those formats. I want them to make it so *anyone* can add a new codec. Then they don't have to worry so much about which codecs to support. The community can take care of that. If Oracle is going to officially support another codec the only one worth putting

Re: Draft JEP for new Packaging Tool (replacement for javapackager)

2018-06-05 Thread Scott Palmer
Yes, my only comment was that if we can get a window up using standard Java GUI frameworks fast enough, then the complexity of adding splashscreen support to the launcher isn't justified. Mario's example shows that is it 1-2 seconds to get a window up. That is a bit high. If it was under 1s then

Re: Draft JEP for new Packaging Tool (replacement for javapackager)

2018-06-04 Thread Scott Palmer
Nobody is arguing against splash screens. I’m simply suggesting that the JVM startup is not slow enough that we need special handling of this in native code. If Java can get a window displayed in under half a second there is no need for the added complexity to support a native splash screen in

Re: Draft JEP for new Packaging Tool (replacement for javapackager)

2018-06-04 Thread Scott Palmer
get the JVM and JavaFX up and running because > it can never be as instant as a splash has to show up. > > Tom > >> On 04.06.18 01:06, Scott Palmer wrote: >> Has anyone actually timed how long it takes to get a Java window on screen? >> I don’t think the delay is

Re: Draft JEP for new Packaging Tool (replacement for javapackager)

2018-06-03 Thread Scott Palmer
Has anyone actually timed how long it takes to get a Java window on screen? I don’t think the delay is long enough to bother with a splash screen these days. Scott > On Jun 3, 2018, at 4:22 AM, Tom Schindl wrote: > > That's why I requested that since a long time from the packager because > a

Re: Draft JEP for new Packaging Tool (replacement for javapackager)

2018-06-01 Thread Scott Palmer
> On Jun 1, 2018, at 5:01 AM, Tom Schindl wrote: > > On 01.06.18 08:01, Michael Ennen wrote: >> Re-familiarizing myself with what javapackager offers, it seems the >> following JavaFX related >> features are present: >> >> 1.) The conversion of CSS to binary CSS >> 2.) The ability to specify

Re: OpenJFX status update

2018-05-16 Thread Scott Palmer
It needs a lot of work. I’m reminded as a see all the issues I’ve reported against it are being reassigned today. Despite the issues, Javapackager was one of the best things to happen for Java deployment in many years. I’m kinda bummed that it didn’t make it to OpenJDK. jlink isn’t really

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

2018-03-24 Thread Scott Palmer
> On Mar 23, 2018, at 5:50 PM, Michael Ennen wrote: > > Kevin, > > I believe I followed all of your suggestions, except the one with a > re-usable WritableImage. > If you want me to implement that as well, I can, but you seemed unsure > about the necessity > of it. I

Re: Windows Build setupTools

2017-12-21 Thread Scott Palmer
One of the reasons I would like to eliminate Cygwin is that I believe it causes more problems than it is worth. For example, lat time I check, there was a bunch of code in the build scripts to hack paths because Cygwin apparently wants non-Windows paths on Windows. It’s the “let’s pretend we

Re: Building OpenJFX.

2017-12-19 Thread Scott Palmer
> On Dec 19, 2017, at 5:13 PM, Mario Torre <neugens.limasoftw...@gmail.com> > wrote: > > 2017-12-19 23:04 GMT+01:00 Scott Palmer <swpal...@gmail.com>: >> The project should be configured to use the Gradle Wrapper, so the correct >> ver

  1   2   3   >