On Thu, 14 Jul 2022 23:37:31 GMT, John Hendrikx wrote:
> I introduced a bug with the fluent bindings PR which affects all
> ObjectBindings.
>
> This is the code that fails:
>
> SimpleObjectProperty condition = new
> SimpleObjectProperty<>(true);
> ObservableValue binding =
>
>
>1. Unfortunately, even with ”ignore optional problems” Eclipse
>generates the “missing required source folder”.
>
>
I added the following to the classpath of graphics:
Eclipse adds the non-existent source folder even though there is no such
directory and does
On Fri, 15 Jul 2022 07:19:19 GMT, John Hendrikx wrote:
>> I introduced a bug with the fluent bindings PR which affects all
>> ObjectBindings.
>>
>> This is the code that fails:
>>
>> SimpleObjectProperty condition = new
>> SimpleObjectProperty<>(true);
>> ObservableValue
Ah, I missed that it's during runtime. When I reviewed the PR I tested an
external project which relies on the graphics module and it worked fine. I
will try to find a case that throws this error and see what can be done.
On Fri, Jul 15, 2022 at 9:22 PM Andy Goryachev
wrote:
> Nir:
>
>
>
>
Nir:
1. Unfortunately, even with ”ignore optional problems” Eclipse generates the
“missing required source folder”. Below are the four entries I’ve added to
modules/javafx.graphics/.classpath:
First of all, you can set "ignore optional compile problems" on a source
folder in Eclipse. In fact, these folders were set as such before the
change.
But more importantly, I don't see how classes that are only used in
reflection will cause a build error. If these folders are not referenced in
Kevin:
The four classpath entries in question are
build/hlsl/Prism
build/gensrc/jsl-prism
build/hlsl/Decora
build/gensrc/jsl-decora
once added to the Eclipse .classpath file (in graphics) I see two warnings (on
Mac):
Project 'graphics' is missing required source folder:
On 7/15/2022 9:05 AM, Andy Goryachev wrote:
Nir:
So these folders are not needed to compile, but they are needed to run.
I suggest we bring them back to .classpath
Is there a way to make it conditional?
and also modify build.gradle to create all 4 folders as a part of the
corresponding
Nir:
So these folders are not needed to compile, but they are needed to run.
I suggest we bring them back to .classpath and also modify build.gradle to
create all 4 folders as a part of the corresponding target.
What do you think?
-andy
From: openjfx-dev on behalf of Jeanette
Winzenburg
Jeanette, Nir:
Apparently, the classes in build/gensrc are being accessed via reflection, for
example
D3DResourceFactory. createStockShader()
ES2ResourceFactory. createStockShader()
You say the problem went away after adding the classpath entries manually?
-andy
From: openjfx-dev on
On Fri, 15 Jul 2022 01:17:16 GMT, Nicholas Bosshard wrote:
> This fix seems to break `TreeTableView`.
A new bug has been filed to track this:
[JDK-8290348](https://bugs.openjdk.org/browse/JDK-8290348).
-
PR: https://git.openjdk.org/jfx/pull/808
On Thu, 14 Jul 2022 20:55:25 GMT, Andy Goryachev wrote:
> - using Screen.getVisualBounds() instead of Screen.getBounds()
This pull request has now been integrated.
Changeset: 6d76dea2
Author:Andy Goryachev
Committer: Kevin Rushforth
URL:
On Fri, 15 Jul 2022 07:19:19 GMT, John Hendrikx wrote:
>> I introduced a bug with the fluent bindings PR which affects all
>> ObjectBindings.
>>
>> This is the code that fails:
>>
>> SimpleObjectProperty condition = new
>> SimpleObjectProperty<>(true);
>> ObservableValue
On Fri, 15 Jul 2022 13:53:20 GMT, Nir Lisker wrote:
> Any idea why /issue add is only available to the author?
This is deliberate. Commands like `/issue` and `/summary` are under the purview
of the Author of the PR, since they affect the commit message associated with
this PR.
In any case,
On Thu, 14 Jul 2022 23:55:52 GMT, Kevin Rushforth wrote:
>> I introduced a bug with the fluent bindings PR which affects all
>> ObjectBindings.
>>
>> This is the code that fails:
>>
>> SimpleObjectProperty condition = new
>> SimpleObjectProperty<>(true);
>> ObservableValue
On Thu, 14 Jul 2022 20:55:25 GMT, Andy Goryachev wrote:
> - using Screen.getVisualBounds() instead of Screen.getBounds()
I can confirm that running the full set of tests fails without this fix and
works with this fix.
-
Marked as reviewed by kcr (Lead).
PR:
On Mon, 11 Jul 2022 13:59:36 GMT, Johan Vos wrote:
>> In order to fix the issues reported in JDK-8089589, the VirtualFlow now uses
>> the real sizes of the elements that are displayed. This allows for a more
>> natural way of scrolling through lists that contain items of very different
>>
On Fri, 15 Jul 2022 07:19:19 GMT, John Hendrikx wrote:
>> I introduced a bug with the fluent bindings PR which affects all
>> ObjectBindings.
>>
>> This is the code that fails:
>>
>> SimpleObjectProperty condition = new
>> SimpleObjectProperty<>(true);
>> ObservableValue
Zitat von Nir Lisker :
What resource is the error on?
what do you mean by _resource_? It's on the console ..
On Fri, Jul 15, 2022 at 1:19 PM Jeanette Winzenburg
wrote:
Zitat von Nir Lisker :
Hi Nir,
thanks for the explanation - though I have no idea why Eclipse wants
them (see
What resource is the error on?
On Fri, Jul 15, 2022 at 1:19 PM Jeanette Winzenburg
wrote:
>
> Zitat von Nir Lisker :
>
> Hi Nir,
>
> thanks for the explanation - though I have no idea why Eclipse wants
> them (see them again after re-adding as source folders and all running
> as before).
>
>
Zitat von Nir Lisker :
Hi Nir,
thanks for the explanation - though I have no idea why Eclipse wants
them (see them again after re-adding as source folders and all running
as before).
Not sure where to go from here, would prefer not to have a local
classpath that differs from the one
Zitat von Nir Lisker :
The Eclipse project files were updated recently in
https://github.com/openjdk/jfx/pull/804. The OS-specific folders were
removed. I tested it and I had no issue after this change. On what resource
are you getting this error?
hmm .. don't understand the question, sry
To be more specific, FillPgram_Color_Loader.java is located under the
build/gensrc folder, which is created during the javafx setup depending on
the OS. Specifically, it's under build/gensrc/jsl-prism, which is
Windows-specific.
The change to the classpath file removed these folders from the
The Eclipse project files were updated recently in
https://github.com/openjdk/jfx/pull/804. The OS-specific folders were
removed. I tested it and I had no issue after this change. On what resource
are you getting this error?
On Fri, Jul 15, 2022 at 12:44 PM Jeanette Winzenburg <
Hi,
after synching my master branch with upstream (has been a long while
since my previous update ;), I can't use the Eclipse projects (base,
controls, graphics are the only ones I'm keeping for change in
Eclipse) in another project: when running any application it's
throwing the
On Fri, 15 Jul 2022 09:23:20 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new
> This PR adds a new (lazy*) property on `Node` which provides a boolean which
> indicates whether or not the `Node` is currently part of a `Scene`, which in
> turn is part of a currently showing `Window`.
>
> It also adds a new fluent binding method on `ObservableValue` dubbed `when`
> (open
On Fri, 15 Jul 2022 09:03:35 GMT, John Hendrikx wrote:
> This PR adds a new (lazy*) property on `Node` which provides a boolean which
> indicates whether or not the `Node` is currently part of a `Scene`, which in
> turn is part of a currently showing `Window`.
>
> It also adds a new fluent
This PR adds a new (lazy*) property on `Node` which provides a boolean which
indicates whether or not the `Node` is currently part of a `Scene`, which in
turn is part of a currently showing `Window`.
It also adds a new fluent binding method on `ObservableValue` dubbed `when`
(open for
On Fri, 15 Jul 2022 07:19:19 GMT, John Hendrikx wrote:
>> I introduced a bug with the fluent bindings PR which affects all
>> ObjectBindings.
>>
>> This is the code that fails:
>>
>> SimpleObjectProperty condition = new
>> SimpleObjectProperty<>(true);
>> ObservableValue
On Fri, 15 Jul 2022 01:08:46 GMT, Michael Strauß wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change explanatory comment to block comment
>
>
> I introduced a bug with the fluent bindings PR which affects all
> ObjectBindings.
>
> This is the code that fails:
>
> SimpleObjectProperty condition = new
> SimpleObjectProperty<>(true);
> ObservableValue binding = condition.map(Object::toString);
>
>
32 matches
Mail list logo
