On Thu, 13 Apr 2023 10:53:31 -0500
"Karl O. Pinc" wrote:
> On Thu, 13 Apr 2023 16:01:35 +0200
> Brar Piening wrote:
>
> > On 13.04.2023 at 10:31, Peter Eisentraut wrote:
> > > Side project: I noticed that these new hover links don't appear in
> > > the single-page HTML output (make
On Thu, 13 Apr 2023 16:01:35 +0200
Brar Piening wrote:
> On 13.04.2023 at 10:31, Peter Eisentraut wrote:
> > The first patch has been committed.
>
> Yay - thank you!
>
> > The second patch should be sent to pgsql-www for integrating into
> > the web site.
> Done via [1]. Thanks for the
On Thu, 13 Apr 2023 15:58:03 +0100
Dagfinn Ilmari Mannsåker wrote:
> Peter Eisentraut writes:
> > The first patch has been committed.
> Another side note: I notice the links don't appear on
> elements (e.g.
> https://www.postgresql.org/docs/devel/sql-select.html#SQL-WITH), only
> .
This we
Peter Eisentraut writes:
> On 06.04.23 16:19, Brar Piening wrote:
>> 001-make_html_ids_discoverable_v5.postgresql.patch which needs to be
>> applied to the postgresql repository. It adds the XSLT to generate the
>> id links and the CSS to hide/display them. I've added comments as
>> suggested
On 13.04.2023 at 10:31, Peter Eisentraut wrote:
The first patch has been committed.
Yay - thank you!
The second patch should be sent to pgsql-www for integrating into the
web site.
Done via [1]. Thanks for the hint.
Side project: I noticed that these new hover links don't appear in the
On 06.04.23 16:19, Brar Piening wrote:
001-make_html_ids_discoverable_v5.postgresql.patch which needs to be
applied to the postgresql repository. It adds the XSLT to generate the
id links and the CSS to hide/display them. I've added comments as
suggested above.
On Thu, 6 Apr 2023 16:19:30 +0200
Brar Piening wrote:
> Reviewer is Karl O. Pink
"Karl O. Pinc" actually, with a "c".
Regards,
Karl
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
On 06.04.2023 at 11:06, Peter Eisentraut wrote:
On 04.04.23 21:52, Brar Piening wrote:
The XSLT implementation looks sound to me. It would be a touch better
if it had some comments about which parts of the templates were copied
from upstream stylesheets and which were changed. There are
On 04.04.23 21:52, Brar Piening wrote:
The XSLT implementation looks sound to me. It would be a touch better
if it had some comments about which parts of the templates were copied
from upstream stylesheets and which were changed. There are examples
of such commenting in the existing
For what it's worth, I think having the anchors be always-visible when
CSS disabled is a feature. The content is still perfectly readable,
and the core feature from this patch is available. Introducing
JavaScript to lose that functionality seems like a step backwards.
By the way, the latest patch
On Tue, 4 Apr 2023 21:52:31 +0200
Brar Piening wrote:
> On 04.04.2023 at 16:54, Peter Eisentraut wrote:
> > The XSLT implementation looks sound to me. It would be a touch
> > better if it had some comments about which parts of the templates
> > were copied from upstream stylesheets and which
On 04.04.2023 at 16:54, Peter Eisentraut wrote:
First of all, it works very nicely and is very useful. Very welcome.
Thank you!
The XSLT implementation looks sound to me. It would be a touch better
if it had some comments about which parts of the templates were copied
from upstream
On 23.03.23 20:08, Brar Piening wrote:
I've also attached the (unchanged) make_html_ids_discoverable patch for
convenience so this email now contains two patches for postgresql
(ending with .postgresql.patch) and one patch for pgweb (ending with
.pgweb.patch).
Here is my view on this:
First
On 29.03.23 18:03, Brar Piening wrote:
On 29.03.2023 at 06:52, Hayato Kuroda (Fujitsu) wrote:
FYI - my patch is pushed
Thanks!
Could you please rebase your patch?
Done and tested. Patch is attached.
I have committed the most recent patch that added some missing IDs. (I
also added a
Dear Brar,
Thank you for updating the patch. The patch looks good to me.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
On 29.03.2023 at 06:52, Hayato Kuroda (Fujitsu) wrote:
FYI - my patch is pushed
Thanks!
Could you please rebase your patch?
Done and tested. Patch is attached.
Regards,
Brar
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index fcb53c6997..5c50347c58 100644
---
Dear my comrade Brar,
> Thanks, I actually was not aware of this.
>
> Also, kudos for capturing the missing id and advocating for consistency
> regarding ids even before this is actively enforced. This nurtures my
> optimism that consistency might actually be achieveable without
> everybody
On 28.03.2023 at 00:11, Peter Smith wrote:
FYI, there is a lot of overlap between this last attachment and the
patches of Kuroda-san's current thread here [1] which is also adding
ids to create_subscription.sgml.
(Anyway, I guess you might already be aware of that other thread
because your new
On Tue, Mar 28, 2023 at 4:06 AM Brar Piening wrote:
>
> On 23.03.2023 at 20:08, Brar Piening wrote:
> > Since the need for ids is starting to grow again (ecb696527c added an
> > id to a varlistentry in doc/src/sgml/ref/create_subscription.sgml)
> > I've also amended the add-needed-ids patch once
On 23.03.2023 at 20:08, Brar Piening wrote:
Since the need for ids is starting to grow again (ecb696527c added an
id to a varlistentry in doc/src/sgml/ref/create_subscription.sgml)
I've also amended the add-needed-ids patch once again so that the
build does not fail after applying the
On 24.03.2023 at 10:45, Alvaro Herrera wrote:
But why are there no anchors next to items on that page? For
example, how do I get the link for the "Meta Commands" subsection?
I somehow knew that responding from a crappy mobile phone e-mail client
will mess up the format and the thread...
For
On 2023-Mar-24, brar wrote:
> Alvaro wrote:
> > But why are there no anchors next to items on that page? For
> > example, how do I get the link for the "Meta Commands" subsection?
> I can't look at the code right now, but I suspect the headers are
> refsections (not sections) which this patch
> But why are there no anchors next to> items on that page? For example,>
> how do I get the link for the> "Meta Commands" subsection?I can't look at the
> code right now, but I suspect the headers are refsections (not sections)
> which this patch does not add links for yet.I already have
On 2023-Mar-24, Brar Piening wrote:
> On 23.03.2023 at 23:31, Karl O. Pinc wrote:
> > Hi Brar,
> >
> > It occurs to me that I had not actually tested the
> > way the anchor is put only after the last term in a
> > varlistentry. (The code looked obviously right
> > and should work if any
On 24.03.2023 at 06:48, Brar Piening wrote:
Since (after tweaking the color) the general visual appearence looked
ok to me, I didn't bother with this any further.
Also, if we go on with this we'll probably end up in an almost
prototypical bikeshedding scenario where PostgreSQL itself is the
On 24.03.2023 at 05:09, Karl O. Pinc wrote:
Hi Brar,
An observation: The # that shows up when hovering
over section-level headings is styled as the
section-level heading is. But the # that shows
up when hovering over varlistentrys has the default
text style.
This works for me. It's nice to
On 23.03.2023 at 23:31, Karl O. Pinc wrote:
Hi Brar,
It occurs to me that I had not actually tested the
way the anchor is put only after the last term in a
varlistentry. (The code looked obviously right
and should work if any varlistentry terms have anchors,
which they do, but)
Have you
Hi Brar,
An observation: The # that shows up when hovering
over section-level headings is styled as the
section-level heading is. But the # that shows
up when hovering over varlistentrys has the default
text style.
This works for me. It's nice to have the "section #"s
look like the section
This is for the committer, as an FYI.
I cut out the portion
of the docbook XSLT and diffed it with the code for the
same template in the patch. The diff looks like:
-- /tmp/sections.xsl2023-03-22 13:00:33.432968357 -0500
+++ /tmp/make_html_ids_discoverable_v3.patch2023-03-22
Hi Brar,
It occurs to me that I had not actually tested the
way the anchor is put only after the last term in a
varlistentry. (The code looked obviously right
and should work if any varlistentry terms have anchors,
which they do, but)
Have you tested this? If not, catalog.sgml, the
>
> TBH I'm a bit afraid that people will immediately start complaining
> about the failing docs builds after this got applied since it forces
> them to add ids to all varlistenries in a variablelist if they add one,
> which can be perceived as quite a burden (also committers and reviewers
> will
On 23.03.2023 at 10:35, Alvaro Herrera wrote:
As with the patch, we'll need to patch the CSS used in the
website for the docs too, as that's the most important place where docs
are visited.
Ok, I've created and tested a patch for this too.
Since the need for ids is starting to grow again
On Thu, 23 Mar 2023 10:35:55 +0100
Alvaro Herrera wrote:
> As with the patch, we'll need to patch the CSS used in
> the website for the docs too, as that's the most important place
> where docs are visited. See this commit for an example:
>
On Thu, 23 Mar 2023 08:24:48 +0100
Brar Piening wrote:
> On 23.03.2023 at 04:09, Karl O. Pinc wrote:
> > Sorry for the extra work I've put you through.
>
> No problem. As always I've learnt something which may help me in the
> future.
I don't know about you, but sadly, my brain eventually
On 23.03.2023 at 10:35, Alvaro Herrera wrote:
As with the patch, we'll need to patch the CSS used in the
website for the docs too, as that's the most important place where docs
are visited. See this commit for an example:
Thanks, Brar and Karl, I hope we can get this done soon.
As with the patch, we'll need to patch the CSS used in the
website for the docs too, as that's the most important place where docs
are visited. See this commit for an example:
On 23.03.2023 at 04:09, Karl O. Pinc wrote:
You're quite right. I clearly didn't have my XSLT turned on. Importing
only works when templates are matched, not called by name.
Sorry for the extra work I've put you through.
No problem. As always I've learnt something which may help me in the
On Tue, 21 Mar 2023 23:16:25 +0100
Brar Piening wrote:
> On 17.01.2023 at 23:43, Karl O. Pinc wrote:
> > It's good you asked. After poking about the XSLT 1.0 spec to
> > refresh my memory I abandoned the "mode" approach entirely. The
> > real "right way" is to use the import mechanism.
>
On 17.01.2023 at 23:43, Karl O. Pinc wrote:
It's good you asked. After poking about the XSLT 1.0 spec to refresh
my memory I abandoned the "mode" approach entirely. The real "right
way" is to use the import mechanism.
It actually is not.
After quite some time trying to figure out why things
On 20.03.2023 at 19:47, Gregory Stark (as CFM) wrote:
Looks like a lot of good work was happening on this patch right up
until mid-February. Is there a lot of work left? Do you think you'll
have a chance to wrap it up this commitfest for this release?
Thanks for the ping.
I had another look
On Thu, 26 Jan 2023 at 15:55, Brar Piening wrote:
>
> On 18.01.2023 at 06:50, Brar Piening wrote:
>
> > I'll give it a proper look this weekend.
>
> It turns out I didn't get a round tuit.
>
> ... and I'm afraid I probably will not be able to work on this until
> mid/end February so we'll have to
Hi,
On 2023-02-15 13:34:37 -0600, Karl O. Pinc wrote:
> This makes me think that it would be useful to add --nonet to the
> xsltproc invocations. That would catch this error before it goes to
> CI.
We are doing that now :)
commit 969509c3f2e3b4c32dcf264f9d642b5ef01319f3
Author: Tom Lane
Date:
On Tue, 14 Feb 2023 12:13:18 -0800
Andres Freund wrote:
> A small note: As-is this fails on CI, because we don't allow network
> access during the docs build anymore (since it always fails these
> days):
>
> https://cirrus-ci.com/task/5474029402849280?logs=docs_build#L297
>
> [17:02:03.114]
Hi,
On 2023-01-26 21:48:54 +0100, Brar Piening wrote:
> On 18.01.2023 at 06:50, Brar Piening wrote:
>
> > I'll give it a proper look this weekend.
>
> It turns out I didn't get a round tuit.
>
> ... and I'm afraid I probably will not be able to work on this until
> mid/end February so we'll
On 18.01.2023 at 06:50, Brar Piening wrote:
I'll give it a proper look this weekend.
It turns out I didn't get a round tuit.
... and I'm afraid I probably will not be able to work on this until
mid/end February so we'll have to move this to the next commitfest until
somebody wants to take it
On Tue, 17 Jan 2023 16:43:13 -0600
"Karl O. Pinc" wrote:
> It might be useful to add --nonet to the xsltproc invocation(s)
> in the Makefile(s). Just in case; to keep from retrieving
> stylesheets from the net. (If the option is not already there.
> I didn't look.)
>
> If this is the first
On 17.01.2023 at 23:43, Karl O. Pinc wrote:
It's good you asked. After poking about the XSLT 1.0 spec to refresh
my memory I abandoned the "mode" approach entirely. The real "right
way" is to use the import mechanism.
I've attached a patch that "wraps" the section.heading template
and adds
On Tue, 17 Jan 2023 19:13:38 +0100
Brar Piening wrote:
> On 17.01.2023 at 14:12, Karl O. Pinc wrote:
> > If you're not willing to try I am willing to see if I can
> > produce an example to work from. My XSLT is starting to
> > come back.
>
> I'm certainly willing to try but I'd appreciate an
On 17.01.2023 at 14:12, Karl O. Pinc wrote:
If you're not willing to try I am willing to see if I can
produce an example to work from. My XSLT is starting to
come back.
I'm certainly willing to try but I'd appreciate an example in any case.
My XSLT skills are mostly learning by doing
On Tue, 17 Jan 2023 06:57:23 +0100
Brar Piening wrote:
> On 17.01.2023 at 02:05, Karl O. Pinc wrote:
> > Or maybe the right way is to set a mode at the very top,
> > the first apply-templates call, and not mess with the
> > built-in templates at all. (You'd write your own
> > "postgres-mode"
On 17.01.2023 at 02:05, Karl O. Pinc wrote:
Or maybe the right way is to set a mode at the very top,
the first apply-templates call, and not mess with the
built-in templates at all. (You'd write your own
"postgres-mode" templates the same way, to "wrap"
and call the default templates.)
Think
On Mon, 16 Jan 2023 11:14:35 -0600
"Karl O. Pinc" wrote:
> On Sun, 15 Jan 2023 18:01:50 -0600
> "Karl O. Pinc" wrote:
>
> > Regards XSLT:
> >
> > I believe the XSLT needs work.
> In XSLT 1.0 there is no xml:default-mode. So I _think_ what you do
> then is modify the built-in template
On Sun, 15 Jan 2023 18:01:50 -0600
"Karl O. Pinc" wrote:
> Regards XSLT:
>
> I believe the XSLT needs work.
> I believe that overriding the XSLT by copying the original and making
> modifications is the "wrong way" (TM). I think that the right way is
> to declare a xsl:default-mode somewhere
On Sun, 15 Jan 2023 18:01:50 -0600
"Karl O. Pinc" wrote:
> Regards XSLT:
>
> I believe the XSLT needs work.
I also think that the XSLT should error and halt
when there's no id (in the expected places).
Instead of just giving a warning and keeping going. Otherwise
they'll constantly be
Hi Brar,
Here's my first review of the make_html_ids_discoverable.patch.
Overall:
To start with, I'd like to say I like the goal and how everything
works when the patch is applied. I was a bit skeptical, thinking that
the whole thing was going to be distracting when reading the docs or
On 09.01.23 21:18, Tom Lane wrote:
* AFAIK our practice is to use "-" never "_" in XML ID attributes.
You weren't very consistent about that even within this patch, and
the overall effect would have been to have no standard about that
at all, which doesn't seem great. I changed them all to "-".
On 10.01.2023 at 06:28, Brar Piening wrote:
I'll repost a rebased version of the styling patch in a minute.
After checking that there's no need for rebasing I'm reposting the
original patch here, to make cfbot pick it up as the latest one in a
somewhat screwed up thread mixing two patches
On 09.01.2023 at 23:28, Karl O. Pinc wrote:
On Mon, 09 Jan 2023 15:18:18 -0500
Tom Lane wrote:
It's probably going to be necessary to have follow-on patches,
because I'm sure there is stuff in the pipeline that adds more
ID-less tags. Or do we have a way to create warnings about that?
I am
Brar Piening writes:
> On 09.01.2023 at 21:18, Tom Lane wrote:
>> * I got rid of a couple of "-et-al" additions, because it did not
>> seem like a good precedent. That would tempt people to modify
>> existing ID tags when adding variables to an entry, which'd defeat
>> the purpose I think.
> I
On 09.01.2023 at 21:18, Tom Lane wrote:
It's not great to have multiple CF entries pointing at the same email
thread --- it confuses both people and bots. Next time please split
off a thread for each distinct patch.
I agree. I had overestimated the cfbot's ability to handle branched
threads.
"Karl O. Pinc" writes:
> I think there's more to comment on regards the xslt in the
> other patch, but I'll wait for the new thread for that patch.
> That might be where there should be warnings raised, etc.
We can continue using this thread, now that the other commit is in.
On Mon, 09 Jan 2023 15:18:18 -0500
Tom Lane wrote:
> Brar Piening writes:
> > On 09.01.2023 at 03:38, vignesh C wrote:
> >> There are couple of commitfest entries for this:
> >> https://commitfest.postgresql.org/41/4041/
> >> https://commitfest.postgresql.org/41/4042/ Can one of them be
> >>
On Mon, 09 Jan 2023 15:18:18 -0500
Tom Lane wrote:
> I pushed the ID-addition patch, with a few fixes:
>
> * AFAIK our practice is to use "-" never "_" in XML ID attributes.
> You weren't very consistent about that even within this patch, and
> the overall effect would have been to have no
Brar Piening writes:
> On 09.01.2023 at 03:38, vignesh C wrote:
>> There are couple of commitfest entries for this:
>> https://commitfest.postgresql.org/41/4041/
>> https://commitfest.postgresql.org/41/4042/ Can one of them be closed?
> I've split the initial patch into two parts upon Álvaro's
On Mon, 9 Jan 2023 08:09:02 +0100
Brar Piening wrote:
> On 09.01.2023 at 03:31, vignesh C wrote:
> > The patch does not apply on top of HEAD as in [1], please post a
> > rebased patch:
> This one applies on top of 3c569049b7b502bb4952483d19ce622ff0af5fd6
> and the documentation build
On 09.01.2023 at 03:38, vignesh C wrote:
There are couple of commitfest entries for this:
https://commitfest.postgresql.org/41/4041/
https://commitfest.postgresql.org/41/4042/ Can one of them be closed?
I've split the initial patch into two parts upon Álvaro's request in [1]
so that we can
On Mon, 9 Jan 2023 at 08:01, vignesh C wrote:
>
> On Wed, 4 Jan 2023 at 04:13, Karl O. Pinc wrote:
> >
> > On Tue, 3 Jan 2023 21:35:09 +0100
> > Brar Piening wrote:
> >
> > > On 02.01.2023 at 21:53, Karl O. Pinc wrote:
> > > > If the author will look over my version of the patch I believe it
>
On Wed, 4 Jan 2023 at 04:13, Karl O. Pinc wrote:
>
> On Tue, 3 Jan 2023 21:35:09 +0100
> Brar Piening wrote:
>
> > On 02.01.2023 at 21:53, Karl O. Pinc wrote:
> > > If the author will look over my version of the patch I believe it
> > > can be approved and sent on to the committers.
> >
> >
On Tue, 3 Jan 2023 21:35:09 +0100
Brar Piening wrote:
> On 02.01.2023 at 21:53, Karl O. Pinc wrote:
> > If the author will look over my version of the patch I believe it
> > can be approved and sent on to the committers.
>
> LGTM.
Approved for committer!
Regards,
Karl
Free Software: "You
On 02.01.2023 at 21:53, Karl O. Pinc wrote:
If the author will look over my version of the patch I believe it can
be approved and sent on to the committers.
LGTM.
Thanks!
Brar
On 06.12.2022 at 19:11, Brar Piening wrote:
The current statistics for docbook elements with/without ids after
applying the patch are the following:
Somehow my e-mail client destroyed the table. That's how it was supposed
to look like:
name | with_id | without_id | id_coverage |
On 06.12.2022 at 18:59, Brar Piening wrote:
On 06.12.2022 at 09:38, Alvaro Herrera wrote:
I would welcome separate patches: one to add the IDs, another for the
XSL/CSS stuff. That allows us to discuss them separately.
I'll send two patches in two separate e-mails in a moment.
This is patch
On 06.12.2022 at 09:38, Alvaro Herrera wrote:
I care. The problem last time is that we were in the middle of the last
commitfest, so we were (or at least I was) distracted by other stuff.
Ok, thanks. That's appreciated and understood.
Looking at the resulting psql page,
On 2022-Dec-06, Brar Piening wrote:
> On 06.12.2022 at 01:55, Ian Lawrence Barwick wrote:
>
> > Oh, now you mention it, I vaguely recall seeing those. However the thread
> > stalled back in March and the patches don't seem to have made it to a
> > CommitFest entry.
>
> Yes, my patches added
On 06.12.2022 at 01:55, Ian Lawrence Barwick wrote:
Oh, now you mention it, I vaguely recall seeing those. However the thread
stalled back in March and the patches don't seem to have made it to a
CommitFest entry.
Yes, my patches added quite a few ids and also some xsl/css logic to
make them
2022年12月5日(月) 18:56 Alvaro Herrera :
>
> On 2022-Dec-05, Ian Lawrence Barwick wrote:
>
> > On this page:
> >
> > https://www.postgresql.org/docs/current/extend-extensions.html
> >
> > three of the sections are missing an "id" attribute; patch adds
> > these. Noticed when trying to create a
On 2022-Dec-05, Ian Lawrence Barwick wrote:
> On this page:
>
> https://www.postgresql.org/docs/current/extend-extensions.html
>
> three of the sections are missing an "id" attribute; patch adds
> these. Noticed when trying to create a stable link to one of the affected
> sections.
Hm, I
Hi
On this page:
https://www.postgresql.org/docs/current/extend-extensions.html
three of the sections are missing an "id" attribute; patch adds
these. Noticed when trying to create a stable link to one of the affected
sections.
Regards
Ian Barwick
From
78 matches
Mail list logo
