2015-03-25 0:17 GMT+01:00 Tom Lane :
> Pavel Stehule writes:
> > updated version with Jim Nasby's doc and rebase against last changes in
> > plpgsql.
>
> I started looking at this patch. ISTM there are some pretty questionable
> design decisions in it:
>
> 1. Why create a core GUC to control a b
On Tue, Mar 24, 2015 at 03:08:26PM -0400, Bruce Momjian wrote:
> On Tue, Mar 24, 2015 at 10:05:12AM -0400, Bruce Momjian wrote:
> > On Tue, Mar 24, 2015 at 09:47:56AM -0400, Noah Misch wrote:
> > > On Sun, Mar 22, 2015 at 10:53:12PM -0400, Bruce Momjian wrote:
> > > > On Sun, Mar 22, 2015 at 04:41:
2015-03-24 21:19 GMT+01:00 Вадим Горбачев :
> I came across correspondences:
>
> http://www.postgresql.org/message-id/cafjnryu+z1kfkt1..44k4pg69ou7fu...@mail.gmail.com
>
> http://www .
> posatgresql.org/message-id/9a28c8860f777e439aa12e8aea7694f8fb8...@bpxm15gp.gisp.nec.co.jp
> as I understand, in
On Wed, Mar 25, 2015 at 8:26 AM, Tom Lane wrote:
> Hm. We're all agreed that there's a use case for exposing PG_VERSION_NUM
> to the makefiles, but I did not hear one for adding it to pg_config; and
> doing the former takes about two lines whereas adding a pg_config option
> entails quite a lot o
On Tue, Mar 24, 2015 at 09:26:10AM -0700, Jeff Anton wrote:
> The issue of significant (decimal) digits to and from floating point
> representation is a complex one.
>
> What 'significant' means may depend upon the intent.
True. I meant simply that Oracle TO_CHAR emits no more than 17 nonzero di
On Tue, Mar 24, 2015 at 07:26:18PM -0400, Tom Lane wrote:
> Andrew Gierth writes:
> > "Tom" == Tom Lane writes:
> > Tom> I concur with Michael that there's value in exposing the version
> > Tom> number in the numeric form used by PG_VERSION_NUM. However, I
> > Tom> also concur with Andrew tha
On Wed, Mar 25, 2015 at 4:52 AM, Bruce Momjian wrote:
> On Tue, Mar 24, 2015 at 11:15:33AM +0900, Michael Paquier wrote:
>> On Tue, Mar 24, 2015 at 8:44 AM, Bruce Momjian wrote:
>> > Notice the added 'l' next to the '<'. Updated patch attached. Any
>> > other issues?
>>
>> Ah, right. That's a go
> > At this moment, I'm not 100% certain about its logic. Especially, I didn't
> > test SEMI- and ANTI- join cases yet.
> > However, time is money - I want people to check overall design first, rather
> > than detailed debugging. Please tell me if I misunderstood the logic to
> > break
> > down jo
Robert Haas wrote:
> On Wed, Mar 18, 2015 at 7:10 PM, Andres Freund wrote:
> >> + /*
> >> + * For now, parallel operations are required to be strictly
> >> read-only.
> >> + * Unlike heap_update() and heap_delete(), an insert should never
> >> create
> >> + * a combo CID, so
On Wed, Mar 25, 2015 at 12:13 PM, Tatsuo Ishii wrote:
> SyncRepWakeQueue (src/backend/replication/syncrep.c) is not used
> anywhere except in the file. If there's no good reason for it, I think
> it should be declared as a static function. Included patch does so.
That's indeed contradictory with
> On Wed, Mar 25, 2015 at 12:38 AM, David Steele wrote:
>>> 2. OBJECT auditing does not work before adding acl info to pg_class.rel_acl.
>>> In following situation, pg_audit can not audit OBJECT log.
>>> $ cat postgresql.conf | grep audit
>>> shared_preload_libraries = 'pg_audit'
>>> pg_audit.role
SyncRepWakeQueue (src/backend/replication/syncrep.c) is not used
anywhere except in the file. If there's no good reason for it, I think
it should be declared as a static function. Included patch does so.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.p
On Mon, Feb 16, 2015 at 4:46 AM, Andres Freund wrote:
>> At a quick glance, this basic design seems workable. I would suggest
>> expanding the replication IDs to regular 4 byte oids. Two extra bytes is a
>> small price to pay, to make it work more like everything else in the system.
>
> I don't kn
On Tue, Mar 24, 2015 at 8:46 PM, Thom Brown wrote:
> The index is unlogged until reindexing...
>
> [...]
> Which is think also raises the question, why are unlogged indexes made
> persistent by a reindex?
That's a bug of HEAD, ~9.4 keeping the index as unlogged even after
REINDEX INDEX. What happe
On 24/03/15 20:56, Bruce Momjian wrote:
On Fri, Mar 20, 2015 at 04:43:42PM -0400, Bruce Momjian wrote:
On Sat, Nov 8, 2014 at 09:53:18PM +0100, Álvaro Hernández Tortosa wrote:
On 07/11/14 22:02, Greg Sabino Mullane wrote:
Kevin Grittner wrote:
I think most people have always assumed that
BE
> "Kyotaro" == Kyotaro HORIGUCHI writes:
Kyotaro> Hello,
Kyotaro> Grep showed me some unfixed usages of bare constant or
Kyotaro> INT64CONST as (u)int64 max/min values.
Kyotaro> ./src/interfaces/ecpg/pgtypeslib/dt.h:
I didn't touch the ecpg stuff since it wasn't too clear that it was sa
On Tue, Mar 24, 2015 at 8:37 PM, Andres Freund wrote:
> On March 24, 2015 12:35:28 PM GMT+01:00, Michael Paquier wrote:
> I think Thom's point is that he promoted the node...
>
> Thom, are you sure this want transient?
Well, I got his point :)
I was just thinking that this error message is legit,
Hi David,
Thank you for your answer!
On Wed, Mar 25, 2015 at 12:38 AM, David Steele wrote:
> Hi Sawada,
>
> Thank you for taking the time to look at the patch.
>
> On 3/24/15 10:28 AM, Sawada Masahiko wrote:
>> I've applied these patchese successfully.
>>
>> I looked into this module, and had a
Hello,
Grep showed me some unfixed usages of bare constant or INT64CONST
as (u)int64 max/min values.
At Tue, 24 Mar 2015 21:57:42 +, Andrew Gierth
wrote in <87619q6ouh@news-spur.riddles.org.uk>
> > "Kevin" == Kevin Grittner writes:
> Kevin> Well, InvalidSerCommitSeqNo was initiall
On Fri, Mar 20, 2015 at 04:28:38PM -0400, Bruce Momjian wrote:
> On Fri, Mar 20, 2015 at 08:43:21AM -0700, David G. Johnston wrote:
> > On Thu, Mar 19, 2015 at 6:49 PM, Bruce Momjian wrote:
> > It is making a point about nulls and stuff. There are later queries
> > that use format().
> >
On Fri, Mar 20, 2015 at 04:43:42PM -0400, Bruce Momjian wrote:
> On Sat, Nov 8, 2014 at 09:53:18PM +0100, Álvaro Hernández Tortosa wrote:
> >
> > On 07/11/14 22:02, Greg Sabino Mullane wrote:
> > >Kevin Grittner wrote:
> > >>>I think most people have always assumed that
> > >>>BEGIN starts the tr
On Tue, Mar 24, 2015 at 11:19:08PM +0300, Вадим Горбачев wrote:
> I came across correspondences:
> http://www.postgresql.org/message-id/
> cafjnryu+z1kfkt1..44k4pg69ou7fu...@mail.gmail.com
>
> http://www .posatgresql.org/message-id/
> 9a28c8860f777e439aa12e8aea7694f8fb8...@bpxm15gp.gisp.nec.co.jp
On Sun, Mar 22, 2015 at 04:08:32AM +, Andrew Gierth wrote:
> > "Bruce" == Bruce Momjian writes:
>
> > ! However, calculations on numeric values is very slow
>
> arithmetic ... is, but calculations ... are
Ah, good point. Fixed an applied. Thanks.
--
Bruce Momjian h
Andrew Gierth writes:
> "Tom" == Tom Lane writes:
> Tom> I concur with Michael that there's value in exposing the version
> Tom> number in the numeric form used by PG_VERSION_NUM. However, I
> Tom> also concur with Andrew that if the use-case for this is
> Tom> Makefiles, pg_config is a pret
Pavel Stehule writes:
> updated version with Jim Nasby's doc and rebase against last changes in
> plpgsql.
I started looking at this patch. ISTM there are some pretty questionable
design decisions in it:
1. Why create a core GUC to control a behavior that's plpgsql-only?
I think it'd make more
On Tue, Mar 24, 2015 at 3:26 PM, Andres Freund wrote:
>> >> + - The currently active user ID and security context. Note that this is
>> >> +the fourth user ID we restore: the initial step of binding to the
>> >> correct
>> >> +database also involves restoring the authenticated user ID.
> "Kevin" == Kevin Grittner writes:
>> I didn't replace the 0x ones because most or all of them
>> looked like basically bit-masking operations rather than actually
>> dealing with the bounds of an unsigned int or uint32. I was
>> specifically looking for places where literals wer
> "Tom" == Tom Lane writes:
Michael> Well, my point is to have something on which you can directly
Michael> apply maths on without changing its shape ;)
>> There's this trick:
>> # if version < 9.1 ...
>> ifeq ($(filter-out 7.% 8.% 9.0, $(MAJORVERSION)),)
>> # stuff
>> endif
>> # i
Andrew Gierth wrote:
> I didn't replace the 0x ones because most or all of them looked
> like basically bit-masking operations rather than actually dealing with
> the bounds of an unsigned int or uint32. I was specifically looking for
> places where literals were being used to represent m
On 24/03/15 16:33, Andres Freund wrote:
Hi,
Here's the next version of this patch. I've tried to address the biggest
issue (documentation) and some more. Now that both the more flexible
commit WAL record format and the BKI_FORCE_NOT_NULL thing is in, it
looks much cleaner.
Nice, I see you als
Andres Freund writes:
> Also: Man, trying to understand the guts of deadlock.c only made me
> understand how *friggin* expensive deadlock checking is. I'm really
> rather surprised that it only infrequently causes problems.
The reason for that is that we only run deadlock checking if something's
I like the idea of using extra_float_digits (which I always set this to 3 to
ensure I don't lose precision).
http://docs.oracle.com/cd/E19957-01/806-3568/ncg_goldberg.html#1251
Theorem 15
"When a binary IEEE single precision number is converted to the closest
eight digit decimal number,
Andrew Gierth writes:
> "Michael" == Michael Paquier writes:
> Michael> Well, my point is to have something on which you can directly
> Michael> apply maths on without changing its shape ;)
> There's this trick:
> # if version < 9.1 ...
> ifeq ($(filter-out 7.% 8.% 9.0, $(MAJORVERSION)),)
> #
> "Andres" == Andres Freund writes:
>> This replaces the one I posted before; it does both INT64_MIN/MAX and
>> INT32_MIN/MAX, and also int16/int8/uint*. Uses of 0x7fff in code
>> have been replaced unless there was a reason not to, with either INT_MAX
>> or INT32_MAX according to the
Hi,
Here's the next version of this patch. I've tried to address the biggest
issue (documentation) and some more. Now that both the more flexible
commit WAL record format and the BKI_FORCE_NOT_NULL thing is in, it
looks much cleaner.
Changes:
* Loads of documentation and comments
* Revamped locki
Hi,
On 2015-03-22 17:20:22 +, Andrew Gierth wrote:
> This replaces the one I posted before; it does both INT64_MIN/MAX and
> INT32_MIN/MAX, and also int16/int8/uint*. Uses of 0x7fff in code
> have been replaced unless there was a reason not to, with either INT_MAX
> or INT32_MAX according
On 2015-03-19 14:13:59 -0400, Robert Haas wrote:
> On Wed, Mar 18, 2015 at 5:36 PM, Andres Freund wrote:
> > Reading the README first, the rest later. So you can comment on my
> > comments, while I actually look at the code. Parallelism, yay!
>
> Sorry, we don't support parallelism yet. :-)
And
I came across correspondences:
http://www.postgresql.org/message-id/cafjnryu+z1kfkt1..44k4pg69ou7fu...@mail.gmail.com
http://www .
posatgresql.org/message-id/9a28c8860f777e439aa12e8aea7694f8fb8...@bpxm15gp.gisp.nec.co.jp
as I understand, in this https://github.com/dobesv/restgres/project the
idea
On Tue, Mar 24, 2015 at 4:28 PM, Fabrízio de Royes Mello <
fabriziome...@gmail.com> wrote:
>
>
>
> On Mon, Mar 23, 2015 at 12:33 PM, Tom Lane wrote:
> >
> > =?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?=
writes:
> > > On Fri, Mar 20, 2015 at 4:37 PM, Tom Lane wrote:
> > We could fix it by, say, h
Robert Haas wrote:
> On Thu, Mar 12, 2015 at 9:57 AM, Alvaro Herrera
> wrote:
>> However, there's a difference between making a query silently given
>> different results, and breaking it completely forcing the user to
>> re-study how to write it. I think the latter is better. In that light
>>
Etsuro Fujita writes:
> Let me explain further. Here is the comment in ExecOpenScanRelation:
> * Determine the lock type we need. First, scan to see if target
> relation
> * is a result relation. If not, check if it's a FOR UPDATE/FOR SHARE
> * relation. In either of those
On Tue, Mar 24, 2015 at 11:15:33AM +0900, Michael Paquier wrote:
> On Tue, Mar 24, 2015 at 8:44 AM, Bruce Momjian wrote:
> > Notice the added 'l' next to the '<'. Updated patch attached. Any
> > other issues?
>
> Ah, right. That's a good catch and your patch fixes the issue. Still,
> there are p
On Mon, Mar 23, 2015 at 12:33 PM, Tom Lane wrote:
>
> =?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?= writes:
> > On Fri, Mar 20, 2015 at 4:37 PM, Tom Lane wrote:
> We could fix it by, say, having CheckConstraintFetch() sort the
> constraints by name after loading them.
>
> > Isn't better do
On Tue, Mar 24, 2015 at 10:05:12AM -0400, Bruce Momjian wrote:
> On Tue, Mar 24, 2015 at 09:47:56AM -0400, Noah Misch wrote:
> > On Sun, Mar 22, 2015 at 10:53:12PM -0400, Bruce Momjian wrote:
> > > On Sun, Mar 22, 2015 at 04:41:19PM -0400, Noah Misch wrote:
> > > > On Wed, Mar 18, 2015 at 05:52:44P
> "Jeff" == Jeff Anton writes:
Jeff> Postgresql seems to be using the first interpretation and
Jeff> reporting fewer digits. I've noticed this with pg_dump. That a
Jeff> dump and restore of floating point values does not produce the
Jeff> same floating point values. To me, that is inex
The issue of significant (decimal) digits to and from floating point
representation is a complex one.
What 'significant' means may depend upon the intent.
There are (at least) two different tests which may need to be used.
* How many digits can be stored and then accurately returned?
or
* How
Hi Sawada,
Thank you for taking the time to look at the patch.
On 3/24/15 10:28 AM, Sawada Masahiko wrote:
> I've applied these patchese successfully.
>
> I looked into this module, and had a few comments as follows.
> 1. pg_audit audits only one role currently.
> In currently code, we can not m
On Tue, Mar 24, 2015 at 3:17 AM, Alvaro Herrera
wrote:
> Sawada Masahiko wrote:
>
>> I tied to look into latest patch, but got following error.
>>
>> masahiko [pg_audit] $ LANG=C make
>> gcc -Wall -Wmissing-prototypes -Wpointer-arith
>> -Wdeclaration-after-statement -Wendif-labels
>> -Wmissing-for
king on.
1) Postgres is inited and started:
initdb -D /test/db/common -A trust;pg_ctl start -o "-c port=6543 -c
checkpoint_segments=1 -c log_timezone='Australia/Sydney' -c
timezone='Australia/Sydney' -c wal_level=hot_standby -c archive_mode=on
-c archive_command='
On Tue, Mar 24, 2015 at 09:47:56AM -0400, Noah Misch wrote:
> On Sun, Mar 22, 2015 at 10:53:12PM -0400, Bruce Momjian wrote:
> > On Sun, Mar 22, 2015 at 04:41:19PM -0400, Noah Misch wrote:
> > > On Wed, Mar 18, 2015 at 05:52:44PM -0400, Bruce Momjian wrote:
> > > > This "junk" digit zeroing matches
Anastasia Lubennikova writes:
> There is a problem of slow counting in PostgreSQL [1]. The reason why this
> is slow is related to the *MVCC* implementation in PostgreSQL. Index-only
> scans (implemented since PostgreSQL-9.2) providing some performance
> improvements where the *visibility map* of
On Sun, Mar 22, 2015 at 10:53:12PM -0400, Bruce Momjian wrote:
> On Sun, Mar 22, 2015 at 04:41:19PM -0400, Noah Misch wrote:
> > On Wed, Mar 18, 2015 at 05:52:44PM -0400, Bruce Momjian wrote:
> > > This "junk" digit zeroing matches the Oracle behavior:
> > >
> > > SELECT to_char(1.12345678912345
On Mon, Mar 23, 2015 at 09:41:40PM +, Andrew Gierth wrote:
> > "Peter" == Peter Geoghegan writes:
>
> Peter> As I said, I don't really consider that my patch is a rewrite,
> Peter> especially V4, which changes nothing substantive except removing
> Peter> 32-bit support.
>
> Well, that
Hi, thanks for the new patch.
I made an additional shrink from your last one. Do you have a
look on the attached?
At Sun, 22 Mar 2015 19:42:21 +1300, David Rowley wrote
in
> On 20 March 2015 at 21:11, David Rowley wrote:
> >
> > I can continue working on your patch if you like? Or are you pla
On 24 March 2015 at 11:46, Thom Brown wrote:
>
> On 24 March 2015 at 11:37, Andres Freund wrote:
>
>> On March 24, 2015 12:35:28 PM GMT+01:00, Michael Paquier <
>> michael.paqu...@gmail.com> wrote:
>> >On Tue, Mar 24, 2015 at 5:53 PM, Thom Brown wrote:
>> >> I was attempting to set up a data se
Hi, hackers!
Here is the text of my proposal which I've applied to GSoC.
(and link
http://www.google-melange.com/gsoc/proposal/public/google/gsoc2015/lubennikovaav/5657382461898752
)
Any suggestions and comments are welcome.
*Project name*
Bitmap Index-only Count
*Brief review*
There is a p
On 24 March 2015 at 11:37, Andres Freund wrote:
> On March 24, 2015 12:35:28 PM GMT+01:00, Michael Paquier <
> michael.paqu...@gmail.com> wrote:
> >On Tue, Mar 24, 2015 at 5:53 PM, Thom Brown wrote:
> >> I was attempting to set up a data set to test pg_rewind, when I
> >encountered
> >> an error
On March 24, 2015 12:35:28 PM GMT+01:00, Michael Paquier
wrote:
>On Tue, Mar 24, 2015 at 5:53 PM, Thom Brown wrote:
>> I was attempting to set up a data set to test pg_rewind, when I
>encountered
>> an error. I created a primary and standby, then:
>>
>> [...]
>>
>> # insert into utest (thing) v
2015-03-23 17:11 GMT+01:00 Pavel Stehule :
> Hi
>
> 2015-03-15 16:09 GMT+01:00 Tom Lane :
>
>> Pavel Stehule writes:
>> > other variant, I hope better than previous. We can introduce new long
>> > option "--strict". With this active option, every pattern specified by
>> -t
>> > option have to hav
On Tue, Mar 24, 2015 at 5:53 PM, Thom Brown wrote:
> I was attempting to set up a data set to test pg_rewind, when I encountered
> an error. I created a primary and standby, then:
>
> [...]
>
> # insert into utest (thing) values ('moomoo');
> ERROR: index "utest_pkey" contains unexpected zero pa
2015/03/23 9:12、Kouhei Kaigai のメール：
> Sorry for my response late. It was not easy to code during business trip.
>
> The attached patch adds a hook for FDW/CSP to replace entire join-subtree
> by a foreign/custom-scan, according to the discussion upthread.
>
> GetForeignJoinPaths handler of FDW
Hello,
On 03/24/15 06:34, Kyotaro HORIGUCHI wrote:
Sorry, not shown above, the *previous* t1 had been done "alter table
t1 add statistics (a, b, c)". Removing t1 didn't remove the setting.
reiniting cluster let me do that without error.
OK, thanks. My guess is this issue got already fixed in
On Tue, Mar 24, 2015 at 9:54 AM, David Steele wrote:
> On 3/23/15 12:42 AM, Venkata Balaji N wrote:
> > Hi,
> >
> > Assuming that this might require a patch, i am posting this in
> > pgsql-hackers. Apologies, if this is not the appropriate mailing list to
> > start this discussion.
> >
> > I perf
Hi,
I was attempting to set up a data set to test pg_rewind, when I encountered
an error. I created a primary and standby, then:
# create table test (id serial primary key, thing text);
CREATE TABLE
# create unlogged table utest (id serial primary key, thing text);
CREATE TABLE
# insert into t
On 24 March 2015 at 17:51, Ashutosh Bapat
wrote:
>
> In case of million inserts or bulk load with constraints on, these few
> cycles spent in ordering the constraints might be problematic, unless the
> ordering happens only once for a series of inserts.
>
As far as I can see this sort only occu
So here's the latest (and, hopefully, last) version:
- adds diagnostic output from numeric_abbrev_abort using the trace_sort
GUC
- fixed Datum cs. uint32 issues in hash_uint32
- added a short comment about excess-k representation
- tweaked the indenting and comments a bit
I'm not partic
66 matches
Mail list logo
