Hello Tom,
sub pgbench($)
My concern is basically about maintaining coding style consistency.
Yes, I'm fine with that. I have removed it in the v12 patch.
reasons why it's not like that already. I do have to say that many of
the examples I've seen look more like line noise than reada
Here is the copyright in partition.h:
* Copyright (c) 2007-2017, PostgreSQL Global Development Group
I think it's reasonable that that matches the copyright in partition.c,
but partition.c has:
* Portions Copyright (c) 1996-2017, PostgreSQL Global Development Group
* Portions Copyright (c)
On Tue, Sep 5, 2017 at 12:06 PM, Amit Langote
wrote:
> On 2017/09/05 15:30, Ashutosh Bapat wrote:
>> Those changes are already part of my updated 0001 patch. Aren't they?
>> May be you should just review those and see if those are suitable for
>> you?
>
> Yeah, I think it's going to be the same pa
Thank you for the opinions.
At Tue, 29 Aug 2017 15:00:57 +0900, Masahiko Sawada
wrote in
> On Tue, Aug 29, 2017 at 10:16 AM, Robert Haas wrote:
> > On Mon, Aug 28, 2017 at 5:26 AM, Kyotaro HORIGUCHI
> > wrote:
> >> Currently the message shows the '%d skipped-frozen' message but
> >> it is ins
On 2017/09/05 15:30, Ashutosh Bapat wrote:
> Those changes are already part of my updated 0001 patch. Aren't they?
> May be you should just review those and see if those are suitable for
> you?
Yeah, I think it's going to be the same patch, functionality-wise.
And sorry, I didn't realize you were
On 2017/09/05 13:20, Amit Langote wrote:
On 2017/09/04 21:32, Ashutosh Bapat wrote:
+1. Will Fujita-san's patch also handle getting rid of partitioned_rels list?
As Fujita-san mentioned, his patch won't. Actually, I suppose he didn't
say that partitioned_rels itself is useless, just that it
On Tue, Sep 5, 2017 at 11:54 AM, Amit Langote
wrote:
> On 2017/09/05 13:20, Amit Langote wrote:
>> The later phase can
>> build that list from the AppendRelInfos that you mention we now [1] build.
>>
>> [1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=30833ba154
>
> Looking at th
On 2017/09/05 13:20, Amit Langote wrote:
> The later phase can
> build that list from the AppendRelInfos that you mention we now [1] build.
>
> [1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=30833ba154
Looking at that commit again, AppendRelInfos are still not created for
part
On 4 September 2017 at 06:34, Amit Langote
wrote:
> Hi Amit,
>
> On 2017/09/03 16:07, Amit Khandekar wrote:
>> On 31 August 2017 at 13:06, Amit Langote
>> wrote:
Mind you, that idea has some problems anyway in the face of default
partitions, null partitions, and list partitions which a
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
This feature is obviously a pretty deep cut, and I don't understand the J
On 2017/09/04 21:32, Ashutosh Bapat wrote:
> On Mon, Sep 4, 2017 at 10:04 AM, Amit Langote wrote:
>> By the way, if you want to get rid of PartitionedChildRelInfo, you can do
>> that as long as you find some other way of putting together the
>> partitioned_rels list to add into the ModifyTable (App
On Tue, Sep 5, 2017 at 12:24 PM, Michael Paquier
wrote:
> On Tue, Sep 5, 2017 at 12:05 PM, Masahiko Sawada
> wrote:
>> In get_rel_oids() we often switch the memory context to vac_context
>> and switch back. As a result almost code in get_rel_oids() is working
>> in vac_context. Maybe we can swit
> FWIW, I find that good ol' patch is much more reliable about applying
> patches that didn't come from git itself. In this case
>
>
Thanks, I knew I was missing something!
Ryan
Hi all,
Cache lookup errors with elog() can be triggered easily by users at
SQL level using replication origin functions:
=# select pg_replication_origin_advance('popo', '0/1');
ERROR: XX000: cache lookup failed for replication origin 'popo'
LOCATION: replorigin_by_name, origin.c:229
=# select p
Ryan Murphy writes:
> I downloaded the latest patch "clean-nodeModifyTable-v2.patch"
> and tried applying it to HEAD using "git apply ".
> The only response from git was "fatal: unrecognized input".
FWIW, I find that good ol' patch is much more reliable about applying
patches that didn't come fr
On 2017/09/04 21:32, Ashutosh Bapat wrote:
On Mon, Sep 4, 2017 at 10:04 AM, Amit Langote
By the way, if you want to get rid of PartitionedChildRelInfo, you can do
that as long as you find some other way of putting together the
partitioned_rels list to add into the ModifyTable (Append/MergeAppend
Fabien COELHO writes:
>> * In the same vein, I don't know what this does:
>> sub pgbench($)
>> and I see no existing instances of it elsewhere in our tree. I think it'd
>> be better not to require advanced degrees in Perl programming in order to
>> read the test cases.
> It just says that 5
Hello!
I downloaded the latest patch "clean-nodeModifyTable-v2.patch"
and tried applying it to HEAD using "git apply ".
The only response from git was "fatal: unrecognized input".
I tried this with git 2.5.4 stable that comes native on my mac, and git 2.12
built from source.
In both cases I got
On 5 September 2017 at 02:16, Michael Paquier wrote:
> On Mon, Sep 4, 2017 at 11:47 PM, Bossart, Nathan wrote:
>> I've made this change in v14 of the main patch.
>>
>> In case others had opinions regarding the de-duplication patch, I've
>> attached that again as well.
>
> + /*
> +* Create t
On Tue, Sep 5, 2017 at 12:05 PM, Masahiko Sawada wrote:
> In get_rel_oids() we often switch the memory context to vac_context
> and switch back. As a result almost code in get_rel_oids() is working
> in vac_context. Maybe we can switch memory context before and after
> the calling get_rel_oids?
I
On Tue, Sep 5, 2017 at 10:16 AM, Michael Paquier
wrote:
> On Mon, Sep 4, 2017 at 11:47 PM, Bossart, Nathan wrote:
>> I've made this change in v14 of the main patch.
>>
>> In case others had opinions regarding the de-duplication patch, I've
>> attached that again as well.
>
> + /*
> +* Creat
On 2017-09-05 11:36:47 +0900, Michael Paquier wrote:
> On Thu, Aug 31, 2017 at 9:19 PM, Magnus Hagander wrote:
> > PFA an updated and rebased patch.
> >
> > Rebased. Now named pg_advance_replication_slot. ERROR on logical slots.
> > Forward only.
> >
> > I think that, in the end, covered all the c
On Thu, Aug 31, 2017 at 9:19 PM, Magnus Hagander wrote:
> PFA an updated and rebased patch.
>
> Rebased. Now named pg_advance_replication_slot. ERROR on logical slots.
> Forward only.
>
> I think that, in the end, covered all the comments?
+ if (backwards)
+ ereport(WARNING,
+
> What do you think? I've not really tested this with the extended
> protocol, so I'd appreciate if you could rerun your test from the
> older thread.
Attached is your patch just rebased against master branch.
Also I attached the test cases and results using pgproto on patched
master branch. All
On Mon, Sep 4, 2017 at 11:15 PM, Tom Lane wrote:
> I don't want to go there, and was thinking we should expand the new
> comment in DefineSavepoint to explain why not.
Okay.
> It's certainly not that
> much additional work to allow a savepoint so far as xact.c is concerned,
> as your patch shows
On Mon, Sep 4, 2017 at 11:47 PM, Bossart, Nathan wrote:
> I've made this change in v14 of the main patch.
>
> In case others had opinions regarding the de-duplication patch, I've
> attached that again as well.
+ /*
+* Create the relation list in a long-lived memory context so that it
+*
On 2017/09/04 20:46, Konstantin Knizhnik wrote:
> On 04.09.2017 12:59, Amit Langote wrote:
>> On 2017/09/04 18:19, Konstantin Knizhnik wrote:
>>> Concerning your suggestion to merge check_index_predicates() and
>>> remove_restrictions_implied_by_constraints() functions: may be it can be
>>> done, b
On Tue, Sep 5, 2017 at 2:33 AM, Fabien COELHO wrote:
>
> Hello Masahiko-san,
>
Currently TRUNCATE pgbench_accounts command is executed within a
transaction started immediately before it. If we move it out of the
transaction, the table data will be truncated even if the copying data
Anyway, done with the addition of a "chomp" parameter, leaving only the
TAP test changes to consider.
Ok, thanks.
I'll set the CF entry back to "waiting on author" pending your
revisions of those.
See attached.
Removed scalar/array ref hack, plenty [] added everywhere to match.
Removed p
If I tell pg_basebackup to use a non-existent slot, it immediately reports
an error. And then it exits with an error, but only after streaming the
entire database contents.
If you are doing this interactively and are on the ball, of course, you can
hit ctrl-C when you see the error message.
I do
On Mon, Sep 4, 2017 at 2:04 PM, wrote:
> Our clients complain about this issue and therefore I want to raise the
> discussion and suggest several solutions to this problem:
>
> I. Why does PG use Fatal when Error is enough to release lock that rises
> lock conflict?
> "If (RecoveryConflictPending
Fabien COELHO writes:
>> * I do not think we need expr_scanner_chomp_substring. Of the three
>> existing callers of expr_scanner_get_substring, one is doing a manual
>> chomp afterwards, and the other two need chomps per your patch.
> Ok. I thought that I would get a slap on the hand if I change
On Mon, Sep 4, 2017 at 1:56 PM, Fabien COELHO wrote:
>
> Hello Jeff,
>
> I have fixed a bug introduced in the patch by changing && by || in the
(min_sec > 0 && maxsock != -1) condition which was inducing errors with
multi-threads & clients...
>>>
> Since this commit (12788ae49e1933
Hello Jeff,
I have fixed a bug introduced in the patch by changing && by || in the
(min_sec > 0 && maxsock != -1) condition which was inducing errors with
multi-threads & clients...
Since this commit (12788ae49e1933f463bc5), if I use the --rate to throttle
the transaction rate, it does get t
Hi,
On 2017-09-04 20:01:03 +0300, Konstantin Knizhnik wrote:
> > I previously had an early prototype of JITing [1] expression evaluation
> > and tuple deforming. I've since then worked a lot on this.
> >
> > Here's an initial, not really pretty but functional, submission. This
> > supports all t
I think we should go with Daniel's idea for all three parts.
I'm okay with that, although probably it should be an independent patch.
In the documentation, I do not think that both SERVER_VERSION_NAME and
_NUM (or whatever their chosen name) deserve two independent explanations
with heavy re
On Mon, Sep 26, 2016 at 1:01 AM, Heikki Linnakangas wrote:
> On 09/24/2016 12:45 PM, Fabien COELHO wrote:
>
>>
>> Attached are some small changes to your version:
>>
>> I have added the sleep_until fix.
>>
>> I have fixed a bug introduced in the patch by changing && by || in the
>> (min_sec > 0 &
Fabien COELHO writes:
> I also like Daniel's idea to update formatting rules, eg following what is
> done for environment variables and accepting that it won't fit in one page
> anyway.
Yeah. When you look at all three portions of the helpVariables output,
it's clear that we have faced this is
Hello Tom,
As for included bug fixes, I can do separate patches, but I think that it
is enough to first commit the pgbench files and then the tap-test files,
in that order. I'll see what committers say.
Starting to look at this. I concur that the bug fixes ought to be
committed separately, b
Nikolay Shaplov writes:
> 2. Patch for -t/-R/-L case.
> Current pgbench does not process -t/-R/-L case correctly. This was also fixed
> in this patch.
This portion of the patch seems uncontroversial, so I've pushed it, with
some minor cosmetic adjustments (mostly comments).
Hello Tom,
So I thought we were done bikeshedding the variable names for this
feature, but as I was reviewing the patch with intent to commit,
I noticed you hadn't updated helpVariables() to mention them.
Indeed.
Possibly you missed this because it doesn't mention VERSION either,
but that d
Fabien COELHO writes:
> As for included bug fixes, I can do separate patches, but I think that it
> is enough to first commit the pgbench files and then the tap-test files,
> in that order. I'll see what committers say.
Starting to look at this. I concur that the bug fixes ought to be
committe
Looks good to me. I have marked the patch status as "Ready for
committer".
LGTM too. Pushed with a minor adjustment to make parseVariable()
have exactly the same test as valid_variable_name().
\set ありがとうございました 1
\set 谢谢 2
\set dankeschön 3
:-)
--
Fabien.
--
Sent via pgsql-hackers maili
On Mon, Sep 4, 2017 at 7:46 PM, Peter Geoghegan wrote:
> On Mon, Sep 4, 2017 at 10:05 AM, Marko Tiikkaja wrote:
> But I'm generally against
> > interfaces which put arbitrary restrictions on what power users can do on
> > the basis that less experienced people might misuse the interface.
>
> I
2017-09-04 19:35 GMT+02:00 Tom Lane :
> "Daniel Verite" writes:
> > The two-space left margin on the entire block does not add that
> > much to readability, IMV, so maybe we could reclaim these
> > two characters.
>
> Well, it's a sub-list of the entire output of helpVariables(), so
> I think som
On Mon, Sep 4, 2017 at 10:05 AM, Marko Tiikkaja wrote:
> I had to look at the patch to see what I'd done, and the tests suggest that
> we already complain about this with if a FOR [lock level] clause is present:
>
>+begin transaction isolation level read committed;
>+insert into selfconfli
Tatsuo Ishii writes:
>> Here is a v3 with a more precise comment.
> Looks good to me. I have marked the patch status as "Ready for
> committer".
LGTM too. Pushed with a minor adjustment to make parseVariable()
have exactly the same test as valid_variable_name().
regards
"Daniel Verite" writes:
> The two-space left margin on the entire block does not add that
> much to readability, IMV, so maybe we could reclaim these
> two characters.
Well, it's a sub-list of the entire output of helpVariables(), so
I think some indentation is a good idea.
> That would look lik
Hello Masahiko-san,
Currently TRUNCATE pgbench_accounts command is executed within a
transaction started immediately before it. If we move it out of the
transaction, the table data will be truncated even if the copying data
failed. Maybe we can do TRUNCATE pgbench_accounts, pgbench_history
inst
On 09/04/2017 06:16 PM, Alexander Korotkov wrote:
> Looks good for me. I've integrated those changes in the patch.
> New revision is attached.
Thanks, I changed status to "ready for commiter".
--
Adrien NAYRAT
http://dalibo.com - http://dalibo.org
signature.asc
Description: OpenPGP digital
2017-09-04 19:08 GMT+02:00 Tom Lane :
> Pavel Stehule writes:
> > 2017-09-04 18:56 GMT+02:00 Tom Lane :
> >> Just had another idea: maybe make the new variable names
> >> SERVER_VERSION_S
> >> SERVER_VERSION_N
> >> VERSION_S
> >> VERSION_N
>
> > SERVER_VERSION_STR looks better than this.
>
> I du
Tom Lane wrote:
> Since we've blown past 80 columns on some of the other
> output, maybe that doesn't matter. Or maybe we should shorten this
> variable name so it doesn't force reformatting of all this text.
The two-space left margin on the entire block does not add that
much to readabi
Pavel Stehule writes:
> 2017-09-04 18:56 GMT+02:00 Tom Lane :
>> Just had another idea: maybe make the new variable names
>> SERVER_VERSION_S
>> SERVER_VERSION_N
>> VERSION_S
>> VERSION_N
> SERVER_VERSION_STR looks better than this.
I dunno, I'm not very pleased with the "STR" idea because the v
On Mon, Sep 4, 2017 at 4:09 AM, Peter Geoghegan wrote:
> On Tue, Aug 15, 2017 at 12:17 AM, Marko Tiikkaja wrote:
> > On Tue, Aug 15, 2017 at 7:43 AM, Peter Geoghegan wrote:
> >>
> >> On Mon, Aug 14, 2017 at 6:23 PM, Marko Tiikkaja wrote:
> >> > Attached is a patch for $SUBJECT. It might still
2017-09-04 18:56 GMT+02:00 Tom Lane :
> I wrote:
> > ... Or maybe we should shorten this
> > variable name so it doesn't force reformatting of all this text.
> > Possible ideas include "DB_VERSION_NAME", "SERVER_VER_NAME", or
> > "SERVER_VERSION_STR". (The last saves only one character, whereas
>
On 01.09.2017 09:41, Andres Freund wrote:
Hi,
I previously had an early prototype of JITing [1] expression evaluation
and tuple deforming. I've since then worked a lot on this.
Here's an initial, not really pretty but functional, submission. This
supports all types of expressions, and tuples
Hi
2017-09-04 18:31 GMT+02:00 Tom Lane :
> So I thought we were done bikeshedding the variable names for this
> feature, but as I was reviewing the patch with intent to commit,
> I noticed you hadn't updated helpVariables() to mention them.
> Possibly you missed this because it doesn't mention VE
I wrote:
> ... Or maybe we should shorten this
> variable name so it doesn't force reformatting of all this text.
> Possible ideas include "DB_VERSION_NAME", "SERVER_VER_NAME", or
> "SERVER_VERSION_STR". (The last saves only one character, whereas
> we really need to save two if we're trying not t
So I thought we were done bikeshedding the variable names for this
feature, but as I was reviewing the patch with intent to commit,
I noticed you hadn't updated helpVariables() to mention them.
Possibly you missed this because it doesn't mention VERSION either,
but that doesn't seem very defensible
On Mon, Sep 04, 2017 at 05:27:40PM +0100, Greg Stark wrote:
> I was just looking over the CSV logging code and have a few questions
> about why things were done the way they were done.
>
> 1) Why do we gather a per-session log line number? Is it just to aid
> people importing to avoid duplicate en
I was just looking over the CSV logging code and have a few questions
about why things were done the way they were done.
1) Why do we gather a per-session log line number? Is it just to aid
people importing to avoid duplicate entries from partial files? Is
there some other purpose given that entri
On 04.09.2017 15:17, Alexey Chernyshov wrote:
make check-world fails on contrib/postgres_fdw because of Subquery Scan on ...
Probably, query plan was changed.
Hi Alexey,
Thanks for testing! This is the same problem as the one in
'select_distinct' I mentioned before. I changed the test, the u
Hi, Adrien!
On Mon, Sep 4, 2017 at 3:57 PM, Adrien Nayrat
wrote:
> On 08/30/2017 02:26 PM, Alexander Korotkov wrote:
> I reviewed this patch. It works as expected but I have few remarks :
>
Thank you for reviewing my patch!.
> * There is a warning during compilation :
>
> gram.y: In functio
On Mon, Sep 4, 2017 at 4:51 PM, Alex Ignatov
wrote:
> In this situation this parameter (max_standby_streaming_delay) wont help
> because if you have subsequent statement on standby (following info is from
> documentation and from our experience ): Thus, if one query has resulted in
> significant
On Fri, Sep 01, 2017 at 10:33:37PM +0200, Alvaro Herrera wrote:
> Tom Lane wrote:
> > Robert Haas writes:
> > > On Thu, Aug 31, 2017 at 1:52 PM, Andreas Karlsson
> > > wrote:
>
> > >> There are currently two failing SSL tests which at least to me seems more
> > >> like they test specific OpenSS
Simon Riggs writes:
> Which is why next year when upgrading from PG10 -> PG11 we will
> mention it and that point not mention the other older solutions, which
> were once our best.
This is boilerplate text that we tend to copy-and-paste without thinking
about it; if it's designed in a way that re
On Fri, Sep 1, 2017 at 12:09:35PM -0400, Robert Haas wrote:
> I think that what this shows is that the current set of GUCs is overly
> OpenSSL-centric. We created a set of GUCs that are actually specific
> to one particular implementation but named them as if they were
> generic. My idea about t
Michael Paquier writes:
> Hmm. While this patch looks to me in a better shape than what Simon's
> is proposing, thinking about
> cah2-v61vxnentfj2v-zd+ma-g6kqmjgd5svxou3jbvdzqh0...@mail.gmail.com
> which involved a migration Oracle->Postgres, I have been wondering if
> it is possible to still allo
-Original Message-
From: pgsql-hackers-ow...@postgresql.org
[mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Amit Kapila
Sent: Monday, September 4, 2017 3:32 PM
To: i.kartys...@postgrespro.ru
Cc: pgsql-hackers
Subject: Re: [HACKERS] WIP: long transactions on hot standby feedback
On Tue, Aug 22, 2017 at 08:28:15PM -0400, Peter Eisentraut wrote:
> It seems to me that this code in pg_upgrade/check.c has been useless
> since at least version 9.1:
>
> /* Is it 9.0 but without tablespace directories? */
> if (GET_MAJOR_VERSION(new_cluster.major_version) == 900 &&
>
I forget to include patch in last letter.
Craig Ringer wrote 2017-08-15 05:00:
That ship sailed a long time ago unfortunately, they're all over
pg_stat_replication and pg_replication_slots and so on. They're
already routinely used for monitoring replication lag in bytes,
waiting for a peer to ca
On 08/30/2017 02:26 PM, Alexander Korotkov wrote:
> Patch rebased to current master is attached.
Hello,
I reviewed this patch. It works as expected but I have few remarks :
* There is a warning during compilation :
gram.y: In function ‘base_yyparse’:
gram.y:2090:6: warning: ISO C90 forbids mi
On Mon, Sep 4, 2017 at 3:48 PM, Alvaro Herrera wrote:
>
> if (tuples > 0)
> {
> - if (tableinfo.relkind !=
> RELKIND_PARTITIONED_TABLE)
> - printfPQExpBuffer(&buf, _("Number of
> c
Hi
When we reviewed the ecpg code,we found the array seem not have the end
character('\0') after using the strncpy function.
In the function ECPGnoticeReceiver, we use the stncpy function copy the
sqlstate to sqlca->sqlstate. And the sqlca->sqlstate is defined as the size
of 5, and the copy si
On 4 September 2017 at 12:11, Robert Haas wrote:
>
> It's not really true that the only alternatives to pglogical are
> proprietary. Really, one could use any logical replication solution,
> and there have been multiple open source alternatives for a decade.
True, but it is by far the best solut
On Mon, Sep 4, 2017 at 10:04 AM, Amit Langote
wrote:
> On 2017/09/04 12:38, Etsuro Fujita wrote:
>> On 2017/09/02 4:10, Ashutosh Bapat wrote:
>>> This rebase mainly changes patch 0001, which translates partition
>>> hierarchy into inheritance hierarchy creating AppendRelInfos and
>>> RelOptInfos f
On Mon, Sep 4, 2017 at 4:34 PM, wrote:
> Our clients complain about this issue and therefore I want to raise the
> discussion and suggest several solutions to this problem:
>
> I. Why does PG use Fatal when Error is enough to release lock that rises
> lock conflict?
> "If (RecoveryConflictPending
On 4 September 2017 at 10:34, Andreas Joseph Krogh wrote:
> I'd like at big red warning "Logical decoding doesn't support Large Objects"
> in that case;
>
> "If upgrading from a 9.4 server or later, and you don't use Large Objects,
> external utilities using logical decoding, such as pglogical or
On 4 September 2017 at 12:39, Robert Haas wrote:
> On Mon, Sep 4, 2017 at 7:14 AM, Magnus Hagander wrote:
>> I agree that singling it out there is probably not the best idea. But a
>> sentence/paragraph saying that there are third party replication solutions
>> that can solve the problem, along w
Hello, thank you for your comments over main idea and code.
On 13.03.2017 05:20, Thomas Munro wrote:
1)
First, I'll restate my view of the syntax-vs-function question: I
think an fmgr function is the wrong place to do this, because it
doesn't work for our 2 higher isolation levels as mentioned.
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
Hi Alexander,
make check-world fails on contrib/postgres_fdw because of
On 9/3/17, 11:46 PM, "Michael Paquier" wrote:
> I did not consider first that the list portion also needed to be
> modified, perhaps because I am not coding that myself... So now that
> it is becoming more complicated what about just using AutovacMemCxt?
> This would simplify the list of VacuumRel
On 04.09.2017 12:59, Amit Langote wrote:
Hi Konstantin,
On 2017/09/04 18:19, Konstantin Knizhnik wrote:
On 04.09.2017 05:38, Amit Langote wrote:
On 2017/09/02 12:44, Thomas Munro wrote:
On Wed, Aug 16, 2017 at 9:23 PM, Konstantin Knizhnik
wrote:
postgres=# explain select * from bt where k
On Mon, Sep 4, 2017 at 7:14 AM, Magnus Hagander wrote:
> I agree that singling it out there is probably not the best idea. But a
> sentence/paragraph saying that there are third party replication solutions
> that can solve the problem, along with linking to the page with the list,
> perhaps?
Yeah
On 2017-05-25 17:52 Petr Jelinek wrote:
> Hi,
>
> We have had issue with walsender timeout when used with logical
> decoding and the transaction is taking long time to be decoded
> (because it contains many changes)
>
> I was looking today at the walsender code and realized that it's
> because if
On 2017/09/04 15:38, Michael Paquier wrote:
On Thu, Aug 31, 2017 at 11:12 AM, Tatsuro Yamada
wrote:
Then I have questions.
* Should we have separate views for them? Or should both be covered by the
same view with some indication of which command (CLUSTER or VACUUM FULL)
is actual
On Mon, Sep 4, 2017 at 1:11 PM, Robert Haas wrote:
> On Mon, Sep 4, 2017 at 4:49 AM, Simon Riggs wrote:
> > Migration to Version 10
> >
> > "A dump/restore using pg_dumpall, or use of pg_upgrade, is required
> > for those wishing to migrate data from any previous release."
> >
> > This isn't tru
On Mon, Sep 4, 2017 at 4:49 AM, Simon Riggs wrote:
> Migration to Version 10
>
> "A dump/restore using pg_dumpall, or use of pg_upgrade, is required
> for those wishing to migrate data from any previous release."
>
> This isn't true and is seriously misleading ...
Fair point.
> since pglogical a
Our clients complain about this issue and therefore I want to raise the
discussion and suggest several solutions to this problem:
I. Why does PG use Fatal when Error is enough to release lock that rises
lock conflict?
"If (RecoveryConflictPending && DoingCommandRead)"
II. Do we really need to
I've updated patch to use an extended hash function (Commit #
81c5e46c490e2426db243eada186995da5bb0ba7) for the partitioning.
Regards,
Amul
On Thu, Jul 27, 2017 at 5:11 PM, amul sul wrote:
> Attaching newer patches rebased against the latest master head. Thanks !
>
> Regards,
> Amul
>
0001-
On Mon, Sep 4, 2017 at 12:23 PM, Michael Paquier
wrote:
> On Mon, Sep 4, 2017 at 7:21 PM, Michael Paquier
> wrote:
> > A simple idea would be to pass as a parameter a regex on which we
> > check files to skip when scanning the directory of the target remotely
> > or locally. This needs to be use
Ok so I have a proof of concept patch here.
This is proof of concept only. It odes not change documentation or the
like.
The purpose of the patch is discussion on the "do we want this" side.
The patch is fairly trivial but I have not added test cases or changed docs
yet.
Intention of the patch
On Mon, Sep 4, 2017 at 7:21 PM, Michael Paquier
wrote:
> A simple idea would be to pass as a parameter a regex on which we
> check files to skip when scanning the directory of the target remotely
> or locally. This needs to be used with care though, it would be easy
> to corrupt an instance.
I ac
On Mon, Sep 4, 2017 at 5:53 PM, Chris Travers wrote:
> In some experiments with pg_rewind and rep mgr I noticed that local testing
> is complicated by the fact that pg_rewind appears to copy configuration
> files from the source to target directory.
>
> I would propose to make a modest patch to ex
if (tuples > 0)
{
- if (tableinfo.relkind !=
RELKIND_PARTITIONED_TABLE)
- printfPQExpBuffer(&buf, _("Number of
child tables: %d (Use \\d+ to list them.)"), tuples);
-
On 2017/06/21 17:57, Amit Langote wrote:
On 2017/06/21 16:59, Etsuro Fujita wrote:
Commit d3cc37f1d801a6b5cad9bf179274a8d767f1ee50 added this to
ExecInitModifyTable:
+ /* The root table RT index is at the head of the partitioned_rels list */
+ if (node->partitioned_rels)
+ {
+ Index
Tom Lane wrote:
> Michael Paquier writes:
> > I don't like breaking the abstraction of pg_log() with the existing
> > flags with some kind of pg_debug() layer. The set of APIs present now
> > in pg_rewind for logging is nice to have, and I think that those debug
> > messages should be translated.
Hi Konstantin,
On 2017/09/04 18:19, Konstantin Knizhnik wrote:
> On 04.09.2017 05:38, Amit Langote wrote:
>> On 2017/09/02 12:44, Thomas Munro wrote:
>>> On Wed, Aug 16, 2017 at 9:23 PM, Konstantin Knizhnik
>>> wrote:
postgres=# explain select * from bt where k between 1 and 2 and v
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: not tested
Spec compliant: not tested
Documentation:not tested
PostgreSQL fails with SIGSEGV during `make check-world`.
Backtrace: http
On Sat, Sep 2, 2017 at 12:21 PM, Noah Misch wrote:
> On Thu, Aug 31, 2017 at 03:11:10PM -0400, Robert Haas wrote:
>> On Wed, Aug 30, 2017 at 11:19 AM, Robert Haas wrote:
>> > But since that's an established design fl^H^Hprinciple, maybe that
>> > means we should go with the approach of teaching S
1 - 100 of 109 matches
Mail list logo
