Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-03-08 Thread Andrew Dunstan
On 03/08/2016 08:32 AM, Michael Paquier wrote: On Mon, Mar 7, 2016 at 10:40 PM, Michael Paquier wrote: On Sun, Mar 6, 2016 at 5:55 AM, Andrew Dunstan wrote: On 03/05/2016 01:31 PM, Michael Paquier wrote: On Sat, Mar 5, 2016 at 11:34 PM, Andrew Dunstan wrote: Here is a translation into

Re: [HACKERS] Allowing to run a buildfarm animal under valgrind

2016-03-08 Thread Andrew Dunstan
On 03/07/2016 08:39 PM, Andres Freund wrote: Hi, I'm setting up a buildfarm animal that runs under valgrind. Unfortunately there's not really any good solution to force make check et al. to start postgres wrapped in valgrind. For now I've resorted to adding something like sub replace_postgre

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-03-05 Thread Andrew Dunstan
On 03/05/2016 01:31 PM, Michael Paquier wrote: On Sat, Mar 5, 2016 at 11:34 PM, Andrew Dunstan wrote: Here is a translation into perl of the sed script, courtesy of the s2p incarnation of psed: <https://gist.github.com/adunstan/d61b1261a4b91496bdc6> The sed script appears to have been

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-03-05 Thread Andrew Dunstan
On 03/05/2016 12:46 AM, Tom Lane wrote: Michael Paquier writes: On Sat, Mar 5, 2016 at 1:41 PM, Petr Jelinek wrote: I vote for just using sed considering we need flex and bison anyway. OK cool, we could go with something else than sed to generate probes.h but that seems sensible considerin

Re: [HACKERS] VS 2015 support in src/tools/msvc

2016-03-03 Thread Andrew Dunstan
On 03/03/2016 09:02 AM, Michael Paquier wrote: Hi all, Microsoft provides a set of VMs that one can use for testing and Windows 10 is in the set: https://dev.windows.com/en-us/microsoft-edge/tools/vms/windows/ I have grabbed one and installed the community version of Visual Studio 2015 so I th

Re: [HACKERS] Equivalent of --enable-tap-tests in MSVC scripts

2016-03-01 Thread Andrew Dunstan
On 03/01/2016 08:00 AM, Michael Paquier wrote: Hi all, As of now the MSVC scripts control if TAP tests are enabled or not using a boolean flag as $config->{tap_tests}. However, this flag is just taken into account in vcregress.pl, with the following issues: 1) config_default.pl does not list t

Re: [HACKERS] Re: [COMMITTERS] pgsql: Respect TEMP_CONFIG when running contrib regression tests.

2016-02-28 Thread Andrew Dunstan
On 02/27/2016 01:24 PM, John Gorman wrote: On Sat, Feb 27, 2016 at 9:25 AM, Robert Haas <mailto:robertmh...@gmail.com>> wrote: On Sat, Feb 27, 2016 at 7:08 PM, Andrew Dunstan mailto:and...@dunslane.net>> wrote: > Perhaps what we need to do is modify pg_reg

[HACKERS] Re: [COMMITTERS] pgsql: Respect TEMP_CONFIG when running contrib regression tests.

2016-02-27 Thread Andrew Dunstan
On 02/27/2016 09:25 AM, Robert Haas wrote: On Sat, Feb 27, 2016 at 7:08 PM, Andrew Dunstan wrote: What I had in mind was something like the attached. In testing this seems to do the right thing, and the nice part is that it will be picked up by the buildfarm in the one case that's rel

[HACKERS] Re: [COMMITTERS] pgsql: Respect TEMP_CONFIG when running contrib regression tests.

2016-02-27 Thread Andrew Dunstan
On 02/26/2016 10:59 PM, Robert Haas wrote: On Sat, Feb 27, 2016 at 9:00 AM, Andrew Dunstan wrote: Sure. Saving three lines of Makefile duplication is hardly a world-shattering event, so I thought there might be some other purpose. But I'm not against saving three lines of duplic

[HACKERS] Release 4.17 of the PostgreSQL Buildfarm client

2016-02-20 Thread Andrew Dunstan
I have just cut release 4.17 of the PostgreSQL Buildfarm client. It is available at . Changes of note: * use PGCTLTIMEOUT instead of hardcoded timeout settings * shipped config file is renamed to build-farm.conf.sample to avoid over

Re: [HACKERS] exposing pg_controldata and pg_config as functions

2016-02-17 Thread Andrew Dunstan
On 02/17/2016 05:14 PM, Tom Lane wrote: Peter Eisentraut writes: On 2/17/16 12:15 PM, Joe Conway wrote: Ok, removed the documentation on the function pg_config() and pushed. I still have my serious doubts about this, especially not even requiring superuser access for this information. Coul

Re: [HACKERS] postgres_fdw vs. force_parallel_mode on ppc

2016-02-16 Thread Andrew Dunstan
On 02/15/2016 07:57 PM, Tom Lane wrote: Noah Misch writes: On Mon, Feb 15, 2016 at 07:31:40PM -0500, Robert Haas wrote: Oh, crap. I didn't realize that TEMP_CONFIG didn't affect the contrib test suites. Is there any reason for that, or is it just kinda where we ended up? To my knowledge,

Re: [HACKERS] Tracing down buildfarm "postmaster does not shut down" failures

2016-02-10 Thread Andrew Dunstan
On 02/10/2016 12:53 PM, Tom Lane wrote: Andrew Dunstan writes: Yeah. It's faintly possible that a kernel upgrade will help. Another data point. I have another RPi2B that is running Debian Wheezy rather than the Fedora remix. I'm running the same test on it we ran yesterday on a

Re: [HACKERS] Tracing down buildfarm "postmaster does not shut down" failures

2016-02-10 Thread Andrew Dunstan
On 02/09/2016 11:21 PM, Andrew Dunstan wrote: The idea I was toying with is that previous filesystem activity (making the temp install, the server's never-fsync'd writes, etc) has built up a bunch of dirty kernel buffers, and at some point the kernel goes nuts writing all that

Re: [HACKERS] Tracing down buildfarm "postmaster does not shut down" failures

2016-02-09 Thread Andrew Dunstan
On 02/09/2016 10:27 PM, Tom Lane wrote: Noah Misch writes: On Tue, Feb 09, 2016 at 10:02:17PM -0500, Tom Lane wrote: I wonder if it's worth sticking some instrumentation into stats collector shutdown? I wouldn't be surprised if the collector got backlogged during the main phase of testing a

Re: [HACKERS] Tracing down buildfarm "postmaster does not shut down" failures

2016-02-09 Thread Andrew Dunstan
On 02/09/2016 08:49 PM, Tom Lane wrote: Andrew Dunstan writes: On 02/09/2016 07:49 PM, Tom Lane wrote: However, I'd already noted from some other digging in the buildfarm logs that axolotl's speed seems to vary tremendously. I do not know what else you typically run on that har

Re: [HACKERS] Tracing down buildfarm "postmaster does not shut down" failures

2016-02-09 Thread Andrew Dunstan
On 02/09/2016 07:49 PM, Tom Lane wrote: Andrew Dunstan writes: So running it's not running with fsync off or using the ramdisk for stats_temp_directory. Of course, that doesn't explain why we're not seeing it on branches earlier than 9.5, but it could explain why we're o

Re: [HACKERS] Tracing down buildfarm "postmaster does not shut down" failures

2016-02-09 Thread Andrew Dunstan
On 02/09/2016 06:46 PM, Andrew Dunstan wrote: On 02/09/2016 05:53 PM, Tom Lane wrote: Andrew, I wonder if I could prevail on you to make axolotl run "make check" on HEAD in src/interfaces/ecpg/ until it fails, so that we can see if the logging I added tells anything useful

Re: [HACKERS] Tracing down buildfarm "postmaster does not shut down" failures

2016-02-09 Thread Andrew Dunstan
On 02/09/2016 05:53 PM, Tom Lane wrote: Andrew, I wonder if I could prevail on you to make axolotl run "make check" on HEAD in src/interfaces/ecpg/ until it fails, so that we can see if the logging I added tells anything useful about this. Will do. cheers andre

Re: [HACKERS] Tracing down buildfarm "postmaster does not shut down" failures

2016-02-09 Thread Andrew Dunstan
On 02/09/2016 03:05 PM, Tom Lane wrote: I wrote: In any case, we should proceed with fixing things so that buildfarm owners can specify a higher shutdown timeout for especially slow critters. I looked into doing this as I suggested yesterday, namely modifying the buildfarm scripts, and soon d

Re: [HACKERS] Tracing down buildfarm "postmaster does not shut down" failures

2016-02-09 Thread Andrew Dunstan
On 02/08/2016 10:55 PM, Tom Lane wrote: Noah Misch writes: On Mon, Feb 08, 2016 at 02:15:48PM -0500, Tom Lane wrote: We've seen variants on this theme on half a dozen machines just in the past week --- and it seems to mostly happen in 9.5 and HEAD, which is fishy. It has been affecting only

Re: [HACKERS] Tracing down buildfarm "postmaster does not shut down" failures

2016-02-08 Thread Andrew Dunstan
On 02/08/2016 02:15 PM, Tom Lane wrote: Of late, by far the majority of the random-noise failures we see in the buildfarm have come from failure to shut down the postmaster in a reasonable timeframe. An example is this current failure on hornet: http://buildfarm.postgresql.org/cgi-bin/show_st

Re: [HACKERS] proposal: schema PL session variables

2016-02-08 Thread Andrew Dunstan
On 02/08/2016 03:16 AM, Pavel Stehule wrote: Hi On Russian PgConf I had a talk with Oleg about missing features in PLpgSQL, that can complicates a migrations from Oracle to PostgreSQL. Currently I see only one blocker - missing protected session variables. PL/SQL has package variables with

Re: [HACKERS] proposal: make NOTIFY list de-duplication optional

2016-02-06 Thread Andrew Dunstan
On 02/05/2016 08:49 PM, Tom Lane wrote: Yeah, I agree that a GUC for this is quite unappetizing. Agreed. One idea would be to build a hashtable to aid with duplicate detection (perhaps only once the pending-notify list gets long). Another thought is that it's already the case that duplic

Re: [HACKERS] Template for commit messages

2016-01-28 Thread Andrew Dunstan
On 01/28/2016 09:57 AM, Robert Haas wrote: On Thu, Jan 28, 2016 at 9:52 AM, Tom Lane wrote: Robert Haas writes: On Thu, Jan 28, 2016 at 8:04 AM, Tomas Vondra wrote: Why can't we do both? That is, have a free-form text with the nuances, and then Reviewed-By listing the main reviewers? The

[HACKERS] Buildfarm server move complete

2016-01-19 Thread Andrew Dunstan
The buildfarm server move is complete. Thanks to all who helped, especially Stephen Frost. There might be some small performance regressions which we'll be digging into. Next step: move the mailing lists off pgfoundry. The new lists have been set up I will be working on that migration next

Re: [HACKERS] make error - libpqdll.def No such file or directory

2016-01-19 Thread Andrew Dunstan
On 01/19/2016 02:01 PM, Alvaro Herrera wrote: Andrew Dunstan wrote: jacana does VPATH builds with pretty much this setup all the time. See for example <http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=jacana&dt=2016-01-19%2013%3A00%3A09> Yes, it builds a tree *once*, then d

Re: [HACKERS] make error - libpqdll.def No such file or directory

2016-01-19 Thread Andrew Dunstan
On 01/19/2016 01:08 PM, Igal @ Lucee.org wrote: On 1/17/2016 8:17 PM, Igal @ Lucee.org wrote: On 1/17/2016 3:24 PM, Igal @ Lucee.org wrote: When running make I encounter the following error: gcc.exe: error: libpqdll.def: No such file or directory /home/Admin/sources/postgresql-9.5.0/src/Make

Re: [HACKERS] Buildfarm server move

2016-01-18 Thread Andrew Dunstan
On 01/18/2016 05:20 PM, Andrew Dunstan wrote: People, Apologies for the late notice. Tomorrow, January 18th, at 4.00 pm US East Coast time (UT - 5.0) we will be moving the buildfarm server from its current home at CommandPrompt, where we have been ever since we started, to a machine that

[HACKERS] Buildfarm server move

2016-01-18 Thread Andrew Dunstan
People, Apologies for the late notice. Tomorrow, January 18th, at 4.00 pm US East Coast time (UT - 5.0) we will be moving the buildfarm server from its current home at CommandPrompt, where we have been ever since we started, to a machine that is part of the standard core infrastructure. In do

Re: [HACKERS] system mingw not recognized

2016-01-18 Thread Andrew Dunstan
On 01/18/2016 04:11 PM, Igal @ Lucee.org wrote: I posted the error in the docs to pgsql-d...@postgresql.org If it's possible to update it myself via git, or if it should be reported elsewhere -- please advise. 1. Please don't top-post on the PostgreSQL lists. See

Re: [HACKERS] Removing service-related code in pg_ctl for Cygwin

2016-01-18 Thread Andrew Dunstan
On 01/18/2016 03:46 PM, Alvaro Herrera wrote: Andrew Dunstan wrote: On 01/18/2016 12:38 PM, Alvaro Herrera wrote: Andrew Dunstan wrote: I think we can be a bit more adventurous and remove all the Cygwin-specific code. See attached patch, which builds fine on buildfarm cockatiel

Re: [HACKERS] Removing service-related code in pg_ctl for Cygwin

2016-01-18 Thread Andrew Dunstan
On 01/18/2016 12:38 PM, Alvaro Herrera wrote: Andrew Dunstan wrote: I think we can be a bit more adventurous and remove all the Cygwin-specific code. See attached patch, which builds fine on buildfarm cockatiel. Hopefully you also tested that it builds under MSVC :-) Why would I? This

Re: [HACKERS] Removing service-related code in pg_ctl for Cygwin

2016-01-18 Thread Andrew Dunstan
On 01/14/2016 12:38 AM, Michael Paquier wrote: Hi all, Beginning a new thread seems more adapted regarding $subject but that's mentioned here as well: http://www.postgresql.org/message-id/CAB7nPqQXghm_SdB5iniupz1atzMxk=95gv9a8ocdo83sxcn...@mail.gmail.com It happens based on some investigation

Re: [HACKERS] SET syntax in INSERT

2016-01-14 Thread Andrew Dunstan
On 01/14/2016 03:00 PM, Marko Tiikkaja wrote: On 2016-01-14 20:50, Vitaly Burovoy wrote: On 1/14/16, Tom Lane wrote: Assume a table with an int-array column, and consider INSERT INTO foo SET arraycol[2] = 7, arraycol[4] = 11; Right part is a column name, not an expression. Isn't it? So "a

Re: [HACKERS] pgindent-polluted commits

2016-01-14 Thread Andrew Dunstan
On 01/13/2016 12:13 PM, Tom Lane wrote: Simon Riggs writes: On 13 January 2016 at 14:48, Noah Misch wrote: I've noticed commits, from a few of you, carrying pgindent changes to lines the patch would not otherwise change. Could we review again why this matters? Basically this is trading of

Re: [HACKERS] [COMMITTERS] pgsql: Blind attempt at a Cygwin fix

2016-01-09 Thread Andrew Dunstan
On 01/08/2016 11:17 AM, Tom Lane wrote: Alvaro Herrera writes: Alvaro Herrera wrote: Obviously this wasn't the best idea ever. Andrew suggests on IM to revert this on Cygwin to just do the "isatty" check as originally. Here's a proposed patch. Thoughts? Ugly, but it will hold the fort un

Re: [HACKERS] pg_tables bug?

2015-12-18 Thread Andrew Dunstan
On 12/18/2015 05:18 PM, Gaetano Mendola wrote: From documentation about "CREATE DATABASE name WITH TABLESAPCE = tablespace_name": tablespace_name The name of the tablespace that will be associated with the new database, or DEFAULT to use the template database's tablespace. This tablespace

Re: [HACKERS] Include ppc64le build type for back branches

2015-12-08 Thread Andrew Dunstan
On 12/08/2015 10:27 AM, Tom Lane wrote: Sandeep Thakkar writes: So, config.guess should be changed to include the build type for ppc64le like it is in 9.4+ branches. So far as I can tell from a quick troll of the git history, we have never ever updated config.guess/config.sub in released bra

Re: [HACKERS] jsonb_delete not documented

2015-12-07 Thread Andrew Dunstan
On 12/06/2015 10:49 PM, Tom Lane wrote: Peter Eisentraut writes: I see. The reference from pg_operator to pg_proc is by OID rather than function name, so I didn't find them. Is that because the function is overloaded? Yeah, I suppose so --- regproc can't resolve overloaded function names.

Re: [HACKERS] a word-choice question

2015-12-06 Thread Andrew Dunstan
On 12/06/2015 11:03 AM, Tom Lane wrote: Chapman Flack writes: In PL/Java's function annotations, 'type' has been used for the volatility category: @Function(type=IMMUTABLE) public static String hello() { return "Hello, world!"; } It seems a bit infelicitous because you would probably sooner g

Re: [HACKERS] Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

2015-11-29 Thread Andrew Dunstan
On 11/29/2015 04:28 PM, Noah Misch wrote: +BEGIN +{ + $windows_os = $Config{osname} eq 'MSWin32' || $Config{osname} eq 'msys'; + + # Determine output directories, and create them. The base path is the + # TESTDIR environment variable, which is normally set by the invoking +

Re: [HACKERS] [Pgbuildfarm-members] latest buildfarm client release

2015-11-22 Thread Andrew Dunstan
On 11/22/2015 12:47 AM, Tom Lane wrote: Andrew Dunstan writes: I have just released version 4.16 of the PostgreSQL Buildfarm client I updated my critters to 4.16, and since nothing much was happening in git, decided to test by doing "run_build.pl --nosend --verbose --force" m

[HACKERS] latest buildfarm client release

2015-11-21 Thread Andrew Dunstan
I have just released version 4.16 of the PostgreSQL Buildfarm client It can be downloaded from Several bugs have been fixed, and there are these non-trivial changes: * capturing of TAP test logs * bin check enabled on Windows * rm_wo

[HACKERS] Re: [COMMITTERS] pgsql: Improve vcregress.pl's handling of tap tests for client programs

2015-11-18 Thread Andrew Dunstan
On 11/18/2015 10:58 PM, Michael Paquier wrote: On Thu, Nov 19, 2015 at 12:51 PM, Andrew Dunstan <mailto:and...@dunslane.net>> wrote: Improve vcregress.pl <http://vcregress.pl>'s handling of tap tests for client programs The target is now named 'binche

Re: [HACKERS] [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches.

2015-11-17 Thread Andrew Dunstan
On 11/17/2015 02:15 PM, Tom Lane wrote: Michael Paquier writes: On Tue, Oct 13, 2015 at 10:17 PM, Andrew Dunstan wrote: In general I think we can be a good deal more liberal about backpatching the testing regime than we are with production code, where we are always cautious, and the caution

Re: [HACKERS] proposal: multiple psql option -c

2015-11-17 Thread Andrew Dunstan
On 11/17/2015 04:13 PM, Tom Lane wrote: Robert Haas writes: A few years ago there was a proposal to not only allow multiple -c options, but to allow -c and -f to be intermingled. This seems really rather useful; I'd like to be able to type psql -c do_this_first -f script.sql and have that wo

Re: [HACKERS] proposal: multiple psql option -c

2015-11-16 Thread Andrew Dunstan
On 11/16/2015 11:16 AM, Catalin Iacob wrote: On Sun, Nov 15, 2015 at 3:53 PM, Andrew Dunstan wrote: I suggest you review the original thread on this subject before a line was ever written. "multiple" (see subject line on this whole thread) is clearly what is being asked for. Mak

Re: [HACKERS] proposal: multiple psql option -c

2015-11-16 Thread Andrew Dunstan
On 11/15/2015 08:24 PM, Peter Eisentraut wrote: On 11/15/15 9:53 AM, Andrew Dunstan wrote: I suggest you review the original thread on this subject before a line was ever written. "multiple" (see subject line on this whole thread) is clearly what is being asked for. Making people

Re: [HACKERS] proposal: multiple psql option -c

2015-11-15 Thread Andrew Dunstan
On 11/15/2015 08:50 AM, Catalin Iacob wrote: On Sun, Nov 15, 2015 at 1:27 AM, Andrew Dunstan wrote: That seems to me to get rid of the main motivation for this change, which is to allow multiple such arguments, which together would as as if they were all written to a file which was then

Re: [HACKERS] proposal: multiple psql option -c

2015-11-14 Thread Andrew Dunstan
On 11/13/2015 03:54 PM, Catalin Iacob wrote: So my proposal is: allow a *single* argument for -C and treat its content *exactly* like the input from stdin or from a file. That seems to me to get rid of the main motivation for this change, which is to allow multiple such arguments, which to

Re: [HACKERS] Patch to install config/missing

2015-11-11 Thread Andrew Dunstan
On 11/11/2015 12:34 PM, Tom Lane wrote: Peter Eisentraut writes: On 11/2/15 4:07 PM, Tom Lane wrote: I wonder how much we need that script at all though. If, say, configure doesn't find bison, what's so wrong with just defining BISON=bison and letting the usual shell "bison: command not fou

Re: [HACKERS] ALTER SYSTEM vs symlink

2015-11-02 Thread Andrew Dunstan
On 11/02/2015 09:36 AM, Tom Lane wrote: Andrew Dunstan writes: I don't know if this was discussed at the time ALTER SYSTEM was implemented, but I have just discovered that if postgresql.auto.conf is a symlink to a file elsewhere, ALTER SYSTEM will happily break that link and write it

Re: [HACKERS] fortnight interval support

2015-11-02 Thread Andrew Dunstan
On 11/02/2015 09:20 AM, Merlin Moncure wrote: On Sun, Nov 1, 2015 at 2:20 PM, David Fetter wrote: On Sun, Nov 01, 2015 at 01:06:39PM -0500, Tom Lane wrote: David Fetter writes: On Tue, Oct 27, 2015 at 07:30:13PM +, Nathan Wagner wrote: On Wed, Oct 28, 2015 at 08:17:25AM +1300, Gavin F

[HACKERS] ALTER SYSTEM vs symlink

2015-11-02 Thread Andrew Dunstan
I don't know if this was discussed at the time ALTER SYSTEM was implemented, but I have just discovered that if postgresql.auto.conf is a symlink to a file elsewhere, ALTER SYSTEM will happily break that link and write its own local copy. That strikes me as rather unfriendly. Why not just trunc

Re: [HACKERS] UTF-32 support in PostgreSQL ?

2015-10-26 Thread Andrew Dunstan
On 10/23/2015 11:29 PM, fortin.christ...@videotron.ca wrote: Is PostgreSQL support UNICODE UTF-32 characters ? If not, I think it's a must to be internationnal. To help you in this task, you could use this UTF-32 editor: https://wxmedit.github.io/downloads.html thanks. Do you mean data

Re: [HACKERS] a raft of parallelism-related bug fixes

2015-10-17 Thread Andrew Dunstan
On 10/17/2015 06:17 PM, Robert Haas wrote: However, I'm pretty sure that we don't want to switch the *entire* buildfarm to using lots of unnecessary parallelism. What we might be able to do is have some critters that people spin up for this precise purpose. Just like we currently have CLOBB

Re: [HACKERS] buildfarm failures on crake and sittella

2015-10-17 Thread Andrew Dunstan
On 10/16/2015 02:19 PM, Andrew Dunstan wrote: On 10/16/2015 11:13 AM, Robert Haas wrote: Andrew, The FileTextArrayFDW-build failure on crake, and the RedisFDW-build failure on sittella, are expected results of my commit 5043193b78919a1bd144563aadc2f7f726549913. If those FDWs do not push

Re: [HACKERS] plpython is broken for recursive use

2015-10-17 Thread Andrew Dunstan
On 10/16/2015 10:03 PM, Tom Lane wrote: I wrote: This seems like a very Rube-Goldbergian way of setting up a local namespace for the user-defined code. I think perhaps what we should do is: 1. Compile the user-supplied code directly into a code object, without wrapping it in a "def". (Hence,

Re: [HACKERS] buildfarm failures on crake and sittella

2015-10-16 Thread Andrew Dunstan
On 10/16/2015 11:13 AM, Robert Haas wrote: Andrew, The FileTextArrayFDW-build failure on crake, and the RedisFDW-build failure on sittella, are expected results of my commit 5043193b78919a1bd144563aadc2f7f726549913. If those FDWs do not push quals down, they just need to be updated to pass an

Re: [HACKERS] plpython is broken for recursive use

2015-10-15 Thread Andrew Dunstan
On 10/15/2015 05:16 PM, Josh Berkus wrote: On 10/15/2015 01:10 PM, Tom Lane wrote: I think this means that we should get rid of proc->globals and instead manufacture a new globals dict locally in each call to PLy_exec_function or PLy_exec_trigger. For SETOF functions it would be necessary to

Re: [HACKERS] bugs and bug tracking

2015-10-13 Thread Andrew Dunstan
On 10/13/2015 10:21 AM, Álvaro Hernández Tortosa wrote: On 13/10/15 04:40, Tom Lane wrote: I'm with Robert on the idea that commit log entries need to be limited-width. I personally format them to 75 characters, so that git_changelog's output is less than 80 characters. regards, tom lane

Re: [HACKERS] bugs and bug tracking

2015-10-13 Thread Andrew Dunstan
On 10/12/2015 07:36 PM, Robert Haas wrote: On Tue, Oct 6, 2015 at 2:33 PM, Nathan Wagner wrote: Two, I think any attempt to tell the developers and committers that they need to change their workflow to adapt to some system is bound to fail, so, I have asked, just what changed would you all be

Re: [HACKERS] Postgres service stops when I kill client backend on Windows

2015-10-13 Thread Andrew Dunstan
On 10/12/2015 04:35 PM, Tom Lane wrote: I wrote: This is kind of a mess :-(. But it does look like what we want is for SubPostmasterMain to do more than nothing when it chooses not to reattach. Probably that should include resetting UsedShmemSegAddr to NULL, as well as closing the handle. A

[HACKERS] Re: [COMMITTERS] pgsql: Cause TestLib.pm to define $windows_os in all branches.

2015-10-13 Thread Andrew Dunstan
On 10/12/2015 10:45 PM, Michael Paquier wrote: On Tue, Oct 13, 2015 at 11:31 AM, Tom Lane wrote: Hmm, well, why wasn't that back-patched? We expect these tests to run on Windows don't we? The message related to this particular commit is here: http://www.postgresql.org/message-id/55b90161.509

Re: [HACKERS] Postgres service stops when I kill client backend on Windows

2015-10-11 Thread Andrew Dunstan
On 10/11/2015 05:58 AM, Magnus Hagander wrote: On Sun, Oct 11, 2015 at 5:55 AM, Michael Paquier mailto:michael.paqu...@gmail.com>> wrote: On Sun, Oct 11, 2015 at 8:54 AM, Ali Akbar mailto:the.ap...@gmail.com>> wrote: > C:\Windows\system32>taskkill /F /PID 2080 > SUCCESS: The pr

Re: [HACKERS] Some questions about the array.

2015-10-09 Thread Andrew Dunstan
On 10/09/2015 08:02 AM, YUriy Zhuravlev wrote: We were some of the issues associated with the behavior of arrays. 1. We would like to implement arrays negative indices (from the end) like in Python or Ruby: arr[-2] or arr[1: -1] but as an array can be indexed in the negative area so it probabl

Re: [HACKERS] check fails on Fedora 23

2015-10-06 Thread Andrew Dunstan
On 10/06/2015 05:45 PM, Thomas Munro wrote: On Wed, Oct 7, 2015 at 9:49 AM, Robert Haas wrote: On Sun, Oct 4, 2015 at 11:52 AM, Andrew Dunstan wrote: Isn't this arguably a Fedora regression? What did they change in F23 to make it fail? I note that F23 is still in Beta. Maybe, but

Re: [HACKERS] check fails on Fedora 23

2015-10-06 Thread Andrew Dunstan
On 10/06/2015 04:49 PM, Robert Haas wrote: On Sun, Oct 4, 2015 at 11:52 AM, Andrew Dunstan wrote: Isn't this arguably a Fedora regression? What did they change in F23 to make it fail? I note that F23 is still in Beta. Maybe, but it's pretty unfriendly for us to complain about

Re: [HACKERS] factor out encoding dependent json/jsonb regression tests

2015-10-05 Thread Andrew Dunstan
On 10/05/2015 01:53 PM, Tom Lane wrote: Andrew Dunstan writes: I'm rather tired of having to update two sets of output files every time we change the json and jsonb regression tests. Also, other committers occasionally fall over this trap and fail to update json_1.out and jsonb_1.out,

[HACKERS] factor out encoding dependent json/jsonb regression tests

2015-10-05 Thread Andrew Dunstan
I'm rather tired of having to update two sets of output files every time we change the json and jsonb regression tests. Also, other committers occasionally fall over this trap and fail to update json_1.out and jsonb_1.out, as do almost all other patch authors. I propose that we remove those tes

Re: [HACKERS] Less than ideal error reporting in pg_stat_statements

2015-10-05 Thread Andrew Dunstan
On 10/05/2015 11:15 AM, Tom Lane wrote: Peter Geoghegan writes: I'm annoyed and disappointed that the patch committed does not even begin to address the underlying problem -- it just adds an escape hatch, and fixes another theoretical issue that no one was affected by. Honestly, next time I w

[HACKERS] debbugs

2015-10-04 Thread Andrew Dunstan
Could someone please point me at the documentation that says how to stand up and administer an instance of debbugs? If it doesn't exist I would say that is a very heavy mark against it. If it does, it's well enough hidden that a quick use of Google doesn't make it stand out, which doesn't fill

Re: [HACKERS] Less than ideal error reporting in pg_stat_statements

2015-10-04 Thread Andrew Dunstan
On 10/04/2015 06:16 PM, Tom Lane wrote: Peter Geoghegan writes: To be clear: I wasn't sure why you though I falsely count entries with dropped texts within entry_dealloc(). In the existing^H^H^Hprevious code, dropped-text entries would essentially act as length-zero summands in the average c

Re: [HACKERS] check fails on Fedora 23

2015-10-04 Thread Andrew Dunstan
On 10/04/2015 12:52 PM, Pavel Stehule wrote: Isn't this arguably a Fedora regression? What did they change in F23 to make it fail? I note that F23 is still in Beta. It is working on F22 - so it is looking as regression in some fedora components. can somebody repeat check

Re: [HACKERS] check fails on Fedora 23

2015-10-04 Thread Andrew Dunstan
On 10/04/2015 11:35 AM, Pavel Stehule wrote: > fails on assert Works for me ... what locale/collation are you running in? LANG=cs_CZ.UTF-8 it depends on locale - it is working with C or en_US.UTF-8, but doesn't work with Czech locale and fails w

Re: [HACKERS] jsonb_set array append hack?

2015-10-03 Thread Andrew Dunstan
On 10/03/2015 04:49 PM, Peter Geoghegan wrote: On Mon, Sep 21, 2015 at 2:21 PM, Andrew Dunstan wrote: Thanks for the explanation. So, basically, it should be like this, am I right? postgres=# SELECT jsonb_set( '{"name": "Joe", "vehicle_t

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-10-01 Thread Andrew Dunstan
On 10/01/2015 10:35 AM, Robert Haas wrote: On Wed, Sep 30, 2015 at 10:44 AM, Merlin Moncure wrote: I'm not trolling in any way. I'm just challenging you to back up your blanket assertions with evidence. For example, you're assertion that mailing lists are insufficient is simply stated and e

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-30 Thread Andrew Dunstan
On 09/30/2015 02:16 PM, Joshua D. Drake wrote: On 09/30/2015 10:45 AM, Andrew Dunstan wrote: Frankly, an insistence on moving to some integrated solution is likely to result in the adoption of nothing. And your "educating hackers who don't understand" is more than a little pa

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-30 Thread Andrew Dunstan
On 09/30/2015 01:31 PM, Joshua D. Drake wrote: On 09/30/2015 12:02 AM, Jim Nasby wrote: If people are hell-bent on every tool being separate then fine, but I get the distinct impression that everyone is discarding GitLab out of hand based on completely bogus information. Right, we need to s

Re: [HACKERS] Idea for improving buildfarm robustness

2015-09-30 Thread Andrew Dunstan
On 09/30/2015 01:18 AM, Michael Paquier wrote: On Wed, Sep 30, 2015 at 7:19 AM, Tom Lane wrote: I wrote: Josh Berkus writes: Give me source with the change, and I'll put it on a cheap, low-bandwith AWS instance and hammer the heck out of it. That should raise any false positives we can ex

Re: [HACKERS] Idea for improving buildfarm robustness

2015-09-29 Thread Andrew Dunstan
On 09/29/2015 02:48 PM, Tom Lane wrote: A problem the buildfarm has had for a long time is that if for some reason the scripts fail to stop a test postmaster, the postmaster process will hang around and cause subsequent runs to fail because of socket conflicts. This seems to have gotten a lot w

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-29 Thread Andrew Dunstan
On 09/29/2015 10:55 AM, Steve Crawford wrote: On Tue, Sep 29, 2015 at 7:16 AM, David Fetter > wrote: ...What we're not fine with is depending on a proprietary system, no matter what type of license, as infrastructure... Exactly. Which is why I was warning abo

Re: [HACKERS] Building with MinGW

2015-09-27 Thread Andrew Dunstan
On 09/27/2015 02:11 PM, Jeff Janes wrote: Has anyone had success following the instructions at https://wiki.postgresql.org/wiki/Building_With_MinGW#Installing_Git recently? I've followed the instructions to set up the build environment on a Windows box, and I can't build from git. I can fr

Re: [HACKERS] No Issue Tracker - Say it Ain't So!

2015-09-24 Thread Andrew Dunstan
On 09/24/2015 10:28 AM, k...@rice.edu wrote: On Wed, Sep 23, 2015 at 04:33:33PM -0700, Josh Berkus wrote: On 09/23/2015 03:05 PM, Jim Nasby wrote: On 9/23/15 3:12 PM, Thomas Kellerer wrote: They also support Postgres as their backend (and you do find hints here and there that it is the recom

Re: [HACKERS] Calculage avg. width when operator = is missing

2015-09-22 Thread Andrew Dunstan
On 09/22/2015 12:16 PM, Shulgin, Oleksandr wrote: Hi Hackers, I've recently stumbled upon a problem with table bloat estimation in case there are columns of type JSON. The quick bloat estimation queries use sum over pg_statistic.stawidth of table's columns, but in case of JSON the correspo

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Andrew Dunstan
On 09/22/2015 01:43 PM, Mark Dilger wrote: On Sep 22, 2015, at 6:09 AM, Andrew Dunstan wrote: You are fighting a losing battle. Think of they/them/their/theirs as being indefinitely gendered third person singular pronouns, as well as being third person plural pronouns. Yes it

Re: [HACKERS] 9.5: Can't connect with PGSSLMODE=require on Windows

2015-09-22 Thread Andrew Dunstan
On 09/22/2015 10:57 AM, Robert Haas wrote: On Tue, Sep 22, 2015 at 9:54 AM, Thom Brown wrote: Hi, With 9.5 alpha 2 on Windows 8 (64-bit), trying to require SSL results in a blocking error: pg_hba.conf: hostssl postgres postgres 0.0.0.0/0 trust postgresql.conf: ssl=on C:\Program F

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Andrew Dunstan
On 09/22/2015 10:29 AM, Geoff Winkless wrote: Oh, good! We're actually going to have this argument? Even though I said I don't care what you do? On 22 September 2015 at 15:11, Andrew Dunstan <mailto:and...@dunslane.net>> wrote: On 09/22/2015 09:25 AM, Geoff Winkless

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Andrew Dunstan
On 09/22/2015 09:25 AM, Geoff Winkless wrote: If someone sends me a document that uses "their" in a singular usage, I will think that person is lazy. That will continue to be the case, whether people tell me that it's accepted usage or not. You can think that if you like, but it's not even

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Andrew Dunstan
On 09/22/2015 12:32 AM, Erik Rijkers wrote: - might not be the same as the database user he needs to connect as. + might not be the same as the database user that is to be connect as. It is not an improvement. I would like to see this change rolled back. I agree this is awkward.

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

2015-09-22 Thread Andrew Dunstan
On 09/22/2015 06:17 AM, Geoff Winkless wrote: On 22 September 2015 at 10:52, Gavin Flower >wrote: On 22/09/15 21:33, Geoff Winkless wrote: ​ ​ Without wanting to get into a grammar war, ​I'm not so sure I agree that it "condon

Re: [HACKERS] jsonb_set array append hack?

2015-09-21 Thread Andrew Dunstan
On 09/21/2015 12:13 PM, Dmitry Dolgov wrote: > I would expect some kind of error. We're trying to address a position in an array, and we're instead passing a key. If it completes successfully, the chances are it isn't what the user intended. Thanks for the explanation. So, basically, it sh

Re: [HACKERS] cache type info in json_agg and friends

2015-09-17 Thread Andrew Dunstan
On 09/14/2015 03:41 PM, Alvaro Herrera wrote: Andrew Dunstan wrote: Currently, json_agg, jsonb_agg, json_object_agg and jsonb_object_agg do type classification on their arguments on each call to the transition function. This is quite unnecessary, as the argument types won't change.

Re: [HACKERS] honour TEMP_CONFIG in pg_upgrade tests

2015-09-17 Thread Andrew Dunstan
On 09/17/2015 09:42 AM, Tom Lane wrote: Andrew Dunstan writes: I propose to have the pg_upgrade test honour TEMP_CONFIG as pg_regress (or its Makefile) does, by applying the patch below. There might be opther places this should also be done, but this would be a start. No objection to the

[HACKERS] honour TEMP_CONFIG in pg_upgrade tests

2015-09-17 Thread Andrew Dunstan
I propose to have the pg_upgrade test honour TEMP_CONFIG as pg_regress (or its Makefile) does, by applying the patch below. There might be opther places this should also be done, but this would be a start. The motivation is to see if it stops the errors we often see on the somewhat slow axolotl

Re: [HACKERS] cache type info in json_agg and friends

2015-09-15 Thread Andrew Dunstan
On 09/14/2015 04:24 PM, Andrew Dunstan wrote: On 09/14/2015 03:42 PM, Teodor Sigaev wrote: Currently, json_agg, jsonb_agg, json_object_agg and jsonb_object_agg do type classification on their arguments on each call to the transition function. This is quite unnecessary, as the argument types

Re: [HACKERS] cache type info in json_agg and friends

2015-09-14 Thread Andrew Dunstan
On 09/14/2015 03:42 PM, Teodor Sigaev wrote: Currently, json_agg, jsonb_agg, json_object_agg and jsonb_object_agg do type classification on their arguments on each call to the transition function. This is quite unnecessary, as the argument types won't change. This patch remedies the defect by c

[HACKERS] cache type info in json_agg and friends

2015-09-14 Thread Andrew Dunstan
Currently, json_agg, jsonb_agg, json_object_agg and jsonb_object_agg do type classification on their arguments on each call to the transition function. This is quite unnecessary, as the argument types won't change. This patch remedies the defect by caching the necessary values in the aggregat

Re: [HACKERS] jsonb_set array append hack?

2015-09-14 Thread Andrew Dunstan
On 09/14/2015 01:29 PM, Thom Brown wrote: Hi, I've noticed that if you use a string for an element key in jsonb_set with create_missing set to true, you can use it to append to an array: postgres=# SELECT jsonb_set( '{"name": "Joe", "vehicle_types": ["car","van"]}'::jsonb, '{vehi

<    1   2   3   4   5   6   7   8   9   10   >