D23712: [Cuttlefish] Overhaul program, use Kirigami

davidedmundson added a comment. I love a patch with that much red. ++ to the concept, we shouldn't be using plasma outside of plasma. INLINE COMMENTS > Preview.qml:123 > -source: iconName > -usesPlasmaTheme: cuttlefish.usesPlasmaTheme > -colorGroup: Pl

D23683: [libnotificatonmanager] Initialise member variable

This revision was automatically updated to reflect the committed changes. Closed by commit R120:57a02d81fd00: [libnotificatonmanager] Initialise member variable (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23683?vs=6526

D23683: [libnotificatonmanager] Initialise member variable

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY 1408== Conditional jump or move depends on uninitialised value(s) -

D23342: Add a per-process network information plugin

davidedmundson added a comment. > This could be run on package install by distributions, or we could add an action somewhere to let the user run it on demand. It is run automatically in the cmake. See plugins/process/network/helper/CMakeLists.txt I think that should be enough

D23594: Use sensor index for request ID in SystemMonitorEngine::updateSensors()

davidedmundson added a comment. You're right. -N response to "someSensorName?" (which returns metadata of a sensor) -1 response to "monitors" (which lists things) +N response to a given call > . I couldn't find a place that actually calls that function, so I couldn't verify the

D23293: [Notifications] Implement JobViewV3

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > job_p.cpp:350 > +auto it = properties.find(QStringLiteral("title")); > +if (it != end) { > +updateField(it->toString(), m_summary, &Job::

D23569: Request matching version of plasma-workspace libs

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY We never remember to manually update it given the tight plasma coupling.

D23566: Move code to send signals and set priority of processes to a dedicated object

davidedmundson added a comment. ++ Looks nice and simplifies this old mega class INLINE COMMENTS > process_controller.h:89 > + */ > +void setWidget(QWidget *widget); > + Eww, it would be better if we could make this a qwindow, but I see you're limited by current KAuth > ksysgu

D23508: [dataengines/apps] Port old style connect

This revision was automatically updated to reflect the committed changes. Closed by commit R120:51d5801fe02e: [dataengines/apps] Port old style connect (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23508?vs=64768&id=6487

D23509: [shell/panelconfigview] Port old-style connect

This revision was automatically updated to reflect the committed changes. Closed by commit R120:756b141a431f: [shell/panelconfigview] Port old-style connect (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23509?vs=64769&id

D23506: [dataengines/favicons] Port old-style connect

This revision was automatically updated to reflect the committed changes. Closed by commit R120:07d0ed7e0703: [dataengines/favicons] Port old-style connect (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23506?vs=64766&id=

D22767: Calculate first clickable point, from the top-left

This revision was automatically updated to reflect the committed changes. Closed by commit R120:989a7759a969: Calculate first clickable point, from the top-left (authored by kmaterka, committed by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator

D21619: Wallpaper: delay calling UIReady until the image is actually loaded

davidedmundson abandoned this revision. davidedmundson added a comment. Kai pushed an identical patch REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21619 To: davidedmundson, #plasma, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalouka

D23461: Remove 'magic' filtering of recent apps

davidedmundson added inline comments. INLINE COMMENTS > recentusagemodel.cpp:522 > +if (auto model = > qobject_cast(sourceModel())) { > +model->setShowAllRecents(m_showAllRecents); > +m_showAllRecents = recents; If this is called before refresh model will be null

D23518: Disable media controls and tabsrunner in Firefox again

davidedmundson accepted this revision. davidedmundson added a comment. Yeah, but I /really really really/ don't like surprise upgrade behaviour that you get this patch and suddenly your incognito windows are being publicly broadcast everywhere. It could lead to something quite bad. The w

D23461: Remove 'magic' filtering of recent apps

davidedmundson added a comment. > Is there a reason to change kicker? If not, it needs to be a property. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23461 To: tcanabrava, hein, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, j

D23509: [shell/panelconfigview] Port old-style connect

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.

D23508: [dataengines/apps] Port old style connect

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles. Not sure anything uses it REPOSITORY R120 Plasma Workspace REVISION

D23506: [dataengines/favicons] Port old-style connect

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles. Not sure what uses it? REPOSITORY R120 Plasma Workspace BRANCH origi

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

davidedmundson added inline comments. INLINE COMMENTS > luc4 wrote in main.qml:238 > I think I copied from here: > https://git.reviewboard.kde.org/r/121698/diff/1/#. Is it outdated maybe? ~ish. To explain what it's doing. i18n("hello") will return a translated version of the word "hello" bas

D23461: Remove 'magic' filtering of recent apps

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > recentusagemodel.cpp:98 > - > -return (service && (!favoritesModel || > !favoritesModel->isFavorite(service->storageId(; > -}

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

davidedmundson added a comment. Generally seems ok. Two minor comments. INLINE COMMENTS > main.qml:238 > +_iconName: "edit-redo" > +_text: i18nd("libplasma5", "Redo") > +onTriggered: contextMenu.retFocus(() => > mainText

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

davidedmundson added a comment. > Could you update the title and summary so they reflect what's in the patch now? This isn't done (or at least phabricator is being unhelpful and not showing it if you have) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D2

D21860: Set a font for gtk applications in the fonts kcm

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in fonts.cpp:607 > Given this is a kded module and as such a regular qt application, you should > be able to get all of this automatically. > Is the `QGuiApplication::fontChanged` emitted when you change font settings? There

D23386: [Applet] Double-click on icon to make it the default

davidedmundson added a comment. I don't like patches with secret features that rely on double click. We don't use double click in our UIs and we should be consistent. Also if we do have a UX problem where finding how to change the default is hard (which D23389

D23417: libtaskmanager: fix launch url for startup info with pathless desktop file

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. :/ good catch. INLINE COMMENTS > startuptasksmodel.cpp:178 > +// drop ".desktop" suffix > +appId.chop(8); > I quite like doing appId.chop(strlen(

D23448: Capacity degradation -> Battery health

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. That's much clearer. REPOSITORY R120 Plasma Workspace BRANCH degradation-to-health (branched from master) REVISION DETAIL https://phabricator.kde.org/D23448 To: ngra

D23378: Check if sddm user exists

davidedmundson added inline comments. INLINE COMMENTS > sddmauthhelper.cpp:80 > // create SDDM config directory if it does not exist > QDir > sddmConfigLocation(args[QStringLiteral("sddmUserConfig")].toString()); > if (!sddmConfigLocation.exists()) { can we use sddmHomeDirPath +

D23378: Check if sddm user exists

davidedmundson added a comment. Whilst client checks are nice, for the reason you're changing it this should (also?) be in the authhelper. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D23378 To: filipf Cc: davidedmundson, plasma-devel, LeGas

D23356: Add ksysguard plugin for taskmanager integration

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in taskmanager.cpp:99 > This role is a `QIcon`, potentially created from the window pixmap in case > window mapping failed. > Or is that what the "tiny mods in ProcessModel" is about? Yeah, and I need to map it to there decor

D23356: Add ksysguard plugin for taskmanager integration

davidedmundson updated this revision to Diff 64410. davidedmundson added a comment. update REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23356?vs=64326&id=64410 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23356 AFFECTED FILES plug

D23287: Create a plugin framework for processes

davidedmundson updated this revision to Diff 64404. davidedmundson added a comment. q_decl_hidden ran clang-format over new files REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64291&id=64404 BRANCH master REVISION DETAIL https://

D22514: Show if KRunner is still searching for more things

davidedmundson added inline comments. INLINE COMMENTS > apol wrote in RunCommand.qml:86 > Since it's using QQC2.TextField, won't it be using a completely different > colour scheme? There was some code to make that magically work. (maybe it was that URLInterceptor we removed?) If it doesn't wo

D23356: Add ksysguard plugin for taskmanager integration

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Currently this is all hardcoded in ProcessModel. By moving it into a plugin

D22514: Show if KRunner is still searching for more things

davidedmundson added a comment. Seems to work. There's some comments from Kai above. INLINE COMMENTS > RunCommand.qml:86 > +margins: units.smallSpacing > +rightMargin: height > +} Does using Kirigami.ActionTextField help with positionin

D23342: Add a per-process network information plugin

davidedmundson added inline comments. INLINE COMMENTS > ahiemstra wrote in CMakeLists.txt:26 > We can, if there is a decent way to find executables in libexec, because I > couldn't find anything in QStandardPaths. There's nothing at runtime, but we know KDE_INSTALL_LIBEXECDIR_FULL at configure

D23342: Add a per-process network information plugin

davidedmundson added inline comments. INLINE COMMENTS > CMakeLists.txt:21 > + > +if (HAVE_LIBCAP) > +install( This isn't set. libcap_FOUND is > CMakeLists.txt:26 > +CAP_NET_RAW=+ep > +\$ENV{DESTDIR}${CMAKE_INSTALL_FULL_BINDIR}/ksgrd_network_helper)" > +) Can we use KDE

D23342: Add a per-process network information plugin

davidedmundson added inline comments. INLINE COMMENTS > network.cpp:74 > +const auto parts = line.splitRef(QLatin1Char('|'), > QString::SkipEmptyParts); > +if (parts.size() < 2) > +continue; why 2? We call parts.at(6) Also code style {} > network.h:28-2

D23287: Create a plugin framework for processes

davidedmundson updated this revision to Diff 64291. davidedmundson added a comment. Split ProcessAttribute into a new file Install headers correctly REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64189&id=64291 BRANCH master REVISIO

D23287: Create a plugin framework for processes

davidedmundson updated this revision to Diff 64189. davidedmundson added a comment. update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64155&id=64189 REVISION DETAIL https://phabricator.kde.org/D23287 AFFECTED FILES processcore/C

D23056: RFC: Don't auto-restart KRunner when crashed

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > which might have been what David was referring to Yeah, it was. I'd like us to find a way to make that behaviour choosing explicit not inferred from restart behavio

D23305: Add plugin showing nvidia GPU load stats

davidedmundson updated this revision to Diff 64180. davidedmundson added a comment. remove stray copy pasted line REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23305?vs=64160&id=64180 BRANCH plugins2 REVISION DETAIL https://phabricator.kde.

D23305: Add plugin showing nvidia GPU load stats

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This plugin shows the process GPU load and GPU memory usage for users of Nv

D23288: Move XResources out of the central model into a plugin

davidedmundson updated this revision to Diff 64157. davidedmundson added a comment. update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23288?vs=64135&id=64157 REVISION DETAIL https://phabricator.kde.org/D23288 AFFECTED FILES CMakeLists.tx

D23287: Create a plugin framework for processes

davidedmundson updated this revision to Diff 64155. davidedmundson added a comment. update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64136&id=64155 REVISION DETAIL https://phabricator.kde.org/D23287 AFFECTED FILES processcore/C

D23287: Create a plugin framework for processes

davidedmundson updated this revision to Diff 64136. davidedmundson added a comment. update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64100&id=64136 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23287 AFFECTED FILE

D23287: Create a plugin framework for processes

davidedmundson marked 7 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in extended_process_list.cpp:62 > Add `reserve` call I can't add a meaningful one. p->attributes() is itself another vector of size 0 to N. > broulik wrote in process_data_pro

D23288: Move XResources out of the central model into a plugin

davidedmundson updated this revision to Diff 64135. davidedmundson marked an inline comment as done. davidedmundson added a comment. update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23288?vs=64125&id=64135 BRANCH plugins REVISION DETAIL

D23288: Move XResources out of the central model into a plugin

davidedmundson marked 4 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > apol wrote in xres.h:1 > Copyright? > > First time I see `#pragma once` in KDE software. I've used #pragma once all over the place already, hasn't seemed to cause an issue. REPOSITORY R1

D23288: Move XResources out of the central model into a plugin

davidedmundson updated this revision to Diff 64125. davidedmundson added a comment. Rebase diff REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23288?vs=64098&id=64125 REVISION DETAIL https://phabricator.kde.org/D23288 AFFECTED FILES processp

D23287: Create a plugin framework for processes

davidedmundson updated this revision to Diff 64100. davidedmundson added a comment. Update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64097&id=64100 REVISION DETAIL https://phabricator.kde.org/D23287 AFFECTED FILES processcore/C

D23288: Move XResources out of the central model into a plugin

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY XRes works in an odd way, the evaluation is inside the processui model, the

D23287: Create a plugin framework for processes

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Currently everything for processes is hardcoded with a method for each proc

D23279: [Lock screen] Fix bug causing "Switch User" button to always be visible

davidedmundson added a comment. With this patch how would someone create the first new session? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23279 To: ngraham, mart, #plasma Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampal

D21860: Set a font for gtk applications in the fonts kcm

davidedmundson added a comment. > But it was recomended to me to make the daemon as the patch Discussed where? I'm curious of the long term plans and how this fits in with krdb which does most other syncing. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde

D21860: Set a font for gtk applications in the fonts kcm

davidedmundson added inline comments. INLINE COMMENTS > gikari wrote in CMakeLists.txt:20 > Xml comes from gtk configuration daemon I'm currently working on, whose > source code is currently here . > But it was recomended to me to make the daemon as th

Re: KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 342 - Still Failing!

CI breakage is by me pushing a change that depends on a change I pushed to kcoreaddons. I don't think there's a real problem to fix once CI all syncs up. David

D23261: Add option to discourage reporting bugs

davidedmundson added a comment. Makes sense to me. There are situations with no useful backtraces and users can't install them, but it's nice to have some feedback than just a window completely disappearing. ++ REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D2

Re: plasma* akademy bofs

I put in a placeholder, but we do need to discuss what topics we need and assign them into 1 hour discussions. David

D21860: Set a font for gtk applications in the fonts kcm

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:20 > set(klauncher_xml ${KINIT_DBUS_INTERFACES_DIR}/kf5_org.kde.KLauncher.xml) > +set(kdegtkconfigd_xml ${KINIT_DBUS_INTERFACES

D23198: Skip mime type check only for files on network mounts

davidedmundson added a comment. > True, but then that implies that KFileItem::isSlow() which has the same code is flawed in the same way. It is. We have ironic lockups there. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23198 To: meven, #plasma, dfaur

D23185: [libtaskmanager] Port to lighter KProcessList

This revision was automatically updated to reflect the committed changes. Closed by commit R120:83ca6de8fcd7: [libtaskmanager] Port to lighter KProcessList (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23185?vs=63814&id=

D23257: Allow for easier syncing of Plasma font

davidedmundson added a comment. We have a mixture of two things. Here we have a serialised QFont stored as font=Lato,11,-1,5,50,0,0,0,0,0,Regular using these magic methods: QDataStream &QFont::operator<<(QDataStream &s, const QFont &font) That tell other code how to turn

D17464: [Timer applet] Minor fixes for the applet

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. If it's the exact same code as before, then my opinion will be the same. The digital clock set the text height to 0.7 of the panel and the width is inferred th

D22885: Add global animation speed slider to workspace options KCM

davidedmundson updated this revision to Diff 63844. davidedmundson added a comment. rename config option and variable and property names REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22885?vs=62956&id=63844 BRANCH master REVISION DETAIL https:

D22818: Avoid crash if kicker plugin is used outside plasma context

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c423eb7f959c: Avoid crash if kicker plugin is used outside plasma context (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22818?

D23185: [libtaskmanager] Port to lighter KProcessList

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Only fetches the properties name and command. Avoids bringing a libksysguar

D22327: [libnotificationmanager] Port to lighter KProcessList

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d14aca8cd861: [libnotificationmanager] Port to lighter KProcessList (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22327?vs=61345&id=63810#toc REPOSITORY R120 P

D22053: [libtaskmanager] Track stacking order and window activation (on X11)

davidedmundson added a comment. One minor comment, and anthonyfieroni's comment, and this is good to go. INLINE COMMENTS > xwindowtasksmodel.cpp:203 > +cachedStackingOrder = KWindowSystem::stackingOrder(); > +q->dataChanged(q->index(0, 0), q->index(q->rowCount() - 1, 0

D22012: Clean up old bug workaround in KCMFileIndexer

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. It was first added in 2d5f289767ee7b7c54f8b55e8032d20ef7f092f4 with some pretty sparse docs, then

D21872: Translate keyboard layouts in sddm

davidedmundson added a comment. > So is this unnecessary, and the string should be translated somewhere over in FreeDesktop-land? The translations are done somewhere over in freedesktop-land, but someone still needs to load them. This does it in our theme. My question is why is t

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Intention makes sense, as do most the changes. Just some minor comments. INLINE COMMENTS > ConfigGeneral.qml:124 > +Layout.topMargin: units.gridUnit > +

Re: [System Tray]

On Thu, Aug 1, 2019 at 10:30 AM Konrad Materka wrote: > > Hi, > > recently I was fixing two bugs related to SystemTray (in review: > https://phabricator.kde.org/D22804, > https://phabricator.kde.org/D22767). I noticed that code is highly > coupled and "fragile" with some unclear references like: >

D22901: Make alphabetic categorization of the "All Applications" section optional

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. That's much nicer. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D22901 To: hein, #plasma, davidedmundson, tcanabrava Cc:

D22885: Add global animation speed slider to workspace options KCMGNU nano 4.3/tmp/edit.fd801hu0c34so8k8/new-commitModifiedAdd global animation speed slider to workspace options KCM

davidedmundson updated this revision to Diff 62956. davidedmundson added a comment. update Updating D22885: Add global animation speed slider to workspace options KCM === GNU nano 4.3 /tmp/edit.fd801hu0c34so8k

D22885: Add global animation speed slider to workspace options KCMGNU nano 4.3/tmp/edit.fd801hu0c34so8k8/new-commitModifiedAdd global animation speed slider to workspace options KCM

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Introduce a new config entry into kdeglobals AnimationSpeed that will contr

D18419: Move KCMs in "Workspace Theme" to more appropriate locations

davidedmundson added a comment. > but it doesn't make sense to me that Splash Screen will be in Appearance, while Login Screen (SDDM) will be in Startup and Shutdown. The problem that needs resolving there is SDDM KCM also does autologin and configuring UIDs to list. So you have a spli

D18419: Adjust some KCMs to implement new Appearance section layout

davidedmundson resigned from this revision. davidedmundson added a comment. My opinion on top-down "lets shuffle things" remains the same. However, I am happy to approve iterative changes. I can see how this is a prerequisite to renaming "Workspace Theme" which seems to make sense, given

D22874: Remove the ShellManager

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. The desktop loader has been broken since before 5.0, I think it's a classic example of building something too early. We can always revert if we find a usage later. Go fo

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > Some users complained about the buttons being smaller or the size not being configurable when it previously was. Whatever you change some users will always complain.

D21619: Wallpaper: delay calling UIReady until the image is actually loaded

davidedmundson updated this revision to Diff 62849. davidedmundson added a comment. update REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21619?vs=59259&id=62849 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21619 AFFECTED FILES

D22316: Avoid garbling the sound if the volume slider is moved fast

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Should it queue up a sound so that it plays one sound at the final volume when you've stopped dragging? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https

D22846: Port KeyboardLayout component to use generated DBus interface

This revision was automatically updated to reflect the committed changes. Closed by commit R120:18010b1a89c7: Port KeyboardLayout component to use generated DBus interface (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22

D22847: [runners/kill] Port old style connects

This revision was automatically updated to reflect the committed changes. Closed by commit R120:edaa70cbdb34: [runners/kill] Port old style connects (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22847?vs=62826&id=62831

D22539: Fix broken guard that prevents styling sliders with negative values

This revision was automatically updated to reflect the committed changes. Closed by commit R858:ef066d9d28ac: Fix broken guard that prevents styling sliders with negative values (authored by davidedmundson). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https:/

D22843: [libcolorcorrect] Port old style connects

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7aef897a3a6c: [libcolorcorrect] Port old style connects (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22843?vs=62818&id=6282

D22842: [shell/panelshadows] Port away from old style connect

This revision was automatically updated to reflect the committed changes. Closed by commit R120:214077668667: [shell/panelshadows] Port away from old style connect (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22842?vs=6

D22847: [runners/kill] Port old style connects

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL htt

D22846: Port KeyboardLayout component to use generated DBus interface

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY QDBusInterface is useful for runtime introspection but little else. As w

D22841: [dataengines/hotplug] Port code to new connect syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R120:20c353d4f4ee: [dataengines/hotplug] Port code to new connect syntax (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22841?vs=6

D22840: [interactiveconsole] Port KIO code to new connect syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7ee035acf838: [interactiveconsole] Port KIO code to new connect syntax (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22840?v

D22843: [libcolorcorrect] Port old style connects

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL htt

D22842: [shell/panelshadows] Port away from old style connect

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.

D22841: [dataengines/hotplug] Port code to new connect syntax

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It wasn't ported before due to the slot being overloaded. Code became cl

D22840: [interactiveconsole] Port KIO code to new connect syntax

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It was previously using the old style due to getting downcast too early TEST

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

davidedmundson added a comment. Can you give a bit more rationale? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22359 To: ndavis, #vdg, #plasma Cc: davidedmundson, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himc

D22818: Avoid crash if kicker plugin is used outside plasma context

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Code currently gets the applet interface object passed in explicitly, from

D22762: Take in consideration flat() for the All Applications menu

davidedmundson added a comment. m_flat currently behaves a bit specially. It doesn't affect the toplevel, it only affects sub models created within it. If we used AppsModel directly to fix the original bug, we would need to fix AppsModel to follow m_flat when showing an empty m_entryPath

D19947: systray: show a small animation on the icons when activated

davidedmundson added a comment. Code wise, it's fine. Personally I like it. If VDG approve, go for it. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19947 To: apol, #plasma Cc: anthonyfieroni, davidedmundson, ngraham, plasma-devel, LeGast00n, jraleigh

D17464: [Timer applet] Minor fixes for the applet

davidedmundson added a comment. > The rationale is to make the clock font size and the timer font size identical. Setting 0.84 as timer height multiplier indeed reaches this goal. But two other problems remain: I don't follow how it makes them the same when the other number is different.

<    5   6   7   8   9   10   11   12   13   14   >