Re: [Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2022-01-07 Thread Andrea Bolognani
On Fri, Jan 07, 2022 at 12:06:47PM +, Daniel P. Berrangé wrote: > On Fri, Jan 07, 2022 at 12:55:42PM +0100, Thomas Huth wrote: > > On 07/01/2022 12.43, Andrea Bolognani wrote: > > > On Thu, Aug 29, 2019 at 10:15:05AM +0100, Daniel P. Berrangé wrote: > > > > Where are you seeing pkg-config

Re: [Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2022-01-07 Thread Daniel P . Berrangé
On Fri, Jan 07, 2022 at 12:55:42PM +0100, Thomas Huth wrote: > On 07/01/2022 12.43, Andrea Bolognani wrote: > > On Thu, Aug 29, 2019 at 10:15:05AM +0100, Daniel P. Berrangé wrote: > > > On Thu, Aug 29, 2019 at 04:53:02PM +0800, zhe...@windriver.com wrote: > > > > libgcrypt may also be controlled

Re: [Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2022-01-07 Thread Thomas Huth
On 07/01/2022 12.43, Andrea Bolognani wrote: On Thu, Aug 29, 2019 at 10:15:05AM +0100, Daniel P. Berrangé wrote: On Thu, Aug 29, 2019 at 04:53:02PM +0800, zhe...@windriver.com wrote: libgcrypt may also be controlled by pkg-config, this patch adds pkg-config handling for libgcrypt. Where are

Re: [Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2022-01-07 Thread Andrea Bolognani
On Thu, Aug 29, 2019 at 10:15:05AM +0100, Daniel P. Berrangé wrote: > On Thu, Aug 29, 2019 at 04:53:02PM +0800, zhe...@windriver.com wrote: > > libgcrypt may also be controlled by pkg-config, this patch adds pkg-config > > handling for libgcrypt. > > Where are you seeing pkg-config files for

Re: [Qemu-devel] [PATCH] configure: Define NCURSES_WIDECHAR if we're using curses

2021-06-07 Thread Daniel P . Berrangé
On Mon, Jun 07, 2021 at 02:57:41PM +0200, Laszlo Ersek wrote: > On 06/06/21 20:13, Stefan Weil wrote: > > Am 02.06.17 um 16:35 schrieb Peter Maydell: > > > >> We want the wide character functions from the ncurses header. > >> Unfortunately it doesn't provide them by default, but only > >> if

Re: [Qemu-devel] [PATCH] configure: Define NCURSES_WIDECHAR if we're using curses

2021-06-07 Thread Laszlo Ersek
On 06/06/21 20:13, Stefan Weil wrote: > Am 02.06.17 um 16:35 schrieb Peter Maydell: > >> We want the wide character functions from the ncurses header. >> Unfortunately it doesn't provide them by default, but only >> if either: >>   * NCURSES_WIDECHAR is defined (for ncurses 20111030 and up) >>  

Re: [Qemu-devel] [PATCH] configure: Define NCURSES_WIDECHAR if we're using curses

2021-06-06 Thread Stefan Weil
Am 02.06.17 um 16:35 schrieb Peter Maydell: We want the wide character functions from the ncurses header. Unfortunately it doesn't provide them by default, but only if either: * NCURSES_WIDECHAR is defined (for ncurses 20111030 and up) * _XOPEN_SOURCE/_XOPEN_SOURCE_EXTENDED are suitably

Re: [Qemu-devel] [PATCH] configure: linux-user doesn't need neither fdt nor slirp

2020-02-18 Thread Laurent Vivier
Le 21/06/2019 à 15:05, Laurent Vivier a écrit : > if softmmu is not enabled, we disable by default fdt and > slirp as they are only used by -softmmu targets. > > A side effect is the git submodules are not cloned > if they are not needed. > > Clone and build can be forced with --enable-fdt and >

Re: [Qemu-devel] [PATCH] configure: Add xkbcommon configure options

2019-09-16 Thread Philippe Mathieu-Daudé
On 9/14/19 4:51 PM, James Le Cuirot wrote: > This dependency is currently "automagic", which is bad for distributions. > Fixes: 6a021536e23 Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: James Le Cuirot > --- > configure | 5 + > 1 file changed, 5 insertions(+) > > diff --git

[Qemu-devel] [PATCH] configure: Add xkbcommon configure options

2019-09-14 Thread James Le Cuirot
This dependency is currently "automagic", which is bad for distributions. Signed-off-by: James Le Cuirot --- configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 30aad233d1..30544f52e6 100755 --- a/configure +++ b/configure @@ -1521,6 +1521,10 @@ for

Re: [Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2019-08-29 Thread He Zhe
On 8/29/19 5:15 PM, Daniel P. Berrangé wrote: > On Thu, Aug 29, 2019 at 04:53:02PM +0800, zhe...@windriver.com wrote: >> From: He Zhe >> >> libgcrypt may also be controlled by pkg-config, this patch adds pkg-config >> handling for libgcrypt. > Where are you seeing pkg-config files for

[Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2019-08-29 Thread zhe.he
From: He Zhe libgcrypt may also be controlled by pkg-config, this patch adds pkg-config handling for libgcrypt. Signed-off-by: He Zhe --- configure | 48 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/configure b/configure index

[Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2019-08-29 Thread zhe.he
From: He Zhe libgcrypt may also be controlled by pkg-config, this patch adds pkg-config handling for libgcrypt. Signed-off-by: He Zhe --- configure | 48 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/configure b/configure index

Re: [Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2019-08-29 Thread Daniel P . Berrangé
On Thu, Aug 29, 2019 at 05:26:49PM +0800, He Zhe wrote: > > > On 8/29/19 5:15 PM, Daniel P. Berrangé wrote: > > On Thu, Aug 29, 2019 at 04:53:02PM +0800, zhe...@windriver.com wrote: > >> From: He Zhe > >> > >> libgcrypt may also be controlled by pkg-config, this patch adds pkg-config > >>

Re: [Qemu-devel] [PATCH] configure: Add pkg-config handling for libgcrypt

2019-08-29 Thread Daniel P . Berrangé
On Thu, Aug 29, 2019 at 04:53:02PM +0800, zhe...@windriver.com wrote: > From: He Zhe > > libgcrypt may also be controlled by pkg-config, this patch adds pkg-config > handling for libgcrypt. Where are you seeing pkg-config files for libgcrypt ? The upstream project has (frustratingly) been

Re: [Qemu-devel] [PATCH] configure: more resilient Python version capture

2019-08-26 Thread Cleber Rosa
On Sat, Aug 24, 2019 at 07:32:24AM +, tony.ngu...@bt.com wrote: > > -python_version=$($python -V 2>&1 | sed -e 's/Python\ //') > > +python_version=$(python2 -c 'import sys; print("%d.%d.%d" % > > (sys.version_info[0], sys.version_info[1], sys.version_info[2]))' > > 2>/dev/null) > > On a

Re: [Qemu-devel] [PATCH] configure: more resilient Python version capture

2019-08-25 Thread Peter Maydell
On Sat, 24 Aug 2019 at 08:32, wrote: > > -echo "PYTHON_VERSION=$python_version" >> $config_host_mak > > +echo "PYTHON2=$python2" >> $config_host_mak > ... > > -ifneq ($(findstring v2,"v$(PYTHON_VERSION)"),v2) > > +ifneq ($(PYTHON2),y) > > Succinctly, if Python 3. > > We can further ween the world

Re: [Qemu-devel] [PATCH] configure: more resilient Python version capture

2019-08-24 Thread tony.nguyen
> -python_version=$($python -V 2>&1 | sed -e 's/Python\ //') > +python_version=$(python2 -c 'import sys; print("%d.%d.%d" % > (sys.version_info[0], sys.version_info[1], sys.version_info[2]))' 2>/dev/null) On a Python 3 only system, configure will no longer print the version. e.g. /*

[Qemu-devel] [PATCH] configure: more resilient Python version capture

2019-08-23 Thread Cleber Rosa
The current approach to capture the Python version is fragile, as it was demonstrated by a very specific build of Python 3 on Fedora 29 that, under non-interactive shells would print multiline version information. The (badly) stripped version output would be sent to config-host.mak, producing bad

Re: [Qemu-devel] [PATCH] configure: fix sdl detection using sdl2-config

2019-08-21 Thread Laurent Vivier
Le 11/07/2019 à 00:55, Carlo Marcelo Arenas Belón a écrit : > If SDL2 is requested but pkg-config doesn't have a module for it > configure should fallback to use sdl*-config, but wasn't able to > because and old variable (from SDL) was being used by mistake. > > Correct the variable name and

Re: [Qemu-devel] [PATCH] configure: remove AUTOCONF_HOST

2019-08-06 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1565075472-15106-1-git-send-email-pbonz...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH] configure: remove AUTOCONF_HOST

2019-08-06 Thread Paolo Bonzini
From: Marc-André Lureau This is a left-over from commit c12b6d70e384c769ca372e15ffd19b3e9f563662 ("pixman: drop submodule") Signed-off-by: Marc-André Lureau Signed-off-by: Paolo Bonzini --- configure | 5 - 1 file changed, 5 deletions(-) diff --git a/configure b/configure index

Re: [Qemu-devel] [PATCH] configure: remove AUTOCONF_HOST

2019-07-23 Thread Philippe Mathieu-Daudé
On 7/23/19 2:16 PM, Marc-André Lureau wrote: > This is a left-over from commit > c12b6d70e384c769ca372e15ffd19b3e9f563662 ("pixman: drop submodule") > > Signed-off-by: Marc-André Lureau > --- > configure | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/configure b/configure > index

[Qemu-devel] [PATCH] configure: remove AUTOCONF_HOST

2019-07-23 Thread Marc-André Lureau
This is a left-over from commit c12b6d70e384c769ca372e15ffd19b3e9f563662 ("pixman: drop submodule") Signed-off-by: Marc-André Lureau --- configure | 5 - 1 file changed, 5 deletions(-) diff --git a/configure b/configure index ad0b8582bf..82c65ab46a 100755 --- a/configure +++ b/configure @@

Re: [Qemu-devel] [PATCH] configure: Define target access alignment in configure

2019-07-19 Thread Paolo Bonzini
On 19/07/19 11:17, Aleksandar Markovic wrote: > > On Jul 18, 2019 11:55 AM, "Paolo Bonzini" > wrote: >> >> On 18/07/19 08:01, tony.ngu...@bt.com wrote: >> > This patch moves the define of target access alignment earlier from >> >

Re: [Qemu-devel] [PATCH] configure: Define target access alignment in configure

2019-07-19 Thread Aleksandar Markovic
On Jul 18, 2019 8:02 AM, wrote: > > This patch moves the define of target access alignment earlier from > target/foo/cpu.h to configure. > > Suggested in Richard Henderson's reply to "[PATCH 1/4] tcg: TCGMemOp is now > accelerator independent MemOp" > > Signed-off-by: Tony Nguyen > --- Hi,

Re: [Qemu-devel] [PATCH] configure: Define target access alignment in configure

2019-07-19 Thread Aleksandar Markovic
On Jul 18, 2019 11:55 AM, "Paolo Bonzini" wrote: > > On 18/07/19 08:01, tony.ngu...@bt.com wrote: > > This patch moves the define of target access alignment earlier from > > target/foo/cpu.h to configure. > > > > Suggested in Richard Henderson's reply to "[PATCH 1/4] tcg: TCGMemOp is now > >

Re: [Qemu-devel] [PATCH] configure: Define target access alignment in configure

2019-07-19 Thread Aleksandar Markovic
On Jul 18, 2019 8:02 AM, wrote: > > This patch moves the define of target access alignment earlier from > target/foo/cpu.h to configure. > > Suggested in Richard Henderson's reply to "[PATCH 1/4] tcg: TCGMemOp is now > accelerator independent MemOp" > > Signed-off-by: Tony Nguyen > --- >

Re: [Qemu-devel] [PATCH] configure: Define target access alignment in configure

2019-07-19 Thread Aleksandar Markovic
On Jul 18, 2019 8:02 AM, wrote: > > This patch moves the define of target access alignment earlier from > target/foo/cpu.h to configure. > > Suggested in Richard Henderson's reply to "[PATCH 1/4] tcg: TCGMemOp is now > accelerator independent MemOp" > > Signed-off-by: Tony Nguyen > --- Tony,

Re: [Qemu-devel] [PATCH] configure: Define target access alignment in configure

2019-07-18 Thread Richard Henderson
On 7/17/19 11:01 PM, tony.ngu...@bt.com wrote: > This patch moves the define of target access alignment earlier from > target/foo/cpu.h to configure. > > Suggested in Richard Henderson's reply to "[PATCH 1/4] tcg: TCGMemOp is now > accelerator independent MemOp" > > Signed-off-by: Tony Nguyen >

Re: [Qemu-devel] [PATCH] configure: Define target access alignment in configure

2019-07-18 Thread Paolo Bonzini
On 18/07/19 08:01, tony.ngu...@bt.com wrote: > This patch moves the define of target access alignment earlier from > target/foo/cpu.h to configure. > > Suggested in Richard Henderson's reply to "[PATCH 1/4] tcg: TCGMemOp is now > accelerator independent MemOp" > > Signed-off-by: Tony Nguyen >

Re: [Qemu-devel] [PATCH] configure: Define target access alignment in configure

2019-07-18 Thread Philippe Mathieu-Daudé
On 7/18/19 8:01 AM, tony.ngu...@bt.com wrote: > This patch moves the define of target access alignment earlier from > target/foo/cpu.h to configure. > > Suggested in Richard Henderson's reply to "[PATCH 1/4] tcg: TCGMemOp is now > accelerator independent MemOp" > > Signed-off-by: Tony Nguyen >

[Qemu-devel] [PATCH] configure: Define target access alignment in configure

2019-07-18 Thread tony.nguyen
This patch moves the define of target access alignment earlier from target/foo/cpu.h to configure. Suggested in Richard Henderson's reply to "[PATCH 1/4] tcg: TCGMemOp is now accelerator independent MemOp" Signed-off-by: Tony Nguyen --- configure | 12 ++--

Re: [Qemu-devel] [PATCH] configure: fix sdl detection using sdl2-config

2019-07-12 Thread Philippe Mathieu-Daudé
Cc'ing Gerd On 7/11/19 12:55 AM, Carlo Marcelo Arenas Belón wrote: > If SDL2 is requested but pkg-config doesn't have a module for it > configure should fallback to use sdl*-config, but wasn't able to > because and old variable (from SDL) was being used by mistake. > > Correct the variable name

Re: [Qemu-devel] [PATCH] configure: fix sdl detection using sdl2-config

2019-07-12 Thread Thomas Huth
On 11/07/2019 00.55, Carlo Marcelo Arenas Belón wrote: > If SDL2 is requested but pkg-config doesn't have a module for it > configure should fallback to use sdl*-config, but wasn't able to > because and old variable (from SDL) was being used by mistake. > > Correct the variable name and complete

[Qemu-devel] [PATCH] configure: fix sdl detection using sdl2-config

2019-07-10 Thread Carlo Marcelo Arenas Belón
If SDL2 is requested but pkg-config doesn't have a module for it configure should fallback to use sdl*-config, but wasn't able to because and old variable (from SDL) was being used by mistake. Correct the variable name and complete other related changes so there are no more references to the old

Re: [Qemu-devel] [PATCH] configure: remove obsoleted $sparc_cpu variable

2019-07-10 Thread Philippe Mathieu-Daudé
On 7/10/19 1:43 AM, Carlo Marcelo Arenas Belón wrote: > 9b9c37c364 ("tcg-sparc: Assume v9 cpu always, i.e. force v8plus in > 32-bit mode.", 2012-09-21) removed the need for this variable and > most of the references to it, but this one. > > Remove defunct code, no effect or functionality change

Re: [Qemu-devel] [PATCH] configure: remove obsoleted $sparc_cpu variable

2019-07-10 Thread Richard Henderson
On 7/10/19 1:43 AM, Carlo Marcelo Arenas Belón wrote: > 9b9c37c364 ("tcg-sparc: Assume v9 cpu always, i.e. force v8plus in > 32-bit mode.", 2012-09-21) removed the need for this variable and > most of the references to it, but this one. > > Remove defunct code, no effect or functionality change

[Qemu-devel] [PATCH] configure: remove obsoleted $sparc_cpu variable

2019-07-09 Thread Carlo Marcelo Arenas Belón
9b9c37c364 ("tcg-sparc: Assume v9 cpu always, i.e. force v8plus in 32-bit mode.", 2012-09-21) removed the need for this variable and most of the references to it, but this one. Remove defunct code, no effect or functionality change expected. Signed-off-by: Carlo Marcelo Arenas Belón ---

Re: [Qemu-devel] [PATCH] configure: linux-user doesn't need neither fdt nor slirp

2019-06-21 Thread Philippe Mathieu-Daudé
On 6/21/19 3:05 PM, Laurent Vivier wrote: > if softmmu is not enabled, we disable by default fdt and > slirp as they are only used by -softmmu targets. > > A side effect is the git submodules are not cloned > if they are not needed. > > Clone and build can be forced with --enable-fdt and >

Re: [Qemu-devel] [PATCH] configure: linux-user doesn't need neither fdt nor slirp

2019-06-21 Thread Marc-André Lureau
Hi On Fri, Jun 21, 2019 at 3:05 PM Laurent Vivier wrote: > > if softmmu is not enabled, we disable by default fdt and > slirp as they are only used by -softmmu targets. > > A side effect is the git submodules are not cloned > if they are not needed. > > Clone and build can be forced with

[Qemu-devel] [PATCH] configure: linux-user doesn't need neither fdt nor slirp

2019-06-21 Thread Laurent Vivier
if softmmu is not enabled, we disable by default fdt and slirp as they are only used by -softmmu targets. A side effect is the git submodules are not cloned if they are not needed. Clone and build can be forced with --enable-fdt and --enable-slirp. Signed-off-by: Laurent Vivier --- configure

[Qemu-devel] [PATCH] configure: use valid args testing sem_timedwait

2019-06-17 Thread Daniel P . Berrangé
The sem_timedwait function has been annotated as requiring non-null args in latest header files from GCC snapshot representing the future 2.30 release. This causes configure to fail when -Werror is used: config-temp/qemu-conf.c: In function ‘main’: config-temp/qemu-conf.c:2:25: error: null

Re: [Qemu-devel] [PATCH] configure: remove tpm_passthrough & tpm_emulator

2019-05-24 Thread Paolo Bonzini
On 24/05/19 20:14, Marc-André Lureau wrote: > This is a left-over from commit 7aaa6a16373 "tpm: express dependencies > with Kconfig". > > Signed-off-by: Marc-André Lureau > --- > configure | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/configure b/configure > index

[Qemu-devel] [PATCH] configure: remove tpm_passthrough & tpm_emulator

2019-05-24 Thread Marc-André Lureau
This is a left-over from commit 7aaa6a16373 "tpm: express dependencies with Kconfig". Signed-off-by: Marc-André Lureau --- configure | 10 -- 1 file changed, 10 deletions(-) diff --git a/configure b/configure index 528b9ff705..4da99ee750 100755 --- a/configure +++ b/configure @@

Re: [Qemu-devel] [PATCH] configure: Only enable iconv if curses is enabled

2019-05-24 Thread Gerd Hoffmann
On Fri, May 17, 2019 at 04:18:05PM -0500, Kumar Gala wrote: > iconv is only used with if curses is enabled, there's no need to do any > configure checking for iconv, if curses is disabled. Also, ignore > --enable-iconv if curses is already disabled. How about just doing this ... --- a/configure

Re: [Qemu-devel] [PATCH] configure: Fix spelling of sdl-image in --help

2019-05-18 Thread Thomas Huth
On 17/05/2019 20.32, Markus Armbruster wrote: > Fixes: a442fe2f2b2f20e7be0934277e9400b844b11999 > Cc: qemu-triv...@nongnu.org > Signed-off-by: Markus Armbruster > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index

[Qemu-devel] [PATCH] configure: Only enable iconv if curses is enabled

2019-05-17 Thread Kumar Gala
iconv is only used with if curses is enabled, there's no need to do any configure checking for iconv, if curses is disabled. Also, ignore --enable-iconv if curses is already disabled. Signed-off-by: Kumar Gala --- configure | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH] configure: Fix spelling of sdl-image in --help

2019-05-17 Thread Markus Armbruster
Fixes: a442fe2f2b2f20e7be0934277e9400b844b11999 Cc: qemu-triv...@nongnu.org Signed-off-by: Markus Armbruster --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index d2fc346302..cef51b2a0b 100755 --- a/configure +++ b/configure @@ -1745,7

Re: [Qemu-devel] [PATCH] configure: only link capstone to emulation targets

2019-05-16 Thread Richard Henderson
On 5/16/19 4:39 AM, Daniel P. Berrangé wrote: > Only the emulators link to code that uses capstone, so adding it to the > global LIBs places undesirable dependancies on other binaries, in > particular the tools. > > There is no variable that covers both user emulation and machine > emulation, so

[Qemu-devel] [PATCH] configure: only link capstone to emulation targets

2019-05-16 Thread Daniel P . Berrangé
Only the emulators link to code that uses capstone, so adding it to the global LIBs places undesirable dependancies on other binaries, in particular the tools. There is no variable that covers both user emulation and machine emulation, so add a new "$libs_cpu" for this purpose. In particular

Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-15 Thread Aleksandar Markovic
On May 15, 2019 12:07 PM, "Peter Maydell" wrote: > > On Tue, 14 May 2019 at 20:16, Aleksandar Markovic > wrote: > > > > On May 13, 2019 11:14 PM, "Richard Henderson" < richard.hender...@linaro.org> > > wrote: > > > > > > On 5/11/19 5:47 AM, Aleksandar Markovic wrote: > > > > If no, the patch

Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-15 Thread Peter Maydell
On Tue, 14 May 2019 at 20:16, Aleksandar Markovic wrote: > > On May 13, 2019 11:14 PM, "Richard Henderson" > wrote: > > > > On 5/11/19 5:47 AM, Aleksandar Markovic wrote: > > > If no, the patch shoud be amended. If yes, the commit message should be > > > extended. > > > > Like what? I think

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-05-14 Thread Programmingkid
> On May 12, 2019, at 9:47 AM, Thomas Huth wrote: > > On 11/05/2019 20.28, Programmingkid wrote: >> >>> On May 11, 2019, at 2:05 PM, Thomas Huth wrote: >>> >>> On 11/05/2019 19.21, Programmingkid wrote: > On Apr 20, 2019, at 6:40 AM, Thomas Huth wrote: > > On 19/04/2019

Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-14 Thread Aleksandar Markovic
On May 13, 2019 11:14 PM, "Richard Henderson" wrote: > > On 5/11/19 5:47 AM, Aleksandar Markovic wrote: > > > > On May 10, 2019 10:36 PM, "Richard Henderson" < richard.hender...@linaro.org > > > wrote: > >> > >> For linux-user, there is no need to add slirp to

Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-13 Thread Richard Henderson
On 5/11/19 5:47 AM, Aleksandar Markovic wrote: > > On May 10, 2019 10:36 PM, "Richard Henderson" > wrote: >> >> For linux-user, there is no need to add slirp to the set of >> git modules checked out, nor build it. >> >> This also avoids a makefile bug wrt

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2019 at 10:48:58AM +0100, Peter Maydell wrote: > On Mon, 13 May 2019 at 10:08, Daniel P. Berrangé wrote: > > > > On Sun, May 12, 2019 at 03:47:49PM +0200, Thomas Huth wrote: > > > Maybe try to clean the folder first: > > > > > > rm -r capstone > > > mkdir capstone > > > make

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-05-13 Thread Peter Maydell
On Mon, 13 May 2019 at 10:08, Daniel P. Berrangé wrote: > > On Sun, May 12, 2019 at 03:47:49PM +0200, Thomas Huth wrote: > > Maybe try to clean the folder first: > > > > rm -r capstone > > mkdir capstone > > make git-submodule-update > > > > If that does not help, maybe try a completely fresh

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-05-13 Thread Daniel P . Berrangé
On Sun, May 12, 2019 at 03:47:49PM +0200, Thomas Huth wrote: > Maybe try to clean the folder first: > > rm -r capstone > mkdir capstone > make git-submodule-update > > If that does not help, maybe try a completely fresh git checkout? Rather than deleting stuff like that, it is best to use

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-05-12 Thread Thomas Huth
On 11/05/2019 20.28, Programmingkid wrote: > >> On May 11, 2019, at 2:05 PM, Thomas Huth wrote: >> >> On 11/05/2019 19.21, Programmingkid wrote: >>> On Apr 20, 2019, at 6:40 AM, Thomas Huth wrote: On 19/04/2019 15.44, G 3 wrote: [...] > Thank you for replying. Capstone comes

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-05-11 Thread Programmingkid
> On May 11, 2019, at 2:05 PM, Thomas Huth wrote: > > On 11/05/2019 19.21, Programmingkid wrote: >> >>> On Apr 20, 2019, at 6:40 AM, Thomas Huth wrote: >>> >>> On 19/04/2019 15.44, G 3 wrote: On Apr 19, 2019, at 3:10 AM, Thomas Huth wrote: > On 19/04/2019 00.47, John

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-05-11 Thread Thomas Huth
On 11/05/2019 19.21, Programmingkid wrote: > >> On Apr 20, 2019, at 6:40 AM, Thomas Huth wrote: >> >> On 19/04/2019 15.44, G 3 wrote: >>> >>> On Apr 19, 2019, at 3:10 AM, Thomas Huth wrote: >>> On 19/04/2019 00.47, John Arbuckle wrote: > Capstone is not necessary in order to use QEMU.

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-05-11 Thread Programmingkid
> On Apr 20, 2019, at 6:40 AM, Thomas Huth wrote: > > On 19/04/2019 15.44, G 3 wrote: >> >> On Apr 19, 2019, at 3:10 AM, Thomas Huth wrote: >> >>> On 19/04/2019 00.47, John Arbuckle wrote: Capstone is not necessary in order to use QEMU. Disable it by default. This will save the

Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-11 Thread Aleksandar Markovic
On May 10, 2019 10:36 PM, "Richard Henderson" wrote: > > For linux-user, there is no need to add slirp to the set of > git modules checked out, nor build it. > > This also avoids a makefile bug wrt insufficient dependencies > on subdir-slirp. If slirp/ is not initially present, the >

Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-11 Thread Thomas Huth
On 10/05/2019 22.34, Richard Henderson wrote: > For linux-user, there is no need to add slirp to the set of > git modules checked out, nor build it. > > This also avoids a makefile bug wrt insufficient dependencies > on subdir-slirp. If slirp/ is not initially present, the > dependencies that

[Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-10 Thread Richard Henderson
For linux-user, there is no need to add slirp to the set of git modules checked out, nor build it. This also avoids a makefile bug wrt insufficient dependencies on subdir-slirp. If slirp/ is not initially present, the dependencies that check it out are associated with softmmu, which then

Re: [Qemu-devel] [PATCH] configure: copy MacOS NDRV driver into sharedir for out-of-tree builds

2019-05-10 Thread Peter Maydell
On Fri, 10 May 2019 at 18:18, Mark Cave-Ayland wrote: > > On 10/05/2019 17:49, Peter Maydell wrote: > > The comment above this bit of code says: > > > > # Caution: do not add files or directories here using wildcards. This > > # will result in problems later if a new file matching the wildcard is

Re: [Qemu-devel] [PATCH] configure: copy MacOS NDRV driver into sharedir for out-of-tree builds

2019-05-10 Thread Mark Cave-Ayland
On 10/05/2019 17:49, Peter Maydell wrote: > On Fri, 10 May 2019 at 17:37, Mark Cave-Ayland > wrote: >> >> Make sure that we include *.ndrv files with those being copied to sharedir >> during out-of-tree builds. This ensures that the MacOS driver is correctly >> located and loaded by

Re: [Qemu-devel] [PATCH] configure: copy MacOS NDRV driver into sharedir for out-of-tree builds

2019-05-10 Thread Peter Maydell
On Fri, 10 May 2019 at 17:37, Mark Cave-Ayland wrote: > > Make sure that we include *.ndrv files with those being copied to sharedir > during out-of-tree builds. This ensures that the MacOS driver is correctly > located and loaded by qemu-system-ppc. > > Signed-off-by: Mark Cave-Ayland > --- >

[Qemu-devel] [PATCH] configure: copy MacOS NDRV driver into sharedir for out-of-tree builds

2019-05-10 Thread Mark Cave-Ayland
Make sure that we include *.ndrv files with those being copied to sharedir during out-of-tree builds. This ensures that the MacOS driver is correctly located and loaded by qemu-system-ppc. Signed-off-by: Mark Cave-Ayland --- configure | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Qemu-devel] [PATCH] configure: Require python3 >= 3.5

2019-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2019 at 11:36:04AM +0200, Kevin Wolf wrote: > Am 09.05.2019 um 11:24 hat Kevin Wolf geschrieben: > > Am 09.05.2019 um 07:45 hat Markus Armbruster geschrieben: > > > Eduardo Habkost writes: > > > > diff --git a/.travis.yml b/.travis.yml > > > > index 66448d99d6..0f6986b3f1 100644 >

Re: [Qemu-devel] [PATCH] configure: Require python3 >= 3.5

2019-05-09 Thread Kevin Wolf
Am 09.05.2019 um 11:24 hat Kevin Wolf geschrieben: > Am 09.05.2019 um 07:45 hat Markus Armbruster geschrieben: > > Eduardo Habkost writes: > > > diff --git a/.travis.yml b/.travis.yml > > > index 66448d99d6..0f6986b3f1 100644 > > > --- a/.travis.yml > > > +++ b/.travis.yml > > > @@ -211,7 +211,7

Re: [Qemu-devel] [PATCH] configure: Require python3 >= 3.5

2019-05-09 Thread Kevin Wolf
Am 09.05.2019 um 07:45 hat Markus Armbruster geschrieben: > Eduardo Habkost writes: > > diff --git a/.travis.yml b/.travis.yml > > index 66448d99d6..0f6986b3f1 100644 > > --- a/.travis.yml > > +++ b/.travis.yml > > @@ -211,7 +211,7 @@ matrix: > > - CONFIG="--target-list=x86_64-softmmu" >

Re: [Qemu-devel] [PATCH] configure: Require python3 >= 3.5

2019-05-08 Thread Markus Armbruster
Eduardo Habkost writes: > The oldest python3 version in distros that will be supported by > QEMU 4.1 is 3.5.3 (the one in Debian Stretch). Error out if > running python3 < 3.5. > > We have a .travis.yml job configured to use Python 3.4. Change > it to use Python 3.5. > > Signed-off-by: Eduardo

Re: [Qemu-devel] [PATCH] configure: Require python3 >= 3.5

2019-05-08 Thread Thomas Huth
On 08/05/2019 20.23, Eduardo Habkost wrote: > The oldest python3 version in distros that will be supported by > QEMU 4.1 is 3.5.3 (the one in Debian Stretch). Error out if > running python3 < 3.5. > > We have a .travis.yml job configured to use Python 3.4. Change > it to use Python 3.5. > >

[Qemu-devel] [PATCH] configure: Require python3 >= 3.5

2019-05-08 Thread Eduardo Habkost
The oldest python3 version in distros that will be supported by QEMU 4.1 is 3.5.3 (the one in Debian Stretch). Error out if running python3 < 3.5. We have a .travis.yml job configured to use Python 3.4. Change it to use Python 3.5. Signed-off-by: Eduardo Habkost --- configure | 5 +++--

Re: [Qemu-devel] [PATCH] configure: Remove old *-config-devices.mak.d files when running configure

2019-04-30 Thread Thomas Huth
On 11/03/2019 17.21, Eric Blake wrote: > On 3/11/19 5:29 AM, Thomas Huth wrote: >> When running "make" in a build directory from the pre-Kconfig merge time, >> the build process currently fails with: >> >> make: *** No rule to make target `.../default-configs/pci.mak', >> needed by

Re: [Qemu-devel] [PATCH] configure: Remove --source-path option

2019-04-29 Thread Peter Maydell
On Thu, 25 Apr 2019 at 17:42, Antonio Ospite wrote: > Now that 4.0 has been released, maybe we can move on with this minor change. > > I will send a fix for https://bugs.launchpad.net/qemu/+bug/1817345 after > this patch lands. This patch has just gone in to master, so that should be ok for you

Re: [Qemu-devel] [PATCH] configure: Add -Wno-typedef-redefinition to CFLAGS (for Clang)

2019-04-27 Thread Richard Henderson
On 4/27/19 8:45 AM, Thomas Huth wrote: > Without the -Wno-typedef-redefinition option, clang complains if a typedef > gets redefined in gnu99 mode (since this is officially a C11 feature). This > used to also happen with older versions of GCC, but since we've bumped our > minimum GCC version to

[Qemu-devel] [PATCH] configure: Add -Wno-typedef-redefinition to CFLAGS (for Clang)

2019-04-27 Thread Thomas Huth
Without the -Wno-typedef-redefinition option, clang complains if a typedef gets redefined in gnu99 mode (since this is officially a C11 feature). This used to also happen with older versions of GCC, but since we've bumped our minimum GCC version to 4.8, all versions of GCC that we support do not

Re: [Qemu-devel] [PATCH] configure: Remove --source-path option

2019-04-25 Thread Antonio Ospite
On 19/03/19 09:41, Antonio Ospite wrote: On 18/03/19 14:40, Peter Maydell wrote: Normally configure identifies the source path by looking at the location where the configure script itself exists. We also provide a --source-path option which lets the user manually override this. There isn't

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-04-20 Thread Thomas Huth
On 19/04/2019 15.44, G 3 wrote: > > On Apr 19, 2019, at 3:10 AM, Thomas Huth wrote: > >> On 19/04/2019 00.47, John Arbuckle wrote: >>> Capstone is not necessary in order to use QEMU. Disable it by default. >>> This will save the user the pain of having to figure why QEMU isn't >>> building when

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-04-19 Thread Programmingkid
> On Apr 19, 2019, at 2:22 PM, Richard Henderson wrote: > > On 4/19/19 3:44 AM, G 3 wrote: >> >> Here is the error message I see when compiling QEMU: >> >> CHK version_gen.h >> make[1]: *** No rule to make target >> `/Users/John/qemu-git/capstone/libcapstone.a'. Stop. >> make: ***

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-04-19 Thread Richard Henderson
On 4/19/19 3:44 AM, G 3 wrote: > > Here is the error message I see when compiling QEMU: > > CHK version_gen.h > make[1]: *** No rule to make target > `/Users/John/qemu-git/capstone/libcapstone.a'.  Stop. > make: *** [subdir-capstone] Error 2 You are configuring with --static? I've seen this

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-04-19 Thread G 3
On Apr 19, 2019, at 3:10 AM, Thomas Huth wrote: On 19/04/2019 00.47, John Arbuckle wrote: Capstone is not necessary in order to use QEMU. Disable it by default. This will save the user the pain of having to figure why QEMU isn't building when this library is missing. Signed-off-by: John

Re: [Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-04-19 Thread Thomas Huth
On 19/04/2019 00.47, John Arbuckle wrote: > Capstone is not necessary in order to use QEMU. Disable it by default. > This will save the user the pain of having to figure why QEMU isn't > building when this library is missing. > > Signed-off-by: John Arbuckle > --- > configure | 2 +- > 1 file

[Qemu-devel] [PATCH] configure: Change capstone's default state to disabled

2019-04-18 Thread John Arbuckle
Capstone is not necessary in order to use QEMU. Disable it by default. This will save the user the pain of having to figure why QEMU isn't building when this library is missing. Signed-off-by: John Arbuckle --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-11 Thread Richard Henderson
On 4/9/19 8:17 PM, Stefan Weil wrote: > On 09.04.19 22:39, Richard Henderson wrote: >> On 4/9/19 9:46 AM, Stefan Weil wrote: >>> * Calling conventions. The current implementation works on many hosts, >>> but for example not on Sparc. A fix would require simple calling >>> conventions for all

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-10 Thread Stefan Weil
On 10.04.19 10:22, Thomas Huth wrote: > Additionally, I think it should be possible to compile with the > x86_64-linux-user target and then to run "make check-tcg" ... however, > that currently crashes with: > > TODO qemu/tcg/tci.c:859: tcg_qemu_tb_exec() > qemu/tcg/tci.c:859: tcg fatal error >

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-10 Thread Thomas Huth
On 10/04/2019 08.07, Thomas Huth wrote: > On 09/04/2019 21.46, Stefan Weil wrote: >> On 05.04.19 11:16, Philippe Mathieu-Daudé wrote: >>> On 4/5/19 11:02 AM, Daniel P. Berrangé wrote: On Fri, Apr 05, 2019 at 10:47:54AM +0200, Philippe Mathieu-Daudé wrote: Do the various crashes that you

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-10 Thread Thomas Huth
On 09/04/2019 21.46, Stefan Weil wrote: [...] > The known problems with the current implementation are [...] > * Calling conventions. The current implementation works on many hosts, > but for example not on Sparc Is there also a problem with the sparc *target* (i.e. not only sparc hosts)? TCI does

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-10 Thread Stefan Weil
On 10.04.19 08:07, Thomas Huth wrote: > That's great, good to know that you're still interested in TCI! ... but > I think one of the main problems is still that we completely lack test > coverage for TCI - the code always is in danger to bit-rot if it is not > tested by default. Ideally it would

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-10 Thread Stefan Weil
On 09.04.19 22:39, Richard Henderson wrote: > On 4/9/19 9:46 AM, Stefan Weil wrote: >> * Calling conventions. The current implementation works on many hosts, >> but for example not on Sparc. A fix would require simple calling >> conventions for all helper functions (for example stack based

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-10 Thread Thomas Huth
On 09/04/2019 21.46, Stefan Weil wrote: > On 05.04.19 11:16, Philippe Mathieu-Daudé wrote: >> On 4/5/19 11:02 AM, Daniel P. Berrangé wrote: >>> On Fri, Apr 05, 2019 at 10:47:54AM +0200, Philippe Mathieu-Daudé wrote: >>> Do the various crashes that you illustrate in that cover letter >>> still

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-09 Thread Richard Henderson
On 4/9/19 9:46 AM, Stefan Weil wrote: > * Calling conventions. The current implementation works on many hosts, > but for example not on Sparc. A fix would require simple calling > conventions for all helper functions (for example stack based argument > passing, can this be enforced?), or it needs

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-09 Thread Stefan Weil
On 05.04.19 11:16, Philippe Mathieu-Daudé wrote: > On 4/5/19 11:02 AM, Daniel P. Berrangé wrote: >> On Fri, Apr 05, 2019 at 10:47:54AM +0200, Philippe Mathieu-Daudé wrote: >> Do the various crashes that you illustrate in that cover letter >> still exist today ? If so, 2 years of continued

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-06 Thread Richard Henderson
On 4/5/19 2:56 PM, Helge Deller wrote: > Looking just at some of the debian "ports" (non-release) architectures: > alpha, hppa, ia64, m68k, powerpc, sh4, sparc64 FWIW: sparc64 does have a tcg backend. (Indeed, tcg/sparc does *not* support 32-bit cpus!) powerpc does have a tcg backend, and it

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-05 Thread Philippe Mathieu-Daudé
On 4/5/19 11:02 AM, Daniel P. Berrangé wrote: > On Fri, Apr 05, 2019 at 10:47:54AM +0200, Philippe Mathieu-Daudé wrote: >> Hi Helge, >> >> On 4/5/19 9:56 AM, Helge Deller wrote: >>> On 05.04.19 03:34, Peter Maydell wrote: On Fri, 5 Apr 2019 at 01:59, Helge Deller wrote: > If a

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-05 Thread Daniel P . Berrangé
On Fri, Apr 05, 2019 at 11:02:52AM +0200, Helge Deller wrote: > On 05.04.19 10:26, Daniel P. Berrangé wrote: > > On Fri, Apr 05, 2019 at 09:56:46AM +0200, Helge Deller wrote: > >> Hi Peter, > >> > >> On 05.04.19 03:34, Peter Maydell wrote: > >>> On Fri, 5 Apr 2019 at 01:59, Helge Deller wrote: >

Re: [Qemu-devel] [PATCH] configure: Automatically fall back to TCI on non-release architectures

2019-04-05 Thread Peter Maydell
On Fri, 5 Apr 2019 at 16:02, Helge Deller wrote: > Sadly such special treatment by projects makes life for me > as an architecture maintainer much harder :-( It's kind of inevitable for programs that aren't straightforwardly architecture agnostic. gcc doesn't work for architectures which don't

  1   2   3   4   5   6   7   8   9   10   >