[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7332 To unsubscribe,

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5582: Store sentry privileges in lower case .. IMPALA-5582: Store sentry privileges in lower case Privileges granted to a role assigned

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 10: last gvo failed due to IMPALA-5691 - unrelated. submitting again. -- To view, visit

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 10: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/905/ -- To view,

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 10: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/900/ -- To view,

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7332 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-20 Thread anujphadke (Code Review)
Hello Impala Public Jenkins, Michael Brown, Bharath Vissapragada, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7332 to look at the new patch set (#10). Change subject: IMPALA-5582: Store sentry privileges in lower case

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 8: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/887/ --

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7332 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/887/ -- To view,

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7332 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread anujphadke (Code Review)
Hello Bharath Vissapragada, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7332 to look at the new patch set (#8). Change subject: IMPALA-5582: Store sentry privileges in lower case

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 7: (2 comments) Thanks! 2 small things and otherwise I'm good to go. Let's make sure Michael

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread anujphadke (Code Review)
Hello Bharath Vissapragada, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7332 to look at the new patch set (#7). Change subject: IMPALA-5582: Store sentry privileges in lower case

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 6: > (4 comments) > > None of these comments are must-dos, just things I've noticed. Anuj,

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-18 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 6: (4 comments) None of these comments are must-dos, just things I've noticed.

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-18 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 6: Code-Review+1 (1 comment) Not sure if can +2 this given the change isn't trivial, so

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-18 Thread anujphadke (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7332 to look at the new patch set (#6). Change subject: IMPALA-5582: Store sentry privileges in lower case ..

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-17 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/7332/4//COMMIT_MSG Commit Message: PS4, Line

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-17 Thread anujphadke (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7332 to look at the new patch set (#5). Change subject: IMPALA-5582: Store sentry privileges in lower case ..

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 4: (3 comments) LGTM, have some small nits.

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 4: Code-Review+1 (2 comments) I think it looks pretty good, please address the few small

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-17 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 4: (10 comments) http://gerrit.cloudera.org:8080/#/c/7332/3//COMMIT_MSG Commit Message: PS3, Line

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-17 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#4). Change subject: IMPALA-5582: Store sentry privileges in lower case .. IMPALA-5582: Store sentry privileges in lower case Privileges granted to a db/table whose name contains upper

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-13 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7332/3/be/src/catalog/catalog.cc File

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-13 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 3: (9 comments) Few more in addition to MJ's comments.

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/7332/3/be/src/catalog/catalog.cc File

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-13 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 3: Discussed this issue with MJ. This issue does occur due to inconsistent handling of casing.

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-13 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#3). Change subject: IMPALA-5582: Store sentry privileges in lower case .. IMPALA-5582: Store sentry privileges in lower case Privileges granted to a db/table whose name contains upper

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 2: (1 comment) I think we need to figure out a way to test this. A test could be added to

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-12 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 2: (1 comment) The JIRA shows an example & log snippet where only one of the two grants on

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-06-29 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#2). Change subject: IMPALA-5582: Store sentry privileges in lower case .. IMPALA-5582: Store sentry privileges in lower case Privileges granted to a db whose name contains upper case

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-06-29 Thread anujphadke (Code Review)
anujphadke has uploaded a new change for review. http://gerrit.cloudera.org:8080/7332 Change subject: IMPALA-5582: Store sentry privileges in lower case .. IMPALA-5582: Store sentry privileges in lower case Privileges