[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-29 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4533 to look at the new patch set (#3). Change subject: [tools] Implement a manual leader_step_down for a tablet ..

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 3: (9 comments) TFTR Adar, pls see responses inline, also pls see why my jenkins are still

[kudu-CR] [tools] added insert-generated-rows into kudu tools

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools] added insert-generated-rows into kudu tools .. Patch Set 18: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4412 To unsubscribe, visit htt

[kudu-CR] thirdparty: reorganize tree

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: thirdparty: reorganize tree .. thirdparty: reorganize tree This patch changes the organization of the thirdparty tree. The new layout looks like this: - in

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4533/1/src/kudu/tools/kudu-admin-test.cc

[kudu-CR] thirdparty: use libc++ instead libstdc++ for TSAN builds

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: use libc++ instead libstdc++ for TSAN builds .. Patch Set 3: Verified+1 do it -- To view, visit http://gerrit.cloudera.org:8080/4511 To unsubscribe,

[kudu-CR] thirdparty: use libc++ instead libstdc++ for TSAN builds

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: use libc++ instead libstdc++ for TSAN builds .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4511 To unsubscribe, visi

[kudu-CR] thirdparty: use libc++ instead libstdc++ for TSAN builds

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: thirdparty: use libc++ instead libstdc++ for TSAN builds .. thirdparty: use libc++ instead libstdc++ for TSAN builds This all began because I wanted two th

[kudu-CR] thirdparty: fix up libtool scripts if needed

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: fix up libtool scripts if needed .. Patch Set 5: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4512 To unsubscribe, visit

[kudu-CR] thirdparty: fix up libtool scripts if needed

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: thirdparty: fix up libtool scripts if needed .. thirdparty: fix up libtool scripts if needed Older versions of libtool (such as the version found on el6) d

[kudu-CR] thirdparty: split into dependency groups

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: split into dependency groups .. Patch Set 4: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4513 To unsubscribe, visit htt

[kudu-CR] thirdparty: split into dependency groups

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: thirdparty: split into dependency groups .. thirdparty: split into dependency groups The monolithic thirdparty build is now quite a bit larger than it used

[kudu-CR] thirdparty: stifle unused argument warnings when building with clang

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: stifle unused argument warnings when building with clang .. Patch Set 4: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4

[kudu-CR] thirdparty: build C dependencies with TSAN instrumentation too

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: build C dependencies with TSAN instrumentation too .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4559 To unsubscribe, v

[kudu-CR] thirdparty: build C dependencies with TSAN instrumentation too

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: thirdparty: build C dependencies with TSAN instrumentation too .. thirdparty: build C dependencies with TSAN instrumentation too Our C library dependencie

[kudu-CR] c++ client: stop requiring the old gcc ABI

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: c++ client: stop requiring the old gcc ABI .. Patch Set 4: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4515 To unsubscribe, visit h

[kudu-CR] thirdparty: stifle unused argument warnings when building with clang

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: thirdparty: stifle unused argument warnings when building with clang .. thirdparty: stifle unused argument warnings when building with clang Dan tested m

[kudu-CR] c++ client: stop requiring the old gcc ABI

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: c++ client: stop requiring the old gcc ABI .. c++ client: stop requiring the old gcc ABI With the upgrade to clang 3.9 and the transition to libc++ for TS

[kudu-CR] [tools] added insert-generated-rows into kudu tools

2016-09-29 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4412 to look at the new patch set (#19). Change subject: [tools] added insert-generated-rows into kudu tools

[kudu-CR] [tools] added insert-generated-rows into kudu tools

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools] added insert-generated-rows into kudu tools .. Patch Set 20: (2 comments) http://gerrit.cloudera.org:8080/#/c/4412/20/src/kudu/tools/tool_action_test.cc Fi

[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp

2016-09-29 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4560 to look at the new patch set (#5). Change subject: [docs] Release note for OperationResponse.getWriteTimestamp .

[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp

2016-09-29 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [docs] Release note for OperationResponse.getWriteTimestamp .. Patch Set 5: Had to rebase due to your changes, Adar. -- To view, visit http://gerrit.cloud

[kudu-CR] [docs] Cleanup beta mentions, links

2016-09-29 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/4565 Change subject: [docs] Cleanup beta mentions, links .. [docs] Cleanup beta mentions, links Change-Id: I56fa65be9d027f5b40628aa5db5f

[kudu-CR] [docs] Cleanup beta mentions, links

2016-09-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [docs] Cleanup beta mentions, links .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4565 To unsubscribe, visit http://gerr

[kudu-CR] [util] Fix a minor bug in AssertEventually()

2016-09-29 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4566 to review the following change. Change subject: [util] Fix a minor bug in AssertEventually() ..

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4551 to look at the new patch set (#3). Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 2: (3 comments) Test added in slow mode. http://gerrit.cloudera.org:8080/#/c/4551/2/

[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [docs] Release note for OperationResponse.getWriteTimestamp .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4560 To unsubscribe, vi

[kudu-CR] [util] Fix a minor bug in AssertEventually()

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] Fix a minor bug in AssertEventually() .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4566/1/src/kudu/common/column_predicate.cc File src/k

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4551/3/src/kudu/integration-tests/

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4551 to look at the new patch set (#4). Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4551 to look at the new patch set (#5). Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4551/3/src/kudu/integration-tests

[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp

2016-09-29 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [docs] Release note for OperationResponse.getWriteTimestamp .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4560 To unsubscrib

[kudu-CR] [docs] Cleanup beta mentions, links

2016-09-29 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [docs] Cleanup beta mentions, links .. [docs] Cleanup beta mentions, links Change-Id: I56fa65be9d027f5b40628aa5db5f9e4a57c1fbc9 Reviewed-on: http:/

[kudu-CR] [docs] Release note for OperationResponse.getWriteTimestamp

2016-09-29 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [docs] Release note for OperationResponse.getWriteTimestamp .. [docs] Release note for OperationResponse.getWriteTimestamp See https://gerrit.cloud

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4551/5/src/kudu/integration-tests/

[kudu-CR] build-and-test.sh: update gcovr location

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new change for review. http://gerrit.cloudera.org:8080/4567 Change subject: build-and-test.sh: update gcovr location .. build-and-test.sh: update gcovr location Coverage builds were failing because o

[kudu-CR] build-and-test.sh: update gcovr location

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: build-and-test.sh: update gcovr location .. Patch Set 1: Verified+1 gerrit precommit tests don't cover this (perhaps ironically). -- To view, visit http://gerrit.

[kudu-CR] build-and-test.sh: update gcovr location

2016-09-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: build-and-test.sh: update gcovr location .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4567 To unsubscribe, visit http:/

[kudu-CR] [util] Fix a minor bug in AssertEventually()

2016-09-29 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4566 to look at the new patch set (#2). Change subject: [util] Fix a minor bug in AssertEventually() ...

[kudu-CR] [util] Fix a minor bug in AssertEventually()

2016-09-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [util] Fix a minor bug in AssertEventually() .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4566/1/src/kudu/common/column_predicate.cc File src/

[kudu-CR] build-and-test.sh: update gcovr location

2016-09-29 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4567 to look at the new patch set (#2). Change subject: build-and-test.sh: update gcovr location .. build-and-tes

[kudu-CR] [util] Fix a minor bug in AssertEventually()

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [util] Fix a minor bug in AssertEventually() .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4566/2/src/kudu/common/column_predicate.

[kudu-CR] build-and-test.sh: update gcovr location

2016-09-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: build-and-test.sh: update gcovr location .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4567 To unsubscribe, visit http:/

[kudu-CR] build-and-test.sh: update gcovr location

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: build-and-test.sh: update gcovr location .. build-and-test.sh: update gcovr location Coverage builds were failing because of this. Change-Id: I8874d298b61

[kudu-CR] build-and-test.sh: update gcovr location

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: build-and-test.sh: update gcovr location .. Patch Set 2: Verified+1 No coverage from gerrit here. -- To view, visit http://gerrit.cloudera.org:8080/4567 To unsubs

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 5: Code-Review+2 +2 from me, once Adar's nits get addressed. Thanks for adding

[kudu-CR] [WIP]KUDU-1640 - [python] Add IN-list predicate support

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [WIP]KUDU-1640 - [python] Add IN-list predicate support .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4548/3/python/kudu/client.pyx File python/

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4551 to look at the new patch set (#6). Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4551/5/src/kudu/integration-tests

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4551/5/src/kudu/integ

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/4551/2/src/kudu/fs/log_block_mana

[kudu-CR] [WIP]KUDU-1640 - [python] Add IN-list predicate support

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [WIP]KUDU-1640 - [python] Add IN-list predicate support .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4548/3/python/kudu/client.pyx File python/

[kudu-CR] [util] Fix a minor bug in AssertEventually()

2016-09-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [util] Fix a minor bug in AssertEventually() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4566/2/src/kudu/common/column_predicate.cc File src/k

[kudu-CR] Add a design doc for rpc retry/failover semantics

2016-09-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2642 to look at the new patch set (#6). Change subject: Add a design doc for rpc retry/failover semantics .. Add a desig

[kudu-CR] Add a design doc for rpc retry/failover semantics

2016-09-29 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2642 to look at the new patch set (#7). Change subject: Add a design doc for rpc retry/failover semantics .. Add a desig

[kudu-CR] KuduPredicate::Clone on IN list predicate causes segfault

2016-09-29 Thread Dan Burkert (Code Review)
Hello Jordan Birdsell, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4568 to review the following change. Change subject: KuduPredicate::Clone on IN list predicate causes segfault .

[kudu-CR] [tools] added insert-generated-rows into kudu tools

2016-09-29 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4412 to look at the new patch set (#21). Change subject: [tools] added insert-generated-rows into kudu tools

[kudu-CR] [tools] added insert-generated-rows into kudu tools

2016-09-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [tools] added insert-generated-rows into kudu tools .. Patch Set 20: (2 comments) http://gerrit.cloudera.org:8080/#/c/4412/20/src/kudu/tools/tool_action_test.cc

[kudu-CR] KuduPredicate::Clone on IN list predicate causes segfault

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KuduPredicate::Clone on IN list predicate causes segfault .. Patch Set 1: Code-Review+2 Would be great to just remove the Clone() API, or deprecate it or something.

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4551/2/src/kudu/fs/log_block_mana

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4551 to look at the new patch set (#7). Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash

[kudu-CR] [tools] added insert-generated-rows into kudu tools

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools] added insert-generated-rows into kudu tools .. Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/4412/21/src/kudu/tools/tool_action_test.cc Fil

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4551 To unsubscribe

[kudu-CR] KuduPredicate::Clone on IN list predicate causes segfault

2016-09-29 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has posted comments on this change. Change subject: KuduPredicate::Clone on IN list predicate causes segfault .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4568 To unsubscribe,

[kudu-CR] [c++ client] added few deprecation notes

2016-09-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4569 Change subject: [c++ client] added few deprecation notes .. [c++ client] added few deprecation notes KUDU-1661 Mark kudu::client::KuduCl

[kudu-CR] [tools] added insert-generated-rows into kudu tools

2016-09-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [tools] added insert-generated-rows into kudu tools .. Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/4412/21/src/kudu/tools/tool_action_test.cc

[kudu-CR] [tools] added insert-generated-rows into kudu tools

2016-09-29 Thread Alexey Serbin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4412 to look at the new patch set (#22). Change subject: [tools] added insert-generated-rows into kudu tools

[kudu-CR] [c++ client] added few deprecation notes

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [c++ client] added few deprecation notes .. Patch Set 1: (1 comment) Shouldn't we wait until the new API lands before deprecating the old one though? http://gerri

[kudu-CR] [tools] added insert-generated-rows into kudu tools

2016-09-29 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [tools] added insert-generated-rows into kudu tools .. Patch Set 22: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4412 To unsubscribe, visit htt

[kudu-CR] [tools] added insert-generated-rows into kudu tools

2016-09-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [tools] added insert-generated-rows into kudu tools .. [tools] added insert-generated-rows into kudu tools The insert-generated-rows tool has been merge

[kudu-CR] [c++ client] added few deprecation notes

2016-09-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [c++ client] added few deprecation notes .. Patch Set 1: (1 comment) > (1 comment) > > Shouldn't we wait until the new API lands before deprecating the > ol

[kudu-CR] [c++ client] added few deprecation notes

2016-09-29 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4569 to look at the new patch set (#2). Change subject: [c++ client] added few deprecation notes .. [c++ client] added f

[kudu-CR] [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader

2016-09-29 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/4570 Change subject: [java client] Tight-ish loop in master lookups if a tablet doesn't have a leader .. [java client] Tight-ish loop in

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4533/1/src/kudu/tools/kudu-admin-test.cc

[kudu-CR] KuduPredicate::Clone on IN list predicate causes segfault

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KuduPredicate::Clone on IN list predicate causes segfault .. KuduPredicate::Clone on IN list predicate causes segfault Jordan Birdsell uncovered this issu

[kudu-CR] [tools] select only tablet leader for RWYW

2016-09-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4571 Change subject: [tools] select only tablet leader for RWYW .. [tools] select only tablet leader for RWYW To enable stable read-what-you-

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-29 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4533 to look at the new patch set (#4). Change subject: [tools] Implement a manual leader_step_down for a tablet ..

[kudu-CR] [tools] select only tablet leader for RWYW

2016-09-29 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [tools] select only tablet leader for RWYW .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4571 To unsubscribe, visit http

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [tools] Implement a manual leader_step_down for a tablet .. Patch Set 4: Please rebase this patch before pushing another revision. -- To view, visit http://gerri

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 7: Verified+1 Jenkins is completely hosed and I'm tired of waiting. -- To view, visi

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. KUDU-1657: read-only FsManager::Open on active tablet can crash This fixes a race condi

[kudu-CR] KUDU-1657: read-only FsManager::Open on active tablet can crash

2016-09-29 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1657: read-only FsManager::Open on active tablet can crash .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4551/2/src/kudu/fs/log_block_manag

[kudu-CR] [tools] Implement a manual leader step down for a tablet

2016-09-29 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4533 to look at the new patch set (#5). Change subject: [tools] Implement a manual leader_step_down for a tablet ..

[kudu-CR] [tools] select only tablet leader for RWYW

2016-09-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [tools] select only tablet leader for RWYW .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4571 To unsubscribe, visit http://gerrit

[kudu-CR] [tools] select only tablet leader for RWYW

2016-09-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [tools] select only tablet leader for RWYW .. Patch Set 1: > Patch Set 1: Verified+1 Removed -1 by Jenkins because of unrelated failure of DeleteTableTest.Test

[kudu-CR] [tools] select only tablet leader for RWYW

2016-09-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [tools] select only tablet leader for RWYW .. [tools] select only tablet leader for RWYW To enable stable read-what-you-write behavior in case of multip