Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4738
to look at the new patch set (#7).
Change subject: WIP: [iwyu] first pass
..
WIP: [iwyu] first pass
Updated C++ so
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5237
to look at the new patch set (#2).
Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw
exception when a column is not set
.
YanlongZheng has posted comments on this change.
Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw
exception when a column is not set
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5237
Mike Percy has posted comments on this change.
Change subject: cmake: Throw cmake error if unit test does not exist
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5222/1/CMakeLists.txt
File CMakeLists.txt:
L
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5222
to look at the new patch set (#2).
Change subject: cmake: Throw cmake error if unit test does not exist
..
cmake: T
Mike Percy has posted comments on this change.
Change subject: cmake: Throw cmake error if unit test does not exist
..
Patch Set 2:
This is what the error output looked like when I defined a non-existent test
called consistenc
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5240
to look at the new patch set (#3).
Change subject: WIP: Support safe time advancement on replicas in the absense
of writes
Dinesh Bhat has posted comments on this change.
Change subject: [consensus] KUDU-1718: Fix few bugs around replica eviction
failures
..
Patch Set 2:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/5111/2/src/kudu/consensus/c
Hello David Ribeiro Alves, Mike Percy, Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5111
to look at the new patch set (#3).
Change subject: [consensus] KUDU-1718: Fix few bugs around replica eviction
failures
..
Hello David Ribeiro Alves, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5256
to review the following change.
Change subject: WIP: KUDU-1767. Create a client flush interleave test
..
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5256
to look at the new patch set (#2).
Change subject: WIP: KUDU-1767. Create a client flush interleave test
..
WIP: KU
Hello Dinesh Bhat,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5257
to review the following change.
Change subject: tablet copy: Fix tidy warnings in TabletCopySourceSession{Test}
..
tab
Mike Percy has abandoned this change.
Change subject: scoped_cleanup: Use std::function instead of template
..
Abandoned
OK, abandoning
--
To view, visit http://gerrit.cloudera.org:8080/5043
To unsubscribe, visit http://gerri
Mike Percy has abandoned this change.
Change subject: TSTabletManager: Replace TransitionInProgressDeleter with
ScopedCleanup
..
Abandoned
Abandoning due to abandoning the preceding patch, which is required for this
one.
--
Mike Percy has posted comments on this change.
Change subject: [tools] Tombstone the tablet with "local_replica delete"
..
Patch Set 2:
(11 comments)
overall looks good, mostly minor comments
http://gerrit.cloudera.org:8080/#
Mike Percy has posted comments on this change.
Change subject: [consensus] KUDU-1718: Fix few bugs around replica eviction
failures
..
Patch Set 3:
I would also prefer to see these split into several individual patches
--
To
Mike Percy has posted comments on this change.
Change subject: [consensus] KUDU-1718: Fix few bugs around replica eviction
failures
..
Patch Set 3:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/5111/3/src/kudu/consensus/co
Mike Percy has posted comments on this change.
Change subject: Don't output unobservable rows from the MemRowset
..
Patch Set 13:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4994/13/src/kudu/tablet/compaction-test.cc
File
Mike Percy has posted comments on this change.
Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files
..
Patch Set 19:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/4995/19/src/kudu/tablet/compaction-t
Mike Percy has posted comments on this change.
Change subject: Add Reinserts to tablet_history_gc-itest
..
Patch Set 13: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4997
To unsubscribe, visit http://gerrit.
Todd Lipcon has posted comments on this change.
Change subject: tablet copy: Fix tidy warnings in TabletCopySourceSession{Test}
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5257
To unsubscrib
Todd Lipcon has posted comments on this change.
Change subject: tablet copy: Rename tablet copy session source files
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5042
To unsubscribe, visit ht
Mike Percy has submitted this change and it was merged.
Change subject: tablet copy: Rename tablet copy session source files
..
tablet copy: Rename tablet copy session source files
This is just a quick cleanup to the class rena
Mike Percy has submitted this change and it was merged.
Change subject: tablet copy: Fix tidy warnings in TabletCopySourceSession{Test}
..
tablet copy: Fix tidy warnings in TabletCopySourceSession{Test}
Done as a follow-up comm
Alexey Serbin has posted comments on this change.
Change subject: WIP: KUDU-1767. Create a client flush interleave test
..
Patch Set 2:
(7 comments)
It looks like a nice test to isolate this problem!
http://gerrit.cloudera.or
Mike Percy has posted comments on this change.
Change subject: WIP: KUDU-1767. Create a client flush interleave test
..
Patch Set 2:
Thanks for the review, Alexey. Yes, this test is currently pretty messy. I do
need to clean i
Mike Percy has posted comments on this change.
Change subject: Don't output unobservable rows from the MemRowset
..
Patch Set 13:
>
> DRS 1:
> undo: del @ 2
> base: v1
> redo delta: del @3
>
> DRS 2:
> base: v2
>
>
David Ribeiro Alves has posted comments on this change.
Change subject: [i-tests] scan token timestamp propagation test
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5219/1/src/kudu/integration-tests/consist
Hello Adar Dembo, Dimitris Tsirogiannis, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5262
to review the following change.
Change subject: Update debug partition and row printing
Dan Burkert has posted comments on this change.
Change subject: Update debug partition and row printing
..
Patch Set 1:
screenshots of updated web UIs: http://imgur.com/a/VNlMA
--
To view, visit http://gerrit.cloudera.org:808
Todd Lipcon has posted comments on this change.
Change subject: bshuf_block: some code cleanup
..
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/5193/3/src/kudu/cfile/bshuf_block.cc
File src/kudu/cfile/bshuf_blo
Alexey Serbin has posted comments on this change.
Change subject: [i-tests] scan token timestamp propagation test
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5219/1/src/kudu/integration-tests/consistency-i
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5193
to look at the new patch set (#6).
Change subject: bshuf_block: some code cleanup
..
bshuf_block: some code cleanup
Adar Dembo has submitted this change and it was merged.
Change subject: cmake: Throw cmake error if unit test does not exist
..
cmake: Throw cmake error if unit test does not exist
Previously, if the unit test file did not exis
Adar Dembo has posted comments on this change.
Change subject: cmake: Throw cmake error if unit test does not exist
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5222
To unsubscribe, visit htt
Todd Lipcon has posted comments on this change.
Change subject: KUDU-798 (part 1) Unify leader/follower mvcc behavior
..
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5055
To unsubscribe, visit
Todd Lipcon has posted comments on this change.
Change subject: KUDU-798 (part 2) Remove automatic safe time adjustment from
mvcc
..
Patch Set 13: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5057
To unsubs
Todd Lipcon has submitted this change and it was merged.
Change subject: Change 100M-int cfile tests to use BIT_SHUFFLE instead of
GROUP_VARINT
..
Change 100M-int cfile tests to use BIT_SHUFFLE instead of GROUP_VARINT
We no lo
Todd Lipcon has submitted this change and it was merged.
Change subject: cfile_set-test: switch to using INT32 instead of UINT32
..
cfile_set-test: switch to using INT32 instead of UINT32
We don't actually support users using U
David Ribeiro Alves has submitted this change and it was merged.
Change subject: KUDU-798 (part 2) Remove automatic safe time adjustment from
mvcc
..
KUDU-798 (part 2) Remove automatic safe time adjustment from mvcc
This patch
David Ribeiro Alves has submitted this change and it was merged.
Change subject: KUDU-798 (part 1) Unify leader/follower mvcc behavior
..
KUDU-798 (part 1) Unify leader/follower mvcc behavior
This patch does the following:
1) I
Todd Lipcon has posted comments on this change.
Change subject: encodings: change IsBlockFull() to not take a limit parameter
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/5200/2/src/kudu/cfile/binary_plain_
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5200
to look at the new patch set (#3).
Change subject: encodings: change IsBlockFull() to not take a limit parameter
..
Todd Lipcon has posted comments on this change.
Change subject: Update debug partition and row printing
..
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5262/1/src/kudu/common/partition.cc
File src/kudu/common/
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files
..
Patch Set 19:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/4995/19/src/kudu/tablet/com
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4995
to look at the new patch set (#20).
Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files
..
Adar Dembo has posted comments on this change.
Change subject: encodings: change IsBlockFull() to not take a limit parameter
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5200
To unsubscribe,
Alexey Serbin has posted comments on this change.
Change subject: bshuf_block: some code cleanup
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5193
To unsubscribe, visit http://gerrit.cloudera
Todd Lipcon has posted comments on this change.
Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files
..
Patch Set 20:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/4995/20/src/kudu/tablet/compaction-t
Adar Dembo has posted comments on this change.
Change subject: bshuf_block: some code cleanup
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5193/6/src/kudu/cfile/bshuf_block.cc
File src/kudu/cfile/bshuf_block
Alexey Serbin has posted comments on this change.
Change subject: bshuf_block: some code cleanup
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5193/6/src/kudu/cfile/bshuf_block.cc
File src/kudu/cfile/bshuf_bl
Todd Lipcon has posted comments on this change.
Change subject: bshuf_block: some code cleanup
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5193/6/src/kudu/cfile/bshuf_block.cc
File src/kudu/cfile/bshuf_bloc
Adar Dembo has posted comments on this change.
Change subject: KUDU-1634 (part 3). Changed tmp files' infix from ".tmp" to
".kudutmp"
..
Patch Set 3:
Hey Maxim, looks like this patch has some conflicts and needs to be rebased.
Adar Dembo has posted comments on this change.
Change subject: bshuf_block: some code cleanup
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5193
To unsubscribe, visit http://gerrit.cloudera.or
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5193
to look at the new patch set (#7).
Change subject: bshuf_block: some code cleanup
..
bshuf_block: so
David Ribeiro Alves has posted comments on this change.
Change subject: Add snapshot scans to fuzz-itest
..
Patch Set 12:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4996/12/src/kudu/tablet/key_value_test_schema.h
File src
Todd Lipcon has posted comments on this change.
Change subject: bshuf_block: some code cleanup
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5193/6/src/kudu/cfile/bshuf_block.cc
File src/kudu/cfile/bshuf_bloc
David Ribeiro Alves has posted comments on this change.
Change subject: Add snapshot scans to fuzz-itest
..
Patch Set 12:
(15 comments)
http://gerrit.cloudera.org:8080/#/c/4996/12/src/kudu/integration-tests/fuzz-itest.cc
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4996
to look at the new patch set (#14).
Change subject: Add snapshot scans to fuzz-itest
..
Add snapshot scans to fuzz-
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4995
to look at the new patch set (#21).
Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files
..
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files
..
Patch Set 20:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/4995/20/src/kudu/tablet/comp
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4994
to look at the new patch set (#14).
Change subject: Don't output unobservable rows from the MemRowset
..
Don't outp
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4995
to look at the new patch set (#22).
Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files
..
David Ribeiro Alves has posted comments on this change.
Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files
..
Patch Set 12:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4995/12/src/kudu/tablet/compa
Todd Lipcon has submitted this change and it was merged.
Change subject: bshuf_block: some code cleanup
..
bshuf_block: some code cleanup
* Some typo/grammar fixes/reformatting in comments.
* Rename kMaxHeaderSize to kHeaderSiz
Todd Lipcon has submitted this change and it was merged.
Change subject: encodings: change IsBlockFull() to not take a limit parameter
..
encodings: change IsBlockFull() to not take a limit parameter
Everywhere we called this,
Todd Lipcon has posted comments on this change.
Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files
..
Patch Set 22: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4995
To unsubscribe,
David Ribeiro Alves has posted comments on this change.
Change subject: [i-tests] scan token timestamp propagation test
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5219/1/src/kudu/integration-tests/consiste
Hello Adar Dembo, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5266
to review the following change.
Change subject: KUDU-1766: Java client partition pruning with MAX_VALUE
equality predicate fails
.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1766: Java client partition pruning with MAX_VALUE
equality predicate fails
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/
Adar Dembo has posted comments on this change.
Change subject: KUDU-1766: Java client partition pruning with MAX_VALUE
equality predicate fails
..
Patch Set 1:
(1 comment)
Just passing through...
http://gerrit.cloudera.org:8
Alexey Serbin has posted comments on this change.
Change subject: bshuf_block: some code cleanup
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5193/6/src/kudu/cfile/bshuf_block.cc
File src/kudu/cfile/bshuf_bl
Dan Burkert has posted comments on this change.
Change subject: KUDU-1766: Java client partition pruning with MAX_VALUE
equality predicate fails
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5266/1/java/kudu
Hello Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5266
to look at the new patch set (#2).
Change subject: KUDU-1766: Java client partition pruning with MAX_VALUE
equality predicate fails
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5240
to look at the new patch set (#4).
Change subject: WIP: Support safe time advancement on replicas in the absense
of writes
David Ribeiro Alves has posted comments on this change.
Change subject: WIP: Support safe time advancement on replicas in the absense
of writes
..
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/5240/3/src/kudu/
Dan Burkert has posted comments on this change.
Change subject: bshuf_block: fix GetFirstKey() and GetLastKey()
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5192
To unsubscribe, visit http://
Todd Lipcon has submitted this change and it was merged.
Change subject: bshuf_block: fix GetFirstKey() and GetLastKey()
..
bshuf_block: fix GetFirstKey() and GetLastKey()
This fixes a bug where the bitshuffle encoding would re
Dan Burkert has posted comments on this change.
Change subject: cfile-test: use a faster data generator for 100M-string test
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5201
To unsubscribe,
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5268
Change subject: [i-tests] test for timestamp propagation with write ops
..
[i-tests] test for timestamp propagation with write ops
Added
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5269
Change subject: [c++ client] propagate timestamp for write operations
..
[c++ client] propagate timestamp for write operations
Updated t
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5195
to look at the new patch set (#5).
Change subject: bshuf_block: some low-hanging-fruit optimizations on write path
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [c++ client] propagate timestamp for write operations
..
[c++ client] propagate timestamp for write operations
Updated the Kudu C++ client library to propagate tim
Adar Dembo has posted comments on this change.
Change subject: bshuf_block: some low-hanging-fruit optimizations on write path
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5195/5/src/kudu/cfile/bshuf_block.h
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4994
to look at the new patch set (#15).
Change subject: Don't output unobservable rows from the MemRowset
..
Don't outp
Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4995
to look at the new patch set (#23).
Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files
...
Dan Burkert has posted comments on this change.
Change subject: bshuf_block: some low-hanging-fruit optimizations on write path
..
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5195/5//COMMIT_MSG
Commit Message
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5240
to look at the new patch set (#5).
Change subject: WIP: Support safe time advancement on replicas in the absense
of writes
Dan Burkert has posted comments on this change.
Change subject: binary_plain_block: avoid a virtual call in hot path
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5202
To unsubscribe, visit ht
Alexey Serbin has posted comments on this change.
Change subject: bshuf_block: some low-hanging-fruit optimizations on write path
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5195/5/src/kudu/cfile/bshuf_bloc
Todd Lipcon has posted comments on this change.
Change subject: binary_plain_block: avoid a virtual call in hot path
..
Patch Set 3: Code-Review-1
Dan and I actaully just chatted, and it sounds like a better solution with
equi
Dan Burkert has posted comments on this change.
Change subject: cfile-test: use a faster data generator for 100M-string test
..
Patch Set 3:
This is going to make the prefix encoder less effective on the dataset, is that
impor
Todd Lipcon has posted comments on this change.
Change subject: cfile-test: use a faster data generator for 100M-string test
..
Patch Set 3:
I don't think it'll be that much less effective, since now it'll at least have
the pr
Dan Burkert has posted comments on this change.
Change subject: cfile-test: use a faster data generator for 100M-string test
..
Patch Set 3:
Right, forgot about the padding.
--
To view, visit http://gerrit.cloudera.org:8080/5
Dan Burkert has posted comments on this change.
Change subject: cfile-test: use a faster data generator for 100M-string test
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5201
To unsubscribe,
Todd Lipcon has submitted this change and it was merged.
Change subject: cfile-test: use a faster data generator for 100M-string test
..
cfile-test: use a faster data generator for 100M-string test
The current data generator us
Todd Lipcon has posted comments on this change.
Change subject: bshuf_block: some low-hanging-fruit optimizations on write path
..
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5195/5//COMMIT_MSG
Commit Message
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5195
to look at the new patch set (#6).
Change subject: bshuf_block: some low-hanging-fruit optimizations on write path
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5202
to look at the new patch set (#4).
Change subject: cfile: make encoder/decoder classes final
..
cfile:
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5271
to review the following change.
Change subject: Remove GROUP_VARINT encoding
..
Remove GROUP_VARINT encoding
This enc
1 - 100 of 142 matches
Mail list logo