[kudu-CR](branch-1.2.x) KUDU-1812: don't log user data in the Java client

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1812: don't log user data in the Java client .. KUDU-1812: don't log user data in the Java client I manually inspected a few logs to make sure

[kudu-CR](branch-1.2.x) KUDU-1812. Fix printed default of redaction flag for tools

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1812. Fix printed default of redaction flag for tools .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5575 To unsubscribe,

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1812: don't log user data in the Java client .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5549 To unsubscribe, visit

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1812: don't log user data in the Java client .. KUDU-1812: don't log user data in the Java client I manually inspected a few logs to make sure

[kudu-CR](branch-1.2.x) KUDU-1812. Fix printed default of redaction flag for tools

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1812. Fix printed default of redaction flag for tools .. KUDU-1812. Fix printed default of redaction flag for tools A previous commit made the

[kudu-CR](branch-1.2.x) KUDU-1812. Redact calls to Slice::ToDebugString

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1812. Redact calls to Slice::ToDebugString .. KUDU-1812. Redact calls to Slice::ToDebugString The Slice::ToDebugString method is used pervasively to

[kudu-CR](branch-1.2.x) KUDU-1812. Redact calls to Slice::ToDebugString

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1812. Redact calls to Slice::ToDebugString .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5576 To unsubscribe, visit

[kudu-CR] Kudu Jepsen Tests - Initial Commit

2016-12-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Kudu Jepsen Tests - Initial Commit .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5492/4/java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj

[kudu-CR] [jepsen.kudu] some updates

2016-12-22 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5500 to look at the new patch set (#5). Change subject: [jepsen.kudu] some updates .. [jepsen.kudu] some updates

[kudu-CR] WIP: Kudu Jepsen Tests - Initial Commit

2016-12-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. Change subject: WIP: Kudu Jepsen Tests - Initial Commit .. Abandoned See https://gerrit.cloudera.org/#/c/5492/ instead. -- To view, visit http://gerrit.cloudera.org:8080/5550 To

[kudu-CR] Kudu Jepsen Tests - Initial Commit

2016-12-22 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5492 to look at the new patch set (#6). Change subject: Kudu Jepsen Tests - Initial Commit .. Kudu Jepsen Tests -

[kudu-CR] WIP: Kudu Jepsen Tests - Initial Commit

2016-12-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: Kudu Jepsen Tests - Initial Commit .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/5492/4/java/kudu-jepsen/project.clj File

[kudu-CR](branch-1.2.x) KUDU-1812: don't log user data in the Java client

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/5577 Change subject: KUDU-1812: don't log user data in the Java client .. KUDU-1812: don't log user data in the Java client I manually

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1812: don't log user data in the Java client .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5549 To unsubscribe, visit

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1812: don't log user data in the Java client .. Patch Set 2: (1 comment) I audited all Logger.getLogger() calls, and then all the calls to those LOG

[kudu-CR](branch-1.2.x) KUDU-1812. Redact calls to Slice::ToDebugString

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/5576 Change subject: KUDU-1812. Redact calls to Slice::ToDebugString .. KUDU-1812. Redact calls to Slice::ToDebugString The

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-22 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5549 to look at the new patch set (#3). Change subject: KUDU-1812: don't log user data in the Java client .. KUDU-1812:

[kudu-CR](branch-1.2.x) KUDU-1812. Fix printed default of redaction flag for tools

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/5575 Change subject: KUDU-1812. Fix printed default of redaction flag for tools .. KUDU-1812. Fix printed default of redaction flag for tools

[kudu-CR](branch-1.2.x) KUDU-1812: redact HexDump output

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1812: redact HexDump output .. KUDU-1812: redact HexDump output After auditing calls to HexDump across the (non-test) Kudu codebase, it was found

[kudu-CR](branch-1.2.x) KUDU-1812. Replace PB DebugString calls with redactable variants

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1812. Replace PB DebugString calls with redactable variants .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5573 To

[kudu-CR](branch-1.2.x) KUDU-1812: redact HexDump output

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1812: redact HexDump output .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5571 To unsubscribe, visit

[kudu-CR] KUDU-1812. Fix printed default of redaction flag for tools

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1812. Fix printed default of redaction flag for tools .. KUDU-1812. Fix printed default of redaction flag for tools A previous commit made the

[kudu-CR] WIP: Kudu Jepsen Tests - Initial Commit

2016-12-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: Kudu Jepsen Tests - Initial Commit .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/5492/1/java/kudu-jepsen/.gitignore File

[kudu-CR] KUDU-1812. Redact calls to Slice::ToDebugString

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1812. Redact calls to Slice::ToDebugString .. KUDU-1812. Redact calls to Slice::ToDebugString The Slice::ToDebugString method is used pervasively to

[kudu-CR] KUDU-1812. Replace PB DebugString calls with redactable variants

2016-12-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1812. Replace PB DebugString calls with redactable variants .. Patch Set 3: Code-Review+2 I also applied the patch and used git grep a bit, like on

[kudu-CR] KUDU-1812. Redaction support for protobufs

2016-12-22 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1812. Redaction support for protobufs .. KUDU-1812. Redaction support for protobufs This adds a new local protobuf option 'kudu.REDACT' which can be

[kudu-CR] KUDU-1812. Redaction support for protobufs

2016-12-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1812. Redaction support for protobufs .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5553 To unsubscribe, visit

[kudu-CR] KUDU-1812: redact HexDump output

2016-12-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1812: redact HexDump output .. Patch Set 1: (1 comment) lgtm, just a nit http://gerrit.cloudera.org:8080/#/c/5567/1/src/kudu/util/hexdump.h File

[kudu-CR] KUDU-1812. address comments on 1179bbdb

2016-12-22 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5566 to look at the new patch set (#3). Change subject: KUDU-1812. address comments on 1179bbdb .. KUDU-1812. address

[kudu-CR] KUDU-1812. Redact a few more protobuf fields

2016-12-22 Thread Adar Dembo (Code Review)
Adar Dembo has abandoned this change. Change subject: KUDU-1812. Redact a few more protobuf fields .. Abandoned Rolled into http://gerrit.cloudera.org:8080/5553. -- To view, visit http://gerrit.cloudera.org:8080/5564 To

[kudu-CR] KUDU-1812. pb util: add a 'using' to import secure PB strings

2016-12-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1812. pb_util: add a 'using' to import secure PB strings .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5561 To unsubscribe,

[kudu-CR] KUDU-1812. Redaction support for protobufs

2016-12-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1812. Redaction support for protobufs .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5553/4/src/kudu/util/pb_util_test.proto

[kudu-CR] KUDU-1812. address comments on 1179bbdb

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1812. address comments on 1179bbdb .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5566/2/src/kudu/tools/tool_main.cc File

[kudu-CR] KUDU-1812. Clang tool for replacing DebugString calls

2016-12-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1812. Clang tool for replacing DebugString calls .. Patch Set 1: (2 comments) I don't have a strong opinion on whether to merge this now or later. If we're

[kudu-CR] Update kudu-lint to LLVM 3.9

2016-12-22 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Update kudu-lint to LLVM 3.9 .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4475/2/build-support/tools/kudu-lint/CMakeLists.txt File

[kudu-CR] KUDU-1812. Redact calls to Slice::ToDebugString

2016-12-22 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5568 to review the following change. Change subject: KUDU-1812. Redact calls to Slice::ToDebugString

[kudu-CR] KUDU-1812: redact HexDump output

2016-12-22 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5567 to review the following change. Change subject: KUDU-1812: redact HexDump output ..

[kudu-CR] KUDU-1812. address comments on 1179bbdb

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1812. address comments on 1179bbdb .. Patch Set 1: So this is failing because moving the flag above flag parsing means that the enable_experimental flag

[kudu-CR](branch-1.2.x) KUDU-1812. Redact pretty-printed sensitive user data

2016-12-22 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5565 to look at the new patch set (#3). Change subject: KUDU-1812. Redact pretty-printed sensitive user data

[kudu-CR](branch-1.2.x) KUDU-1812. Redact pretty-printed sensitive user data

2016-12-22 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5565 to look at the new patch set (#2). Change subject: KUDU-1812. Redact pretty-printed sensitive user data

[kudu-CR] KUDU-1812. Redaction support for protobufs

2016-12-22 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5553 to look at the new patch set (#4). Change subject: KUDU-1812. Redaction support for protobufs .. KUDU-1812.

[kudu-CR] KUDU-1812. Replace PB DebugString calls with redactable variants

2016-12-22 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5562 to look at the new patch set (#3). Change subject: KUDU-1812. Replace PB DebugString calls with redactable variants

[kudu-CR] KUDU-1812. tool main should set redaction flag default before parsing flags

2016-12-22 Thread Dan Burkert (Code Review)
Dan Burkert has abandoned this change. Change subject: KUDU-1812. tool_main should set redaction flag default before parsing flags .. Abandoned rolled into https://gerrit.cloudera.org/#/c/5566/ -- To view, visit

[kudu-CR] KUDU-1812. address comments on 1179bbdb

2016-12-22 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5566 to review the following change. Change subject: KUDU-1812. address comments on 1179bbdb ..

[kudu-CR](branch-1.2.x) KUDU-1812. Redact pretty-printed sensitive user data

2016-12-22 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5565 to review the following change. Change subject: KUDU-1812. Redact pretty-printed sensitive user data ..

[kudu-CR] [jenkins] added JEPSEN build configuration

2016-12-22 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5559 to look at the new patch set (#3). Change subject: [jenkins] added JEPSEN build configuration .. [jenkins] added

[kudu-CR] WIP [jepsen.kudu] run tests from clojure-maven-plugin

2016-12-22 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5551 to look at the new patch set (#7). Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin .. WIP

[kudu-CR] KUDU-1812. Redact a few more protobuf fields

2016-12-22 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5564 to review the following change. Change subject: KUDU-1812. Redact a few more protobuf fields ..

[kudu-CR] KUDU-1812. Replace PB DebugString calls with redactable variants

2016-12-22 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5562 to look at the new patch set (#2). Change subject: KUDU-1812. Replace PB DebugString calls with redactable variants

[kudu-CR] KUDU-1812. pb util: add a 'using' to import secure PB strings

2016-12-22 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5561 to review the following change. Change subject: KUDU-1812. pb_util: add a 'using' to import secure PB strings

[kudu-CR] KUDU-1812. Replace PB DebugString calls with redactable variants

2016-12-22 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5562 to review the following change. Change subject: KUDU-1812. Replace PB DebugString calls with redactable variants

[kudu-CR] WIP: KUDU-1812. redaction of PB fields

2016-12-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: KUDU-1812. redaction of PB fields .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/5553/2/src/kudu/util/pb_util.cc File

[kudu-CR] KUDU-1643 Prune hash partitions based on IN-list predicates

2016-12-22 Thread Haijie Hong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5176 to look at the new patch set (#12). Change subject: KUDU-1643 Prune hash partitions based on IN-list predicates ..

[kudu-CR] KUDU-1812. Redact pretty-printed sensitive user data

2016-12-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: KUDU-1812. Redact pretty-printed sensitive user data .. KUDU-1812. Redact pretty-printed sensitive user data This commit introduces a framework in