Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812: don't log user data in the Java client
..
KUDU-1812: don't log user data in the Java client
I manually inspected a few logs to make sure nothin
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812: don't log user data in the Java client
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5577
To unsubscribe, visit http:
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. Fix printed default of redaction flag for tools
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5575
To unsubscribe, vi
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812: don't log user data in the Java client
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5549
To unsubscribe, visit http://g
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812: don't log user data in the Java client
..
KUDU-1812: don't log user data in the Java client
I manually inspected a few logs to make sure nothin
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812. Fix printed default of redaction flag for tools
..
KUDU-1812. Fix printed default of redaction flag for tools
A previous commit made the defaul
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
..
KUDU-1812. Redact calls to Slice::ToDebugString
The Slice::ToDebugString method is used pervasively to
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5576
To unsubscribe, visit http://
Alexey Serbin has posted comments on this change.
Change subject: Kudu Jepsen Tests - Initial Commit
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5492/4/java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5500
to look at the new patch set (#5).
Change subject: [jepsen.kudu] some updates
..
[jepsen.kudu] some updates
Update
Alexey Serbin has abandoned this change.
Change subject: WIP: Kudu Jepsen Tests - Initial Commit
..
Abandoned
See https://gerrit.cloudera.org/#/c/5492/ instead.
--
To view, visit http://gerrit.cloudera.org:8080/5550
To unsubs
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5492
to look at the new patch set (#6).
Change subject: Kudu Jepsen Tests - Initial Commit
..
Kudu Jepsen Tests - Initia
Alexey Serbin has posted comments on this change.
Change subject: WIP: Kudu Jepsen Tests - Initial Commit
..
Patch Set 4:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/5492/4/java/kudu-jepsen/project.clj
File java/kudu-jeps
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5577
Change subject: KUDU-1812: don't log user data in the Java client
..
KUDU-1812: don't log user data in the Java client
I manually inspecte
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812: don't log user data in the Java client
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5549
To unsubscribe, visit http:
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812: don't log user data in the Java client
..
Patch Set 2:
(1 comment)
I audited all Logger.getLogger() calls, and then all the calls to those LOG
objects.
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5576
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
..
KUDU-1812. Redact calls to Slice::ToDebugString
The Slice::ToDebugStrin
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5549
to look at the new patch set (#3).
Change subject: KUDU-1812: don't log user data in the Java client
..
KUDU-1812:
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5575
Change subject: KUDU-1812. Fix printed default of redaction flag for tools
..
KUDU-1812. Fix printed default of redaction flag for tools
A
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812: redact HexDump output
..
KUDU-1812: redact HexDump output
After auditing calls to HexDump across the (non-test) Kudu codebase, it
was found tha
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. Replace PB DebugString calls with redactable variants
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5573
To unsubscri
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812: redact HexDump output
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5571
To unsubscribe, visit http://gerrit.cloudera
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812. Fix printed default of redaction flag for tools
..
KUDU-1812. Fix printed default of redaction flag for tools
A previous commit made the defaul
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812. Replace PB DebugString calls with redactable variants
..
KUDU-1812. Replace PB DebugString calls with redactable variants
This uses the clang t
Alexey Serbin has posted comments on this change.
Change subject: WIP: Kudu Jepsen Tests - Initial Commit
..
Patch Set 1:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/5492/1/java/kudu-jepsen/.gitignore
File java/kudu-jepse
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
..
KUDU-1812. Redact calls to Slice::ToDebugString
The Slice::ToDebugString method is used pervasively to
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5568
To unsubscribe, visit http://g
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5568
To unsubscribe, visit http:
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812. Fix printed default of redaction flag for tools
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5574
To unsubscribe, vis
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5574
to review the following change.
Change subject: KUDU-1812. Fix printed default of redaction flag for tools
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
..
Patch Set 3:
(3 comments)
> I could have sworn I saw one of Dan's patches that dealt with this using
> KUDU_SH
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5568
to look at the new patch set (#5).
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
..
K
Alexey Serbin has posted comments on this change.
Change subject: WIP: Kudu Jepsen Tests - Initial Commit
..
Patch Set 4:
(1 comment)
Thank you for the review! I'll address most of your comments in my follow-up
patch, since
Hello Adar Dembo, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5573
to review the following change.
Change subject: KUDU-1812. Replace PB DebugString calls with redactable variants
.
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
..
Patch Set 3:
> > What about std::ostream& operator<<(std::ostream& o, const Slice&
> > s) in slice.h, line 281?
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812. address comments on 1179bbdb
..
KUDU-1812. address comments on 1179bbdb
Change-Id: Ia6d4d1b76c0c24b3468c27f68354c44cb4223bc4
Reviewed-on: http:
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. address comments on 1179bbdb
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5572
To unsubscribe, visit http://gerrit.c
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5568/3//COMMIT_MSG
Commit Message:
Is it worth
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5568
to look at the new patch set (#4).
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
..
K
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
..
Patch Set 3: Code-Review+2
I looked at StringPiece's ToString() and as_string() methods. Didn't see
anything wor
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
..
Patch Set 3:
> What about std::ostream& operator<<(std::ostream& o, const Slice&
> s) in slice.h, line 281?
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
..
Patch Set 3:
What about std::ostream& operator<<(std::ostream& o, const Slice& s) in
slice.h, line 281?
--
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812. Redaction support for protobufs
..
KUDU-1812. Redaction support for protobufs
This adds a new local protobuf option 'kudu.REDACT' which can be
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. Redaction support for protobufs
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5570
To unsubscribe, visit http://gerri
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5572
Change subject: KUDU-1812. address comments on 1179bbdb
..
KUDU-1812. address comments on 1179bbdb
Change-Id: Ia6d4d1b76c0c24b3468c27f6835
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812: redact HexDump output
..
KUDU-1812: redact HexDump output
After auditing calls to HexDump across the (non-test) Kudu codebase, it
was found tha
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5571
Change subject: KUDU-1812: redact HexDump output
..
KUDU-1812: redact HexDump output
After auditing calls to HexDump across the (non-test)
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812: redact HexDump output
..
Patch Set 2: Code-Review+2
I took a look at all the HexDump() callers, ignoring the test-only ones. There
are a few places wher
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5570
Change subject: KUDU-1812. Redaction support for protobufs
..
KUDU-1812. Redaction support for protobufs
This adds a new local protobuf op
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1812: redact HexDump output
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5567
To unsubscribe, visit http://gerrit.cloude
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812. Replace PB DebugString calls with redactable variants
..
KUDU-1812. Replace PB DebugString calls with redactable variants
This uses the clang t
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812: redact HexDump output
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5567/1/src/kudu/util/hexdump.h
File src/kudu/util/hexdump.h:
PS1
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812. address comments on 1179bbdb
..
KUDU-1812. address comments on 1179bbdb
Change-Id: Ia6d4d1b76c0c24b3468c27f68354c44cb4223bc4
Reviewed-on: http:
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5567
to look at the new patch set (#2).
Change subject: KUDU-1812: redact HexDump output
..
KUDU-1812: redact HexDump ou
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812. address comments on 1179bbdb
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5566
To unsubscribe, visit http://gerrit.cl
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812. Replace PB DebugString calls with redactable variants
..
Patch Set 3: Code-Review+2
I also applied the patch and used git grep a bit, like on '\.DebugStr
Adar Dembo has submitted this change and it was merged.
Change subject: KUDU-1812. Redaction support for protobufs
..
KUDU-1812. Redaction support for protobufs
This adds a new local protobuf option 'kudu.REDACT' which can be u
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812. Redaction support for protobufs
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5553
To unsubscribe, visit http://gerrit
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1812: redact HexDump output
..
Patch Set 1:
(1 comment)
lgtm, just a nit
http://gerrit.cloudera.org:8080/#/c/5567/1/src/kudu/util/hexdump.h
File src/kudu/
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5566
to look at the new patch set (#3).
Change subject: KUDU-1812. address comments on 1179bbdb
..
KUDU-1812. address co
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. address comments on 1179bbdb
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5566/2/src/kudu/common/partition-test.cc
File src/kudu/com
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. Redact pretty-printed sensitive user data
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5565
To unsubscribe, visit ht
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1812. Redact pretty-printed sensitive user data
..
KUDU-1812. Redact pretty-printed sensitive user data
This commit introduces a framework in logging
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5568
to look at the new patch set (#3).
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
..
KUDU-1812. Re
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5553
to look at the new patch set (#5).
Change subject: KUDU-1812. Redaction support for protobufs
..
KUDU-1
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. pb_util: add a 'using' to import secure PB strings
..
Patch Set 1:
it's actually been rolled into https://gerrit.cloudera.org/#/c/5562/
--
To view, vi
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. pb_util: add a 'using' to import secure PB strings
..
Patch Set 1:
or it will be
--
To view, visit http://gerrit.cloudera.org:8080/5561
To unsubscribe
Dan Burkert has abandoned this change.
Change subject: KUDU-1812. pb_util: add a 'using' to import secure PB strings
..
Abandoned
This got rolled into https://gerrit.cloudera.org/#/c/5553/
--
To view, visit http://gerrit.clou
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5568
to look at the new patch set (#2).
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
..
KUDU-1812. Re
Adar Dembo has abandoned this change.
Change subject: KUDU-1812. Redact a few more protobuf fields
..
Abandoned
Rolled into http://gerrit.cloudera.org:8080/5553.
--
To view, visit http://gerrit.cloudera.org:8080/5564
To unsub
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812. pb_util: add a 'using' to import secure PB strings
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5561
To unsubscribe,
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812. Redaction support for protobufs
..
Patch Set 4: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5553/4/src/kudu/util/pb_util_test.proto
Fi
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. address comments on 1179bbdb
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5566/2/src/kudu/tools/tool_main.cc
File src/kudu/tools/too
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812. address comments on 1179bbdb
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5566/2/src/kudu/common/partition-test.cc
File src/kudu/com
Adar Dembo has posted comments on this change.
Change subject: KUDU-1812. Clang tool for replacing DebugString calls
..
Patch Set 1:
(2 comments)
I don't have a strong opinion on whether to merge this now or later. If we're
g
Adar Dembo has posted comments on this change.
Change subject: Update kudu-lint to LLVM 3.9
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/4475/2/build-support/tools/kudu-lint/CMakeLists.txt
File build-suppor
Hello Adar Dembo, Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5568
to review the following change.
Change subject: KUDU-1812. Redact calls to Slice::ToDebugString
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5566
to look at the new patch set (#2).
Change subject: KUDU-1812. address comments on 1179bbdb
..
KUDU-1812. address co
Hello Adar Dembo, Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5567
to review the following change.
Change subject: KUDU-1812: redact HexDump output
..
KUDU-18
Dan Burkert has posted comments on this change.
Change subject: KUDU-1812. address comments on 1179bbdb
..
Patch Set 1:
So this is failing because moving the flag above flag parsing means that the
enable_experimental flag need
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5565
to look at the new patch set (#3).
Change subject: KUDU-1812. Redact pretty-printed sensitive user data
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5565
to look at the new patch set (#2).
Change subject: KUDU-1812. Redact pretty-printed sensitive user data
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5553
to look at the new patch set (#4).
Change subject: KUDU-1812. Redaction support for protobufs
..
KUDU-1812. Redacti
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5562
to look at the new patch set (#3).
Change subject: KUDU-1812. Replace PB DebugString calls with redactable variants
Dan Burkert has abandoned this change.
Change subject: KUDU-1812. tool_main should set redaction flag default before
parsing flags
..
Abandoned
rolled into https://gerrit.cloudera.org/#/c/5566/
--
To view, visit http://gerri
Hello Adar Dembo, Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5566
to review the following change.
Change subject: KUDU-1812. address comments on 1179bbdb
..
Hello Adar Dembo, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5565
to review the following change.
Change subject: KUDU-1812. Redact pretty-printed sensitive user data
..
K
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5559
to look at the new patch set (#3).
Change subject: [jenkins] added JEPSEN build configuration
..
[jenkins] added JE
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5551
to look at the new patch set (#7).
Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin
..
WIP [je
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5564
to review the following change.
Change subject: KUDU-1812. Redact a few more protobuf fields
..
KUDU-1812.
Hello Dan Burkert, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5562
to look at the new patch set (#2).
Change subject: KUDU-1812. Replace PB DebugString calls with redactable variants
.
Hello Dan Burkert, Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5553
to look at the new patch set (#3).
Change subject: KUDU-1812. Redaction support for protobufs
.
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5560
to review the following change.
Change subject: KUDU-1812. Clang tool for replacing DebugString calls
..
K
Hello Dan Burkert, Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4475
to look at the new patch set (#2).
Change subject: Update kudu-lint to LLVM 3.9
..
Update
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5561
to review the following change.
Change subject: KUDU-1812. pb_util: add a 'using' to import secure PB strings
.
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5562
to review the following change.
Change subject: KUDU-1812. Replace PB DebugString calls with redactable variants
..
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5563
to review the following change.
Change subject: KUDU-1812. tool_main should set redaction flag default before
parsing flags
..
Todd Lipcon has posted comments on this change.
Change subject: WIP: KUDU-1812. redaction of PB fields
..
Patch Set 2:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/5553/2/src/kudu/util/pb_util.cc
File src/kudu/util/pb_util
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5176
to look at the new patch set (#12).
Change subject: KUDU-1643 Prune hash partitions based on IN-list predicates
..
Alexey Serbin has posted comments on this change.
Change subject: KUDU-1812. Redact pretty-printed sensitive user data
..
Patch Set 6:
(11 comments)
Woops, I accidentally pressed wrong button :(
My bad -- I'm sorry. I was ab
1 - 100 of 101 matches
Mail list logo