[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5439 to look at the new patch set (#7). Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

Will Berkeley has posted comments on this change. Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5439/6/src/kudu/client/client.h File

[kudu-CR] WIP [master] store CA information in the system table

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5793 to look at the new patch set (#4). Change subject: WIP [master] store CA information in the system table .. WIP [ma

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

Dan Burkert has posted comments on this change. Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5439/7/src/kudu/client/client.cc File

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

Will Berkeley has posted comments on this change. Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5439/7/src/kudu/client/client.cc Fi

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5439 to look at the new patch set (#8). Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

Dan Burkert has posted comments on this change. Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5439 To unsubscribe, v

[kudu-CR] tls: move setting of verification modes into TlsHandshake

Dan Burkert has posted comments on this change. Change subject: tls: move setting of verification modes into TlsHandshake .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5839 To unsubscribe, vis

[kudu-CR] openssl util: avoid non-POD vector in static storage

Dan Burkert has posted comments on this change. Change subject: openssl_util: avoid non-POD vector in static storage .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5853 To unsubscribe, visit ht

[kudu-CR] tls: move setting of verification modes into TlsHandshake

Todd Lipcon has submitted this change and it was merged. Change subject: tls: move setting of verification modes into TlsHandshake .. tls: move setting of verification modes into TlsHandshake Depending on the particular type of

[kudu-CR] openssl util: avoid non-POD vector in static storage

Todd Lipcon has submitted this change and it was merged. Change subject: openssl_util: avoid non-POD vector in static storage .. openssl_util: avoid non-POD vector in static storage This addresses an ASAN crash I've seen a coup

[kudu-CR] Extract a static function to generate a self-signed CA

Alexey Serbin has posted comments on this change. Change subject: Extract a static function to generate a self-signed CA .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5844/3/src/kudu/security/security-test-u

[kudu-CR] Extract a static function to generate a self-signed CA

Todd Lipcon has posted comments on this change. Change subject: Extract a static function to generate a self-signed CA .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5844/3/src/kudu/security/security-test-util

[kudu-CR] Allow configuring TlsContext with key wrappers

Alexey Serbin has posted comments on this change. Change subject: Allow configuring TlsContext with key wrappers .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/5845/3/src/kudu/security/cert.cc File src/kudu/s

[kudu-CR] Extract a static function to generate a self-signed CA

Alexey Serbin has posted comments on this change. Change subject: Extract a static function to generate a self-signed CA .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5844/3/src/kudu/security/se

[kudu-CR] Bump Squeasel version

Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5855 to review the following change. Change subject: Bump Squeasel version .. Bump Squeasel version Squease

[kudu-CR] Bump Squeasel version

Dan Burkert has posted comments on this change. Change subject: Bump Squeasel version .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5855/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh:

[kudu-CR] Bump Squeasel version

Alexey Serbin has posted comments on this change. Change subject: Bump Squeasel version .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5855 To unsubscribe, visit http://gerrit.cloudera.org:8080

[kudu-CR] security: simplify CertSigner interface

Alexey Serbin has posted comments on this change. Change subject: security: simplify CertSigner interface .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/5846/3/src/kudu/security/ca/cert_management-test.cc Fil

[kudu-CR] Extract a static function to generate a self-signed CA

Dan Burkert has posted comments on this change. Change subject: Extract a static function to generate a self-signed CA .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5844/3/src/kudu/security/security-test-util

[kudu-CR] KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates

Will Berkeley has submitted this change and it was merged. Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates .. KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates This patch exposes client API

[kudu-CR] Allow configuring TlsContext with key wrappers

Dan Burkert has posted comments on this change. Change subject: Allow configuring TlsContext with key wrappers .. Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/5845/3/src/kudu/security/tls_context

[kudu-CR] Bump Squeasel version

Adar Dembo has posted comments on this change. Change subject: Bump Squeasel version .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5855/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh:

[kudu-CR] WIP [master] store CA information in the system table

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5793 to look at the new patch set (#5). Change subject: WIP [master] store CA information in the system table .. WIP [ma

[kudu-CR] Extract a static function to generate a self-signed CA

Dan Burkert has posted comments on this change. Change subject: Extract a static function to generate a self-signed CA .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5844/3/src/kudu/security/secu

[kudu-CR] security: simplify CertSigner interface

Dan Burkert has posted comments on this change. Change subject: security: simplify CertSigner interface .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5846 To unsubscribe, visit http://gerrit.c

[kudu-CR] Bump Squeasel version

Todd Lipcon has posted comments on this change. Change subject: Bump Squeasel version .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5855/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh:

[kudu-CR] Bump Squeasel version

Todd Lipcon has posted comments on this change. Change subject: Bump Squeasel version .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5855 To unsubscribe, visit http://gerrit.cloudera.org:8080/s

[kudu-CR] Allow configuring TlsContext with key wrappers

Todd Lipcon has posted comments on this change. Change subject: Allow configuring TlsContext with key wrappers .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5845/1/src/kudu/security/tls_context.h File src/kud

[kudu-CR] Fix to KUDU-1642 patch

Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/5856 Change subject: Fix to KUDU-1642 patch .. Fix to KUDU-1642 patch This is a quick fix to the MakePredicate code. It had an unnecessary Sc

[kudu-CR] Fix to KUDU-1642 patch

Adar Dembo has posted comments on this change. Change subject: Fix to KUDU-1642 patch .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5856 To unsubscribe, visit http://gerrit.cloudera.org:8080/s

[kudu-CR] Bump Squeasel version

Adar Dembo has posted comments on this change. Change subject: Bump Squeasel version .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5855/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh:

[kudu-CR] Extract a static function to generate a self-signed CA

Todd Lipcon has submitted this change and it was merged. Change subject: Extract a static function to generate a self-signed CA .. Extract a static function to generate a self-signed CA We had some similar code in a test case a

[kudu-CR] Bump Squeasel version

Hello Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5855 to look at the new patch set (#2). Change subject: Bump Squeasel version .. Bump Squeas

[kudu-CR] Bump Squeasel version

Dan Burkert has posted comments on this change. Change subject: Bump Squeasel version .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5855/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh

[kudu-CR] Update Impala docs for Impala 2.8 release

Matthew Jacobs has posted comments on this change. Change subject: Update Impala docs for Impala 2.8 release .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5733/3/docs/kudu_impala_integration.ado

[kudu-CR] Bump Squeasel version

Adar Dembo has posted comments on this change. Change subject: Bump Squeasel version .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5855 To unsubscribe, visit http://gerrit.cloudera.org:8080/se

[kudu-CR] Fix to KUDU-1642 patch

Will Berkeley has submitted this change and it was merged. Change subject: Fix to KUDU-1642 patch .. Fix to KUDU-1642 patch This is a quick fix to the MakePredicate code. It had an unnecessary Schema argument that can be droppe

[kudu-CR] Update Impala docs for Impala 2.8 release

Jean-Daniel Cryans has posted comments on this change. Change subject: Update Impala docs for Impala 2.8 release .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5733 To unsubscribe, visit http:/

[kudu-CR] Update Impala docs for Impala 2.8 release

Jean-Daniel Cryans has posted comments on this change. Change subject: Update Impala docs for Impala 2.8 release .. Patch Set 3: Verified+1 Unrelated flake. -- To view, visit http://gerrit.cloudera.org:8080/5733 To unsubscrib

[kudu-CR] Update Impala docs for Impala 2.8 release

Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Update Impala docs for Impala 2.8 release .. Update Impala docs for Impala 2.8 release * No longer needs to document the special 'IMPALA_KUDU' buil

[kudu-CR] Allow configuring TlsContext with key wrappers

Todd Lipcon has posted comments on this change. Change subject: Allow configuring TlsContext with key wrappers .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/5845/3/src/kudu/security/cert.cc File src/kudu/sec

[kudu-CR] security: simplify CertSigner interface

Todd Lipcon has posted comments on this change. Change subject: security: simplify CertSigner interface .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5846/3/src/kudu/security/ca/cert_management-test.cc File

[kudu-CR] Allow configuring TlsContext with key wrappers

Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5845 to look at the new patch set (#4). Change subject: Allow configuring TlsContext with key wrappers .. A

[kudu-CR] security: simplify CertSigner interface

Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5846 to look at the new patch set (#4). Change subject: security: simplify CertSigner interface .. security

[kudu-CR] Bump Squeasel version

Todd Lipcon has posted comments on this change. Change subject: Bump Squeasel version .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5855 To unsubscribe, visit http://gerrit.cloudera.org:8080/s

[kudu-CR] Bump Squeasel version

Todd Lipcon has submitted this change and it was merged. Change subject: Bump Squeasel version .. Bump Squeasel version Squeasel has recently landed some security-related fixes: * OpenSSL is now dynamically linked, instead of

[kudu-CR] thirdparty: patch cmake to avoid select() when reading from subprocess pipes

Hello Matthew Jacobs, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5857 to review the following change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes .

[kudu-CR] WIP: tls: hook up internal PKI system to TlsContext

Todd Lipcon has posted comments on this change. Change subject: WIP: tls: hook up internal PKI system to TlsContext .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5808/2/src/kudu/security/tls_handshake-test.cc

[kudu-CR] thirdparty: patch cmake to avoid select() when reading from subprocess pipes

Todd Lipcon has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes .. Patch Set 1: hrm... is there any patch upstream in cmake to switch from select() t

[kudu-CR] thirdparty: patch cmake to avoid select() when reading from subprocess pipes

Adar Dembo has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes .. Patch Set 1: > hrm... is there any patch upstream in cmake to switch from select()

[kudu-CR] thirdparty: patch cmake to avoid select() when reading from subprocess pipes

Matthew Jacobs has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes .. Patch Set 1: @Todd, why does this add 5s to rebuild? is thirdparty always rebui

[kudu-CR] thirdparty: patch cmake to avoid select() when reading from subprocess pipes

Matthew Jacobs has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes .. Patch Set 1: this happens somewhat regularly, maybe 25% of the time when we bui

[kudu-CR] thirdparty: patch cmake to avoid select() when reading from subprocess pipes

Todd Lipcon has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes .. Patch Set 1: > @Todd, why does this add 5s to rebuild? is thirdparty always rebuil

[kudu-CR] thirdparty: patch cmake to avoid select() when reading from subprocess pipes

Matthew Jacobs has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes .. Patch Set 1: This should only affect the cmake build itself, i.e. thirdparty.

[kudu-CR] thirdparty: patch cmake to avoid select() when reading from subprocess pipes

Adar Dembo has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes .. Patch Set 1: > This should only affect the cmake build itself, i.e. thirdparty. Ju

[kudu-CR] thirdparty: patch cmake to avoid select() when reading from subprocess pipes

Matthew Jacobs has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes .. Patch Set 1: > > This should only affect the cmake build itself, i.e. thirdpart

[kudu-CR] thirdparty: patch cmake to avoid select() when reading from subprocess pipes

Matthew Jacobs has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes .. Patch Set 1: > > > This should only affect the cmake build itself, i.e. > thir

[kudu-CR] tls socket: support zero-length writes

Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5861 to review the following change. Change subject: tls_socket: support zero-length writes .. tls_socket: s

[kudu-CR] WIP: tls: hook up internal PKI system to TlsContext

Hello Dan Burkert, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5808 to look at the new patch set (#7). Change subject: WIP: tls: hook up internal PKI system to TlsContext .

[kudu-CR] thirdparty: patch cmake to avoid select() when reading from subprocess pipes

Adar Dembo has posted comments on this change. Change subject: thirdparty: patch cmake to avoid select() when reading from subprocess pipes .. Patch Set 1: Code-Review-2 MJ and I discussed this further and decided it might be

[kudu-CR] Add security-test dependency on security

Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5862 to review the following change. Change subject: Add security-test dependency on security .. Add security-test dependen

[kudu-CR] tls socket: support zero-length writes

Alexey Serbin has posted comments on this change. Change subject: tls_socket: support zero-length writes .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5861 To unsubscribe, visit http://gerrit.

[kudu-CR] Add security-test dependency on security

Todd Lipcon has posted comments on this change. Change subject: Add security-test dependency on security .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5862 To unsubscribe, visit http://gerrit.

[kudu-CR] tls socket: support zero-length writes

Todd Lipcon has submitted this change and it was merged. Change subject: tls_socket: support zero-length writes .. tls_socket: support zero-length writes In some cases, we try to call Write() with a zero-length buffer. This is

[kudu-CR] WIP: tls: hook up internal PKI system to TlsContext

Todd Lipcon has posted comments on this change. Change subject: WIP: tls: hook up internal PKI system to TlsContext .. Patch Set 7: Cool! clean test run with all RPCs going over TLS. -- To view, visit http://gerrit.cloudera.o

[kudu-CR] Add security-test dependency on security

Dan Burkert has submitted this change and it was merged. Change subject: Add security-test dependency on security .. Add security-test dependency on security Change-Id: I341de3a46af75ed9716eb81f22b0ef7e92029338 Reviewed-on: htt

[kudu-CR] [master] store CA information in the system table

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5793 to look at the new patch set (#6). Change subject: [master] store CA information in the system table .. [master] st

[kudu-CR] Move 'master rpc.h' into the client/ module

Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5864 to review the following change. Change subject: Move 'master_rpc.h' into the client/ module .. Move 'ma

[kudu-CR] Move 'master rpc.h' into the client/ module

Adar Dembo has posted comments on this change. Change subject: Move 'master_rpc.h' into the client/ module .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5864/1//COMMIT_MSG Commit Message: Line 7: Move 'mast

[kudu-CR] Move 'master rpc.h' into the client/ module

Todd Lipcon has posted comments on this change. Change subject: Move 'master_rpc.h' into the client/ module .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5864/1//COMMIT_MSG Commit Message: PS1, Line 10: Even

[kudu-CR] Move 'master rpc.h' into the client/ module

Todd Lipcon has posted comments on this change. Change subject: Move 'master_rpc.h' into the client/ module .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5864/1/src/kudu/client/client-internal.cc File src/ku

[kudu-CR] WIP: KUDU-1845: Kerberos client keytab should be periodically renewed

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5820 to look at the new patch set (#2). Change subject: WIP: KUDU-1845: Kerberos client keytab should be periodically renewed ..

[kudu-CR] WIP: KUDU-1845: Kerberos client keytab should be periodically renewed

Sailesh Mukil has posted comments on this change. Change subject: WIP: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 2: (17 comments) Sorry for the slow response, I kept getting pulled onto oth

[kudu-CR] [security] adjust TLS certificate verification

Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5865 to review the following change. Change subject: [security] adjust TLS certificate verification .. [secu

[kudu-CR] [security] adjust TLS certificate verification

Hello Todd Lipcon, Alexey Serbin, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5865 to look at the new patch set (#2). Change subject: [security] adjust TLS certificate verification ..

[kudu-CR] [security] Add negotiation test with TLS + GSSAPI

Dan Burkert has abandoned this change. Change subject: [security] Add negotiation test with TLS + GSSAPI .. Abandoned Rolled into https://gerrit.cloudera.org/#/c/5865/ -- To view, visit http://gerrit.cloudera.org:8080/5849 To

[kudu-CR] Move 'master rpc.{h,cc}' into the client/ module

Hello Dan Burkert, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5864 to look at the new patch set (#2). Change subject: Move 'master_rpc.{h,cc}' into the client/ module

[kudu-CR] client: rename various function calls and classes to ConnectToCluster

Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5868 to review the following change. Change subject: client: rename various function calls and classes to ConnectToCluster .

[kudu-CR] Fix some clang-tidy errors for std::move

Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5867 to review the following change. Change subject: Fix some clang-tidy errors for std::move .. Fix some cl

[kudu-CR] WIP: Add new ConnectToMaster RPC, implement client fallback

Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5869 to review the following change. Change subject: WIP: Add new ConnectToMaster RPC, implement client fallback

[kudu-CR] [master] store CA information in the system table

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5793 to look at the new patch set (#7). Change subject: [master] store CA information in the system table .. [master] st

[kudu-CR] [security] adjust TLS certificate verification

Todd Lipcon has posted comments on this change. Change subject: [security] adjust TLS certificate verification .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5865/2//COMMIT_MSG Commit Message: L

[kudu-CR] [mini cluster] fix crash in GetLeaderMasterIndex()

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5870 Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex() .. [mini_cluster] fix crash in GetLeaderMasterIndex() If at least one

[kudu-CR] [mini cluster] fix crash in GetLeaderMasterIndex()

Alexey Serbin has uploaded a new patch set (#2). Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex() .. [mini_cluster] fix crash in GetLeaderMasterIndex() If at least one of the mini-masters is shutdown by explici

[kudu-CR] WIP: issue authentication tokens and CA certs to clients

Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5871 to review the following change. Change subject: WIP: issue authentication tokens and CA certs to clients ...

[kudu-CR] client: rename various function calls and classes to ConnectToCluster

Alexey Serbin has posted comments on this change. Change subject: client: rename various function calls and classes to ConnectToCluster .. Patch Set 1: Code-Review+2 (1 comment) LGTM, consider fixing a tiny typo before commit

[kudu-CR] [mini cluster] fix crash in GetLeaderMasterIndex()

Adar Dembo has posted comments on this change. Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5870/2/src/kudu/integration-tests/mini_cluster.c

[kudu-CR] Move 'master rpc.{h,cc}' into the client/ module

Adar Dembo has posted comments on this change. Change subject: Move 'master_rpc.{h,cc}' into the client/ module .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5864 To unsubscribe, visit http://

[kudu-CR] Fix some clang-tidy errors for std::move

Adar Dembo has posted comments on this change. Change subject: Fix some clang-tidy errors for std::move .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5867/1/src/kudu/rpc/reactor.cc File src/kudu

[kudu-CR] client: rename various function calls and classes to ConnectToCluster

Adar Dembo has posted comments on this change. Change subject: client: rename various function calls and classes to ConnectToCluster .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5868 To unsu

[kudu-CR] [master] store CA information in the system table

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5793 to look at the new patch set (#8). Change subject: [master] store CA information in the system table .. [master] st

[kudu-CR] WIP: Add new ConnectToMaster RPC, implement client fallback

Adar Dembo has posted comments on this change. Change subject: WIP: Add new ConnectToMaster RPC, implement client fallback .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/5869/1/src/kudu/client/master_rpc.cc F

[kudu-CR] [mini cluster] fix crash in GetLeaderMasterIndex()

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5870 to look at the new patch set (#3). Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex() .. [mini_clus

[kudu-CR] [mini cluster] fix crash in GetLeaderMasterIndex()

Alexey Serbin has posted comments on this change. Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5870/2/src/kudu/integration-tests/mini_cluste

[kudu-CR] WIP: issue authentication tokens and CA certs to clients

Alexey Serbin has posted comments on this change. Change subject: WIP: issue authentication tokens and CA certs to clients .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5871/1/src/kudu/master/authn_token_man