Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5439
to look at the new patch set (#7).
Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates
Will Berkeley has posted comments on this change.
Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5439/6/src/kudu/client/client.h
File
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#4).
Change subject: WIP [master] store CA information in the system table
..
WIP [ma
Dan Burkert has posted comments on this change.
Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates
..
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5439/7/src/kudu/client/client.cc
File
Will Berkeley has posted comments on this change.
Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates
..
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5439/7/src/kudu/client/client.cc
Fi
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5439
to look at the new patch set (#8).
Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates
Dan Burkert has posted comments on this change.
Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5439
To unsubscribe, v
Dan Burkert has posted comments on this change.
Change subject: tls: move setting of verification modes into TlsHandshake
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5839
To unsubscribe, vis
Dan Burkert has posted comments on this change.
Change subject: openssl_util: avoid non-POD vector in static storage
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5853
To unsubscribe, visit ht
Todd Lipcon has submitted this change and it was merged.
Change subject: tls: move setting of verification modes into TlsHandshake
..
tls: move setting of verification modes into TlsHandshake
Depending on the particular type of
Todd Lipcon has submitted this change and it was merged.
Change subject: openssl_util: avoid non-POD vector in static storage
..
openssl_util: avoid non-POD vector in static storage
This addresses an ASAN crash I've seen a coup
Alexey Serbin has posted comments on this change.
Change subject: Extract a static function to generate a self-signed CA
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5844/3/src/kudu/security/security-test-u
Todd Lipcon has posted comments on this change.
Change subject: Extract a static function to generate a self-signed CA
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5844/3/src/kudu/security/security-test-util
Alexey Serbin has posted comments on this change.
Change subject: Allow configuring TlsContext with key wrappers
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5845/3/src/kudu/security/cert.cc
File src/kudu/s
Alexey Serbin has posted comments on this change.
Change subject: Extract a static function to generate a self-signed CA
..
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5844/3/src/kudu/security/se
Hello Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5855
to review the following change.
Change subject: Bump Squeasel version
..
Bump Squeasel version
Squease
Dan Burkert has posted comments on this change.
Change subject: Bump Squeasel version
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5855/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
Alexey Serbin has posted comments on this change.
Change subject: Bump Squeasel version
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5855
To unsubscribe, visit http://gerrit.cloudera.org:8080
Alexey Serbin has posted comments on this change.
Change subject: security: simplify CertSigner interface
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5846/3/src/kudu/security/ca/cert_management-test.cc
Fil
Dan Burkert has posted comments on this change.
Change subject: Extract a static function to generate a self-signed CA
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5844/3/src/kudu/security/security-test-util
Will Berkeley has submitted this change and it was merged.
Change subject: KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates
..
KUDU-1595 and KUDU-1642: IS NOT NULL and IS NULL predicates
This patch exposes client API
Dan Burkert has posted comments on this change.
Change subject: Allow configuring TlsContext with key wrappers
..
Patch Set 3: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5845/3/src/kudu/security/tls_context
Adar Dembo has posted comments on this change.
Change subject: Bump Squeasel version
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5855/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#5).
Change subject: WIP [master] store CA information in the system table
..
WIP [ma
Dan Burkert has posted comments on this change.
Change subject: Extract a static function to generate a self-signed CA
..
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5844/3/src/kudu/security/secu
Dan Burkert has posted comments on this change.
Change subject: security: simplify CertSigner interface
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5846
To unsubscribe, visit http://gerrit.c
Todd Lipcon has posted comments on this change.
Change subject: Bump Squeasel version
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5855/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
Todd Lipcon has posted comments on this change.
Change subject: Bump Squeasel version
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5855
To unsubscribe, visit http://gerrit.cloudera.org:8080/s
Todd Lipcon has posted comments on this change.
Change subject: Allow configuring TlsContext with key wrappers
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5845/1/src/kudu/security/tls_context.h
File src/kud
Will Berkeley has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5856
Change subject: Fix to KUDU-1642 patch
..
Fix to KUDU-1642 patch
This is a quick fix to the MakePredicate code. It had an unnecessary
Sc
Adar Dembo has posted comments on this change.
Change subject: Fix to KUDU-1642 patch
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5856
To unsubscribe, visit http://gerrit.cloudera.org:8080/s
Adar Dembo has posted comments on this change.
Change subject: Bump Squeasel version
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5855/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
Todd Lipcon has submitted this change and it was merged.
Change subject: Extract a static function to generate a self-signed CA
..
Extract a static function to generate a self-signed CA
We had some similar code in a test case a
Hello Todd Lipcon, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5855
to look at the new patch set (#2).
Change subject: Bump Squeasel version
..
Bump Squeas
Dan Burkert has posted comments on this change.
Change subject: Bump Squeasel version
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5855/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh
Matthew Jacobs has posted comments on this change.
Change subject: Update Impala docs for Impala 2.8 release
..
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5733/3/docs/kudu_impala_integration.ado
Adar Dembo has posted comments on this change.
Change subject: Bump Squeasel version
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5855
To unsubscribe, visit http://gerrit.cloudera.org:8080/se
Will Berkeley has submitted this change and it was merged.
Change subject: Fix to KUDU-1642 patch
..
Fix to KUDU-1642 patch
This is a quick fix to the MakePredicate code. It had an unnecessary
Schema argument that can be droppe
Jean-Daniel Cryans has posted comments on this change.
Change subject: Update Impala docs for Impala 2.8 release
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5733
To unsubscribe, visit http:/
Jean-Daniel Cryans has posted comments on this change.
Change subject: Update Impala docs for Impala 2.8 release
..
Patch Set 3: Verified+1
Unrelated flake.
--
To view, visit http://gerrit.cloudera.org:8080/5733
To unsubscrib
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: Update Impala docs for Impala 2.8 release
..
Update Impala docs for Impala 2.8 release
* No longer needs to document the special 'IMPALA_KUDU' buil
Todd Lipcon has posted comments on this change.
Change subject: Allow configuring TlsContext with key wrappers
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5845/3/src/kudu/security/cert.cc
File src/kudu/sec
Todd Lipcon has posted comments on this change.
Change subject: security: simplify CertSigner interface
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5846/3/src/kudu/security/ca/cert_management-test.cc
File
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5845
to look at the new patch set (#4).
Change subject: Allow configuring TlsContext with key wrappers
..
A
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5846
to look at the new patch set (#4).
Change subject: security: simplify CertSigner interface
..
security
Todd Lipcon has posted comments on this change.
Change subject: Bump Squeasel version
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5855
To unsubscribe, visit http://gerrit.cloudera.org:8080/s
Todd Lipcon has submitted this change and it was merged.
Change subject: Bump Squeasel version
..
Bump Squeasel version
Squeasel has recently landed some security-related fixes:
* OpenSSL is now dynamically linked, instead of
Hello Matthew Jacobs, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5857
to review the following change.
Change subject: thirdparty: patch cmake to avoid select() when reading from
subprocess pipes
.
Todd Lipcon has posted comments on this change.
Change subject: WIP: tls: hook up internal PKI system to TlsContext
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5808/2/src/kudu/security/tls_handshake-test.cc
Todd Lipcon has posted comments on this change.
Change subject: thirdparty: patch cmake to avoid select() when reading from
subprocess pipes
..
Patch Set 1:
hrm... is there any patch upstream in cmake to switch from select() t
Adar Dembo has posted comments on this change.
Change subject: thirdparty: patch cmake to avoid select() when reading from
subprocess pipes
..
Patch Set 1:
> hrm... is there any patch upstream in cmake to switch from select()
Matthew Jacobs has posted comments on this change.
Change subject: thirdparty: patch cmake to avoid select() when reading from
subprocess pipes
..
Patch Set 1:
@Todd, why does this add 5s to rebuild? is thirdparty always rebui
Matthew Jacobs has posted comments on this change.
Change subject: thirdparty: patch cmake to avoid select() when reading from
subprocess pipes
..
Patch Set 1:
this happens somewhat regularly, maybe 25% of the time when we bui
Todd Lipcon has posted comments on this change.
Change subject: thirdparty: patch cmake to avoid select() when reading from
subprocess pipes
..
Patch Set 1:
> @Todd, why does this add 5s to rebuild? is thirdparty always rebuil
Matthew Jacobs has posted comments on this change.
Change subject: thirdparty: patch cmake to avoid select() when reading from
subprocess pipes
..
Patch Set 1:
This should only affect the cmake build itself, i.e. thirdparty.
Adar Dembo has posted comments on this change.
Change subject: thirdparty: patch cmake to avoid select() when reading from
subprocess pipes
..
Patch Set 1:
> This should only affect the cmake build itself, i.e. thirdparty.
Ju
Matthew Jacobs has posted comments on this change.
Change subject: thirdparty: patch cmake to avoid select() when reading from
subprocess pipes
..
Patch Set 1:
> > This should only affect the cmake build itself, i.e. thirdpart
Matthew Jacobs has posted comments on this change.
Change subject: thirdparty: patch cmake to avoid select() when reading from
subprocess pipes
..
Patch Set 1:
> > > This should only affect the cmake build itself, i.e.
> thir
Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5861
to review the following change.
Change subject: tls_socket: support zero-length writes
..
tls_socket: s
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5808
to look at the new patch set (#7).
Change subject: WIP: tls: hook up internal PKI system to TlsContext
.
Adar Dembo has posted comments on this change.
Change subject: thirdparty: patch cmake to avoid select() when reading from
subprocess pipes
..
Patch Set 1: Code-Review-2
MJ and I discussed this further and decided it might be
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5862
to review the following change.
Change subject: Add security-test dependency on security
..
Add security-test dependen
Alexey Serbin has posted comments on this change.
Change subject: tls_socket: support zero-length writes
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5861
To unsubscribe, visit http://gerrit.
Todd Lipcon has posted comments on this change.
Change subject: Add security-test dependency on security
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5862
To unsubscribe, visit http://gerrit.
Todd Lipcon has submitted this change and it was merged.
Change subject: tls_socket: support zero-length writes
..
tls_socket: support zero-length writes
In some cases, we try to call Write() with a zero-length buffer. This is
Todd Lipcon has posted comments on this change.
Change subject: WIP: tls: hook up internal PKI system to TlsContext
..
Patch Set 7:
Cool! clean test run with all RPCs going over TLS.
--
To view, visit http://gerrit.cloudera.o
Dan Burkert has submitted this change and it was merged.
Change subject: Add security-test dependency on security
..
Add security-test dependency on security
Change-Id: I341de3a46af75ed9716eb81f22b0ef7e92029338
Reviewed-on: htt
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#6).
Change subject: [master] store CA information in the system table
..
[master] st
Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5864
to review the following change.
Change subject: Move 'master_rpc.h' into the client/ module
..
Move 'ma
Adar Dembo has posted comments on this change.
Change subject: Move 'master_rpc.h' into the client/ module
..
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5864/1//COMMIT_MSG
Commit Message:
Line 7: Move 'mast
Todd Lipcon has posted comments on this change.
Change subject: Move 'master_rpc.h' into the client/ module
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5864/1//COMMIT_MSG
Commit Message:
PS1, Line 10: Even
Todd Lipcon has posted comments on this change.
Change subject: Move 'master_rpc.h' into the client/ module
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/5864/1/src/kudu/client/client-internal.cc
File src/ku
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5820
to look at the new patch set (#2).
Change subject: WIP: KUDU-1845: Kerberos client keytab should be periodically
renewed
..
Sailesh Mukil has posted comments on this change.
Change subject: WIP: KUDU-1845: Kerberos client keytab should be periodically
renewed
..
Patch Set 2:
(17 comments)
Sorry for the slow response, I kept getting pulled onto oth
Hello Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5865
to review the following change.
Change subject: [security] adjust TLS certificate verification
..
[secu
Hello Todd Lipcon, Alexey Serbin,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5865
to look at the new patch set (#2).
Change subject: [security] adjust TLS certificate verification
..
Dan Burkert has abandoned this change.
Change subject: [security] Add negotiation test with TLS + GSSAPI
..
Abandoned
Rolled into https://gerrit.cloudera.org/#/c/5865/
--
To view, visit http://gerrit.cloudera.org:8080/5849
To
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5864
to look at the new patch set (#2).
Change subject: Move 'master_rpc.{h,cc}' into the client/ module
Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5868
to review the following change.
Change subject: client: rename various function calls and classes to
ConnectToCluster
.
Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5867
to review the following change.
Change subject: Fix some clang-tidy errors for std::move
..
Fix some cl
Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5869
to review the following change.
Change subject: WIP: Add new ConnectToMaster RPC, implement client fallback
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#7).
Change subject: [master] store CA information in the system table
..
[master] st
Todd Lipcon has posted comments on this change.
Change subject: [security] adjust TLS certificate verification
..
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5865/2//COMMIT_MSG
Commit Message:
L
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5870
Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex()
..
[mini_cluster] fix crash in GetLeaderMasterIndex()
If at least one
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex()
..
[mini_cluster] fix crash in GetLeaderMasterIndex()
If at least one of the mini-masters is shutdown by explici
Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5871
to review the following change.
Change subject: WIP: issue authentication tokens and CA certs to clients
...
Alexey Serbin has posted comments on this change.
Change subject: client: rename various function calls and classes to
ConnectToCluster
..
Patch Set 1: Code-Review+2
(1 comment)
LGTM, consider fixing a tiny typo before commit
Adar Dembo has posted comments on this change.
Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex()
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5870/2/src/kudu/integration-tests/mini_cluster.c
Adar Dembo has posted comments on this change.
Change subject: Move 'master_rpc.{h,cc}' into the client/ module
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5864
To unsubscribe, visit http://
Adar Dembo has posted comments on this change.
Change subject: Fix some clang-tidy errors for std::move
..
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5867/1/src/kudu/rpc/reactor.cc
File src/kudu
Adar Dembo has posted comments on this change.
Change subject: client: rename various function calls and classes to
ConnectToCluster
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5868
To unsu
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5793
to look at the new patch set (#8).
Change subject: [master] store CA information in the system table
..
[master] st
Adar Dembo has posted comments on this change.
Change subject: WIP: Add new ConnectToMaster RPC, implement client fallback
..
Patch Set 1:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/5869/1/src/kudu/client/master_rpc.cc
F
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5870
to look at the new patch set (#3).
Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex()
..
[mini_clus
Alexey Serbin has posted comments on this change.
Change subject: [mini_cluster] fix crash in GetLeaderMasterIndex()
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5870/2/src/kudu/integration-tests/mini_cluste
Alexey Serbin has posted comments on this change.
Change subject: WIP: issue authentication tokens and CA certs to clients
..
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/5871/1/src/kudu/master/authn_token_man
96 matches
Mail list logo