Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7917
Change subject: Add "make tidy" target
..
Add "make tidy" target
This adds a simple cmake target to run a local clang-tidy check, instead
o
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7919
to review the following change.
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
Hello Dan Burkert, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7918
to review the following change.
Change subject: Implement a lock table
..
Implement a lock table
This loc
Hello Andrew Wong, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7914
to look at the new patch set (#5).
Change subject: docs: light editing on 1.5 release notes; spark security docs
...
Will Berkeley has posted comments on this change.
Change subject: KUDU-2078: Sink failure if batch size > session's flush buffer
size
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7641/1/java/kudu-flume-sink
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7641
to look at the new patch set (#2).
Change subject: KUDU-2078: Sink failure if batch size > session's flush buffer
size
Dan Burkert has posted comments on this change.
Change subject: Implement a lock table
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7918/1/src/kudu/util/lock_table.h
File src/kudu/util/lock_table.h:
Line 42
Mike Percy has posted comments on this change.
Change subject: KUDU-2078: Sink failure if batch size > session's flush buffer
size
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7641
To unsubs
Mike Percy has submitted this change and it was merged.
Change subject: KUDU-2078: Sink failure if batch size > session's flush buffer
size
..
KUDU-2078: Sink failure if batch size > session's flush buffer size
The Flume sink
Hello Dan Burkert, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7921
to review the following change.
Change subject: KUDU-2078: Sink failure if batch size > session's flush buffer
size
Alexey Serbin has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 5:
(4 comments)
A few other things which might worth mentioning.
http://gerrit.cloud
Mike Percy has posted comments on this change.
Change subject: Implement a lock table
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7918/1/src/kudu/util/lock_table.h
File src/kudu/util/lock_table.h:
Line 42:
Dan Burkert has posted comments on this change.
Change subject: KUDU-2078: Sink failure if batch size > session's flush buffer
size
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7921
To unsub
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7918
to look at the new patch set (#2).
Change subject: Implement a lock table
..
Implement a lock table
This lock tabl
Mike Percy has submitted this change and it was merged.
Change subject: KUDU-2078: Sink failure if batch size > session's flush buffer
size
..
KUDU-2078: Sink failure if batch size > session's flush buffer size
The Flume sink
Hello Andrew Wong, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7914
to look at the new patch set (#6).
Change subject: docs: light editing on 1.5 release notes; spark security docs
...
Dan Burkert has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7914/5/docs/release_notes.adoc
File
Alexey Serbin has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 6: Code-Review+2
(1 comment)
LGTM. You might want to get more feedback from Adar and
Dan Burkert has posted comments on this change.
Change subject: Implement a lock table
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7918
To unsubscribe, visit http://gerrit.cloudera.org:8080/
Hao Hao has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 6: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7914/6/docs/release_notes.
Alexey Serbin has posted comments on this change.
Change subject: Add "make tidy" target
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7917
To unsubscribe, visit http://gerrit.cloudera.org:808
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7917
to look at the new patch set (#2).
Change subject: Add "make tidy" target
..
Add "make tidy" target
Hello Hao Hao, Andrew Wong, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7914
to look at the new patch set (#7).
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Dan Burkert has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7914/6/docs/release_notes.adoc
File
Andrew Wong has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7914/6/docs/release_notes.adoc
File
Adar Dembo has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe,
Dan Burkert has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7914/6/docs/release_notes.adoc
File
Hello Hao Hao, Andrew Wong, Adar Dembo, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7914
to look at the new patch set (#8).
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Dan Burkert has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7924
To u
Dan Burkert has submitted this change and it was merged.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
docs: light editing on 1.5 release notes; spark security docs
Change-Id: I49014dda6fcec32
Dan Burkert has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 8: Code-Review+2
Carrying over Alexey and Adar's +2
--
To view, visit http://gerrit.cl
Dan Burkert has posted comments on this change.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7914
To unsubscribe, vi
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7924
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
docs: light editing on 1.5 release notes; spark security d
Dan Burkert has submitted this change and it was merged.
Change subject: docs: light editing on 1.5 release notes; spark security docs
..
docs: light editing on 1.5 release notes; spark security docs
Change-Id: I49014dda6fcec32
Adar Dembo has posted comments on this change.
Change subject: Add "make tidy" target
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7917/2/CMakeLists.txt
File CMakeLists.txt:
Line 1117: add_custom_target(
Mike Percy has posted comments on this change.
Change subject: Implement a lock table
..
Patch Set 2: Verified+1
Overriding unrelated flaky test failure of
RaftConsensusITest.TestReplicaBehaviorViaRPC
--
To view, visit http:
Adar Dembo has posted comments on this change.
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
..
Patch Set 1:
I'd like to better understand the concurrency model here.
The tablet cop
Alexey Serbin has posted comments on this change.
Change subject: Add "make tidy" target
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7917/2/CMakeLists.txt
File CMakeLists.txt:
Line 1118: add_dependencie
Adar Dembo has posted comments on this change.
Change subject: KUDU-2055: Coalesce hole punching when deleting groups of blocks
..
Patch Set 3:
I'd like to avoid the mega-review that we had for the other patch by carving
this
Hao Hao has posted comments on this change.
Change subject: KUDU-2055: Coalesce hole punching when deleting groups of blocks
..
Patch Set 3:
> I'd like to avoid the mega-review that we had for the other patch
> by carving this
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7919
to look at the new patch set (#2).
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
..
Hello Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7925
to review the following change.
Change subject: Fix RAT warnings
..
Fix RAT warnings
Change-Id: I0260ce9ce08790d3c6004
Dan Burkert has posted comments on this change.
Change subject: feat: add the wrapper for the Iterator by using
InterruptibleIterator
..
Patch Set 2:
My only hesitation with TaskKilledException is that it's a developer API, so
Mike Percy has posted comments on this change.
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
..
Patch Set 2:
> I'd like to better understand the concurrency model here.
>
> The ta
Mike Percy has posted comments on this change.
Change subject: Add "make tidy" target
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7917/2/CMakeLists.txt
File CMakeLists.txt:
Line 1117: add_custom_target(
Alexey Serbin has posted comments on this change.
Change subject: Add "make tidy" target
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7917/2/README.adoc
File README.adoc:
Line 263: === Running
Alexey Serbin has posted comments on this change.
Change subject: Add "make tidy" target
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7917
To unsubscribe, visit http://gerrit.cloudera.org:808
Dan Burkert has posted comments on this change.
Change subject: KUDU-2098. Drop Spark 1 Support
..
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7690/2//COMMIT_MSG
Commit Message:
Line 9: Spark 2 has been avai
Adar Dembo has posted comments on this change.
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
..
Patch Set 2:
> Having such a session id design is more about de-duplicating
> begin-s
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7909
to look at the new patch set (#3).
Change subject: master: always use smart pointers when accessing TableInfo and
TabletInfo
..
Adar Dembo has posted comments on this change.
Change subject: master: always use smart pointers when accessing TableInfo and
TabletInfo
..
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/7909/2/src/kudu/master/
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7926
to review the following change.
Change subject: Fix RAT complaints in gradle properties files
..
Fix RAT complaints in
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7925
to look at the new patch set (#2).
Change subject: Fix RAT warnings
..
Fix RAT warnings
Change-Id: I0260ce9ce08790
Mike Percy has posted comments on this change.
Change subject: Fix RAT warnings
..
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7925/1/build-support/release/rat_exclude_files.txt
File build-support/release/rat
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7925
to look at the new patch set (#3).
Change subject: Fix RAT warnings
..
Fix RAT warnings
Change-Id: I0260ce9ce08790
Mike Percy has posted comments on this change.
Change subject: Fix RAT warnings
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7925/2/build-support/release/rat_exclude_files.txt
File build-support/release/rat
Mike Percy has posted comments on this change.
Change subject: Fix RAT warnings
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7925/3/java/gradle/wrapper/gradle-wrapper.properties
File java/gradle/wrapper/grad
Mike Percy has posted comments on this change.
Change subject: Fix RAT warnings
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7925/1/build-support/release/rat_exclude_files.txt
File build-support/release/rat_
Mike Percy has abandoned this change.
Change subject: Fix RAT complaints in gradle properties files
..
Abandoned
Dan has an uber patch that he is rolling all of these changes into
--
To view, visit http://gerrit.cloudera.org:
Grant Henke has posted comments on this change.
Change subject: Fix RAT warnings
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7925/3/java/gradle/wrapper/gradle-wrapper.properties
File java/gradle/wrapper/gra
Hello Dan Burkert, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7927
to review the following change.
Change subject: gradle: convert gradle-wrapper.properties into a real generated
file
Dan Burkert has posted comments on this change.
Change subject: gradle: convert gradle-wrapper.properties into a real generated
file
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7927
To unsu
Mike Percy has posted comments on this change.
Change subject: gradle: convert gradle-wrapper.properties into a real generated
file
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7927/1/java/gradlew
File java
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7928
Change subject: [doc] add info about the iwyu target
..
[doc] add info about the iwyu target
Added information about the cmake-generated
Adar Dembo has posted comments on this change.
Change subject: master: always use smart pointers when accessing TableInfo and
TabletInfo
..
Patch Set 3: Verified+1
There were two TSAN failures. One was KUDU-2059. The other was
Alexey Serbin has posted comments on this change.
Change subject: master: always use smart pointers when accessing TableInfo and
TabletInfo
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7909
Adar Dembo has posted comments on this change.
Change subject: [doc] add info about the iwyu target
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7928/1/README.adoc
File README.adoc:
PS1, Line 267: consiste
Adar Dembo has posted comments on this change.
Change subject: gradle: convert gradle-wrapper.properties into a real generated
file
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7927/1/java/gradlew
File java
Grant Henke has posted comments on this change.
Change subject: gradle: convert gradle-wrapper.properties into a real generated
file
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7927
To unsu
Hello Dan Burkert, Grant Henke, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7927
to look at the new patch set (#2).
Change subject: gradle: convert gradle-wrapper.properties into a real generated
file
.
Mike Percy has posted comments on this change.
Change subject: gradle: convert gradle-wrapper.properties into a real generated
file
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7927
To unsub
Mike Percy has posted comments on this change.
Change subject: gradle: convert gradle-wrapper.properties into a real generated
file
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7927/2/LICENSE.txt
File LICE
Mike Percy has posted comments on this change.
Change subject: gradle: convert gradle-wrapper.properties into a real generated
file
..
Patch Set 2: -Code-Review
--
To view, visit http://gerrit.cloudera.org:8080/7927
To unsubs
Alexey Serbin has posted comments on this change.
Change subject: [doc] add info about the iwyu target
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7928/1/README.adoc
File README.adoc:
PS1, Line 267: consi
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7928
to look at the new patch set (#2).
Change subject: [doc] add info about the iwyu target
..
[doc] add info about the
Alexey Serbin has posted comments on this change.
Change subject: gradle: convert gradle-wrapper.properties into a real generated
file
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7927/2/java/gradlew
File j
Mike Percy has submitted this change and it was merged.
Change subject: Add "make tidy" target
..
Add "make tidy" target
This adds a simple cmake target to run a local clang-tidy check, instead
of having to come up with the inc
Mike Percy has posted comments on this change.
Change subject: [doc] add info about the iwyu target
..
Patch Set 2:
(2 comments)
Sorry, you will need to manually rebase after I merged my "make tidy" patch
http://gerrit.cloude
Mike Percy has posted comments on this change.
Change subject: [doc] add info about the iwyu target
..
Patch Set 3:
Oh, what do you know, automatic rebase worked...
--
To view, visit http://gerrit.cloudera.org:8080/7928
To un
Mike Percy has posted comments on this change.
Change subject: [doc] add info about the iwyu target
..
Patch Set 3: Code-Review+2
I thought you had to manually rebase but my previous nits weren't very
important, so LGTM
--
T
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7928
to look at the new patch set (#4).
Change subject: [doc] add info about the iwyu target
..
[doc] add in
Alexey Serbin has posted comments on this change.
Change subject: [doc] add info about the iwyu target
..
Patch Set 4:
> (2 comments)
>
> Sorry, you will need to manually rebase after I merged my "make
> tidy" patch
That's
Alexey Serbin has posted comments on this change.
Change subject: [doc] add info about the iwyu target
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7928/2/README.adoc
File README.adoc:
PS2, Line 264:
> m
Hello Mike Percy, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7928
to look at the new patch set (#5).
Change subject: [doc] add info about the iwyu target
..
[doc] add in
Dan Burkert has posted comments on this change.
Change subject: master: always use smart pointers when accessing TableInfo and
TabletInfo
..
Patch Set 3:
(1 comment)
A bunch of the s/push_back/emplace_back calls aren't really
Hello Dan Burkert, Grant Henke, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7927
to look at the new patch set (#3).
Change subject: gradle: convert the rest of the gradle wrapper into generated
files
..
Adar Dembo has posted comments on this change.
Change subject: [doc] add info about the iwyu target
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7928
To unsubscribe, visit http://gerrit.cloud
Mike Percy has posted comments on this change.
Change subject: [doc] add info about the iwyu target
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7928
To unsubscribe, visit http://gerrit.cloud
Dan Burkert has posted comments on this change.
Change subject: gradle: convert the rest of the gradle wrapper into generated
files
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7927
To unsub
Grant Henke has posted comments on this change.
Change subject: gradle: convert the rest of the gradle wrapper into generated
files
..
Patch Set 3: Code-Review+1
I think this is okay for this release since the gradle build is
Mike Percy has posted comments on this change.
Change subject: gradle: convert the rest of the gradle wrapper into generated
files
..
Patch Set 3: Code-Review+1
(1 comment)
looks good, just a comment nit
http://gerrit.cloude
Adar Dembo has posted comments on this change.
Change subject: master: always use smart pointers when accessing TableInfo and
TabletInfo
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7909/3/src/kudu/master/s
Adar Dembo has submitted this change and it was merged.
Change subject: master: always use smart pointers when accessing TableInfo and
TabletInfo
..
master: always use smart pointers when accessing TableInfo and TabletInfo
Mix
Adar Dembo has posted comments on this change.
Change subject: gradle: convert the rest of the gradle wrapper into generated
files
..
Patch Set 3:
> I think this is okay for this release since the gradle build is
> experiment
Adar Dembo has posted comments on this change.
Change subject: gradle: convert the rest of the gradle wrapper into generated
files
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7927/3/java/gradlew
File java/
Mike Percy has submitted this change and it was merged.
Change subject: [doc] add info about the iwyu target
..
[doc] add info about the iwyu target
Added information about the cmake-generated target to run IWYU
against the upd
Mike Percy has posted comments on this change.
Change subject: [doc] add info about the iwyu target
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7928
To unsubscribe, visit http://gerrit.cloudera
Hello Dan Burkert, Mike Percy, Grant Henke, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7927
to look at the new patch set (#4).
Change subject: gradle: convert the rest of the gradle wrapper into generated
files
..
Mike Percy has posted comments on this change.
Change subject: KUDU-2124. Don't hold session lock while initializing a
TabletCopySession
..
Patch Set 2:
> > Having such a session id design is more about de-duplicating
> > beg
Mike Percy has posted comments on this change.
Change subject: gradle: convert the rest of the gradle wrapper into generated
files
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7927
To unsubs
1 - 100 of 113 matches
Mail list logo