[kudu-CR] Add "make tidy" target

Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/7917 Change subject: Add "make tidy" target .. Add "make tidy" target This adds a simple cmake target to run a local clang-tidy check, instead o

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7919 to review the following change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession

[kudu-CR] Implement a lock table

Hello Dan Burkert, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7918 to review the following change. Change subject: Implement a lock table .. Implement a lock table This loc

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

Hello Andrew Wong, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7914 to look at the new patch set (#5). Change subject: docs: light editing on 1.5 release notes; spark security docs ...

[kudu-CR] KUDU-2078: Sink failure if batch size > session's flush buffer size

Will Berkeley has posted comments on this change. Change subject: KUDU-2078: Sink failure if batch size > session's flush buffer size .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7641/1/java/kudu-flume-sink

[kudu-CR] KUDU-2078: Sink failure if batch size > session's flush buffer size

Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7641 to look at the new patch set (#2). Change subject: KUDU-2078: Sink failure if batch size > session's flush buffer size

[kudu-CR] Implement a lock table

Dan Burkert has posted comments on this change. Change subject: Implement a lock table .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7918/1/src/kudu/util/lock_table.h File src/kudu/util/lock_table.h: Line 42

[kudu-CR] KUDU-2078: Sink failure if batch size > session's flush buffer size

Mike Percy has posted comments on this change. Change subject: KUDU-2078: Sink failure if batch size > session's flush buffer size .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7641 To unsubs

[kudu-CR] KUDU-2078: Sink failure if batch size > session's flush buffer size

Mike Percy has submitted this change and it was merged. Change subject: KUDU-2078: Sink failure if batch size > session's flush buffer size .. KUDU-2078: Sink failure if batch size > session's flush buffer size The Flume sink

[kudu-CR](branch-1.5.x) KUDU-2078: Sink failure if batch size > session's flush buffer size

Hello Dan Burkert, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7921 to review the following change. Change subject: KUDU-2078: Sink failure if batch size > session's flush buffer size

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

Alexey Serbin has posted comments on this change. Change subject: docs: light editing on 1.5 release notes; spark security docs .. Patch Set 5: (4 comments) A few other things which might worth mentioning. http://gerrit.cloud

[kudu-CR] Implement a lock table

Mike Percy has posted comments on this change. Change subject: Implement a lock table .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7918/1/src/kudu/util/lock_table.h File src/kudu/util/lock_table.h: Line 42:

[kudu-CR](branch-1.5.x) KUDU-2078: Sink failure if batch size > session's flush buffer size

Dan Burkert has posted comments on this change. Change subject: KUDU-2078: Sink failure if batch size > session's flush buffer size .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7921 To unsub

[kudu-CR] Implement a lock table

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7918 to look at the new patch set (#2). Change subject: Implement a lock table .. Implement a lock table This lock tabl

[kudu-CR](branch-1.5.x) KUDU-2078: Sink failure if batch size > session's flush buffer size

Mike Percy has submitted this change and it was merged. Change subject: KUDU-2078: Sink failure if batch size > session's flush buffer size .. KUDU-2078: Sink failure if batch size > session's flush buffer size The Flume sink

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

Hello Andrew Wong, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7914 to look at the new patch set (#6). Change subject: docs: light editing on 1.5 release notes; spark security docs ...

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

Dan Burkert has posted comments on this change. Change subject: docs: light editing on 1.5 release notes; spark security docs .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7914/5/docs/release_notes.adoc File

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

Alexey Serbin has posted comments on this change. Change subject: docs: light editing on 1.5 release notes; spark security docs .. Patch Set 6: Code-Review+2 (1 comment) LGTM. You might want to get more feedback from Adar and

[kudu-CR] Implement a lock table

Dan Burkert has posted comments on this change. Change subject: Implement a lock table .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7918 To unsubscribe, visit http://gerrit.cloudera.org:8080/

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

Hao Hao has posted comments on this change. Change subject: docs: light editing on 1.5 release notes; spark security docs .. Patch Set 6: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7914/6/docs/release_notes.

[kudu-CR] Add "make tidy" target

Alexey Serbin has posted comments on this change. Change subject: Add "make tidy" target .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7917 To unsubscribe, visit http://gerrit.cloudera.org:808

[kudu-CR] Add "make tidy" target

Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7917 to look at the new patch set (#2). Change subject: Add "make tidy" target .. Add "make tidy" target

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

Hello Hao Hao, Andrew Wong, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7914 to look at the new patch set (#7). Change subject: docs: light editing on 1.5 release notes; spark security docs ..

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

Dan Burkert has posted comments on this change. Change subject: docs: light editing on 1.5 release notes; spark security docs .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7914/6/docs/release_notes.adoc File

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

Andrew Wong has posted comments on this change. Change subject: docs: light editing on 1.5 release notes; spark security docs .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/7914/6/docs/release_notes.adoc File

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

Adar Dembo has posted comments on this change. Change subject: docs: light editing on 1.5 release notes; spark security docs .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7914 To unsubscribe,

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

Dan Burkert has posted comments on this change. Change subject: docs: light editing on 1.5 release notes; spark security docs .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/7914/6/docs/release_notes.adoc File

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

Hello Hao Hao, Andrew Wong, Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7914 to look at the new patch set (#8). Change subject: docs: light editing on 1.5 release notes; spark security docs ..

[kudu-CR](branch-1.5.x) docs: light editing on 1.5 release notes; spark security docs

Dan Burkert has posted comments on this change. Change subject: docs: light editing on 1.5 release notes; spark security docs .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7924 To u

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

Dan Burkert has submitted this change and it was merged. Change subject: docs: light editing on 1.5 release notes; spark security docs .. docs: light editing on 1.5 release notes; spark security docs Change-Id: I49014dda6fcec32

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

Dan Burkert has posted comments on this change. Change subject: docs: light editing on 1.5 release notes; spark security docs .. Patch Set 8: Code-Review+2 Carrying over Alexey and Adar's +2 -- To view, visit http://gerrit.cl

[kudu-CR] docs: light editing on 1.5 release notes; spark security docs

Dan Burkert has posted comments on this change. Change subject: docs: light editing on 1.5 release notes; spark security docs .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7914 To unsubscribe, vi

[kudu-CR](branch-1.5.x) docs: light editing on 1.5 release notes; spark security docs

Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/7924 Change subject: docs: light editing on 1.5 release notes; spark security docs .. docs: light editing on 1.5 release notes; spark security d

[kudu-CR](branch-1.5.x) docs: light editing on 1.5 release notes; spark security docs

Dan Burkert has submitted this change and it was merged. Change subject: docs: light editing on 1.5 release notes; spark security docs .. docs: light editing on 1.5 release notes; spark security docs Change-Id: I49014dda6fcec32

[kudu-CR] Add "make tidy" target

Adar Dembo has posted comments on this change. Change subject: Add "make tidy" target .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7917/2/CMakeLists.txt File CMakeLists.txt: Line 1117: add_custom_target(

[kudu-CR] Implement a lock table

Mike Percy has posted comments on this change. Change subject: Implement a lock table .. Patch Set 2: Verified+1 Overriding unrelated flaky test failure of RaftConsensusITest.TestReplicaBehaviorViaRPC -- To view, visit http:

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

Adar Dembo has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 1: I'd like to better understand the concurrency model here. The tablet cop

[kudu-CR] Add "make tidy" target

Alexey Serbin has posted comments on this change. Change subject: Add "make tidy" target .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7917/2/CMakeLists.txt File CMakeLists.txt: Line 1118: add_dependencie

[kudu-CR] KUDU-2055: Coalesce hole punching when deleting groups of blocks

Adar Dembo has posted comments on this change. Change subject: KUDU-2055: Coalesce hole punching when deleting groups of blocks .. Patch Set 3: I'd like to avoid the mega-review that we had for the other patch by carving this

[kudu-CR] KUDU-2055: Coalesce hole punching when deleting groups of blocks

Hao Hao has posted comments on this change. Change subject: KUDU-2055: Coalesce hole punching when deleting groups of blocks .. Patch Set 3: > I'd like to avoid the mega-review that we had for the other patch > by carving this

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7919 to look at the new patch set (#2). Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession ..

[kudu-CR] Fix RAT warnings

Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7925 to review the following change. Change subject: Fix RAT warnings .. Fix RAT warnings Change-Id: I0260ce9ce08790d3c6004

[kudu-CR] feat: add the wrapper for the Iterator by using InterruptibleIterator

Dan Burkert has posted comments on this change. Change subject: feat: add the wrapper for the Iterator by using InterruptibleIterator .. Patch Set 2: My only hesitation with TaskKilledException is that it's a developer API, so

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

Mike Percy has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 2: > I'd like to better understand the concurrency model here. > > The ta

[kudu-CR] Add "make tidy" target

Mike Percy has posted comments on this change. Change subject: Add "make tidy" target .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7917/2/CMakeLists.txt File CMakeLists.txt: Line 1117: add_custom_target(

[kudu-CR] Add "make tidy" target

Alexey Serbin has posted comments on this change. Change subject: Add "make tidy" target .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7917/2/README.adoc File README.adoc: Line 263: === Running

[kudu-CR] Add "make tidy" target

Alexey Serbin has posted comments on this change. Change subject: Add "make tidy" target .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7917 To unsubscribe, visit http://gerrit.cloudera.org:808

[kudu-CR] KUDU-2098. Drop Spark 1 Support

Dan Burkert has posted comments on this change. Change subject: KUDU-2098. Drop Spark 1 Support .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7690/2//COMMIT_MSG Commit Message: Line 9: Spark 2 has been avai

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

Adar Dembo has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 2: > Having such a session id design is more about de-duplicating > begin-s

[kudu-CR] master: always use smart pointers when accessing TableInfo and TabletInfo

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7909 to look at the new patch set (#3). Change subject: master: always use smart pointers when accessing TableInfo and TabletInfo ..

[kudu-CR] master: always use smart pointers when accessing TableInfo and TabletInfo

Adar Dembo has posted comments on this change. Change subject: master: always use smart pointers when accessing TableInfo and TabletInfo .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7909/2/src/kudu/master/

[kudu-CR] Fix RAT complaints in gradle properties files

Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7926 to review the following change. Change subject: Fix RAT complaints in gradle properties files .. Fix RAT complaints in

[kudu-CR] Fix RAT warnings

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7925 to look at the new patch set (#2). Change subject: Fix RAT warnings .. Fix RAT warnings Change-Id: I0260ce9ce08790

[kudu-CR] Fix RAT warnings

Mike Percy has posted comments on this change. Change subject: Fix RAT warnings .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7925/1/build-support/release/rat_exclude_files.txt File build-support/release/rat

[kudu-CR] Fix RAT warnings

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7925 to look at the new patch set (#3). Change subject: Fix RAT warnings .. Fix RAT warnings Change-Id: I0260ce9ce08790

[kudu-CR] Fix RAT warnings

Mike Percy has posted comments on this change. Change subject: Fix RAT warnings .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7925/2/build-support/release/rat_exclude_files.txt File build-support/release/rat

[kudu-CR] Fix RAT warnings

Mike Percy has posted comments on this change. Change subject: Fix RAT warnings .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7925/3/java/gradle/wrapper/gradle-wrapper.properties File java/gradle/wrapper/grad

[kudu-CR] Fix RAT warnings

Mike Percy has posted comments on this change. Change subject: Fix RAT warnings .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7925/1/build-support/release/rat_exclude_files.txt File build-support/release/rat_

[kudu-CR] Fix RAT complaints in gradle properties files

Mike Percy has abandoned this change. Change subject: Fix RAT complaints in gradle properties files .. Abandoned Dan has an uber patch that he is rolling all of these changes into -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] Fix RAT warnings

Grant Henke has posted comments on this change. Change subject: Fix RAT warnings .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7925/3/java/gradle/wrapper/gradle-wrapper.properties File java/gradle/wrapper/gra

[kudu-CR] gradle: convert gradle-wrapper.properties into a real generated file

Hello Dan Burkert, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7927 to review the following change. Change subject: gradle: convert gradle-wrapper.properties into a real generated file

[kudu-CR] gradle: convert gradle-wrapper.properties into a real generated file

Dan Burkert has posted comments on this change. Change subject: gradle: convert gradle-wrapper.properties into a real generated file .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7927 To unsu

[kudu-CR] gradle: convert gradle-wrapper.properties into a real generated file

Mike Percy has posted comments on this change. Change subject: gradle: convert gradle-wrapper.properties into a real generated file .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7927/1/java/gradlew File java

[kudu-CR] [doc] add info about the iwyu target

Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7928 Change subject: [doc] add info about the iwyu target .. [doc] add info about the iwyu target Added information about the cmake-generated

[kudu-CR] master: always use smart pointers when accessing TableInfo and TabletInfo

Adar Dembo has posted comments on this change. Change subject: master: always use smart pointers when accessing TableInfo and TabletInfo .. Patch Set 3: Verified+1 There were two TSAN failures. One was KUDU-2059. The other was

[kudu-CR] master: always use smart pointers when accessing TableInfo and TabletInfo

Alexey Serbin has posted comments on this change. Change subject: master: always use smart pointers when accessing TableInfo and TabletInfo .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7909

[kudu-CR] [doc] add info about the iwyu target

Adar Dembo has posted comments on this change. Change subject: [doc] add info about the iwyu target .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7928/1/README.adoc File README.adoc: PS1, Line 267: consiste

[kudu-CR] gradle: convert gradle-wrapper.properties into a real generated file

Adar Dembo has posted comments on this change. Change subject: gradle: convert gradle-wrapper.properties into a real generated file .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7927/1/java/gradlew File java

[kudu-CR] gradle: convert gradle-wrapper.properties into a real generated file

Grant Henke has posted comments on this change. Change subject: gradle: convert gradle-wrapper.properties into a real generated file .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7927 To unsu

[kudu-CR] gradle: convert gradle-wrapper.properties into a real generated file

Hello Dan Burkert, Grant Henke, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7927 to look at the new patch set (#2). Change subject: gradle: convert gradle-wrapper.properties into a real generated file .

[kudu-CR] gradle: convert gradle-wrapper.properties into a real generated file

Mike Percy has posted comments on this change. Change subject: gradle: convert gradle-wrapper.properties into a real generated file .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7927 To unsub

[kudu-CR] gradle: convert gradle-wrapper.properties into a real generated file

Mike Percy has posted comments on this change. Change subject: gradle: convert gradle-wrapper.properties into a real generated file .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7927/2/LICENSE.txt File LICE

[kudu-CR] gradle: convert gradle-wrapper.properties into a real generated file

Mike Percy has posted comments on this change. Change subject: gradle: convert gradle-wrapper.properties into a real generated file .. Patch Set 2: -Code-Review -- To view, visit http://gerrit.cloudera.org:8080/7927 To unsubs

[kudu-CR] [doc] add info about the iwyu target

Alexey Serbin has posted comments on this change. Change subject: [doc] add info about the iwyu target .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7928/1/README.adoc File README.adoc: PS1, Line 267: consi

[kudu-CR] [doc] add info about the iwyu target

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7928 to look at the new patch set (#2). Change subject: [doc] add info about the iwyu target .. [doc] add info about the

[kudu-CR] gradle: convert gradle-wrapper.properties into a real generated file

Alexey Serbin has posted comments on this change. Change subject: gradle: convert gradle-wrapper.properties into a real generated file .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7927/2/java/gradlew File j

[kudu-CR] Add "make tidy" target

Mike Percy has submitted this change and it was merged. Change subject: Add "make tidy" target .. Add "make tidy" target This adds a simple cmake target to run a local clang-tidy check, instead of having to come up with the inc

[kudu-CR] [doc] add info about the iwyu target

Mike Percy has posted comments on this change. Change subject: [doc] add info about the iwyu target .. Patch Set 2: (2 comments) Sorry, you will need to manually rebase after I merged my "make tidy" patch http://gerrit.cloude

[kudu-CR] [doc] add info about the iwyu target

Mike Percy has posted comments on this change. Change subject: [doc] add info about the iwyu target .. Patch Set 3: Oh, what do you know, automatic rebase worked... -- To view, visit http://gerrit.cloudera.org:8080/7928 To un

[kudu-CR] [doc] add info about the iwyu target

Mike Percy has posted comments on this change. Change subject: [doc] add info about the iwyu target .. Patch Set 3: Code-Review+2 I thought you had to manually rebase but my previous nits weren't very important, so LGTM -- T

[kudu-CR] [doc] add info about the iwyu target

Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7928 to look at the new patch set (#4). Change subject: [doc] add info about the iwyu target .. [doc] add in

[kudu-CR] [doc] add info about the iwyu target

Alexey Serbin has posted comments on this change. Change subject: [doc] add info about the iwyu target .. Patch Set 4: > (2 comments) > > Sorry, you will need to manually rebase after I merged my "make > tidy" patch That's

[kudu-CR] [doc] add info about the iwyu target

Alexey Serbin has posted comments on this change. Change subject: [doc] add info about the iwyu target .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7928/2/README.adoc File README.adoc: PS2, Line 264: > m

[kudu-CR] [doc] add info about the iwyu target

Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7928 to look at the new patch set (#5). Change subject: [doc] add info about the iwyu target .. [doc] add in

[kudu-CR] master: always use smart pointers when accessing TableInfo and TabletInfo

Dan Burkert has posted comments on this change. Change subject: master: always use smart pointers when accessing TableInfo and TabletInfo .. Patch Set 3: (1 comment) A bunch of the s/push_back/emplace_back calls aren't really

[kudu-CR] gradle: convert the rest of the gradle wrapper into generated files

Hello Dan Burkert, Grant Henke, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7927 to look at the new patch set (#3). Change subject: gradle: convert the rest of the gradle wrapper into generated files ..

[kudu-CR] [doc] add info about the iwyu target

Adar Dembo has posted comments on this change. Change subject: [doc] add info about the iwyu target .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7928 To unsubscribe, visit http://gerrit.cloud

[kudu-CR] [doc] add info about the iwyu target

Mike Percy has posted comments on this change. Change subject: [doc] add info about the iwyu target .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7928 To unsubscribe, visit http://gerrit.cloud

[kudu-CR] gradle: convert the rest of the gradle wrapper into generated files

Dan Burkert has posted comments on this change. Change subject: gradle: convert the rest of the gradle wrapper into generated files .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7927 To unsub

[kudu-CR] gradle: convert the rest of the gradle wrapper into generated files

Grant Henke has posted comments on this change. Change subject: gradle: convert the rest of the gradle wrapper into generated files .. Patch Set 3: Code-Review+1 I think this is okay for this release since the gradle build is

[kudu-CR] gradle: convert the rest of the gradle wrapper into generated files

Mike Percy has posted comments on this change. Change subject: gradle: convert the rest of the gradle wrapper into generated files .. Patch Set 3: Code-Review+1 (1 comment) looks good, just a comment nit http://gerrit.cloude

[kudu-CR] master: always use smart pointers when accessing TableInfo and TabletInfo

Adar Dembo has posted comments on this change. Change subject: master: always use smart pointers when accessing TableInfo and TabletInfo .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7909/3/src/kudu/master/s

[kudu-CR] master: always use smart pointers when accessing TableInfo and TabletInfo

Adar Dembo has submitted this change and it was merged. Change subject: master: always use smart pointers when accessing TableInfo and TabletInfo .. master: always use smart pointers when accessing TableInfo and TabletInfo Mix

[kudu-CR] gradle: convert the rest of the gradle wrapper into generated files

Adar Dembo has posted comments on this change. Change subject: gradle: convert the rest of the gradle wrapper into generated files .. Patch Set 3: > I think this is okay for this release since the gradle build is > experiment

[kudu-CR] gradle: convert the rest of the gradle wrapper into generated files

Adar Dembo has posted comments on this change. Change subject: gradle: convert the rest of the gradle wrapper into generated files .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7927/3/java/gradlew File java/

[kudu-CR] [doc] add info about the iwyu target

Mike Percy has submitted this change and it was merged. Change subject: [doc] add info about the iwyu target .. [doc] add info about the iwyu target Added information about the cmake-generated target to run IWYU against the upd

[kudu-CR] [doc] add info about the iwyu target

Mike Percy has posted comments on this change. Change subject: [doc] add info about the iwyu target .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7928 To unsubscribe, visit http://gerrit.cloudera

[kudu-CR] gradle: convert the rest of the gradle wrapper into generated files

Hello Dan Burkert, Mike Percy, Grant Henke, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7927 to look at the new patch set (#4). Change subject: gradle: convert the rest of the gradle wrapper into generated files ..

[kudu-CR] KUDU-2124. Don't hold session lock while initializing a TabletCopySession

Mike Percy has posted comments on this change. Change subject: KUDU-2124. Don't hold session lock while initializing a TabletCopySession .. Patch Set 2: > > Having such a session id design is more about de-duplicating > > beg

[kudu-CR] gradle: convert the rest of the gradle wrapper into generated files

Mike Percy has posted comments on this change. Change subject: gradle: convert the rest of the gradle wrapper into generated files .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7927 To unsubs

  1   2   >