[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 72: Code-Review+2 (4 comments) Please address one nit a

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-29 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test when using 64k container block alignment .. Patch Set 15: Code-Review+2 (1 comment)

[kudu-CR] [rpc] validate security-related parameters earlier

2024-01-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20961 Change subject: [rpc] validate security-related parameters earlier .. [rpc] validate security-related parameters earlier This patch mov

[kudu-CR] KUDU-3527 Fix block manager test when using 64k container block alignment

2024-01-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test when using 64k container block alignment .. Patch Set 14: Code-Review+1 (9 comments)

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20908 ) Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .. [rpc] introduce rpc_listened_socket_rx_queue_size m

[kudu-CR](branch-1.17.x) Fix CheckHolePunch for bigger than 4k blocks.

2024-01-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20930 ) Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Fix CheckHolePunch for bigger than 4k blocks. With the new 64

[kudu-CR] [rpc] introduce rpc pending connections metric

2024-01-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [rpc] introduce rpc_pending_connections metric .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20949 To unsubscribe,

[kudu-CR] [rpc] introduce rpc pending connections metric

2024-01-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20949 ) Change subject: [rpc] introduce rpc_pending_connections metric .. Patch Set 2: Verified+1 unrelated test failure in Java test (TSAN)

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20908 To uns

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20908 ) Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .. Patch Set 5: Verified+1 unrelated test failure in RaftCons

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-24 Thread Alexey Serbin (Code Review)
Hello Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20908 to look at the new patch set (#5). Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric ..

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20908 ) Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-24 Thread Alexey Serbin (Code Review)
Hello Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20908 to look at the new patch set (#4). Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric ..

[kudu-CR] [rpc] introduce rpc pending connections metric

2024-01-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20949 Change subject: [rpc] introduce rpc_pending_connections metric .. [rpc] introduce rpc_pending_connections metric One of the prior patch

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-23 Thread Alexey Serbin (Code Review)
Hello Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, Wang Xixu, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20908 to look at the new patch set (#3). Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric ..

[kudu-CR] [docs] Expand master add argument list

2024-01-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20940 ) Change subject: [docs] Expand master add argument list .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20940/1//COMMI

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20908 ) Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/

[kudu-CR] [net] DiagnosticSocket wrapper for sock diag API

2024-01-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20892 ) Change subject: [net] DiagnosticSocket wrapper for sock_diag API .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2089

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-22 Thread Alexey Serbin (Code Review)
Hello Yingchun Lai, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20908 to look at the new patch set (#2). Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .

[kudu-CR](branch-1.17.x) Fix CheckHolePunch for bigger than 4k blocks.

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20930 To unsubscribe, v

[kudu-CR](branch-1.17.x) Fix CheckHolePunch for bigger than 4k blocks.

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20930 ) Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Patch Set 1: Verified+1 unrelated test failure in MasterMigrationTest

[kudu-CR] KUDU-3527 Fix block manager test on 64k filesystems

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test on 64k filesystems .. Patch Set 7: (9 comments) Overall looks good to me, but I thin

[kudu-CR](branch-1.17.x) Fix CheckHolePunch for bigger than 4k blocks.

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20930 Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Fix CheckHolePunch for bigger than 4k blocks. With the new 64k ARM cor

[kudu-CR] Fix CheckHolePunch for bigger than 4k blocks.

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20894 ) Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Patch Set 5: Code-Review+2 Thank you for the fix! I verified it work

[kudu-CR] Fix CheckHolePunch for bigger than 4k blocks.

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20894 ) Change subject: Fix CheckHolePunch for bigger than 4k blocks. .. Fix CheckHolePunch for bigger than 4k blocks. With the new 64

[kudu-CR] KUDU-3527 Fix block manager test on 64k filesystems

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20725 ) Change subject: KUDU-3527 Fix block manager test on 64k filesystems .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/2

[kudu-CR](branch-1.17.x) KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR](branch-1.17.x) KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20923 ) Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. Patch Set 1: Verified+1 unrelated test failure

[kudu-CR] Fix typos

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20927 ) Change subject: Fix typos .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20927 To unsubscribe, visit

[kudu-CR] Fix typos

2024-01-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20927 ) Change subject: Fix typos .. Fix typos Change-Id: I71524db97455bb27db44b5820cbe81fd95e207d9 Reviewed-on: http://gerrit.clouder

[kudu-CR](branch-1.17.x) KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20923 Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. KUDU-3526 [java] Scanner should bind with a tser

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20715 ) Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. KUDU-3526 [java] Scanner should bind wi

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20715 ) Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. Patch Set 28: Code-Review+2 (3 comments) Than

[kudu-CR](branch-1.17.x) KUDU-3491 Destruct master before creating a new one

2024-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3491 Destruct master before creating a new one .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20917 To unsubscr

[kudu-CR](branch-1.17.x) KUDU-3491 Destruct master before creating a new one

2024-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20917 ) Change subject: KUDU-3491 Destruct master before creating a new one .. Patch Set 1: Verified+1 unrelated CI pipeline failure: Could no

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20908 To uns

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20908 ) Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .. Patch Set 1: Verified+1 unrelated test failures in a Java

[kudu-CR] [net] DiagnosticSocket wrapper for sock diag API

2024-01-18 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20892 ) Change subject: [net] DiagnosticSocket wrapper for sock_diag API .. [net] DiagnosticSocket wrapper for sock_diag API This patc

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 71: (74 comments) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR](branch-1.17.x) KUDU-3491 Destruct master before creating a new one

2024-01-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20917 Change subject: KUDU-3491 Destruct master before creating a new one .. KUDU-3491 Destruct master before creating a new one ServerBase c

[kudu-CR] [net] DiagnosticSocket wrapper for sock diag API

2024-01-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [net] DiagnosticSocket wrapper for sock_diag API .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20892 To unsubscribe

[kudu-CR] [net] DiagnosticSocket wrapper for sock diag API

2024-01-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20892 ) Change subject: [net] DiagnosticSocket wrapper for sock_diag API .. Patch Set 3: Verified+1 unrelated CI pipeline failure (TSAN): Coul

[kudu-CR] [net] DiagnosticSocket wrapper for sock diag API

2024-01-16 Thread Alexey Serbin (Code Review)
Hello Yingchun Lai, Attila Bukor, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20892 to look at the new patch set (#3). Change subject: [net] DiagnosticSocket wrapper for sock_diag API

[kudu-CR] [rpc] introduce rpc listened socket rx queue size metric

2024-01-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20908 Change subject: [rpc] introduce rpc_listened_socket_rx_queue_size metric .. [rpc] introduce rpc_listened_socket_rx_queue_size metric Th

[kudu-CR] [net] DiagnosticSocket wrapper for sock diag API

2024-01-16 Thread Alexey Serbin (Code Review)
Hello Yingchun Lai, Attila Bukor, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20892 to look at the new patch set (#2). Change subject: [net] DiagnosticSocket wrapper for sock_diag API

[kudu-CR] [net] DiagnosticSocket wrapper for sock diag API

2024-01-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20892 ) Change subject: [net] DiagnosticSocket wrapper for sock_diag API .. Patch Set 1: (5 comments) Thank you for feedback! http://gerrit.

[kudu-CR] [net] DiagnosticSocket wrapper for sock diag API

2024-01-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20892 Change subject: [net] DiagnosticSocket wrapper for sock_diag API .. [net] DiagnosticSocket wrapper for sock_diag API This patch introdu

[kudu-CR] [net] remove unused Socket::GetSockError() method

2024-01-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20888 ) Change subject: [net] remove unused Socket::GetSockError() method .. [net] remove unused Socket::GetSockError() method Change-

[kudu-CR] [net] remove unused Socket::GetSockError() method

2024-01-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [net] remove unused Socket::GetSockError() method .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20888 To unsubscrib

[kudu-CR] [net] remove unused Socket::GetSockError() method

2024-01-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20888 ) Change subject: [net] remove unused Socket::GetSockError() method .. Patch Set 1: Verified+1 unrelated test failures in HmsConfigurat

[kudu-CR] [net] remove unused Socket::GetSockError() method

2024-01-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20888 Change subject: [net] remove unused Socket::GetSockError() method .. [net] remove unused Socket::GetSockError() method Change-Id: I7459

[kudu-CR] WIP [util] RX and TX queue size for listened socket

2024-01-10 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20878 to look at the new patch set (#2). Change subject: WIP [util] RX and TX queue size for listened socket ..

[kudu-CR] WIP [util] RX and TX queue size for listened socket

2024-01-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20878 Change subject: WIP [util] RX and TX queue size for listened socket .. WIP [util] RX and TX queue size for listened socket Socket::GetS

[kudu-CR] KUDU-3543 Fix Content-Type headers

2024-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20868 ) Change subject: KUDU-3543 Fix Content-Type headers .. Patch Set 3: (12 comments) http://gerrit.cloudera.org:8080/#/c/20868/3//COMMIT_

[kudu-CR] Use GTEST SKIP() to skip tests

2024-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20875 ) Change subject: Use GTEST_SKIP() to skip tests .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20875

[kudu-CR] Use GTEST SKIP() to skip tests

2024-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20875 ) Change subject: Use GTEST_SKIP() to skip tests .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/20875

[kudu-CR] Add CLion build directories to .gitignore

2024-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20873 ) Change subject: Add CLion build directories to .gitignore .. Add CLion build directories to .gitignore Change-Id: If1770e53e8a

[kudu-CR] Add CLion build directories to .gitignore

2024-01-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20873 ) Change subject: Add CLion build directories to .gitignore .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:

[kudu-CR] KUDU-3543 Fix Content-Type headers

2024-01-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20868 ) Change subject: KUDU-3543 Fix Content-Type headers .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20868/2//COMMIT_M

[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20861 ) Change subject: KUDU-3532: Follow up to replica placement bug .. Patch Set 2: Verified+1 unrelated test failures -- To view, visit h

[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20861 ) Change subject: KUDU-3532: Follow up to replica placement bug .. KUDU-3532: Follow up to replica placement bug This patch addr

[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: KUDU-3532: Follow up to replica placement bug .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20861 To unsubscribe, v

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 62: (16 comments) Thank you for revving the patch! Ove

[kudu-CR](branch-1.17.x) [java] fix NPE in Connection::exceptionCaught()

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [java] fix NPE in Connection::exceptionCaught() .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/20865 To unsubscribe,

[kudu-CR](branch-1.17.x) [java] fix NPE in Connection::exceptionCaught()

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20865 ) Change subject: [java] fix NPE in Connection::exceptionCaught() .. Patch Set 1: Verified+1 unrelated failures in C++ tests (ASAN) --

[kudu-CR](branch-1.17.x) KUDU-3532: Follow up to replica placement bug

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20861 ) Change subject: KUDU-3532: Follow up to replica placement bug .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:

[kudu-CR] [compaction/flush] Cleanup of compaction and flush code paths

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20720 ) Change subject: [compaction/flush] Cleanup of compaction and flush code paths .. Patch Set 7: (1 comment) > > Patch Set 7: Code-Revie

[kudu-CR] [compaction/test] Add tests to generate heavy rowset compaction

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20816 ) Change subject: [compaction/test] Add tests to generate heavy rowset compaction .. Patch Set 6: (12 comments) http://gerrit.cloudera.

[kudu-CR] [compaction] Add memory estimation unit test

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20787 ) Change subject: [compaction] Add memory estimation unit test .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/20787/6/

[kudu-CR](branch-1.17.x) [java] fix NPE in Connection::exceptionCaught()

2024-01-05 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20865 Change subject: [java] fix NPE in Connection::exceptionCaught() .. [java] fix NPE in Connection::exceptionCaught() Before this patch, a

[kudu-CR] KUDU-3252: Follow up to replica placement bug

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20827 ) Change subject: KUDU-3252: Follow up to replica placement bug .. KUDU-3252: Follow up to replica placement bug This patch addr

[kudu-CR] KUDU-3252: Follow up to replica placement bug

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20827 ) Change subject: KUDU-3252: Follow up to replica placement bug .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.

[kudu-CR] KUDU-3252: Follow up to replica placement bug

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20827 ) Change subject: KUDU-3252: Follow up to replica placement bug .. Patch Set 2: Verified+1 unrelated test failures -- To view, visit h

[kudu-CR] [docs] updated info on the C++ standard used in Kudu code

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20859 Change subject: [docs] updated info on the C++ standard used in Kudu code .. [docs] updated info on the C++ standard used in Kudu code

[kudu-CR] [java] add sequenceId into the tracked RPCs' trace

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20857 ) Change subject: [java] add sequenceId into the tracked RPCs' trace .. [java] add sequenceId into the tracked RPCs' trace This

[kudu-CR] [java] fix NPE in Connection::exceptionCaught()

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20858 Change subject: [java] fix NPE in Connection::exceptionCaught() .. [java] fix NPE in Connection::exceptionCaught() Before this patch, a

[kudu-CR] [java] add sequenceId into the tracked RPCs' trace

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20857 Change subject: [java] add sequenceId into the tracked RPCs' trace .. [java] add sequenceId into the tracked RPCs' trace This patch add

[kudu-CR] Do not enter ALTERING state just for replication factor changed.

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20830 ) Change subject: Do not enter ALTERING state just for replication factor changed. .. Do not enter ALTERING state just for replic

[kudu-CR] Do not enter ALTERING state just for replication factor changed.

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20830 ) Change subject: Do not enter ALTERING state just for replication factor changed. .. Patch Set 10: Code-Review+2 (1 comment) Thank you

[kudu-CR] [WIP] Increase AssertEventually timeout to 60 seconds

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20846 ) Change subject: [WIP] Increase AssertEventually timeout to 60 seconds .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/

[kudu-CR] [log] use THROTTLE MSG for KLOG EVERY N SECS when necessary

2024-01-04 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20855 Change subject: [log] use THROTTLE_MSG for KLOG_EVERY_N_SECS when necessary .. [log] use THROTTLE_MSG for KLOG_EVERY_N_SECS when necessa

[kudu-CR] KUDU-3526 [java] Scanner should bind with a tserver in java client.

2024-01-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20715 ) Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. .. Patch Set 19: (13 comments) It seems not many

[kudu-CR] Do not enter ALTERING state just for replication factor changed.

2024-01-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20830 ) Change subject: Do not enter ALTERING state just for replication factor changed. .. Patch Set 6: (2 comments) http://gerrit.cloudera.

[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana

2024-01-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 ) Change subject: Add blog post about Prometheus/Grafana .. Patch Set 1: (3 comments) Thank you for working on a blog post! That's bee

[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana

2024-01-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 ) Change subject: Add blog post about Prometheus/Grafana .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/20814/1/_post

[kudu-CR] [compaction] Add memory estimation unit test

2024-01-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20787 ) Change subject: [compaction] Add memory estimation unit test .. Patch Set 6: (10 comments) http://gerrit.cloudera.org:8080/#/c/20787/

[kudu-CR] Do not enter ALTERING state just for replication factor changed.

2024-01-02 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20830 ) Change subject: Do not enter ALTERING state just for replication factor changed. .. Patch Set 3: Code-Review+1 (5 comments) > (2 comm

[kudu-CR] Do not enter ALTERING state just for replication factor changed.

2023-12-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20830 ) Change subject: Do not enter ALTERING state just for replication factor changed. .. Patch Set 2: (3 comments) http://gerrit.cloudera.

[kudu-CR] KUDU-3252: Follow up to replica placement bug

2023-12-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20827 ) Change subject: KUDU-3252: Follow up to replica placement bug .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/20827/

[kudu-CR] KUDU-3371 [fs] Use RocksDB to store LBM metadata

2023-12-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 ) Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata .. Patch Set 61: (17 comments) http://gerrit.cloudera.org:8080/#/c/1

[kudu-CR] [rpc] extra test scenarios for exactly-once RPC logic

2023-12-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20831 ) Change subject: [rpc] extra test scenarios for exactly-once RPC logic .. Patch Set 1: Verified+1 unrelated test failure in AutoIncreme

[kudu-CR] [rpc] extra test scenarios for exactly-once RPC logic

2023-12-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20831 Change subject: [rpc] extra test scenarios for exactly-once RPC logic .. [rpc] extra test scenarios for exactly-once RPC logic In the c

[kudu-CR] KUDU-3534 [compaction] Log timestamp of two matching DELETE REDO mutations.

2023-12-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20792 ) Change subject: KUDU-3534 [compaction] Log timestamp of two matching DELETE REDO mutations. .. Patch Set 4: Code-Review+2 -- To view

[kudu-CR] KUDU-3534 [compaction] Log timestamp of two matching DELETE REDO mutations.

2023-12-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20792 ) Change subject: KUDU-3534 [compaction] Log timestamp of two matching DELETE REDO mutations. .. KUDU-3534 [compaction] Log time

[kudu-CR] [webserver] add security-related HTTP headers

2023-12-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18253 ) Change subject: [webserver] add security-related HTTP headers .. [webserver] add security-related HTTP headers To please vario

[kudu-CR] [webserver] add security-related HTTP headers

2023-12-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [webserver] add security-related HTTP headers .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/18253 To unsubscribe, v

[kudu-CR] [webserver] add security-related HTTP headers

2023-12-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18253 ) Change subject: [webserver] add security-related HTTP headers .. Patch Set 9: Verified+1 unrelated test failures in: * CatalogManage

[kudu-CR] [util] Add a warning into 'heap sample every n bytes' flag description.

2023-12-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20716 ) Change subject: [util] Add a warning into 'heap_sample_every_n_bytes' flag description. .. [util] Add a warning into 'heap_sam

[kudu-CR] [util] Add a warning into 'heap sample every n bytes' flag description.

2023-12-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20716 ) Change subject: [util] Add a warning into 'heap_sample_every_n_bytes' flag description. .. Patch Set 17: Code-Review+2 (1 comment) h

<    4   5   6   7   8   9   10   11   12   13   >