[kudu-CR] KUDU-2791 p2: add basic protobuf msg

2019-11-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14426 ) Change subject: KUDU-2791 p2: add basic protobuf msg .. Patch Set 2: (1 comment) > Patch Set 2: > > (1 comment) > > > Patch Set 1: > > > >

[kudu-CR] KUDU-2791 p2: add basic protobuf msg

2019-11-18 Thread Hao Hao (Code Review)
Hello Attila Bukor, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14426 to look at the new patch set (#3). Change subject: KUDU-2791 p2: add basic protobuf msg

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-11-18 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14425 ) Change subject: KUDU-2971 p1: add subprocess module .. Patch Set 4: (8 comments) > Patch Set 2: > > > Patch Set 2: Code-Review+1 > > > >

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-11-18 Thread Hao Hao (Code Review)
Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14425 to look at the new patch set (#4). Change subject: KUDU-2971 p1: add subprocess module

[kudu-CR](branch-1.10.x) [docs] add release notes for 1.10.1

2019-11-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14659 ) Change subject: [docs] add release notes for 1.10.1 .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/14659

[kudu-CR] [wip] KUDU-2971 p3: concurrent requests support for subprocess

2019-11-04 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14625 Change subject: [wip] KUDU-2971 p3: concurrent requests support for subprocess .. [wip] KUDU-2971 p3: concurrent requests support for

[kudu-CR] [spark] Separate out DefaultSourceTests

2019-10-17 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14491 ) Change subject: [spark] Separate out DefaultSourceTests .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.11.x) [hms] Fix TestKuduMetastorePlugin on Hive 4

2019-10-17 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14489 ) Change subject: [hms] Fix TestKuduMetastorePlugin on Hive 4 .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [hms] Fix TestKuduMetastorePlugin on Hive 4

2019-10-17 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14487 ) Change subject: [hms] Fix TestKuduMetastorePlugin on Hive 4 .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] [java] KUDU-2791: process communicates via protobuf-based protocol

2019-10-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 ) Change subject: [java] KUDU-2791: process communicates via protobuf-based protocol .. Patch Set 2: Verified+1 Unrelated flaky test. --

[kudu-CR] [java] KUDU-2791: process communicates via protobuf-based protocol

2019-10-14 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: [java] KUDU-2791: process communicates via protobuf-based protocol .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/14329

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-10-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14425 ) Change subject: KUDU-2971 p1: add subprocess module .. Patch Set 2: (4 comments)

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-10-14 Thread Hao Hao (Code Review)
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14425 to look at the new patch set (#2). Change subject: KUDU-2971 p1: add subprocess module .. KUDU-2971 p1:

[kudu-CR] [java] KUDU-2791: process communicates via protobuf-based protocol

2019-10-14 Thread Hao Hao (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14329 to look at the new patch set (#2). Change subject: [java] KUDU-2791: process communicates via protobuf-based protocol

[kudu-CR] [java] KUDU-2791: process communicates via protobuf-based protocol

2019-10-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14329 ) Change subject: [java] KUDU-2791: process communicates via protobuf-based protocol .. Patch Set 2: (10 comments)

[kudu-CR] [subprocess] KUDU-2791 p2: add basic protobuf msg

2019-10-14 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14426 Change subject: [subprocess] KUDU-2791 p2: add basic protobuf msg .. [subprocess] KUDU-2791 p2: add basic protobuf msg This commit adds some

[kudu-CR] KUDU-2971 p1: add subprocess module

2019-10-14 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14425 Change subject: KUDU-2971 p1: add subprocess module .. KUDU-2971 p1: add subprocess module This commit separates a facility class that

[kudu-CR] TestMiniKuduCluster: deflake testHiveMetastoreIntegration

2019-10-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14335 ) Change subject: TestMiniKuduCluster: deflake testHiveMetastoreIntegration .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [java] process communicates via protobuf-based protocol

2019-09-30 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14329 Change subject: [java] process communicates via protobuf-based protocol .. [java] process communicates via protobuf-based protocol This

[kudu-CR] [mini cluster] introduce 'builtin' clock source

2019-09-13 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14227 ) Change subject: [mini_cluster] introduce 'builtin' clock source .. Patch Set 2: (1 comment)

[kudu-CR] [thirdparty] add SO REUSEPORT for chronyd NTP socket

2019-09-13 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14228 ) Change subject: [thirdparty] add SO_REUSEPORT for chronyd NTP socket .. Patch Set 1: Code-Review+1 -- To view, visit

[kudu-CR] KUDU-2069 p5: recheck tablet health when exiting maintenance mode

2019-09-13 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14223 ) Change subject: KUDU-2069 p5: recheck tablet health when exiting maintenance mode .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2069 p5: recheck tablet health when exiting maintenance mode

2019-09-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14223 ) Change subject: KUDU-2069 p5: recheck tablet health when exiting maintenance mode .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-2069 p4: stop replication from failed servers in maintenance mode

2019-09-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14222 ) Change subject: KUDU-2069 p4: stop replication from failed servers in maintenance mode .. Patch Set 2: (6 comments)

[kudu-CR] KUDU-2069 p3: add RPC endpoint for maintenance mode

2019-09-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14221 ) Change subject: KUDU-2069 p3: add RPC endpoint for maintenance mode .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2069 p2: stop placement on servers in maintenance mode

2019-09-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14220 ) Change subject: KUDU-2069 p2: stop placement on servers in maintenance mode .. Patch Set 2: (2 comments)

[kudu-CR] [hms] Sync external HMS tables with purge property

2019-09-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14179 ) Change subject: [hms] Sync external HMS tables with purge property .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] [hms] Sync external HMS tables with purge property

2019-09-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14179 ) Change subject: [hms] Sync external HMS tables with purge property .. Patch Set 6: (1 comment) LGTM, just one more test case to have

[kudu-CR] [hms] Sync external HMS tables with purge property

2019-09-09 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14179 ) Change subject: [hms] Sync external HMS tables with purge property .. Patch Set 4: (1 comment)

[kudu-CR] KUDU-2921: Exposing the table statistics to spark relation.

2019-09-06 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14107 ) Change subject: KUDU-2921: Exposing the table statistics to spark relation. .. Patch Set 7: Code-Review+1 (2 comments)

[kudu-CR] [hms] Sync external HMS tables with purge property

2019-09-06 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14179 ) Change subject: [hms] Sync external HMS tables with purge property .. Patch Set 2: (5 comments)

[kudu-CR] test: deflake ksck remote-test TestChecksumSnapshotCurrentTimestamp

2019-08-23 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13887 ) Change subject: test: deflake ksck_remote-test TestChecksumSnapshotCurrentTimestamp .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2921: Exposing the table statistics to spark relation.

2019-08-23 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14107 ) Change subject: KUDU-2921: Exposing the table statistics to spark relation. .. Patch Set 2: (1 comment) > Patch Set 2: > > > Patch Set 2:

[kudu-CR] Prepare for upgrading to Hive 3

2019-08-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14018 ) Change subject: Prepare for upgrading to Hive 3 .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14018 To

[kudu-CR] POC: Disable Sentry related tests

2019-08-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14020 ) Change subject: POC: Disable Sentry related tests .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/14020 To

[kudu-CR] POC: Upgrade Hive dependency to 3.1.1

2019-08-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13256 ) Change subject: POC: Upgrade Hive dependency to 3.1.1 .. Patch Set 13: Code-Review+1 -- To view, visit

[kudu-CR] Prepare for upgrading to Hive 3

2019-08-08 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14018 ) Change subject: Prepare for upgrading to Hive 3 .. Patch Set 2: (4 comments) LGTM, just some nits.

[kudu-CR] docs: add the required config for Sentry

2019-07-24 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13902 ) Change subject: docs: add the required config for Sentry .. docs: add the required config for Sentry This commit adds the required

[kudu-CR] docs: add the required config for Sentry

2019-07-24 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13902 ) Change subject: docs: add the required config for Sentry .. Patch Set 3: Verified+1 Unrelated flaky test -- To view, visit

[kudu-CR] docs: add the required config for Sentry

2019-07-24 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: docs: add the required config for Sentry .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13902 To unsubscribe, visit

[kudu-CR] docs: add the required config for Sentry

2019-07-23 Thread Hao Hao (Code Review)
Hello Alex Rodoni, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13902 to look at the new patch set (#3). Change subject: docs: add the required config for Sentry

[kudu-CR] docs: add the required config for Sentry

2019-07-23 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13902 ) Change subject: docs: add the required config for Sentry .. Patch Set 3: (2 comments)

[kudu-CR] docs: add the required config for Sentry

2019-07-23 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13902 ) Change subject: docs: add the required config for Sentry .. Patch Set 2: (2 comments)

[kudu-CR] docs: add the required config for Sentry

2019-07-23 Thread Hao Hao (Code Review)
Hello Alex Rodoni, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13902 to look at the new patch set (#2). Change subject: docs: add the required config for Sentry

[kudu-CR] docs: add the required config for Sentry

2019-07-23 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13902 Change subject: docs: add the required config for Sentry .. docs: add the required config for Sentry Staged version here:

[kudu-CR] [docs] update Hive Metastore integration and Impala integration docs

2019-07-01 Thread Hao Hao (Code Review)
Hello Alex Rodoni, Alexey Serbin, Kudu Jenkins, Andrew Wong, Priyanka Chheda, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13757 to look at the new patch set (#4). Change subject: [docs] update Hive Metastore integration and Impala

[kudu-CR] docs: add info about Sentry

2019-07-01 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13759 ) Change subject: docs: add info about Sentry .. Patch Set 4: (6 comments) LGTM, thanks a lot for documenting it! Though it would be good to

[kudu-CR] [docs] update Hive Metastore integration and Impala integration docs

2019-07-01 Thread Hao Hao (Code Review)
Hello Alex Rodoni, Alexey Serbin, Kudu Jenkins, Andrew Wong, Priyanka Chheda, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13757 to look at the new patch set (#3). Change subject: [docs] update Hive Metastore integration and Impala

[kudu-CR] [docs] update Hive Metastore integration and Impala integration docs

2019-06-30 Thread Hao Hao (Code Review)
Hello Alex Rodoni, Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13757 to look at the new patch set (#2). Change subject: [docs] update Hive Metastore integration and Impala integration docs

[kudu-CR] [docs] update Hive Metastore integration and Impala integration docs

2019-06-30 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13757 ) Change subject: [docs] update Hive Metastore integration and Impala integration docs .. Patch Set 1: (20 comments)

[kudu-CR] security: add docs for Sentry

2019-06-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13759 ) Change subject: security: add docs for Sentry .. Patch Set 2: (14 comments) http://gerrit.cloudera.org:8080/#/c/13759/2/docs/security.adoc

[kudu-CR](branch-1.10.x) docs: adjust ordering of security docs

2019-06-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13766 ) Change subject: docs: adjust ordering of security docs .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.10.x) [docs] add Hive Metastore integration

2019-06-28 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: [docs] add Hive Metastore integration .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13761 To unsubscribe, visit

[kudu-CR](branch-1.10.x) [docs] add Hive Metastore integration

2019-06-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13761 ) Change subject: [docs] add Hive Metastore integration .. Patch Set 1: Verified+1 Unrelated flaky tests. -- To view, visit

[kudu-CR](branch-1.10.x) [docs] add Hive Metastore integration

2019-06-28 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13761 ) Change subject: [docs] add Hive Metastore integration .. [docs] add Hive Metastore integration Change-Id:

[kudu-CR] docs: adjust ordering of security docs

2019-06-28 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13758 ) Change subject: docs: adjust ordering of security docs .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [docs] update Hive Metastore integration and Impala integration docs

2019-06-27 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13757 Change subject: [docs] update Hive Metastore integration and Impala integration docs .. [docs] update Hive Metastore integration and Impala

[kudu-CR] [docs] add Hive Metastore integration

2019-06-27 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11798 ) Change subject: [docs] add Hive Metastore integration .. [docs] add Hive Metastore integration Change-Id:

[kudu-CR](branch-1.10.x) [docs] Add 1.10.0 release notes

2019-06-20 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13669 ) Change subject: [docs] Add 1.10.0 release notes .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/13669 To

[kudu-CR] [java] KUDU-2873: attach authz tokens to SplitKeyRangeRequests

2019-06-20 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13692 ) Change subject: [java] KUDU-2873: attach authz tokens to SplitKeyRangeRequests .. Patch Set 2: Code-Review+2 (2 comments)

[kudu-CR](branch-1.10.x) [sentry] add require db privileges flag for ListTables

2019-06-19 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: [sentry] add require_db_privileges flag for ListTables .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/13678 To

[kudu-CR](branch-1.10.x) [sentry] add require db privileges flag for ListTables

2019-06-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13678 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. Patch Set 1: Verified+1 -- To view, visit

[kudu-CR](branch-1.10.x) [sentry] add require db privileges flag for ListTables

2019-06-19 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13678 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. [sentry] add require_db_privileges flag for ListTables

[kudu-CR] KUDU-2870: allow super-user to skip authz checks in Checksum

2019-06-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13681 ) Change subject: KUDU-2870: allow super-user to skip authz checks in Checksum .. Patch Set 5: Code-Review+1 -- To view, visit

[kudu-CR](branch-1.10.x) [sentry] add require db privileges flag for ListTables

2019-06-19 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13678 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-16 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13657 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. [sentry] add require_db_privileges flag for ListTables

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13657 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13657 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. Patch Set 3: (1 comment)

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-16 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13657 to look at the new patch set (#4). Change subject: [sentry] add require_db_privileges flag for ListTables

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13657 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. Patch Set 3: (1 comment)

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-14 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13657 to look at the new patch set (#3). Change subject: [sentry] add require_db_privileges flag for ListTables

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13657 ) Change subject: [sentry] add require_db_privileges flag for ListTables .. Patch Set 2: (2 comments)

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-14 Thread Hao Hao (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13657 to look at the new patch set (#2). Change subject: [sentry] add require_db_privileges flag for ListTables

[kudu-CR] [sentry] Add ListPrivilegesByAuthorizablesAndUser sentry client API

2019-06-14 Thread Hao Hao (Code Review)
Hao Hao has abandoned this change. ( http://gerrit.cloudera.org:8080/13599 ) Change subject: [sentry] Add ListPrivilegesByAuthorizablesAndUser sentry client API .. Abandoned -- To view, visit

[kudu-CR] wip: [sentry] use bulk Sentry API for ListTables

2019-06-14 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13600 ) Change subject: wip: [sentry] use bulk Sentry API for ListTables .. Patch Set 2: (1 comment)

[kudu-CR] wip: [sentry] use bulk Sentry API for ListTables

2019-06-14 Thread Hao Hao (Code Review)
Hao Hao has abandoned this change. ( http://gerrit.cloudera.org:8080/13600 ) Change subject: wip: [sentry] use bulk Sentry API for ListTables .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/13600 To unsubscribe,

[kudu-CR] [sentry] add require db privileges flag for ListTables

2019-06-14 Thread Hao Hao (Code Review)
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13657 Change subject: [sentry] add require_db_privileges flag for ListTables .. [sentry] add require_db_privileges flag for ListTables This patch

[kudu-CR] wip: [sentry] use bulk Sentry API for ListTables

2019-06-13 Thread Hao Hao (Code Review)
Hello Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13600 to look at the new patch set (#2). Change subject: wip: [sentry] use bulk Sentry API for ListTables .. wip:

[kudu-CR] [sentry] Add ListPrivilegesByAuthorizablesAndUser sentry client API

2019-06-13 Thread Hao Hao (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13599 to look at the new patch set (#4). Change subject: [sentry] Add ListPrivilegesByAuthorizablesAndUser sentry client API

[kudu-CR] thrift: follow-up to 327be47820dcaba358095f118e516a5e92621a59

2019-06-13 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13638 ) Change subject: thrift: follow-up to 327be47820dcaba358095f118e516a5e92621a59 .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR](branch-1.10.x) Bump Sentry version to b71a78e

2019-06-13 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13637 ) Change subject: Bump Sentry version to b71a78e .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13637 To

[kudu-CR] [sentry] Add ListPrivilegesByAuthoriablesAndUser sentry client API

2019-06-12 Thread Hao Hao (Code Review)
Hello Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13599 to look at the new patch set (#3). Change subject: [sentry] Add ListPrivilegesByAuthoriablesAndUser sentry client API

[kudu-CR] Bump Sentry version to b71a78e

2019-06-12 Thread Hao Hao (Code Review)
Hello Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13598 to look at the new patch set (#3). Change subject: Bump Sentry version to b71a78e .. Bump Sentry version to b71a78e

[kudu-CR] [hms] Adjust storage handler package follow up

2019-06-12 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13595 ) Change subject: [hms] Adjust storage handler package follow up .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig

2019-06-11 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13556 ) Change subject: KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] hms: clarify message to pass in --hive metastore uris

2019-06-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13578 ) Change subject: hms: clarify message to pass in --hive_metastore_uris .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] sentry: allow caching of COLUMN/TABLE privileges when checking higher scopes

2019-06-10 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13552 ) Change subject: sentry: allow caching of COLUMN/TABLE privileges when checking higher scopes .. sentry: allow caching of

[kudu-CR] sentry: avoid authorizing every table in ListTables

2019-06-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13549 ) Change subject: sentry: avoid authorizing every table in ListTables .. Patch Set 8: Code-Review+2 -- To view, visit

[kudu-CR] authz: refactor authorization for ListTables

2019-06-10 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13566 ) Change subject: authz: refactor authorization for ListTables .. authz: refactor authorization for ListTables Authorization for

[kudu-CR] authz: refactor authorization for ListTables

2019-06-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13566 ) Change subject: authz: refactor authorization for ListTables .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] [itbll] make error/failure easier to detect

2019-06-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13575 ) Change subject: [itbll] make error/failure easier to detect .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] sentry: allow caching of COLUMN/TABLE privileges when checking higher scopes

2019-06-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13552 ) Change subject: sentry: allow caching of COLUMN/TABLE privileges when checking higher scopes .. Patch Set 6: Code-Review+2 -- To view,

[kudu-CR] authz: refactor authorization for ListTables

2019-06-10 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13566 ) Change subject: authz: refactor authorization for ListTables .. Patch Set 5: Code-Review+1 (1 comment)

[kudu-CR] [hms] Adjust storage handler package

2019-06-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13540 ) Change subject: [hms] Adjust storage handler package .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13540

[kudu-CR] KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig

2019-06-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13556 ) Change subject: KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig .. Patch Set 1: (1 comment) LGTM, just one minor nit.

[kudu-CR] KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig

2019-06-07 Thread Hao Hao (Code Review)
Hao Hao has removed Anonymous Coward (314) from this change. ( http://gerrit.cloudera.org:8080/13556 ) Change subject: KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig .. Removed reviewer null. -- To view,

[kudu-CR] [hms] Adjust storage handler package

2019-06-07 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13540 ) Change subject: [hms] Adjust storage handler package .. Patch Set 4: Code-Review+1 (3 comments) LGTM, just nits.

[kudu-CR] sentry: don't send requests for DATABASE/SERVER privileges

2019-06-06 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13494 ) Change subject: sentry: don't send requests for DATABASE/SERVER privileges .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] sentry: don't send requests for DATABASE/SERVER privileges

2019-06-06 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13494 ) Change subject: sentry: don't send requests for DATABASE/SERVER privileges .. sentry: don't send requests for DATABASE/SERVER

[kudu-CR] hms: allow for tooling to run without Kudu plugin

2019-06-06 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13510 ) Change subject: hms: allow for tooling to run without Kudu plugin .. hms: allow for tooling to run without Kudu plugin Currently,

<    2   3   4   5   6   7   8   9   10   11   >