s 1202 (patched)
<https://reviews.apache.org/r/65127/#comment278211>
`cbegin() / cend()` please
src/checks/checker_process.cpp
Lines 1367 (patched)
<https://reviews.apache.org/r/65127/#comment278215>
`cbegin / cend`
- Alexander Rukletsov
On Feb. 22,
577-578 (patched)
<https://reviews.apache.org/r/65419/#comment278170>
`cbegin() / cend()` please.
- Alexander Rukletsov
On Feb. 21, 2018, 2:07 a.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail.
edding this peculiarity into `Http` check type description
does not feel right.
I'd go for just keeping `ipv6` flag here and keep the old code for domain
construction in "checker_process.cpp". However I leave the decision to you.
- Alexander Rukletsov
On Feb. 16, 20
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65396/#review197941
---
Ship it!
Ship It!
- Alexander Rukletsov
On Feb. 8, 2018, 5
cutor.cpp
Lines 44 (patched)
<https://reviews.apache.org/r/65395/#comment278164>
Do you need it here?
src/launcher/default_executor.cpp
Lines 48 (patched)
<https://reviews.apache.org/r/65395/#comment278165>
Do you need this include?
- Alexander Rukletsov
On Feb.
(patched)
<https://reviews.apache.org/r/65394/#comment278146>
Why not saying `const std::string& _scheme = DEFAULT_HTTP_SCHEME`?
- Alexander Rukletsov
On Feb. 16, 2018, 11:25 p.m., Akash Gupta wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65393/#review197850
---
Ship it!
Ship It!
- Alexander Rukletsov
On Feb. 16, 2018
> On Feb. 7, 2018, 1:07 p.m., Alexander Rukletsov wrote:
> > Is this related to https://issues.apache.org/jira/browse/MESOS-4812 ?
>
> Akash Gupta wrote:
> Yeah, I think it will fix that issue, but I have to confirm it.
>
> Alexander Rukletsov wrote:
> Pleas
suggestion
below.
src/docker/executor.cpp
Lines 523-527 (patched)
<https://reviews.apache.org/r/65713/#comment278131>
Instead of this, why not make `stop.onFailed` below `stop.recover`?
- Alexander Rukletsov
On Feb. 20, 2018, 5:11 p.m., Andrei Budnik wrote:
>
> --
>
> (Updated Feb. 6, 2018, 5:45 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> This class exposes profiling functionality of jemalloc memory alloca
> On Feb. 6, 2018, 5:48 p.m., Alexander Rukletsov wrote:
> > 3rdparty/libprocess/src/memory_profiler.cpp
> > Lines 243-249 (patched)
> > <https://reviews.apache.org/r/63368/diff/3/?file=1951296#file1951296line243>
> >
> > I think it is safe to use th
> On Feb. 7, 2018, 1:07 p.m., Alexander Rukletsov wrote:
> > Is this related to https://issues.apache.org/jira/browse/MESOS-4812 ?
>
> Akash Gupta wrote:
> Yeah, I think it will fix that issue, but I have to confirm it.
Please do! And if it does fix it, adjust th
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65395/
> ---
>
> (Updated Feb. 8, 2018, 5:49 p.m.)
>
>
> Re
> On Feb. 7, 2018, 1:35 p.m., Alexander Rukletsov wrote:
> > src/checks/checker.cpp
> > Line 86 (original), 89 (patched)
> > <https://reviews.apache.org/r/65395/diff/2/?file=1950438#file1950438line89>
> >
> > please no abbreviations like this, it is u
n
move duplicate code into the lower level `CheckerProcess`?
- Alexander Rukletsov
On Jan. 30, 2018, 10:06 a.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
This is not quite true: you only mean command health checks. HTTP and TCP
are still performed by the executor directly.
- Alexander Rukletsov
On Jan. 30, 2018, 10:05 a.m., Akash Gupta wrote:
>
> ---
> This is an automati
-4812 ?
- Alexander Rukletsov
On Jan. 30, 2018, 10:12 a.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
tate;
profilerState.values["jemalloc_detected"] = detected;
profilerState.values["profiling_active"] = heapProfilingActive;
state.values["memory_profiler"] = std::move(profilerState);
}
```
3rdparty/libprocess/src/memory_profiler.cpp
Lin
omment275982>
Don't you need to check `graphId.isSome()`?
3rdparty/libprocess/src/memory_profiler.cpp
Lines 807 (patched)
<https://reviews.apache.org/r/63368/#comment275983>
Do you check that the file actually exists before streaming it
(patched)
<https://reviews.apache.org/r/65348/#comment275901>
Remove the comment as well!
- Alexander Rukletsov
On Jan. 26, 2018, 12:55 p.m., Jan Schlicht wrote:
>
> ---
> This is an automatically generated e-mail.
tomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65223/#review196197
---
On Jan. 18, 2018, 5:46 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an
sting
---
Ensured the modified test fails without the fix.
`make check` on Mac OS 10.11.6 and several Linux distributions.
Thanks,
Alexander Rukletsov
ed test fails without the fix.
`make check` on Mac OS 10.11.6 and several Linux distributions.
Thanks,
Alexander Rukletsov
;.
src/slave/containerizer/mesos/paths.hpp
Lines 152 (patched)
<https://reviews.apache.org/r/65261/#comment275722>
Add "See comments in IOSwitchboardServer::create()".
- Alexander Rukletsov
On Jan. 22, 2018, 1 p.m., Andrei Budnik wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65180/#review196184
---
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 17, 2018
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65317/#review196183
---
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 24, 2018, 6
tps://reviews.apache.org/r/65305/#comment275647>
Any specific reason why this is not a value, i.e.,
```
static std::mutex authorization_callbacks_mutex;
```
- Alexander Rukletsov
On Jan. 24, 2018, 12:54 a.m., Benjamin Mahler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65307/#review196136
---
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 24, 2018, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65305/#review196133
---
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 24, 2018
> On Jan. 23, 2018, 3:12 p.m., Alexander Rukletsov wrote:
> > src/slave/containerizer/mesos/io/switchboard.cpp
> > Lines 842-843 (original), 845-852 (patched)
> > <https://reviews.apache.org/r/65261/diff/1/?file=1943241#file1943241line849>
> >
&
w about "prefatory" or "preparatory". Maybe "prep" is sufficient. Can you
please consult a native English speaker?
- Alexander Rukletsov
On Jan. 22, 2018, 1 p.m., Andrei Budnik wrote:
>
> ---
> Th
> On Jan. 22, 2018, 1:27 p.m., Alexander Rukletsov wrote:
> > src/checks/checker_process.hpp
> > Lines 40-47 (patched)
> > <https://reviews.apache.org/r/64386/diff/8/?file=1941023#file1941023line40>
> >
> > What meaning do you put in the difference betw
And here is the beauty of your approach: these guys should go into
`UCRContainerInfo` runtime!
src/launcher/executor.cpp
Lines 653-658 (patched)
<https://reviews.apache.org/r/64386/#comment275236>
How is this used in the checker library at the moment? Do you distinguish
there b
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65203/#review195889
---
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 20, 2018, 2
98fb513e1c
Diff: https://reviews.apache.org/r/65223/diff/1/
Testing
---
`make check` on MacOS 10.13.2
Thanks,
Alexander Rukletsov
/64574/diff/2/
Changes: https://reviews.apache.org/r/64574/diff/1-2/
Testing
---
Ensured the modified test fails without the fix.
`make check` on Mac OS 10.11.6 and several Linux distributions.
Thanks,
Alexander Rukletsov
right to me, since it prevents the
> > user of libprocess from seeing what the original path was. Have you
> > considered any other approaches? (also I think you only needed to trim from
> > the tail?)
>
> Alexander Rukletsov wrote:
> Why so? `name` is a local va
/
Testing
---
make check on:
`Apple LLVM version 8.0.0 (clang-800.0.42.1)` on Mac OS 10.11.6
`c++ (GCC) 6.2.1 20160916 (Red Hat 6.2.1-2)` on Fedora 24
Thanks,
Alexander Rukletsov
://reviews.apache.org/r/61811/diff/2-3/
Testing
---
make check on:
`Apple LLVM version 8.0.0 (clang-800.0.42.1)` on Mac OS 10.11.6
`c++ (GCC) 6.2.1 20160916 (Red Hat 6.2.1-2)` on Fedora 24
Thanks,
Alexander Rukletsov
sh --work_dir=./m`
a: `GLOG_v=1 sudo ./bin/mesos-agent.sh --master=:5050 --work_dir=./a
--containerizers=docker`
f: `./src/mesos-execute --master=:5050 --containerizer=docker
--docker_image=fedora:25 --name=pull-test --command="sleep 1000"`
Thanks,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65179/#review195618
---
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 16, 2018, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65190/#review195612
---
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 17, 2018, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65122/#review195611
---
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 17, 2018, 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65190/#review195610
---
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 17, 2018, 4
/
- Alexander Rukletsov
On Jan. 17, 2018, 2:14 p.m., Andrei Budnik wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
(patched)
<https://reviews.apache.org/r/63661/#comment274856>
Why not a on-liner?
```
call.mutable_subscribe()->mutable_framework_info()->CopyFrom(frameworkInfo);
```
- Alexander Rukletsov
On Nov. 8, 2017, 10:46 a.m., Armand G
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64770/#review195254
---
Ship it!
Ship It!
- Alexander Rukletsov
On Dec. 21, 2017, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64848/#review195251
---
Ship it!
Nice cleanup, Till!
- Alexander Rukletsov
On Jan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64847/#review195249
---
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 9, 2018, 3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64846/#review195248
---
Ship it!
Ship It!
- Alexander Rukletsov
On Dec. 28, 2017, 2
> On Jan. 10, 2018, 1:41 p.m., Alexander Rukletsov wrote:
> > src/tests/health_check_tests.cpp
> > Lines 120-122 (patched)
> > <https://reviews.apache.org/r/64387/diff/5/?file=1938012#file1938012line123>
> >
> > Why only on windows?
>
> Akash Gu
> On Jan. 10, 2018, 12:09 p.m., Alexander Rukletsov wrote:
> > 3rdparty/stout/include/stout/windows.hpp
> > Lines 343-348 (original), 343-348 (patched)
> > <https://reviews.apache.org/r/63859/diff/5/?file=1931096#file1931096line343>
> >
> > Could you p
> On Jan. 10, 2018, 12:32 p.m., Alexander Rukletsov wrote:
> > docs/networking.md
> > Lines 118-122 (patched)
> > <https://reviews.apache.org/r/63861/diff/8/?file=1938000#file1938000line118>
> >
> > Can you please mention that other network modes than
> On Jan. 10, 2018, 1:16 p.m., Alexander Rukletsov wrote:
> > src/checks/checker.hpp
> > Lines 73 (patched)
> > <https://reviews.apache.org/r/64386/diff/5/?file=1938002#file1938002line73>
> >
> > I think all such commands should not be passed from o
.
Diffs
-
3rdparty/libprocess/src/process.cpp 53969a79f5e877b955dcab5c3ab9e508ebe96e88
Diff: https://reviews.apache.org/r/65048/diff/2/
Testing
---
`make check` on Mac OS 10.11.6
Thanks,
Alexander Rukletsov
53969a79f5e877b955dcab5c3ab9e508ebe96e88
Diff: https://reviews.apache.org/r/65048/diff/2/
Changes: https://reviews.apache.org/r/65048/diff/1-2/
Testing
---
`make check` on Mac OS 10.11.6
Thanks,
Alexander Rukletsov
53969a79f5e877b955dcab5c3ab9e508ebe96e88
Diff: https://reviews.apache.org/r/65048/diff/1/
Testing (updated)
---
`make check` on Mac OS 10.11.6
Thanks,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65071/#review195218
---
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 10, 2018, 6
r
the place?
- Alexander Rukletsov
On Jan. 10, 2018, 1:41 a.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
is something we should likely do in a broader scope. Chances
are, someone else in a different place will try to solve the same problem.
- Alexander Rukletsov
On Jan. 5, 2018, 6:33 p.m., Akash Gupta wrote:
>
> ---
> This is an au
/#comment274275>
Why is this not part of the health check library? This way, the code
related to http and tcp checking is scattered over the codebase.
- Alexander Rukletsov
On Jan. 10, 2018, 1:28 a.m., Akash Gupta wrote:
>
>
not sure this is true with our proto having a default value. Can you
please verify that?
- Alexander Rukletsov
On Jan. 10, 2018, 1:42 a.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail
f // __WINDOWS__
break;
}
case ContainerInfo::DockerInfo::NONE: {
options.network = "none";
break;
}
```
src/docker/docker.cpp
Lines 758-759 (patched)
<https://reviews.apache.org/r/63860/#commen
), 343-348 (patched)
<https://reviews.apache.org/r/63859/#comment274268>
Could you please clarify, what the fix is here? At least in the patch
description, but feel free to update the comment above.
- Alexander Rukletsov
On Jan. 5, 2018, 12:28 a.m., Akash Gupta
,
Alexander Rukletsov
,
Alexander Rukletsov
---
See summary.
Diffs
-
docs/health-checks.md b9b6327dea8c70dbc4aab204487a088f76c79479
Diff: https://reviews.apache.org/r/64980/diff/1/
Testing
---
Rendered in MacDown.
Thanks,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64953/#review194845
---
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 4, 2018, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64933/#review194744
---
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 3, 2018, 10
iff: https://reviews.apache.org/r/64686/diff/3/
Testing
---
make check on Mac OS 10.11.6 and various Linux distros
Thanks,
Alexander Rukletsov
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64810/#review194440
---
Ship it!
Ship It!
- Alexander Rukletsov
On Dec. 22, 2017, 3
-------
On Dec. 22, 2017, 1:42 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64685/
> --
n do this. There is also `stat()` POSIX function.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64807/#review194428
---
On Dec. 2
://reviews.apache.org/r/64686/diff/3/
Changes: https://reviews.apache.org/r/64686/diff/2-3/
Testing
---
make check on Mac OS 10.11.6 and various Linux distros
Thanks,
Alexander Rukletsov
---
See https://reviews.apache.org/r/64686/
Thanks,
Alexander Rukletsov
Description
---
See summary.
Diffs
-
src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139
Diff: https://reviews.apache.org/r/64807/diff/1/
Testing
---
make check on various Linux distros
Thanks,
Alexander Rukletsov
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64686/#review194361
---
On Dec. 22, 2017, 1:39 p.m., Alexander Rukletsov wrote:
>
> ---
://reviews.apache.org/r/64686/diff/2/
Testing
---
make check on Mac OS 10.11.6 and various Linux distros
Thanks,
Alexander Rukletsov
---
Thanks,
Alexander Rukletsov
/
Changes: https://reviews.apache.org/r/64686/diff/1-2/
Testing
---
make check on Mac OS 10.11.6 and various Linux distros
Thanks,
Alexander Rukletsov
/diff/3-4/
Testing
---
Thanks,
Alexander Rukletsov
,
Alexander Rukletsov
ask.task_id());
AWAIT_READY(statusFailed);
EXPECT_EQ(TASK_FAILED, statusFailed->state());
driver.stop();
driver.join();
}
```
Thanks,
Alexander Rukletsov
10.11.6
Manual testing using modified "exec.cpp" that drops executor registration
confirmation.
Thanks,
Alexander Rukletsov
10.11.6
Manual testing using modified "exec.cpp" that drops executor registration
confirmation.
Thanks,
Alexander Rukletsov
://reviews.apache.org/r/64070/diff/2/
Changes: https://reviews.apache.org/r/64070/diff/1-2/
Testing
---
Thanks,
Alexander Rukletsov
// Launch a task with the command executor.
TaskInfo task = createTask(
offers->front().slave_id(),
offers->front().resources(),
SLEEP_COMMAND(1000));
driver.launchTasks(offers->front().id(), {task});
driver.stop();
driver.join();
}
```
Thanks,
Alexander Rukletsov
change.
Thanks,
Alexander Rukletsov
even arrived before the executor had subscribed.
Diffs
-
src/executor/v0_v1executor.cpp 61d591993e6388ba3b4d64a3bdb63c3a3513fbeb
Diff: https://reviews.apache.org/r/64070/diff/1/
Testing (updated)
---
Thanks,
Alexander Rukletsov
/
Testing
---
Thanks,
Alexander Rukletsov
s executor registration
confirmation.
Thanks,
Alexander Rukletsov
even arrived before the executor had subscribed.
Diffs
-
src/executor/v0_v1executor.cpp 61d591993e6388ba3b4d64a3bdb63c3a3513fbeb
Diff: https://reviews.apache.org/r/64070/diff/1/
Testing
---
See https://reviews.apache.org/r/64033/
Thanks,
Alexander Rukletsov
kInfo task = createTask(
offers->front().slave_id(),
offers->front().resources(),
SLEEP_COMMAND(1000));
driver.launchTasks(offers->front().id(), {task});
driver.stop();
driver.join();
}
```
Thanks,
Alexander Rukletsov
isit:
https://reviews.apache.org/r/64069/#review193931
-------
On Dec. 15, 2017, 10:43 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64749/#review194240
---
Ship it!
Ship It!
- Alexander Rukletsov
On Dec. 20, 2017, 1
e and commit it for you.
docs/agent-recovery.md
Lines 72-73 (patched)
<https://reviews.apache.org/r/64450/#comment272971>
Indentation
- Alexander Rukletsov
On Dec. 20, 2017, 1:26 p.m., Benno Evers wrote:
>
> ---
> This
069/#review194088
-------
On Dec. 15, 2017, 10:43 a.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.
e.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64069/#review194147
-------
On Dec. 15, 2017, 10:43 a.m., Alexander Rukle
ed)
<https://reviews.apache.org/r/64450/#comment272945>
s/slave/agent
docs/configuration/agent.md
Lines 1062 (patched)
<https://reviews.apache.org/r/64450/#comment272949>
s/which/which, e.g.,/
- Alexander Rukletsov
On Dec. 12, 2017, 11:16 a.m., Benno Evers wrote:
>
d to return 301 codes in response to operator API
endpoints.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64574/#review194106
-----
301 - 400 of 3026 matches
Mail list logo
