Re: Review Request 43561: Improve Ranges parsing to handle single values.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review136543 --- On June 11, 2016, 10:29 p.m., Klaus Ma wrote: > > -

Re: Review Request 43561: Improve Ranges parsing to handle single values.

587cb68551d438621e215953e89818b623b7f71b src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 Diff: https://reviews.apache.org/r/43561/diff/ Testing --- make make check GTEST_FILTER=~"*" ./src/mesos-test Thanks, Klaus Ma

Re: Review Request 43561: Improve Ranges parsing to handle single values.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review136543 --- On June 11, 2016, 10:29 p.m., Klaus Ma wrote: > > -

Re: Review Request 48914: Added GPU_RESOURCES capability to FrameworkInfo.

> On June 19, 2016, 10:18 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1277-1279 > > > > > > This logic seems also allow agents without gpu resources offered to the > > framework

Review Request 49140: Added startsWith/endsWith to support char.

Thanks, Klaus Ma

Re: Review Request 41857: Got evictable executors.

Diffs (updated) - src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f Diff: https://reviews.apache.org/r/41857/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 35711: Disallow special characters in role name.

ole: do we support other language, e.g. Chinese? If not, I'd suggest also to highlight in document. src/common/roles.cpp (line 64) <https://reviews.apache.org/r/35711/#comment174398> I'm not sure whether this will introduce porting issue: for the whitespace, it's better to use C std (is

Re: Review Request 42113: Handle unreserve logic for dynamic reservation (2/3).

slaves[slaveId].total -= freeResources; freeAllocationSlack -= freeResources; } src/master/allocator/mesos/hierarchical.cpp (line 708) <https://reviews.apache.org/r/42113/#comment175255> There should be `freeAllocationSlack` which is not allocated for now. - Kla

Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

/42289/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 41791: Updated allocation slack for dynamic reserve (1/3).

Update the comments to list cases, for example: 1. if new `reserved.stateless` > old, pala... 2. if new ... <, pala... - if xxx - if xxx - Klaus Ma On Jan. 13, 2016, 8:58 p.m.,

Re: Review Request 42194: Handle unreserve logic for dynamic reservation (3/3).

to merge this patch with `updateAllocation`. - Klaus Ma On Jan. 13, 2016, 9:10 p.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41772: Added helper function to flatten resources.

patches highly depend on those helper functions. > > So what about the following: > 1) Rename flattenReserved() to reserved_() which will return all reserved > resources with different roles in a flatten mode. > 2) Remove flattenSlack() and merge it to flatten(). > &g

Re: Review Request 35711: Disallow special characters in role name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review114367 --- Ship it! Ship It! - Klaus Ma On Jan. 14, 2016, 1:12 a.m

Review Request 42254: Checked whether the remaining cluster resources is allocatable.

: mesos Description --- Checked whether the remaining cluster resources is allocatable. Diffs - src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056 Diff: https://reviews.apache.org/r/42254/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 42221: Removed references to wDRF from allocator.

tps://reviews.apache.org/r/42221/#comment175029> Not related to this patch, But I think `allocable()` is better than `empty()`. - Klaus Ma On Jan. 13, 2016, 7:06 a.m., Alexander Rukletsov wrote: > > --- > This is an automati

Re: Review Request 42222: Added a comment on allocator recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review114218 --- Ship it! Ship It! - Klaus Ma On Jan. 13, 2016, 7:06 a.m

Re: Review Request 41772: Added helper function to flatten resources.

gt; https://reviews.apache.org/r/41772/ > --- > > (Updated Jan. 13, 2016, 8:16 p.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, and Klaus Ma. > > > Bugs: MESOS-426

Re: Review Request 42113: Handle unreserve logic for dynamic reservation (2/3).

tps://reviews.apache.org/r/42113/#comment175324> Should be `freeAllocationSlack.get(name)` - Klaus Ma On Jan. 14, 2016, 8:46 p.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master.

7fe566770bbd802111885de061a53a3edf914840 Diff: https://reviews.apache.org/r/41308/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master.

> On Jan. 13, 2016, 8:39 p.m., Klaus Ma wrote: > > @Joseph/Vinod, would you help to review those patches move executor from > > slave to master? > > Joseph Wu wrote: > There are still several open issues open on each prior review. Can you > go through and ma

Re: Review Request 41306: MESOS-1718: use command line executor to launch tasks.

759c8d5b1bfb5ad723aa423e1487998ed62bbc3a Diff: https://reviews.apache.org/r/41306/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master.

b8edd6fafedd4c2221a8d19c1ebc71254071a8c7 src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66 src/tests/slave_tests.cpp 076660daf025d6fd5065cd0c1930f17ecc5ca5aa Diff: https://reviews.apache.org/r/41308/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41302: MESOS-1718: add slave's configuration into SlaveInfo.

-1718: add slave's configuration into SlaveInfo Diffs - include/mesos/mesos.proto b12e0f3eff44d90ec01360fc08bf9e597d7ed9dd include/mesos/v1/mesos.proto fa7e82e03b11cf6619a4f16e8e0fbbf755bf210c Diff: https://reviews.apache.org/r/41302/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

863a11c82d322f56db1ccf25b73a41304a46 src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a Diff: https://reviews.apache.org/r/41305/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41306: MESOS-1718: use command line executor to launch tasks.

Diffs (updated) - src/master/validation.cpp c7cf56815fc743ff52ef423b23d78398ad1b35a3 src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a Diff: https://reviews.apache.org/r/41306/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41772: Added helper function to flatten resources.

patches highly depend on those helper functions. > > So what about the following: > 1) Rename flattenReserved() to reserved_() which will return all reserved > resources with different roles in a flatten mode. > 2) Remove flattenSlack() and merge it to flatten(). > &g

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/#review114908 --- Ping @alex-mesos/@jvanremoortere, any comments. - Klaus Ma

Re: Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master

> On Jan. 13, 2016, 8:39 p.m., Klaus Ma wrote: > > @Joseph/Vinod, would you help to review those patches move executor from > > slave to master? > > Joseph Wu wrote: > There are still several open issues open on each prior review. Can you > go through and ma

Re: Review Request 41302: MESOS-1718: add slave's configuration into SlaveInfo

b12e0f3eff44d90ec01360fc08bf9e597d7ed9dd include/mesos/v1/mesos.proto fa7e82e03b11cf6619a4f16e8e0fbbf755bf210c Diff: https://reviews.apache.org/r/41302/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

eviews.apache.org/r/41305/#review110166 --- On Jan. 15, 2016, 1:17 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41305/ > ---

Re: Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master

/slave_tests.cpp 076660daf025d6fd5065cd0c1930f17ecc5ca5aa Diff: https://reviews.apache.org/r/41308/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41306: MESOS-1718: use command line executor to launch tasks

) - src/master/validation.cpp c7cf56815fc743ff52ef423b23d78398ad1b35a3 src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a Diff: https://reviews.apache.org/r/41306/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master

b7586ce42bfac9d9885a3eb8d82deb94680c236c src/slave/slave.cpp 759c8d5b1bfb5ad723aa423e1487998ed62bbc3a Diff: https://reviews.apache.org/r/41305/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

(updated) - src/master/allocator/mesos/hierarchical.cpp 48acde69b1a2f305b568a7e322a58708063dd30a Diff: https://reviews.apache.org/r/42289/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

://reviews.apache.org/r/42289/diff/ Testing --- make make check Thanks, Klaus Ma

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

-tests.sh`; it seems perf did not support no-Linux system. - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42289/#review115132 ---

Re: Review Request 41302: MESOS-1718: add slave's configuration into SlaveInfo.

0be4bed336e86a5c377e87ac6212c70ac3b4c66b include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd Diff: https://reviews.apache.org/r/41302/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c src/slave/slave.cpp bb501810d7bb1261ebbbdd147c49948e5a2f8665 Diff: https://reviews.apache.org/r/41305/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41306: MESOS-1718: use command line executor to launch tasks.

tasks Diffs (updated) - src/master/validation.cpp 98360b690382ed1912a868ac93b058cb28003a12 src/slave/slave.cpp bb501810d7bb1261ebbbdd147c49948e5a2f8665 Diff: https://reviews.apache.org/r/41306/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 41308: MESOS-1718: Unit Test for moving getExecutorInfo from slave to master.

7fe566770bbd802111885de061a53a3edf914840 Diff: https://reviews.apache.org/r/41308/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

--gtest_filter="HierarchicalAllocatorTest.*" --verbose --gtest_repeat=100 --gtest_shuffle Thanks, Klaus Ma

Re: Review Request 42289: Calcuated 'remainingClusterResources' by all activated slaves.

="HierarchicalAllocatorTest.*" --verbose --gtest_repeat=100 --gtest_shuffle Thanks, Klaus Ma

Re: Review Request 49140: Added startsWith/endsWith to support char.

18bcb0e499a9d2d84113b5b9e609e5e40913ebcc support/docker_build.sh 8ae1aadbc12b12e44984d34ccfbcb8a97bf05bcf Diff: https://reviews.apache.org/r/49140/diff/ Testing --- make Thanks, Klaus Ma

Re: Review Request 49140: Added startsWith/endsWith to support char.

: https://reviews.apache.org/r/49140/diff/ Testing --- make Thanks, Klaus Ma

Review Request 49223: WIP: enhance value parsing.

: enhance value parsing. Diffs - src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b Diff: https://reviews.apache.org/r/49223/diff/ Testing --- make Thanks, Klaus Ma

Re: Review Request 49223: Enhanced Value parsing.

Diff: https://reviews.apache.org/r/49223/diff/ Testing (updated) --- make && make check Thanks, Klaus Ma

Re: Review Request 49223: Enhanced Value parsing.

mp; make check Thanks, Klaus Ma

Review Request 49246: Enhanced startsWith/endsWith's performance.

&& make check Thanks, Klaus Ma

Re: Review Request 49246: Enhanced startsWith/endsWith's performance.

: https://reviews.apache.org/r/49246/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 49140: Added startsWith/endsWith to support char.

of `startsWith/endsWith` to improve the performance. - Klaus Ma On June 26, 2016, 5:46 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 43328: Title for documentation webpages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43328/#review118237 --- Ship it! Ship It! - Klaus Ma On Feb. 8, 2016, 11:28 p.m

Re: Review Request 43159: Removed the duplicate "active" field in json schema of `Framework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43159/#review118166 --- Ship it! Ship It! - Klaus Ma On Feb. 4, 2016, 7:11 a.m

Re: Review Request 43159: Removed the duplicate "active" field in json schema of `Framework`.

> On Feb. 7, 2016, 11:29 a.m., Klaus Ma wrote: > > Ship It! Add test case for duplicated keys in our output: did not prase json, just `std::count` should be OK. - Klaus --- This is an automatically generated e-mail. To rep

Re: Review Request 42946: Replaced tabs with spaces in configure.ac.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42946/#review118142 --- ping @Joris, any comments on this? - Klaus Ma On Jan. 29, 2016

Re: Review Request 43267: Returned "ServiceUnavailable" for slave's /state during recovery.

driver.stop() driver.join() ``` - Klaus Ma On Feb. 6, 2016, 6:46 a.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 42589: Added test case for allocator recover with Quota.

r/42589/#review117197 --- On Jan. 21, 2016, 2:27 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42589/ > --

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

> On Feb. 4, 2016, 9:38 p.m., Klaus Ma wrote: > > 3rdparty/libprocess/src/process.cpp, line 2211 > > <https://reviews.apache.org/r/43144/diff/1/?file=1231709#file1231709line2211> > > > > Just `os::getenv("LIB...")` is OK. > > Maged Mich

Re: Review Request 40375: Support distinguishing revocable resources in the Resource protobuf.

d e-mail. To reply, visit: https://reviews.apache.org/r/40375/#review117796 ------- On Jan. 7, 2016, 11:43 a.m., Klaus Ma wrote: > > --- > This is an automatically g

Re: Review Request 43149: Add LIBPROCESS_THREAD_COUNT to override the thread pool size.

tps://reviews.apache.org/r/43149/#comment179067> Check negative and zero value. 3rdparty/libprocess/src/process.cpp (line 2205) <https://reviews.apache.org/r/43149/#comment179068> Add test for this patch. - Klaus Ma On Feb. 4, 2016, 8:40 a.m., James

Re: Review Request 43144: Added env var to set upper bound on number of worker threads.

tps://reviews.apache.org/r/43144/#comment179070> blank line before. 3rdparty/libprocess/src/process.cpp (line 2211) <https://reviews.apache.org/r/43144/#comment179069> Just `os::getenv("LIB...")` is OK. - Klaus Ma On Feb. 4, 2016, 4:57 a.m

Re: Review Request 42516: Add support for user-defined networks.

g/r/42516/#comment180148> Also check whether `network_name()` is empty string `""`. please add unit test cases for this patches; refer to `bridge` test cases. - Klaus Ma On Feb. 10, 2016, 4:34 p.m., Ez

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

-- On Jan. 19, 2016, 10:55 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41305/ >

Re: Review Request 41305: MESOS-1718: move getExecutorInfo from slave to master.

slave did not report `slaveInfo`, right? - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41305/#review115703 -------

Re: Review Request 42908: Fixed a flaky test in quota tests.

> On Jan. 29, 2016, 4:42 p.m., Klaus Ma wrote: > > src/tests/master_quota_tests.cpp, line 957 > > <https://reviews.apache.org/r/42908/diff/1/?file=1224834#file1224834line957> > > > > Just check the code on `setQuota-->rescindOffer`, why not let al

Re: Review Request 42908: Fixed a flaky test in quota tests.

apache.org/r/42908/#comment178000> ``` driver.stop(); driver.join(); ``` - Klaus Ma On Jan. 28, 2016, 8:20 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 42946: Replaced tabs with spaces in configure.ac.

in configure.ac. Diffs - configure.ac cb39c7f Diff: https://reviews.apache.org/r/42946/diff/ Testing --- ../configure make Thanks, Klaus Ma

Re: Review Request 42908: Fixed a flaky test in quota tests.

> On Jan. 29, 2016, 4:42 p.m., Klaus Ma wrote: > > src/tests/master_quota_tests.cpp, line 957 > > <https://reviews.apache.org/r/42908/diff/1/?file=1224834#file1224834line957> > > > > Just check the code on `setQuota-->rescindOffer`, why not let al

Re: Review Request 42876: Disallowed non-`const` iteration over `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42876/#review116661 --- Ship it! Ship It! - Klaus Ma On Jan. 28, 2016, 6:50 a.m

Re: Review Request 42877: Cleaned up MesosSchedulerDriver shutdown in unit tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42877/#review116670 --- Ship it! Ship It! - Klaus Ma On Jan. 28, 2016, 6:56 a.m

Re: Review Request 42662: Added common command utils file.

/#comment177757> Add a case for `tar/untar` failure. - Klaus Ma On Jan. 28, 2016, 4:29 a.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 42792: Fix compile error in container logger tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42792/#review116333 --- Ship it! Ship It! - Klaus Ma On Jan. 26, 2016, 4:12 p.m

Re: Review Request 42589: Added test case for allocator recover with Quota.

for allocator recover with Quota? - Klaus Ma On Jan. 21, 2016, 2:27 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41772: Added helper function to flatten resources.

k that we cannot rename it to `flatten` as the compiler will not > know what does `flatten()` mean. > > Klaus Ma wrote: > Regarding from `RevocableInfo::Type` to `RevocableInfo`, do you mean > change `RevocableInfo` from `message` to `enum`? I think it's better to > def

Review Request 42946: Replace tabs with spaces in configure.ac.

tabs with spaces in configure.ac. Diffs - configure.ac cb39c7f Diff: https://reviews.apache.org/r/42946/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 42946: Replace tabs with spaces in configure.ac.

/diff/ Testing (updated) --- ../configure make Thanks, Klaus Ma

Re: Review Request 40632: Enabled oversubscribed resources for reservations in allocator.

sorter, and the offer maybe wrong in about cases. - Klaus Ma On Jan. 23, 2016, 11:18 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 42936: Edited flag help strings for style.

tps://reviews.apache.org/r/42936/#comment177994> Move "By" to the next line. - Klaus Ma On Jan. 29, 2016, 12:30 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 43879: Added allocator metrics for number of allocations made.

tps://reviews.apache.org/r/43879/#comment181976> Why a anonymous namespace? `static` should be fine. src/tests/hierarchical_allocator_tests.cpp (line 2395) <https://reviews.apache.org/r/43879/#comment181975> What are you going to do for this comments? or just a notes? - Klaus

Re: Review Request 43880: Added allocator metrics for total and allocated scalar resources.

s.apache.org/r/43880/#comment181980> Can we move the comments above the code and move `getMetric()` into one line? - Klaus Ma On Feb. 24, 2016, 6:58 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail

Re: Review Request 43816: Updated `/frameworks` master endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43816/#review120272 --- Ship it! Ship It! - Klaus Ma On Feb. 22, 2016, 3:11 p.m

Re: Review Request 43868: Add a getter for master::Flags.

f so, please clear it up. Can you also show which part of code will use this function? - Klaus Ma On Feb. 23, 2016, 1:23 p.m., Jay Guo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 42390: Fixed fetching uris when slave is running inside a container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42390/#review120296 --- Ship it! Ship It! - Klaus Ma On Jan. 20, 2016, 10:12 p.m

Re: Review Request 43823: Updated `/tasks` master endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43823/#review120292 --- Ship it! Ship It! - Klaus Ma On Feb. 22, 2016, 3:13 p.m

Re: Review Request 43848: Used `size_t` to track number of frameworks per role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43848/#review120294 --- Ship it! Ship It! - Klaus Ma On Feb. 23, 2016, 3:54 a.m

Re: Review Request 43822: Updated `/slaves` master endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43822/#review120291 --- Ship it! Ship It! - Klaus Ma On Feb. 22, 2016, 3:12 p.m

Re: Review Request 43864: Fix typo of roles doc.

r/43864/#review120347 --- On Feb. 24, 2016, 11:34 a.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 43864: Fix typo of roles doc.

/http.cpp 939fab21a2240de7214ef809a194ffb3837a9f1b Diff: https://reviews.apache.org/r/43864/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 43884: Added allocator metrics for used quotas.

tps://reviews.apache.org/r/43884/#comment182802> Remove it when removeQuota. src/master/allocator/mesos/hierarchical.cpp (line 1108) <https://reviews.apache.org/r/43884/#comment182803> This's not necessary; all resources in quotaSorter are `nonRevocable()`. - Klaus Ma On Feb.

Re: Review Request 43718: Added fs::supported() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43718/#review121140 --- Ship it! Ship It! - Klaus Ma On Feb. 28, 2016, 9:08 p.m

Re: Review Request 44047: Added full reserved resource info to `/slaves` master endpoint.

g/r/44047/#comment182798> s/slave/agent/ src/master/http.cpp (line 1047) <https://reviews.apache.org/r/44047/#comment182799> `` for /unreserve and /destroy-volumes. - Klaus Ma On Feb. 28, 2016, 8:17 a.m., Neil

Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44110/#review121151 --- Ship it! Ship It! - Klaus Ma On Feb. 27, 2016, 8:55 a.m

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

> On Feb. 26, 2016, 12:30 a.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 376 > > <https://reviews.apache.org/r/43881/diff/7/?file=1270846#file1270846line376> > > > > We also need to remove counter in `removeFramework`; or

Re: Review Request 43718: Added fs::supported() function.

> On Feb. 28, 2016, 9:16 p.m., Guangya Liu wrote: > > src/linux/fs.cpp, line 60 > > > > > > I think that should `continue` here, if one line failed, other lines > > should still be tried to see if the fs is

Re: Review Request 44063: Waited for status update to happen before proceeding in test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44063/#review121143 --- Ship it! Ship It! - Klaus Ma On Feb. 28, 2016, 6:27 p.m

Re: Review Request 43883: Added allocator metrics for number of offer filters per framework.

tps://reviews.apache.org/r/43883/#comment182801> Should we remove this `Gauge` when remove framework? - Klaus Ma On Feb. 27, 2016, 1:01 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 43881: Added allocator metric for the number of allocations to a framework.

eviews.apache.org/r/43881/#comment182182> ditto - Klaus Ma On Feb. 25, 2016, 7:37 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 43882: Added allocation metrics for allocation time.

tps://reviews.apache.org/r/43882/#comment182184> It seems a general functional class, can we move it into `process/metrics`? - Klaus Ma On Feb. 25, 2016, 7:37 p.m., Benjamin Bannier wrote: > > --- > This is an automatica

Re: Review Request 43561: Improve Ranges parsing to handle single values.

/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11 src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 Diff: https://reviews.apache.org/r/43561/diff/ Testing --- make make check GTEST_FILTER=~"*" ./src/mesos-test Thanks, Klaus Ma

Re: Review Request 43838: Added note about not implemented requestResources call.

tps://reviews.apache.org/r/43838/#comment181681> It seems scheduler did not send `ResourceRequestMessage` to the master; so other allocator also can not handle it. I'd like to say Master ignore this call. - Klaus Ma On Feb. 23, 2016, 12:54 a.m., Joerg Schad

Review Request 43864: Fix typo of roles doc.

--- Fix typo of roles doc. Diffs - docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83 docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 Diff: https://reviews.apache.org/r/43864/diff/ Testing --- Thanks, Klaus Ma

<    1   2   3   4   5   6   7   >