On Sat, 20 Feb 2021 11:35:18 GMT, Lin Zang wrote:
>> Marked as reviewed by cjplummer (Reviewer).
>
> Mark it as ready for pushing. Thanks @plummercj @sspitsyn and @YaSuenag for
> help reviewing!
Dear All，
May I ask your help to push this PR as it is ready.
Thanks!
Lin
-
PR: https
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
refine the argument name
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/files
- new: https:/
On Fri, 19 Feb 2021 20:01:08 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - fix indentation isue
>> - fix help message issue and Use ByteBuffer for integer writing
>
> Marked as reviewed by cjplu
On Sat, 20 Feb 2021 10:48:22 GMT, Serguei Spitsyn wrote:
>> Lin Zang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - fix indentation isue
>> - fix help message issue and Use ByteBuffer for integer writing
>
> Hi Lin,
> I'm sorry for t
On Wed, 10 Feb 2021 04:04:56 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - fix indentation isue
> - fix help message issue and Use Byt
On Wed, 10 Feb 2021 04:04:56 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - fix indentation isue
> - fix help message issue and Use Byt
On Wed, 10 Feb 2021 04:23:43 GMT, Yasumasa Suenaga wrote:
>> Lin Zang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - fix indentation isue
>> - fix help message issue and Use ByteBuffer for integer writing
>
> Marked as reviewed by ys
On Wed, 10 Feb 2021 02:42:26 GMT, Lin Zang wrote:
> Do you think it is ok to also change these codes? If my understanding is
> correct, the fileOutputStream does not have the process of big/little endian.
Yes, I agree with your latest change. It looks good to me.
-
PR: https://git
On Wed, 10 Feb 2021 04:04:56 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - fix indentation isue
> - fix help message issue and Use Byt
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with two additional commits
since the last revision:
- fix indentation isue
- fix help message issue and Use ByteBuffer for integer writing
-
Changes:
- all: ht
On Wed, 10 Feb 2021 01:53:38 GMT, Yasumasa Suenaga wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refine code in test.
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
> line
On Wed, 10 Feb 2021 01:53:38 GMT, Yasumasa Suenaga wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refine code in test.
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
> line
On Tue, 9 Feb 2021 10:04:55 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refine code in test.
src/jdk.hotspot.agent/share/classes/sun/j
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
refine code in test.
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/files
- new: https://git
On Tue, 9 Feb 2021 08:28:57 GMT, Serguei Spitsyn wrote:
>> Dear Serguei,
>>
>>> There are two checks for cntTokens > 2. The second check has to be removed.
>>> Also, a return needs to be added after the line 1779 with "usage();" , so
>>> the "else" statement can be removed.
>>> This has to be r
On Tue, 9 Feb 2021 04:27:44 GMT, Serguei Spitsyn wrote:
>> Thanks @plummercj @sspitsyn @YaSuenag a lot for helping review this PR
>> again and again!
>> I have marked it as ready for push.
>
> Hi Lin,
>
> Sorry for confusing you but I've not noticed a duplication in your code:
>
> 1778
On Tue, 9 Feb 2021 06:37:21 GMT, Lin Zang wrote:
>> Hi Lin,
>>
>> Sorry for confusing you but I've not noticed a duplication in your code:
>>
>> 1778 if (cntTokens > 2) {
>> 1779 usage();
>> 1780 } else {
>> 1781 JMap jmap
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
remove redundant check
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/files
- new: https://g
On Tue, 9 Feb 2021 02:38:44 GMT, Lin Zang wrote:
>> Marked as reviewed by cjplummer (Reviewer).
>
> Thanks @plummercj @sspitsyn @YaSuenag a lot for helping review this PR again
> and again!
> I have marked it as ready for push.
Hi Lin,
Sorry for confusing you but I've not noticed a duplicati
On Mon, 8 Feb 2021 22:03:18 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refine code for argument parsing
>
> Marked as reviewed by cjplummer (Reviewer).
Thanks @plummercj @sspitsyn @YaSuenag a
On Mon, 8 Feb 2021 08:05:09 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refine code for argument parsing
Marked as reviewed by cjplumm
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
refine code for argument parsing
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/files
- new:
On Sun, 7 Feb 2021 08:20:10 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - add test in HeapDumpTest and fix in argument parsing
> - rev
On Thu, 4 Feb 2021 03:54:26 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - fix an issue of double printing error message.
>> - fix jcmd jmap issue and add test in BascJMapTest and code refine
>
>
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with two additional commits
since the last revision:
- add test in HeapDumpTest and fix in argument parsing
- revert changes in jcmd jmap
Another PR has been created for
On Sat, 6 Feb 2021 04:42:32 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refine help message and also refactor the logic in CommandProcessor
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot
On Fri, 5 Feb 2021 15:36:00 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refine help message and also refactor the logic in CommandProce
On Fri, 5 Feb 2021 19:58:42 GMT, Serguei Spitsyn wrote:
>> Dear @plummercj,
>>
>>> `--dumpfile` and `--gz` can only be used with `--binaryheap`. That should
>>> be made clear in the help text.
>>
>> I added indentation for these two sub-options.
>>
>>> * SA's `jhsdb jmap --binaryheap` (which
On Thu, 4 Feb 2021 23:23:41 GMT, Chris Plummer wrote:
>> Thanks for the thorough list, I have tested most of them but not all. I will
>> cover them and update here later.
>>
>>> So really there are two implementations of heap dumping, one in the VM and
>>> one in SA, but a total of 5 ways to g
On Fri, 5 Feb 2021 15:32:26 GMT, Lin Zang wrote:
>> One implementation is in the JVM itself, to be used when the JVM is still
>> running well, and not just from command line tools. Heap dumping can also be
>> triggered by the JVM itslef by setting flags like -XX:+HeapDumpBeforeFullGC.
>> The o
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
refine help message and also refactor the logic in CommandProcessor
-
Changes:
- all: https://git.openjdk.ja
On Fri, 5 Feb 2021 15:01:26 GMT, Lin Zang wrote:
>> Also, this method can be refactored to something like this (the check for
>> exactly one option argument is needed):
>>private int parseHeapDumpCompressionLevel(String option) {
>>String[] keyValue = option.split("=");
>>if
On Fri, 5 Feb 2021 10:36:25 GMT, Serguei Spitsyn wrote:
>> Hi Lin,
>>
>> A week ago you replied that you are accepting the following suggested
>> refactoring:
>>
>>/*
>> * Possible commands:
>> * dumpheap gz=1 file
>>
On Fri, 5 Feb 2021 10:03:09 GMT, Serguei Spitsyn wrote:
>> One implementation is in the JVM itself, to be used when the JVM is still
>> running well, and not just from command line tools. Heap dumping can also be
>> triggered by the JVM itslef by setting flags like -XX:+HeapDumpBeforeFullGC.
>
On Thu, 4 Feb 2021 23:23:41 GMT, Chris Plummer wrote:
>> Thanks for the thorough list, I have tested most of them but not all. I will
>> cover them and update here later.
>>
>>> So really there are two implementations of heap dumping, one in the VM and
>>> one in SA, but a total of 5 ways to g
On Thu, 4 Feb 2021 08:10:00 GMT, Lin Zang wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/SALauncher.java line 130:
>>
>>> 128: System.out.println("--binaryheapTo dump java
>>> heap in hprof binary format.");
>>> 129: System.out.println("--dumpf
On Fri, 29 Jan 2021 22:54:57 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - fix an issue of double printing error message.
>> - fix jcmd jmap issue and add test in BascJMapTest and code refine
>
On Fri, 29 Jan 2021 22:51:23 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - fix an issue of double printing error message.
>> - fix jcmd jmap issue and add test in BascJMapTest and code refine
>
On Fri, 29 Jan 2021 05:39:59 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - fix an issue of double printing error message.
> - fix jcmd
On Thu, 28 Jan 2021 22:33:53 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix the logic of using gz= as file name
>
> You added clhsdb testing to ClhsdbDumpheap.java, but I had also suggested
> a
On Fri, 29 Jan 2021 05:14:31 GMT, Lin Zang wrote:
>> Hi Lin,
>>
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java
>>
>> Thank you for the update.
>>
>> The list of possible commands must include one more variant with no
>> arguments:
>> + * Possi
On Fri, 29 Jan 2021 05:33:19 GMT, Serguei Spitsyn wrote:
> You are right.
> So, in my suggestion just replace this block:
>
> ```
> if (gzlevel <= 0 || gzlevel > 9) {
> err.println("Invalid "gz=" option: " + option);
>
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with two additional commits
since the last revision:
- fix an issue of double printing error message.
- fix jcmd jmap issue and add test in BascJMapTest and code refine
--
On Fri, 29 Jan 2021 04:27:32 GMT, Serguei Spitsyn wrote:
>> You added clhsdb testing to ClhsdbDumpheap.java, but I had also suggested
>> adding testing to BasicJMapTest.java to test pmap. Can you please add some
>> testing there also?
>
> Hi Lin,
>
> src/jdk.hotspot.agent/share/classes/sun/jvm
On Thu, 28 Jan 2021 22:33:53 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix the logic of using gz= as file name
>
> You added clhsdb testing to ClhsdbDumpheap.java, but I had also suggested
> a
On Thu, 28 Jan 2021 22:33:53 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix the logic of using gz= as file name
>
> You added clhsdb testing to ClhsdbDumpheap.java, but I had also suggested
> a
On Wed, 27 Jan 2021 23:54:58 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix the logic of using gz= as file name
src/jdk.hotspot.agent
On Wed, 27 Jan 2021 23:54:58 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix the logic of using gz= as file name
You added clhsdb test
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix the logic of using gz= as file name
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/files
On Wed, 27 Jan 2021 20:22:00 GMT, Serguei Spitsyn wrote:
>>> Do you think it is reasonable to treat "gz=[number]/[non-number]"
>>> differently in this case? or should it just exit with error for all "gz="
>>> options that is not in the range of compression level? BTW, I think your
>>> suggeste
On Wed, 27 Jan 2021 18:58:01 GMT, Chris Plummer wrote:
> I think we should produce an error for something like gz=abc rather than use
> that as the filename, because I think it is likely user error.
Agreed. My suggestion was exactly this. We have to return an error in any
attempt to start filen
On Wed, 27 Jan 2021 10:36:54 GMT, Lin Zang wrote:
> Do you think it is reasonable to treat "gz=[number]/[non-number]" differently
> in this case? or should it just exit with error for all "gz=" options that is
> not in the range of compression level? BTW, I think your suggested code is
> bette
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix code in CommandProcessor
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/files
- new: htt
On Tue, 26 Jan 2021 10:03:13 GMT, Serguei Spitsyn wrote:
>> Copyrights need updating.
>
> Minor suggestion for
> `src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/JMap.java`:
> +} else if (keyValue[0].equals("gz")) {
> +if (keyValue.le
On Tue, 26 Jan 2021 12:42:41 GMT, Lin Zang wrote:
> This is used to guard the case cntTokens == 0, otherwise that t.nextToken()
> will throw ArrayIndexOutOfBoundsException.
The line `String option = t.nextToken();` can be moved to each of two if
statements:
if (cntTokens == 2) {
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix issue cause JMapHProfLargeHeapTest fail and code refine
-
Changes:
- all: https://git.openjdk.java.net/j
On Wed, 27 Jan 2021 06:38:02 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - update copyright info
> - fix commandline argument issue an
On Tue, 26 Jan 2021 19:44:55 GMT, Chris Plummer wrote:
>> Dear @plummercj,
>> I have made investigation on extending GZIPOutputStream, since it is not
>> possible to override/overwrite private method writeHeader(), the only way I
>> could figure out is to create a class named HProfGZIPOutputS
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with two additional commits
since the last revision:
- update copyright info
- fix commandline argument issue and refine test cases
-
Changes:
- all: https://gi
On Tue, 26 Jan 2021 12:24:16 GMT, Lin Zang wrote:
>> As for any testing requirement, maybe you could pass in a flag to Reader
>> indicating whether or not the testing requires the "HPROF BLOCKSIZE"
>> comment.
>
> Dear @plummercj,
> I have made investigation on extending GZIPOutputStream, si
On Tue, 26 Jan 2021 08:50:06 GMT, Serguei Spitsyn wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java
>> line 2119:
>>
>>> 2117: }
>>> 2118: } else {
>>> 2119: err.println("Unknow option \"" + option + "\"");
>>
>> "Unknown"
>
> -
On Tue, 26 Jan 2021 04:41:40 GMT, Chris Plummer wrote:
>> So the problem is that the code in GzipRandomAccess.getAccess() returns NULL
>> if it doesn't find the "HPROF BLOCKSIZE" comment, but you are also saying
>> that tools like heaphero.io work fine without the comment. So maybe you just
>>
On Tue, 26 Jan 2021 08:50:06 GMT, Serguei Spitsyn wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java
>> line 2119:
>>
>>> 2117: }
>>> 2118: } else {
>>> 2119: err.println("Unknow option \"" + option + "\"");
>>
>> "Unknown"
>
> -
On Tue, 26 Jan 2021 04:41:40 GMT, Chris Plummer wrote:
>> So the problem is that the code in GzipRandomAccess.getAccess() returns NULL
>> if it doesn't find the "HPROF BLOCKSIZE" comment, but you are also saying
>> that tools like heaphero.io work fine without the comment. So maybe you just
>>
On Mon, 25 Jan 2021 21:34:54 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix coding style issue
>
> Copyrights need updating.
Minor suggestion for
`src/jdk.hotspot.agent/share/classes/sun/jvm/h
On Mon, 25 Jan 2021 20:53:19 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix coding style issue
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java
> line 2119:
>
>> 2
On Tue, 26 Jan 2021 04:40:19 GMT, Chris Plummer wrote:
>> Sorry for typo. the GzipAccess should be GzipRandomAccess.
>
> So the problem is that the code in GzipRandomAccess.getAccess() returns NULL
> if it doesn't find the "HPROF BLOCKSIZE" comment, but you are also saying
> that tools like hea
On Tue, 26 Jan 2021 04:02:01 GMT, Lin Zang wrote:
>> Hi Chris,
>> Thanks for review and nice catch on this.
>>
>> I have considered using Reader.readFile() but it can not parse the gziped
>> heap dump successfully, and I investigated the reason is that the underlying
>> GzipAccess class requi
On Tue, 26 Jan 2021 03:53:17 GMT, Lin Zang wrote:
>> test/hotspot/jtreg/serviceability/sa/ClhsdbDumpheap.java line 73:
>>
>>> 71: File out = new File(deCompressedFile);
>>> 72: try {
>>> 73: GZIPInputStream gis = new GZIPInputStream(new
>>> FileInputStrea
On Mon, 25 Jan 2021 21:25:54 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix coding style issue
>
> test/hotspot/jtreg/serviceability/sa/ClhsdbDumpheap.java line 73:
>
>> 71: File ou
On Mon, 25 Jan 2021 13:02:56 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix coding style issue
Copyrights need updating.
src/jdk.hot
On Tue, 19 Jan 2021 21:59:16 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix issue of setting gz option with no value
>
> I think you need to add some additional testing. You can use
> ClhsdbDum
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix coding style issue
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/files
- new: https://g
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix serveral issues and add test cases
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/files
On Fri, 22 Jan 2021 07:29:22 GMT, Lin Zang wrote:
>> The check here is to control the segment size. It checks whether the current
>> segment is too large, if yes, it fills the segment size slot in
>> fillInHeapRecordLength() and set currentSegmentStart = 0, meaning to create
>> a new segment
On Fri, 22 Jan 2021 07:04:47 GMT, Lin Zang wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
>> line 475:
>>
>>> 473: if (!useSegmentedHeapDump) {
>>> 474: // Fill in final length
>>> 475: fillInHeapRecordLength();
>>
On Fri, 22 Jan 2021 07:06:17 GMT, Lin Zang wrote:
>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
>> line 490:
>>
>>> 488: hprofBufferedOut = null;
>>> 489: }
>>> 490:
>>
>> Can you explain what this check is for and why it is no longer nee
On Tue, 19 Jan 2021 21:38:28 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code refine
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
> line 490:
>
>> 4
On Tue, 19 Jan 2021 21:35:16 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix issue of setting gz option with no value
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBi
On Tue, 19 Jan 2021 05:43:12 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> code refine
src/jdk.hotspot.agent/share/classes/sun/jvm/hotsp
On Tue, 19 Jan 2021 12:39:12 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix issue of setting gz option with no value
I think you need
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix issue of setting gz option with no value
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/fi
On Tue, 19 Jan 2021 05:43:12 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> code refine
src/jdk.hotspot.agent/share/classes/sun/jvm/hotsp
On Fri, 8 Jan 2021 13:21:21 GMT, Lin Zang wrote:
>> Changes requested by cjplummer (Reviewer).
>
> Hi @plummercj ,
> Thanks very much for reviewing!
> Sorry that I got stuck on other work and didn't read review message timely.
> I will go through your suggestions carefully and try to fix all is
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
code refine
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/files
- new: https://git.openjdk.
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains five additional commits since
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
refine segment heap dump
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/files
- new: https:/
On Mon, 4 Jan 2021 22:35:24 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> delete unnecessary print
>
> Changes requested by cjplummer (Reviewer).
Hi @plummercj ,
Thanks very much for reviewing!
So
On Mon, 4 Jan 2021 22:00:34 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> delete unnecessary print
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/JMap.java line 62:
>
>> 60:
On Thu, 10 Dec 2020 03:08:48 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> delete unnecessary print
Changes requested by cjplummer (Revi
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
delete unnecessary print
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/files
- new: https:/
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
refine comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/files
- new: https://git.open
8257234 : Add gz option to SA jmap to write a gzipped heap dump
-
Commit messages:
- 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Changes: https://git.openjdk.java.net/jdk/pull/1712/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1712&range=00
Issue
93 matches
Mail list logo
