Re: segfault in clientSocketRecipient

2007-07-26 Thread Robert Collins
On Thu, 2007-07-26 at 22:26 -0600, Alex Rousskov wrote: revision 1.593 date: 2002/09/24 10:46:43; author: robertc; state: Exp; lines: +783 -659 Client side refactoring - no functionality changes Does anybody know whether we should resurrect support for the NULL rep case in

Re: SqString

2007-05-24 Thread Robert Collins
On Thu, 2007-05-24 at 11:19 +0200, Henrik Nordstrom wrote: Should we back out SqString for now until the implicit cast issues have been analyzed in more detail, or try fixing it somehow for the 3.0 release? http://www.squid-cache.org/bugs/show_bug.cgi?id=1970 My vote is to defer the

Re: cvs commit: squid3/lib MemPool.cc

2007-05-23 Thread Robert Collins
On Wed, 2007-05-23 at 22:49 +0200, Henrik Nordstrom wrote: Mem::Init needs to be called via the setUp() method, not from an automatic instantiation constructor.. Actually I spent quite some time making it work correctly without setUp. I think manual setup is very annoying and error prone: if

Re: OS builds

2007-05-01 Thread Robert Collins
On Wed, 2007-05-02 at 14:05 +1200, [EMAIL PROTECTED] wrote: Without knowing a lot about the sourceforge compile farm it seems to me we could possible leverage that. Has anyone looked at it before? Not anymore: As of 2007-02-08, SourceForge.net Compile Farm service has been officially

Re: squid3-largeobj squid3/src AccessLogEntry.h,1.7,1.7.10.1 HttpHeader.cc,1.40,1.40.6.1 HttpHeader.h,1.18,1.18.6.1 HttpHeaderTools.cc,1.21,1.21.6.1 HttpMsg.cc,1.29,1.29.6.1 HttpMsg.h,1.14,1.14.6.1 Ht

2007-04-18 Thread Robert Collins
On Wed, 2007-04-18 at 20:52 +0200, Guido Serassio wrote: I think that here should be used the standard ISO C99 macro PRId64 like in Squid 2.6. This allow the portability of the code: on Windows %lld is not available, when on some Unix 64 bit platforms (HP Tru64 is one) %ld must be used

Re: Squid 3.0 bugs that need you.

2007-04-12 Thread Robert Collins
On Fri, 2007-04-13 at 12:45 +1200, [EMAIL PROTECTED] wrote: It has not been linked to the cppunit testers, but I have written a specific test app to check each function and proivide for maula-eye check in increments from simplest up for both ipv4-pure then dual protocol paths. Then it has

Re: Removing cppunit

2007-04-12 Thread Robert Collins
On Thu, 2007-04-12 at 21:01 -0600, Alex Rousskov wrote: Running make check (or whatever it is) would run cppunit test cases if somebody has cppunit installed and should skip them (with a warning) if somebody does not have cppunit installed. If there is a special make target to force

Re: Removing cppunit

2007-04-12 Thread Robert Collins
On Thu, 2007-04-12 at 22:02 -0600, Alex Rousskov wrote: That is good, but I do not think we should require it. Cppunit is a developer tool. Make check is a user-level reassurance that the package was built correctly. I think this is the root of our disagreement. 'make check' to me is not,

Re: Removing cppunit

2007-04-12 Thread Robert Collins
On Fri, 2007-04-13 at 14:29 +1000, Robert Collins wrote: On Thu, 2007-04-12 at 22:02 -0600, Alex Rousskov wrote: That is good, but I do not think we should require it. Cppunit is a developer tool. Make check is a user-level reassurance that the package was built correctly. ... I think

Re: importing logfiles into MySQL

2007-03-21 Thread Robert Collins
On Wed, 2007-03-21 at 17:48 +0800, Adrian Chadd wrote: There's tens of ways of importing Squid logfiles into MySQL (mostly as part of a web utility to analyse/browse/report on Squid use.) I'm writing one for a client and I figure the best thing we can do is include a Squid format MySQL

Re: squid3 comments

2007-02-28 Thread Robert Collins
On Wed, 2007-02-28 at 17:54 -0700, Alex Rousskov wrote: I think we should start from stating the goal of these changes in Squid 3.0. If they are for performance improvement, I would suggest waiting until v3.1 or until performance tests indicate that we must improve Squid 3 performance

Re: clientReplyContext::replyStatus and proxy_keepalive

2007-02-07 Thread Robert Collins
On Wed, 2007-02-07 at 17:42 -0700, Alex Rousskov wrote: Hello, If you understand clientReplyContext::replyStatus, please see if you can help me with the following problem. ... Could somebody please explain the logic here? Specifically, I do not understand why proxy_keepalive flag is

harmless options should default to on ?

2007-01-24 Thread Robert Collins
I just noticed that the follow-xff feature defaults off. I think we should turn *on* features that dont add extra processing to the default pipeline[we have a number :)] - this would make it easier for distros, and wouldn't impact anything except the default executable size. Thoughts? Rob --

Re: proposal: change installed default squid.conf to fit best practice.

2007-01-01 Thread Robert Collins
On Sat, 2006-12-30 at 16:49 +0800, Adrian Chadd wrote: On Sat, Dec 30, 2006, Robert Collins wrote: As we all recommend that users have a minimal config - just the actually set settings, why dont we install that by default ? What I'd actually like to see is a default squid.conf file

proposal: change installed default squid.conf to fit best practice.

2006-12-29 Thread Robert Collins
As we all recommend that users have a minimal config - just the actually set settings, why dont we install that by default ? -Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message part

Re: squid-3 pre?

2006-10-31 Thread Robert Collins
On Wed, 2006-11-01 at 08:55 +0800, Adrian Chadd wrote: Hiya, Whats left to do before the next PRE is released? JFDI. Its better than the current PRE already. -Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message

Re: Squid-2.6 comm_select_win32.c, time for a rewrite to new commloop structure?

2006-10-29 Thread Robert Collins
On Sat, 2006-10-28 at 02:51 +0200, Henrik Nordstrom wrote: WSAAsyncSelect() ... probably better to go straight to overlapped io, which is pretty nice. -Rib -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message part

Re: the way to support content-encoding of HTTP1.1

2006-10-15 Thread Robert Collins
On Fri, 2006-10-13 at 14:56 +0800, 树新 郑 wrote: hi, I've seen the patch modules of squid which support http-gzip transfer mode with http1.1. (These modules's url such as: http://devel.squid-cache.org/projects.html#gzip http://devel.squid-cache.org/stale_projects.html#te

Re: When you'll finish the Squid Programmers Guide?

2006-10-12 Thread Robert Collins
On Wed, 2006-10-11 at 13:14 +0400, Волков Александр wrote: Hello, squid-dev. When you'll finish some chapters of the Squid Programmers Guide? http://www.squid-cache.org/Doc/Prog-Guide/ especially 15. Server Protocols 20. ICP? If you'd like to write some prose for them that would be

Re: protocol clarity

2006-10-10 Thread Robert Collins
On Tue, 2006-10-10 at 09:24 -0600, Alex Rousskov wrote: On Sun, 2006-09-10 at 21:40 +1000, Robert Collins wrote: So I've finished my analysis of the protocol stuff in squid - protocol_t etc. http://wiki.squid-cache.org/ForwardRework has some thoughts about how we can improve

squid bug fest starting

2006-09-29 Thread Robert Collins
Just letting everyone know, the second 3.0 bugfest is starting now on #squiddev on irc.freenode.net. The focus is on getting the last critical issues ironed out as per the roadmap http://wiki.squid-cache.org/RoadMap Cheers, Rob -- GPG key available at: http://www.robertcollins.net/keys.txt.

Re: proposal to remove port 563 from default ACLs

2006-09-29 Thread Robert Collins
On Fri, 2006-09-29 at 16:07 -0600, Duane Wessels wrote: Our default ACL configuration allows CONNECT requests to port 563, which is for NNTP over SSL. Assuming that nobody really uses NNTP over SSL, especially through an HTTP proxy, I suggest that we remove it from the defaults. Agreed. Rob

font for the new artwork buttons?

2006-09-26 Thread Robert Collins
Duane, do you know what font was used in making the sample buttons for the new artwork ? -Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message part

upcoming bug-fest weekend

2006-09-24 Thread Robert Collins
Just a reminder - this coming weekend is the second monthly bugfest for squid-3.0. I'll be there most of the weekend focusing on squid 3.0, though I have a social engagement for lunch on sunday. Hope to see you all there! -Rob -- GPG key available at: http://www.robertcollins.net/keys.txt.

Re: 3.0 branding - release plans - etc

2006-09-15 Thread Robert Collins
On Fri, 2006-09-15 at 12:04 +0200, Henrik Nordstrom wrote: sön 2006-09-10 klockan 21:52 +1000 skrev Robert Collins: I think 3.0 STABLE1 when release should be: * more functional than 2.6 STABLEX - there should be no regressions in functionality. I disagree. It's more important that we

Re: parser bug in -3 ?

2006-09-12 Thread Robert Collins
On Tue, 2006-09-12 at 22:59 +0800, Adrian Chadd wrote: Hiya, I seem to recall a parser bug in -3 thats hiding somewhere in Bugzilla. Something about an extra newline being over-parsed or something. Could someone help me find it, then help me replicate it? It was emitting an extra newline

Re: 3.0 branding - release plans - etc

2006-09-11 Thread Robert Collins
On Mon, 2006-09-11 at 16:57 -0600, Duane Wessels wrote: On Sun, 10 Sep 2006, Robert Collins wrote: So, chatting with Adrian today, and some friends, I have some thoughts about what precisely 3.0 should be. I think 3.0 STABLE1 when release should be: * more functional than 2.6

protocol clarity

2006-09-10 Thread Robert Collins
So I've finished my analysis of the protocol stuff in squid - protocol_t etc. http://wiki.squid-cache.org/ForwardRework has some thoughts about how we can improve the current api, to make SSL fit in more cleanly, and make doing some nifty things, like forwarding via ssh tunnels, or peers that

3.0 branding - release plans - etc

2006-09-10 Thread Robert Collins
So, chatting with Adrian today, and some friends, I have some thoughts about what precisely 3.0 should be. I think 3.0 STABLE1 when release should be: * more functional than 2.6 STABLEX - there should be no regressions in functionality. * within 10-15% of the speed of 2.6 STABLEX. these two

Re: Split out client protocols from protocol_t

2006-09-09 Thread Robert Collins
On Sat, 2006-09-09 at 10:17 +0200, kinkie wrote: http://www.squid-cache.org/bugs/show_bug.cgi?id=1763 has attached to it a split out of the client protocol support from protocol_t. This is fairly important to folk wanting to write new client protocol modules - at the moment they need to

Re: time for a new 3.0 pre ?

2006-09-07 Thread Robert Collins
On Thu, 2006-09-07 at 11:12 +0200, Guido Serassio wrote: Hi, At 00.58 07/09/2006, Henrik Nordstrom wrote: tor 2006-09-07 klockan 07:09 +1000 skrev Robert Collins: With the bug database in better shape, is it time for a new PRE release of 3.0 ? (I think the bug with BodyReady Adrian

time for a new 3.0 pre ?

2006-09-06 Thread Robert Collins
With the bug database in better shape, is it time for a new PRE release of 3.0 ? (I think the bug with BodyReady Adrian is tracking down should be fixed first though). -Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed

september 1st bugfest was a success!

2006-09-06 Thread Robert Collins
Hi, I think the bugfest last weekend was very successful. During the bugfest, we got: * A number of bugs closed including all those marked critical and most of those marked major: http://wiki.squid-cache.org/BugSprintSeptember2006 * reacquainted with the 3.0 codebase * started some

Re: [squid-users] HEAD requests for non existent files on ftp

2006-09-06 Thread Robert Collins
On Wed, 2006-09-06 at 12:33 -0300, Guilherme Salgado wrote: Hi there, Today I was checking if it'd be possible to use squid to proxy FTP HEAD requests for me, and although I found that this is handled in src/ftp.c and using libwww-perl's GET to issue a HEAD request on an existent file gave

Re: STL revisited

2006-09-03 Thread Robert Collins
On Mon, 2006-09-04 at 00:11 +0800, Adrian Chadd wrote: On Sun, Sep 03, 2006, Robert Collins wrote: I'd like to raise the STL again as an option for squid3 rather than NIH'ing a whole bunch of core infrastructure. Its cool. The STL looks nice. The really trippy thing

BodyReader API issue.. [Attention ICAP folk]

2006-09-02 Thread Robert Collins
Working on bug 772, I've tracked it down thusly: When we call initiateClose, we dont fully free the BodyReader, because the one on conn is preserved. If we dont fully free it, then we dont discard the body, it just spools forever because theres no callback. If we do free the bodyreader, we

Who owns ForwardState?

2006-09-02 Thread Robert Collins
I realised today while looking at these bugs that one thing which is a little unclear is who 'owns' a number of our objects. Refcounting is important when there are multiple owners - but I think it will clarify our code if we say who 'should' own objects: I.e. FwdState - who owns it? Right

weekend-long 3.0 bug-fest starting in 2 hours

2006-09-01 Thread Robert Collins
Hiya all. I'm kicking off the 3.0 bugfest in about 2 hours local time. Anyone and everyone is welcome to attend - irc.freenode.net, channel #squiddev. Cheers, Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message

squid-3 style guidelines update ?

2006-09-01 Thread Robert Collins
I'd like to propose an update to the squid-3 styleguidelines... * Avoid taking actions during a constructor * Avoid taking actions during a destructor The intent for the former is to keep testing clean, but not needing large chains of objects to be ready to use when the thing being tested is

squid3 nt port - mainline

2006-08-29 Thread Robert Collins
Guido, I'm wondering what parts of the nt port could be brought into the trunk. I.e. your WinAIO and WinDiskThreads code ? -Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message part

Re: OpenSSL and Bug #1716

2006-08-27 Thread Robert Collins
On Sun, 2006-08-27 at 12:17 +0200, Guido Serassio wrote: Hi Henrik, At 00.22 27/08/2006, Guido Serassio wrote: Tomorrow morning I will try to define a complete test suite, still I don't have found a rule of how this diabolic function prototype works ... :-) I have completed the tests,

Re: [PATCH] Make URN support an optional component

2006-08-27 Thread Robert Collins
On Sun, 2006-08-27 at 21:00 +0800, Adrian Chadd wrote: I like the intention of this patch but: * I don't think we should be messing around with everything before we've at least -released- Squid-3 (And it pains me to say this, because _I_ want to start taking as much of a knife to the

Re: [PATCH] Make URN support an optional component

2006-08-27 Thread Robert Collins
On Sun, 2006-08-27 at 21:24 +0800, Adrian Chadd wrote: Its a good goal. The trouble is that you're creating new APIs just by refactoring. It might be easy to change the API(s) at the point you've done the refactoring but I don't think it'll be so easy to do later on as other code is

[PATCH] Make URN support an optional component

2006-08-26 Thread Robert Collins
This rather large patch starts breakout apart the bidirectional dependencies between the forwarding logic and the protocol implementations. The current result is that the URN protocol is now utterly invisible to all of the code except for the url parser which dispatches based on finding a matching

Re: [PATCH] Make URN support an optional component

2006-08-26 Thread Robert Collins
On Sun, 2006-08-27 at 00:51 +1000, Robert Collins wrote: This rather large patch starts breakout apart the bidirectional dependencies between the forwarding logic and the protocol implementations. The current result is that the URN protocol is now utterly invisible to all of the code except

file == ftp ?!?!

2006-08-25 Thread Robert Collins
Currently squid treats a request for file:// as an alias to ftp://. I think this is bogus as all browsers I know of treat file:// as the local file scheme. I'd like to remove this alias support from squid. Any objections? -Rob -- GPG key available at: http://www.robertcollins.net/keys.txt.

Re: Squid 2.6 crash

2006-08-24 Thread Robert Collins
On Thu, 2006-08-24 at 13:27 +0200, Guido Serassio wrote: Hi Henrik, At 12.40 24/08/2006, Guido Serassio wrote: Hi Henrik, Just found how to crash Squid 2.6 (latest CVS) ... :-( - Enable authenticated only access - Add to ERR_INVALID_REQ error file User: %aP - reload error

Re: EventLoop shutdown procedure..

2006-08-22 Thread Robert Collins
On Tue, 2006-08-22 at 17:10 +0800, Adrian Chadd wrote: On Mon, Aug 21, 2006, Robert Collins wrote: I'd like to make the shutdown procedure async as well - allowing things like swap log writing to use calls elsewhere in the codebase that are async - like the disk engines. Can this wait

EventLoop shutdown procedure..

2006-08-21 Thread Robert Collins
I'd like to make the shutdown procedure async as well - allowing things like swap log writing to use calls elsewhere in the codebase that are async - like the disk engines. Heres my proposed api: - on EventLoop you can call addShutdownEvent(callback, callbackdata); - this builds up a vector of

3.0 bugfix-fest saturday 2nd - Sunday 3rd september - #squiddev on irc.freenode.net

2006-08-20 Thread Robert Collins
Hi y'all. I plan to spend all my saturday the 2nd september working on 3.0's critical and major bugs. (gawd, bugzilla search urls bite :)

Re: ccache and distcc, take two

2006-08-17 Thread Robert Collins
On Thu, 2006-08-17 at 01:07 +0200, Kinkie wrote: On Thu, 2006-08-17 at 00:03 +0200, Henrik Nordstrom wrote: ons 2006-08-16 klockan 01:36 +0200 skrev Kinkie: Hi all, this is a second attempt at getting autoconf/automake to understand our desire to get builds faster, and this attempt

sf.net CVS commit messages

2006-08-15 Thread Robert Collins
Can we get these to be unidiff -p based rather than the current context diffs ? Cheers, Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message part

epoll - funky copied code?

2006-08-11 Thread Robert Collins
for (;;) { num = epoll_wait(kdpfd, pevents, SQUID_MAXFD, msec); statCounter.select_loops++; if (num = 0) break; if (ignoreErrno(errno)) break; getCurrentTime(); PROF_stop(comm_check_incoming); return

Refactoring event loop

2006-08-06 Thread Robert Collins
I've just checked in a refactoring of the event loop to squid-3. This is mostly harmless. It will likely have one negative impact though: the selftest for EventLoop() will fail if the comms module being built is not updated to the new protocol because the comms code has a now-inappropriate assert

Re: logfile writing

2006-07-16 Thread Robert Collins
On Mon, 2006-07-17 at 00:15 +0200, Henrik Nordstrom wrote: sön 2006-07-16 klockan 21:49 +0800 skrev Adrian Chadd: I've written some code to push logfile writing into an external process, freeing up the main squid process from the potentially blocking stdio writes. Good. This code

Re: 2.6.PRE1 is out the door

2006-05-30 Thread Robert Collins
On Tue, 2006-05-30 at 15:04 +0800, Adrian Chadd wrote: On Mon, May 29, 2006, Jason Titus wrote: Have you considered using libevent as a way to abstract out the polling method? Seems like it might make porting easier and give you kqueue as well...

Re: making cache manager presence/registration optional

2006-05-29 Thread Robert Collins
On Mon, 2006-05-29 at 11:13 -0300, Gonzalo Arana wrote: I've just noticed these other issues: 1) epoll is enabled 2) xprof is not used 3) delay pools are not enabled Attached is a proposal for this (supersedes my previous patch). Thanks, applied. Rob -- GPG key available at:

MEMPROXY_CLASS and virtual methods and cbdata class's

2006-05-27 Thread Robert Collins
saw this comment today.. // reset should not reset the protocol; could have made protoPrefix a // virtual function instead, but it is not clear whether virtual methods // are allowed with MEMPROXY_CLASS() and whether some cbdata void* // conversions are not going to kill virtual tables

making cache manager presence/registration optional

2006-05-27 Thread Robert Collins
I'd like to make the cachemgrRegister calls in various of our fooInit() calls not require dragging in the whole squid to the binary, this is part of the blow-out on linked in objects for squid. Secondly, I'd like to remove the idea of the cachemanager being a global object and make it be

test suite breakage.

2006-05-26 Thread Robert Collins
I fixed the http range requests last weekend, this weekend I see: /home/robertc/source/squid/squid--HEAD--3.0/src/tests/testStoreController.cc: In member function ‘void testStoreController::testStats()’: /home/robertc/source/squid/squid--HEAD--3.0/src/tests/testStoreController.cc:29: error:

Re: C++ question related to casting

2006-05-23 Thread Robert Collins
On Tue, 2006-05-23 at 21:40 +0200, Henrik Nordstrom wrote: tis 2006-05-23 klockan 15:01 -0400 skrev Nick Lewycky: If possible, it should store the HttpHeaderEntry objects themselves instead of pointers to them. Done properly, there shouldn't be any need for a destructor at all. In this

Re: Proposal: Drop the Squid-3.0 patches page

2006-05-05 Thread Robert Collins
On Sat, 2006-05-06 at 02:53 +0200, Henrik Nordstrom wrote: Proposal: Drop the Squid-3 patches page. http://www.squid-cache.org/Version/v3/3.0/bugs/ It's not actively maintained and does not give much benefit to the release process until we are ready to go to STABLE state I think.

Re: [VOTE] Squid-3.0.PRE4 release criteria

2006-05-05 Thread Robert Collins
On Sat, 2006-05-06 at 12:08 +1200, Doug Dixon wrote: All I aim to get Squid-3.0.PRE4 released in four to six weeks' time. The list of bugs to be fixed in 3.0 is here: http://tinyurl.com/f56qm This includes bugs that were discovered in 2.5 but which still need fixing in 3.0. I am

Re: inline the ICAP Makefile ?

2006-05-02 Thread Robert Collins
On Tue, 2006-05-02 at 14:39 -0600, Duane Wessels wrote: On Sun, 30 Apr 2006, Robert Collins wrote: Duane, how do you feel about me inlining the ICAP Makefile into the src Makefile ? It makes it easier for automake to track dependencies, particular when building individual files - less

Re: [patch] refresh bugs

2006-05-01 Thread Robert Collins
On Mon, 2006-05-01 at 19:08 +0200, Henrik Nordstrom wrote: 3. handleIMSGiveClientNewEntry() used to call processMiss() - this caused the duplicate request in bug 1561, and has gone. Was there a reason for doing it this way that still stands? Not that I can think of. I can think of

Re: Squid 3 compile

2006-05-01 Thread Robert Collins
On Mon, 2006-05-01 at 12:53 -0700, Dan Thomson wrote: Hey all, I'm trying to compile squid 3 from the CVS repository and I've come accross a little autoconf problem. I'm using a standard debian/testing system and when I try to bootstrap with automake-1.9 I get the following error:

inline the ICAP Makefile ?

2006-04-30 Thread Robert Collins
Duane, how do you feel about me inlining the ICAP Makefile into the src Makefile ? It makes it easier for automake to track dependencies, particular when building individual files - less recursion etc. I've done it locally, wanted to check before committing it. Rob -- GPG key available at:

Add ostream support for StoreEntry

2006-04-29 Thread Robert Collins
This is a proof of concept patch. On the way to making ufsdump link a much smaller section of squid, I found that anything using Packer requires all of the store. This patch addresses that by adding a replacement for Packer using the C ++ ostream facility: StoreEntryStream stream(anEntry);

HTTPMSGLOCK/UNLOCK

2006-04-28 Thread Robert Collins
I'm unclear why we have these macros rather than smart pointers... having these macros as a pattern means we'll need to learn LOCK/UNLOCK macros for every class that is in use. Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a

StoreEntry conflation : storeAppendPrintf is in the wrong place.

2006-04-28 Thread Robert Collins
I think we should nuke storeAppendPrintf : its really a overloaded concept. The Packer (which in c++ can be a stream easily) is something that is easy to acquire /on/ an entry, and makes the various debugging routines and stats routines we have less coupled to the store, and rather coupled to the

Re: cvs commit: squid3/src cache_cf.cc

2006-04-27 Thread Robert Collins
On Thu, 2006-04-27 at 19:07 +, [EMAIL PROTECTED] wrote: wessels 2006/04/27 13:07:16 MDT Modified files: src cache_cf.cc Log: bugfix: ICAPConfig calls aclParseAccessLine(), which now takes a ConfigParser argument. Use the LegacyParser from cache_cf.cc,

Re: cvs commit: squid3/src cache_cf.cc

2006-04-27 Thread Robert Collins
On Fri, 2006-04-28 at 08:34 +1000, Robert Collins wrote: On Thu, 2006-04-27 at 19:07 +, [EMAIL PROTECTED] wrote: wessels 2006/04/27 13:07:16 MDT Modified files: src cache_cf.cc Log: bugfix: ICAPConfig calls aclParseAccessLine(), which now takes

Re: Path names in testUfs, testNull and testCoss

2006-04-25 Thread Robert Collins
On Tue, 2006-04-25 at 12:12 +0200, Guido Serassio wrote: In testUfs, testNull and testCoss are used path names like testCoss::testCossSearch, testNull::testNullSearch, etc. Heh, I'm already on it :) they are becoming testUfs__test... etc Rob signature.asc Description: This is a

next weekend...

2006-04-25 Thread Robert Collins
So, I did some more today, courtesy of ANZAC day. Hopefully next weekend I'll get another chance to cut some code. I'm thinking of changing strtok - strtok_r in the parser. How portable is strtok_r ? Specifically is it available on mingw, BSD systems ? Rob -- GPG key available at:

Re: Make check fails

2006-04-25 Thread Robert Collins
On Mon, 2006-04-24 at 11:39 +0200, Guido Serassio wrote: Hi Robert, At 23.24 23/04/2006, Robert Collins wrote: On Sun, 2006-04-23 at 13:55 +0200, Guido Serassio wrote: Hi Robert, At 12.39 23/04/2006, Robert Collins wrote: make: *** [check-recursive] Error 1 Tell me

Re: next weekend...

2006-04-25 Thread Robert Collins
On Tue, 2006-04-25 at 14:06 +0200, Guido Serassio wrote: Hi Robert, At 13.52 25/04/2006, Robert Collins wrote: So, I did some more today, courtesy of ANZAC day. Hopefully next weekend I'll get another chance to cut some code. I'm thinking of changing strtok - strtok_r in the parser

Re: STORE_TESTS

2006-04-25 Thread Robert Collins
On Tue, 2006-04-25 at 14:11 +0200, Guido Serassio wrote: Hi Robert, At 11.56 23/04/2006, Robert Collins wrote: Guido - If I read the automake rules right, theres no need to specify the $EXEEXT in the STORE_RULES substition variable. Just verified on MInGW: it fails without $EXEEXT

http/1.1 bugs

2006-04-24 Thread Robert Collins
Henrik, I had a number of bugs open as tasks for making squid 1.1 conformant. You've closed them with a comment about not needing placeholders: I think there is value in having them as a managed TODO list. Is it ok if I reopen them on that basis? Rob -- GPG key available at:

Re: config.test fragments

2006-04-24 Thread Robert Collins
On Mon, 2006-04-24 at 21:46 +0200, Guido Serassio wrote: Hi Duane, At 21.37 24/04/2006, Duane Wessels wrote: seems to me that if we exported all the autoconf values during a config.test run, they would be more portable: see for instance Guido's recent commit to probe /usr/local as well:

Re: config.test fragments

2006-04-24 Thread Robert Collins
On Tue, 2006-04-25 at 01:53 +0200, Henrik Nordstrom wrote: mån 2006-04-24 klockan 22:52 +0200 skrev Guido Serassio: I think that the config.test magic should be true for all platform or for none: the majority of users is a too much indeterminate concept. By majority I refer to the users

STORE_TESTS

2006-04-23 Thread Robert Collins
Guido - If I read the automake rules right, theres no need to specify the $EXEEXT in the STORE_RULES substition variable. Cheers, Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message part

config.test fragments

2006-04-23 Thread Robert Collins
seems to me that if we exported all the autoconf values during a config.test run, they would be more portable: see for instance Guido's recent commit to probe /usr/local as well: unless CPPFLAGS are set correctly that test won't help (because while its on the system, its not available). What

Re: Make check fails

2006-04-23 Thread Robert Collins
On Sun, 2006-04-23 at 13:55 +0200, Guido Serassio wrote: Hi Robert, At 12.39 23/04/2006, Robert Collins wrote: make: *** [check-recursive] Error 1 Tell me, do you inlines enabled or disabled? Should be enabled: /* Keyword used by squid for inlining methods */ #define

anyone played with http://kegel.com/dkftpbench/doc/Poller.html?

2006-04-22 Thread Robert Collins
I'm not planning to put it in squid or anything, I'm more wondering what you thought/think of the API. Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message part

so what is involved in calling squid-3.0 'stable'?

2006-04-22 Thread Robert Collins
Asking adrian on irc - ' 22:34 adrian__ Enough people using it as a traditional forward cache 22:34 adrian__ and saying there aren't any strange problems 22:34 adrian__ Because its got a bad name ' So, what is required. How can we engage the community in making squid-3 stable ? There seems to

Re: squid-3 - cleanup of select_* stuff.

2006-04-22 Thread Robert Collins
Meta comment on this after chatting with adrian - I dont think this will itself make the IO stuff beautiful. But it should allow writing some test helper routines so that anything I find time to fix has a test for it that ensures it stays fixed. -Rob On Sat, 2006-04-22 at 22:23 +1000, Robert

Re: so what is involved in calling squid-3.0 'stable'?

2006-04-22 Thread Robert Collins
On Sun, 2006-04-23 at 00:58 +1200, Reuben Farrelly wrote: On 23/04/2006 12:41 a.m., Robert Collins wrote: Asking adrian on irc - ' 22:34 adrian__ Enough people using it as a traditional forward cache 22:34 adrian__ and saying there aren't any strange problems 22:34 adrian__ Because

Re: so what is involved in calling squid-3.0 'stable'?

2006-04-22 Thread Robert Collins
On Sun, 2006-04-23 at 01:20 +1200, Reuben Farrelly wrote: On 23/04/2006 1:11 a.m., Robert Collins wrote: On Sun, 2006-04-23 at 00:58 +1200, Reuben Farrelly wrote: On 23/04/2006 12:41 a.m., Robert Collins wrote: Asking adrian on irc - ' 22:34 adrian__ Enough people using

Re: so what is involved in calling squid-3.0 'stable'?

2006-04-22 Thread Robert Collins
Meh, and this: Forgetting to remove the enum cascades slightly. --- src/acl.cc 23 Oct 2005 11:55:32 - 1.316 +++ src/acl.cc 22 Apr 2006 13:44:31 - @@ -428,8 +428,7 @@ link = link-next; } -auth_match = NULL; -auth_match = (acl_proxy_auth_match_cache

wikis...

2006-04-21 Thread Robert Collins
I heard that the wiki kinkie had up is ready to go with all content migrated, is it ok if we update the link on squid-cache.org to point to it now ? Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message part

3.0 unit tests

2006-04-21 Thread Robert Collins
I've updated the 3.0 unit tests so 'make check' should work again. There was one thing specifically that I noticed while doing this - the HttpMsg.cc file did a type-check in a method to see if it was an instance of HttpReply. Its usually better to override the method in the specific class that

Re: wikis...

2006-04-21 Thread Robert Collins
On Sat, 2006-04-22 at 00:25 +0200, Henrik Nordstrom wrote: fre 2006-04-21 klockan 22:05 +1000 skrev Robert Collins: I heard that the wiki kinkie had up is ready to go with all content migrated, is it ok if we update the link on squid-cache.org to point to it now ? Has there been

Re: Cannot bootstrap.sh

2006-04-18 Thread Robert Collins
On Tue, 2006-04-18 at 16:07 +1200, Doug Dixon wrote: Great, thanks! I've just obtained the latest squid3 code, but bootstrap.sh is complaining about a missing Makefile.in: $ ./bootstrap.sh automake : autoconfg: libtool : Bootstrapping configure.in:3022: required file

AC_LTDL_DLLIB

2006-04-17 Thread Robert Collins
anyone remember what this call in configure.in was for? It seems to be not present on current autoconf + libtool. --- configure.in21 Mar 2006 23:15:19 - 1.402 +++ configure.in17 Apr 2006 11:47:41 - @@ -32,7 +32,6 @@ AC_PROG_CXX AC_CANONICAL_HOST AC_DISABLE_SHARED

Re: AC_LTDL_DLLIB

2006-04-17 Thread Robert Collins
On Tue, 2006-04-18 at 09:13 +0800, Mr E_T wrote: On Monday 17 April 2006 19:50, Robert Collins wrote: anyone remember what this call in configure.in was for? It seems to be not present on current autoconf + libtool. --- configure.in21 Mar 2006 23:15:19 - 1.402

Re: adding python dependency to the build-chain?

2006-04-16 Thread Robert Collins
On Sun, 2006-04-16 at 17:22 +0200, Kinkie wrote: On Sun, 2006-04-16 at 23:55 +1000, Robert Collins wrote: I've got some automated test stuff that might be useful I've been putting together for a while. Its python based, but integrates with things like cppunit... are there any

Re: squid-2.5 related work

2006-04-14 Thread Robert Collins
On Fri, 2006-04-14 at 10:12 +0200, Henrik Nordstrom wrote: fre 2006-04-14 klockan 08:25 +0800 skrev Adrian Chadd: On Thu, Apr 13, 2006, Henrik Nordstrom wrote: Should it be decided that Squid-2 is reopened then I would be more than happy to candidate for the the role as Squid-2 release

Re: squid-2.5 related work

2006-04-14 Thread Robert Collins
On Fri, 2006-04-14 at 21:12 +0800, Adrian Chadd wrote: On Fri, Apr 14, 2006, Robert Collins wrote: But being able to do temporarily disconnected versioned work without having to worry about resyncing does feel tempting, so maybe it's time to start looking for an alternative to CVS

Re: squid-2.5 related work

2006-04-11 Thread Robert Collins
On Tue, 2006-04-11 at 23:16 +0800, Adrian Chadd wrote: Hiya, There's been quite a lot of interest in squid-2.5 related work but no easy place to put it all. I've found trying to maintain a squid tree with a handful of useful extra functionality patched in quite a pain to manage and I'm sure

Re: Logo

2006-01-23 Thread Robert Collins
On Mon, 2006-01-23 at 10:13 +0100, Kinkie wrote: Second logo just came in, a variation on the first with a different form-factor. I think this is nice. Rob -- GPG key available at: http://www.robertcollins.net/keys.txt. signature.asc Description: This is a digitally signed message part

<    1   2   3   4   5   6   7   >