Re: [Sugar-devel] Review my proposal for GSOC'24 Sugarizer 3D Volume Activity (Harsh Singh)

2024-03-23 Thread Lionel Laské
egards. Lionel Date: Sat, 23 Mar 2024 22:08:52 +0530 > From: Harsh Singh > To: sugar-devel@lists.sugarlabs.org > Subject: [Sugar-devel] Review my proposal for GSOC'24 Sugarizer 3D > Volume Activity > Message-ID: > bf5eya00...@mail.gmail.com> > Co

Re: [Sugar-devel] Review of my GSOC'24 proposal to Sugarizer

2024-03-23 Thread Chihurumnaya Ibiam
I'm guessing you forgot to attach your proposal as none is attached. -- Ibiam Chihurumnaya ib...@sugarlabs.org On Sat, Mar 23, 2024 at 4:48 PM Harsh Singh wrote: > Hi, Lionel Laske > Could you review my proposal? Your feedback would be incredibly helpful. > > Thanks , Harsh Singh >

[Sugar-devel] Review of my GSOC'24 proposal to Sugarizer

2024-03-23 Thread Harsh Singh
Hi, Lionel Laske Could you review my proposal? Your feedback would be incredibly helpful. Thanks , Harsh Singh ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] Review For Proposal (Naveen G)

2023-04-04 Thread Lionel Laské
29 +0530 > From: Naveen G > To: "sugar-devel@lists.sugarlabs.org" > > Subject: [Sugar-devel] Review For Proposal > Message-ID: <1251c958-fca3-4d10-9cfa-c7f6d0bab...@hxcore.ol> > Content-Type: text/plain; charset="us-ascii" > > An HTML attachm

Re: [Sugar-devel] Review for project proposal

2023-04-02 Thread Rishika S V
On Mon, Apr 3, 2023 at 10:53 AM Rishika S V wrote: > Project Name: Music block 4 widgets framework > > sugarlabprojectproposal.pdf Description: Adobe PDF document ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/

[Sugar-devel] Review for project proposal

2023-04-02 Thread Rishika S V
Project Name: Music block 4 widgets framework ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] review of gsoc proposal

2020-03-21 Thread Ashish Aggarwal
Hello Swayam , I went through your proposal . I would suggest you to add more information regarding how will you implement the activities . You have explained what you wanted to build pretty well . Regards Ashish On Sat, 21 Mar 2020 at 17:34, Swayam Samyak Debasis < 1234swayamsam...@gmail.com> wro

Re: [Sugar-devel] Review

2019-12-11 Thread Abhay Malik
Thank you > On Dec 12, 2019, at 11:47, James Cameron wrote: > > Hello Abhay, > > I agree, it has been 38 hours now. I was expecting Ifeanyi Ekperi, > Jaskirat, Vaibhav Aren, or Gourav Sardana to answer. I've answered. > > On Thu, Dec 12, 2019 at 11:27:50AM +0530, Abhay Malik wrote: >> Hey, >

Re: [Sugar-devel] Review

2019-12-11 Thread James Cameron
Hello Abhay, I agree, it has been 38 hours now. I was expecting Ifeanyi Ekperi, Jaskirat, Vaibhav Aren, or Gourav Sardana to answer. I've answered. On Thu, Dec 12, 2019 at 11:27:50AM +0530, Abhay Malik wrote: > Hey, > Hope you all are doing fine, I was just wondering that why hasn’t my >

[Sugar-devel] Review

2019-12-11 Thread Abhay Malik
Hey, Hope you all are doing fine, I was just wondering that why hasn’t my task of making a logo been reviewed by any mentor as it has been more than 36 hours. Thank you, Abhay ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://

[Sugar-devel] Review of the GSoC proposal

2019-03-27 Thread Prabhu Pant
Hello mentors! I am Prabhu Pant, a final year undergraduate student from College of Technology, Pantnagar. I have been contributing to open source from a year now and I would like to work on the project "Create a new set of activities for Sugarizer". I have attached the link to my proposal. Please

Re: [Sugar-devel] Review Request of GSoC Proposal: Making a Beginner Guide

2018-03-26 Thread James Cameron
Good question, Tony. It is for developers. Self-serving. I don't agree with the project at all. I think it is make-work. It doesn't help the children that Sugar is focused on. None of the mentors have made ongoing or material contributions to our existing developer documentation. Very few of

Re: [Sugar-devel] Review Request of GSoC Proposal: Making a Beginner Guide

2018-03-26 Thread Tony Anderson
Is this a 'beginner' in the community of developers or a beginning user of Sugar? Tony On Monday, 26 March, 2018 09:09 AM, Pratul Kumar wrote: Hello, Thanks for the guidance, reviews and feedbacks. Kindly help me with the answer to one of the questions of "You and Community". Question: If

Re: [Sugar-devel] Review Request of GSoC Proposal: Making a Beginner Guide

2018-03-26 Thread Pratul Kumar
Hello, Thanks for the guidance, reviews and feedbacks. Kindly help me with the answer to one of the questions of "You and Community". Question: If your project is successfully completed, what will its impact be on the Sugar Labs community? Give 3 answers, each 1-3 paragraphs in length. The first

Re: [Sugar-devel] Review Request of GSoC Proposal: Making a Beginner Guide

2018-03-20 Thread James Cameron
Thanks, I've no further suggestions. On Tue, Mar 20, 2018 at 08:45:32PM +0530, Pratul Kumar wrote: > * > Hello, > > Thanks for providing feedback and guiding me in the right direction. > I have worked on it and tried to add them and make things bit more refined. > > [1]https://docs.google.com/do

Re: [Sugar-devel] Review Request of GSoC Proposal: Making a Beginner Guide

2018-03-20 Thread Pratul Kumar
Hello, Thanks for providing feedback and guiding me in the right direction. I have worked on it and tried to add them and make things bit more refined. https://docs.google.com/document/d/1Xzn-ub8pBCQuz9-RfltzHqDZqY7uZ2xF77MFP_9fKzw/edit?usp=sharing Kindly have a look at it and if there is somet

Re: [Sugar-devel] Review Request of GSoC Proposal: Making a Beginner Guide

2018-03-19 Thread James Cameron
G'day Pratul, Thanks for the opportunity to comment on your draft proposal. Your proposal suffers from lack of measurable controls for risks. In general, you've added responses to the risks which are mostly either aspirational, hopeful, or procedural. Some of the responses don't address the ris

[Sugar-devel] Review Request of GSoC Proposal: Making a Beginner Guide

2018-03-18 Thread Pratul Kumar
Hello Everyone, I am Pratul Kumar, a sophomore at LNMIIT Jaipur. After discussion with community members previously, I have drafted a proposal with well-thought implementation workflow. As I always believe that nothing in this world is perfect, there is always a scope for improvement in everythin

[Sugar-devel] Review Request for ChimePlay-2

2012-06-10 Thread Art Hunkins
Would a reviewer kindly rescue my ChimePlay-2 from the sandbox? It's been languishing there for about a week, and has unfortunately developed sunburn. And all because he was caught with a small bug and disciplined accordingly. Thanks. Art Hunkins

[Sugar-devel] Review of sound card photogates

2011-03-10 Thread James Cameron
An interesting paper on arXiv ... http://arxiv.org/abs/1103.1760 - shows various photogate sensor designs for attachment to microphone inputs, - describes variations in how microphone inputs on sound cards are wired, - points out some of the value of purpose-built software as opposed to us

Re: [Sugar-devel] Review: [PATCH] Downgrading activities not allowed. (#2164)

2010-10-21 Thread Manusheel Gupta
Sorry for the delayed response on this thread. On Sat, Oct 16, 2010 at 3:09 AM, Sascha Silbe < sascha-ml-reply-to-201...@silbe.org> wrote: > Excerpts from Manusheel Gupta's message of Sat Oct 09 04:46:02 +0200 2010: > > > Ishan tried to add the tag - "Coauthored by" in his patch, and that line >

Re: [Sugar-devel] Review: [PATCH] Downgrading activities not allowed. (#2164)

2010-10-15 Thread Sascha Silbe
Excerpts from Manusheel Gupta's message of Sat Oct 09 04:46:02 +0200 2010: > Ishan tried to add the tag - "Coauthored by" in his patch, and that line > gets scrubbed off. Have you added it right at the end, like you would do with the Reviewed-By: tag? E.g.: (assuming author is set to Shanjit Sin

[Sugar-devel] Review: [PATCH] Downgrading activities not allowed. (#2164)

2010-10-08 Thread Manusheel Gupta
Sascha, Ishan tried to add the tag - "Coauthored by" in his patch, and that line gets scrubbed off. We might have mistaken in understanding your review. Can you elaborate on the format of the patch been worked on by multiple authors? Unfortunately, git does not provide this feature at this junctur

Re: [Sugar-devel] Review of patch submitted by Martin for bug #2087

2010-09-06 Thread Tomeu Vizoso
On Sat, Sep 4, 2010 at 22:20, Aleksey Lim wrote: > On Sat, Sep 04, 2010 at 05:13:03PM +0200, Sascha Silbe wrote: >> Excerpts from Kandarp Kaushik's message of Sat Sep 04 16:16:57 +0200 2010: >> >> [data/sugar.schemas.in] >> > +       >> > +        Protected Activities Bundle Indentifiers >> >> Typ

Re: [Sugar-devel] Review of patch submitted by Martin for bug #2087

2010-09-04 Thread Aleksey Lim
On Sat, Sep 04, 2010 at 05:13:03PM +0200, Sascha Silbe wrote: > Excerpts from Kandarp Kaushik's message of Sat Sep 04 16:16:57 +0200 2010: > > [data/sugar.schemas.in] > > + > > +Protected Activities Bundle Indentifiers > > Typo. Also a bit hard to understand. Something along the lin

Re: [Sugar-devel] Review of patch submitted by Martin for bug #2087

2010-09-04 Thread Sascha Silbe
Excerpts from Kandarp Kaushik's message of Sat Sep 04 16:16:57 +0200 2010: [data/sugar.schemas.in] > + > +Protected Activities Bundle Indentifiers Typo. Also a bit hard to understand. Something along the lines of "Bundle IDs of protected activities" might be better. > +User

[Sugar-devel] Review of patch submitted by Martin for bug #2087

2010-09-04 Thread Kandarp Kaushik
Dear team members, Wish if we could expedite the review of patch submitted by Martin (tch) for bug #2087 - http://bugs.sugarlabs.org/ticket/2087. Appending it. Thank you. Appreciate your support as always. Regards, Kandarp. >From 47678b9155b0c7d970e2c503aadb6e9024317473 Mon Sep 17 00:00:00 20

Re: [Sugar-devel] [REVIEW] adding spiral to Home View

2010-08-07 Thread Gonzalo Odiard
> > > P.S. Random Paint related question. Are you still in the process of tidying > up the toolbar and paint tools? I'm thinking of spending some time there > with the main intention of designing and implementing support for the new > Sugar toolbars. I didn't want to duplicate our effort if you're

Re: [Sugar-devel] [REVIEW] adding spiral to Home View

2010-08-07 Thread Gary Martin
Hi Gonzaalo, On 7 Aug 2010, at 02:09, Gonzalo Odiard wrote: > > - Downloaded a load more activities to try and trigger the spiral, and > notices another three svg icons that don't render correctly in the latest F13 > builds. Scratch, Paint, and Kandid. I'll fix them up and email the activity

Re: [Sugar-devel] [REVIEW] adding spiral to Home View

2010-08-06 Thread Gonzalo Odiard
> - Downloaded a load more activities to try and trigger the spiral, and > notices another three svg icons that don't render correctly in the latest > F13 builds. Scratch, Paint, and Kandid. I'll fix them up and email the > activity authors. > > The Paint icon has been corrected. In the next versio

Re: [Sugar-devel] [REVIEW] adding spiral to Home View

2010-08-06 Thread Walter Bender
On Fri, Aug 6, 2010 at 3:51 PM, Gary Martin wrote: > Hi Walter, > > On 6 Aug 2010, at 19:27, Walter Bender wrote: > >> On Fri, Aug 6, 2010 at 2:18 PM, Walter Bender >> wrote: >>> On Fri, Aug 6, 2010 at 12:19 PM, Sascha Silbe >>> wrote: Excerpts from Gary Martin's message of Fri Aug 06 17:4

Re: [Sugar-devel] [REVIEW] adding spiral to Home View

2010-08-06 Thread Gary Martin
Hi Walter, On 6 Aug 2010, at 19:27, Walter Bender wrote: > On Fri, Aug 6, 2010 at 2:18 PM, Walter Bender wrote: >> On Fri, Aug 6, 2010 at 12:19 PM, Sascha Silbe >> wrote: >>> Excerpts from Gary Martin's message of Fri Aug 06 17:48:36 +0200 2010: >>> patch: malformed patch at line

Re: [Sugar-devel] [REVIEW] adding spiral to Home View

2010-08-06 Thread Walter Bender
On Fri, Aug 6, 2010 at 2:27 PM, Walter Bender wrote: > On Fri, Aug 6, 2010 at 2:18 PM, Walter Bender wrote: >> On Fri, Aug 6, 2010 at 12:19 PM, Sascha Silbe >> wrote: >>> Excerpts from Gary Martin's message of Fri Aug 06 17:48:36 +0200 2010: >>>    patch: malformed patch at line 35: @@

Re: [Sugar-devel] [REVIEW] adding spiral to Home View

2010-08-06 Thread Walter Bender
On Fri, Aug 6, 2010 at 2:18 PM, Walter Bender wrote: > On Fri, Aug 6, 2010 at 12:19 PM, Sascha Silbe > wrote: >> Excerpts from Gary Martin's message of Fri Aug 06 17:48:36 +0200 2010: >> >>>    patch: malformed patch at line 35: @@ -201,6 +202,11 @@ class >>> RingLayout(FavoritesLayout): >>

Re: [Sugar-devel] [REVIEW] adding spiral to Home View

2010-08-06 Thread Walter Bender
On Fri, Aug 6, 2010 at 12:19 PM, Sascha Silbe wrote: > Excerpts from Gary Martin's message of Fri Aug 06 17:48:36 +0200 2010: > >>    patch: malformed patch at line 35: @@ -201,6 +202,11 @@ class >> RingLayout(FavoritesLayout): > It also doesn't apply for me, though at a different point: > >

Re: [Sugar-devel] [REVIEW] adding spiral to Home View

2010-08-06 Thread Sascha Silbe
Excerpts from Gary Martin's message of Fri Aug 06 17:48:36 +0200 2010: >patch: malformed patch at line 35: @@ -201,6 +202,11 @@ class > RingLayout(FavoritesLayout): It also doesn't apply for me, though at a different point: sascha.si...@twin:~/sugar-jhbuild/source/sugar-toolkit$ git am

Re: [Sugar-devel] [REVIEW] adding spiral to Home View

2010-08-06 Thread Gary Martin
Hi Walter, Wanted to give it a quick run in my vm, but when I tried to apply it using patch, it gave me the error: patch: malformed patch at line 35: @@ -201,6 +202,11 @@ class RingLayout(FavoritesLayout): I'm probably doing something dumb, is this the expected way to apply the patch?

[Sugar-devel] [REVIEW] adding spiral to Home View

2010-08-06 Thread Walter Bender
As per http://lists.sugarlabs.org/archive/sugar-devel/2010-August/025874.html I have been experimenting with a variant of the Home View in which the circle morphs into a spiral when the number of icons grows too large. Icons don't shrink until the spiral runs off the screen. With this scheme, we ca

Re: [Sugar-devel] review process changes

2010-06-14 Thread Tomeu Vizoso
On Sat, Jun 12, 2010 at 14:17, Bernie Innocenti wrote: > El Thu, 03-06-2010 a las 12:19 +0200, Tomeu Vizoso escribió: >> Thanks, this is really useful. A few observations: >> >> - how to link tickets and patches? One way is to always end the commit >> message with a link to the bug: http://bugs.su

Re: [Sugar-devel] review process changes

2010-06-12 Thread Bernie Innocenti
El Thu, 03-06-2010 a las 12:19 +0200, Tomeu Vizoso escribió: > Thanks, this is really useful. A few observations: > > - how to link tickets and patches? One way is to always end the commit > message with a link to the bug: http://bugs.sugarlabs.org/ticket/1622 > This is what git-bz does automatica

Re: [Sugar-devel] review process changes

2010-06-03 Thread Tomeu Vizoso
On Thu, Jun 3, 2010 at 09:07, Bernie Innocenti wrote: > El Thu, 03-06-2010 a las 11:55 +1000, James Cameron escribió: >> I don't see a way to make each module a project.  The Patchwork project >> "sugar" would have to encompass all Sugar modules and activities. >> Patchwork prevents me from adding

Re: [Sugar-devel] review process changes

2010-06-03 Thread Bernie Innocenti
El Thu, 03-06-2010 a las 11:55 +1000, James Cameron escribió: > I don't see a way to make each module a project. The Patchwork project > "sugar" would have to encompass all Sugar modules and activities. > Patchwork prevents me from adding another project "paint" that shares > the same mailing list

Re: [Sugar-devel] review process changes

2010-06-02 Thread James Cameron
On Wed, Jun 02, 2010 at 11:45:57AM +0200, Tomeu Vizoso wrote: > On Thu, May 27, 2010 at 08:44, James Cameron wrote: > > On Wed, May 26, 2010 at 01:48:17PM +0200, Tomeu Vizoso wrote: > >> == Issues I need help with == > >> > >> * How can a maintainer keep track of his queue with something like > >>

Re: [Sugar-devel] review process changes

2010-06-02 Thread Tomeu Vizoso
On Thu, May 27, 2010 at 08:44, James Cameron wrote: > On Wed, May 26, 2010 at 01:48:17PM +0200, Tomeu Vizoso wrote: >> == Changes I would like to see == >> >> * Having _all_ reviews in the mailing list. The process already allows >> patches to be sent and discussed in the mailing list, but restric

Re: [Sugar-devel] review process changes

2010-05-26 Thread James Cameron
On Wed, May 26, 2010 at 01:48:17PM +0200, Tomeu Vizoso wrote: > == Changes I would like to see == > > * Having _all_ reviews in the mailing list. The process already allows > patches to be sent and discussed in the mailing list, but restricts it > to "new feature[s] and reasonably big". It also s

Re: [Sugar-devel] review process changes

2010-05-26 Thread Tomeu Vizoso
On Wed, May 26, 2010 at 13:48, Tomeu Vizoso wrote: > Hi, > > would be good to reach some consensus and finally change the review > process as defined in > http://wiki.sugarlabs.org/go/Development_Team/Code_Review Alternatively, we can stay with the same process and discuss instead the several oth

[Sugar-devel] review process changes

2010-05-26 Thread Tomeu Vizoso
Hi, would be good to reach some consensus and finally change the review process as defined in http://wiki.sugarlabs.org/go/Development_Team/Code_Review == Changes I would like to see == * Having _all_ reviews in the mailing list. The process already allows patches to be sent and discussed in th

Re: [Sugar-devel] review process follow-up.

2010-05-26 Thread Tomeu Vizoso
On Wed, May 26, 2010 at 11:56, James Cameron wrote: > On Wed, May 26, 2010 at 10:47:35AM +0200, Tomeu Vizoso wrote: >> I want them to stop doing redundant work, > > Please tell me if I'm doing redundant work, and I'll back off.  It is > often difficult to know what work is being done, so without k

Re: [Sugar-devel] review process follow-up.

2010-05-26 Thread James Cameron
On Wed, May 26, 2010 at 10:47:35AM +0200, Tomeu Vizoso wrote: > I want them to stop doing redundant work, Please tell me if I'm doing redundant work, and I'll back off. It is often difficult to know what work is being done, so without knowledge of this it is quite likely that redundancy will occ

Re: [Sugar-devel] review process follow-up.

2010-05-26 Thread Tomeu Vizoso
On Tue, May 25, 2010 at 17:48, David Farning wrote: > On Tue, May 25, 2010 at 9:34 AM, Tomeu Vizoso wrote: >> Hi David, >> >> thanks a lot for putting some new energy on this discussion, there's >> certainly more opportunities for us in revising this process. > > Certainly, and I will do my best

Re: [Sugar-devel] review process follow-up.

2010-05-25 Thread David Farning
On Tue, May 25, 2010 at 9:34 AM, Tomeu Vizoso wrote: > Hi David, > > thanks a lot for putting some new energy on this discussion, there's > certainly more opportunities for us in revising this process. Certainly, and I will do my best to insure that the process revision is driven by an increase i

Re: [Sugar-devel] review process follow-up.

2010-05-25 Thread Tomeu Vizoso
Hi David, thanks a lot for putting some new energy on this discussion, there's certainly more opportunities for us in revising this process. For background, Bernie and me talked on the phone last week and it helped a lot in aligning our positions on this. When we get the community team up and run

[Sugar-devel] review process follow-up.

2010-05-25 Thread David Farning
I would like to invite input on the new process that Tomeu and Bernie have been developing. I am specifically interested in see how Sugar Labs, OLPC, and third parties such as Activity Central can work together most effectively. Admittedly we are causing a disruption, hopefully one which will cau

Re: [Sugar-devel] Review of our activity

2010-04-08 Thread Tomeu Vizoso
Hi Jose, On Tue, Apr 6, 2010 at 16:38, Jose Camallonga wrote: > Hello everybody, > > I'm Jose a computer science student of FIB (http://www.fib.upc.edu/en.html). > We are developing an activity for Sugar and our director told us to ask here > for a review of our code. Is that correct? Where can I

Re: [Sugar-devel] Review of our activity

2010-04-06 Thread James Simmons
called "Make Your Own Sugar Activities!" which you can read for free at http://flossmanuals.net. It explains using Git and other topics that you might find to be helpful. James Simmons > Date: Tue, 6 Apr 2010 16:38:26 +0200 > From: Jose Camallonga > Subject: [Sugar-devel] Rev

[Sugar-devel] Review of our activity

2010-04-06 Thread Jose Camallonga
Hello everybody, I'm Jose a computer science student of FIB (http://www.fib.upc.edu/en.html). We are developing an activity for Sugar and our director told us to ask here for a review of our code. Is that correct? Where can I attach my cod if that is possible? Thanks . -- Best Regards, Jose Ant

Re: [Sugar-devel] review queue

2010-01-27 Thread Gary C Martin
Hi Luke, On 27 Jan 2010, at 15:35, Luke Faraone wrote: > On Wed, Jan 27, 2010 at 10:33, Tomeu Vizoso wrote: >>> What about submitting the patches to a mailing list (which is as simple as >>> invoking "git send-email" for the submitter) for review instead of on Trac >>> where significant effort i

Re: [Sugar-devel] review queue

2010-01-27 Thread Sascha Silbe
On Wed, Jan 27, 2010 at 10:35:43AM -0500, Luke Faraone wrote: *cough* Launchpad lets you mark bug attachments as patches, so you can quickly do a query to find unreviewed ones. We can do the same in trac with keywords, probably. That's how it currently works. Using a web interface for that is a

Re: [Sugar-devel] review queue

2010-01-27 Thread Luke Faraone
On Wed, Jan 27, 2010 at 10:33, Tomeu Vizoso wrote: >> What about submitting the patches to a mailing list (which is as simple as >> invoking "git send-email" for the submitter) for review instead of on Trac >> where significant effort is required not only to post but also to locate and >> inspect

Re: [Sugar-devel] review queue

2010-01-27 Thread Tomeu Vizoso
On Wed, Jan 27, 2010 at 16:19, Sascha Silbe wrote: > On Wed, Jan 27, 2010 at 03:39:41PM +0100, Tomeu Vizoso wrote: > >> - revive the cron job that posted weekly reports to the mailing list >> about what is in the queue and for how long has been there, > > What about submitting the patches to a mai

Re: [Sugar-devel] review queue

2010-01-27 Thread Sascha Silbe
On Wed, Jan 27, 2010 at 03:39:41PM +0100, Tomeu Vizoso wrote: - revive the cron job that posted weekly reports to the mailing list about what is in the queue and for how long has been there, What about submitting the patches to a mailing list (which is as simple as invoking "git send-email" for

Re: [Sugar-devel] review queue

2010-01-27 Thread Tomeu Vizoso
On Wed, Jan 27, 2010 at 15:52, Mathieu Bridon wrote: > On Wed, Jan 27, 2010 at 15:39, Tomeu Vizoso wrote: >> More thoughts? > > When we submit RPM packages for review in Fedora, we must provide the > output of rpmlint (even if it contains some warnings/errors). The > point is that very often, som

Re: [Sugar-devel] review queue

2010-01-27 Thread Mathieu Bridon
On Wed, Jan 27, 2010 at 15:39, Tomeu Vizoso wrote: > More thoughts? When we submit RPM packages for review in Fedora, we must provide the output of rpmlint (even if it contains some warnings/errors). The point is that very often, someone will build a package, and when the times come to submit it

[Sugar-devel] review queue

2010-01-27 Thread Tomeu Vizoso
Hi, three ideas to make the review queue more agile: - revive the cron job that posted weekly reports to the mailing list about what is in the queue and for how long has been there, - put more resources into reviewing: when someone posts her first patch, unless a lot of effort was put in followi

Re: [Sugar-devel] review of the new toolbars implementation

2009-07-31 Thread Aleksey Lim
On Fri, Jul 31, 2009 at 04:27:37AM +, Aleksey Lim wrote: > On Thu, Jul 30, 2009 at 07:51:07PM +0200, Tomeu Vizoso wrote: > > Hi, > > +class _Palette(gtk.Window): > > > > The palette class is very tricky and is a frequent source of bugs, we > > shouldn't duplicate it. Either we add what you nee

Re: [Sugar-devel] review of the new toolbars implementation

2009-07-31 Thread Tomeu Vizoso
On Fri, Jul 31, 2009 at 06:27, Aleksey Lim wrote: > On Thu, Jul 30, 2009 at 07:51:07PM +0200, Tomeu Vizoso wrote: >> Hi, >> +class _Palette(gtk.Window): >> >> The palette class is very tricky and is a frequent source of bugs, we >> shouldn't duplicate it. Either we add what you need to the existing

Re: [Sugar-devel] review of the new toolbars implementation

2009-07-30 Thread Aleksey Lim
On Thu, Jul 30, 2009 at 07:51:07PM +0200, Tomeu Vizoso wrote: > Hi, > +class _Palette(gtk.Window): > > The palette class is very tricky and is a frequent source of bugs, we > shouldn't duplicate it. Either we add what you need to the existing > Palette, or we split it out in a BasePalette and Pale

[Sugar-devel] review of the new toolbars implementation

2009-07-30 Thread Tomeu Vizoso
Hi, have been looking at the code and have these comments: +def set_toolbar_box(self, toolbar_box): +# make more consistent using ToolbarBox instead of Toolbox +self.set_toolbox(toolbar_box) Maybe mark set_toolbox as DEPRECATED? +ToolButton.__init__(self, 'activity-s

Re: [Sugar-devel] review of the new toolbars API

2009-07-30 Thread Aleksey Lim
On Thu, Jul 30, 2009 at 05:39:47PM +0200, Tomeu Vizoso wrote: > On Thu, Jul 30, 2009 at 17:36, Aleksey Lim wrote: > > On Thu, Jul 30, 2009 at 03:55:44PM +0200, Tomeu Vizoso wrote: > >> Hi Aleksey, > >> > >> I think this is excellent work, we are very close to commit this and > >> start moving activ

Re: [Sugar-devel] review of the new toolbars API

2009-07-30 Thread Tomeu Vizoso
On Thu, Jul 30, 2009 at 17:36, Aleksey Lim wrote: > On Thu, Jul 30, 2009 at 03:55:44PM +0200, Tomeu Vizoso wrote: >> Hi Aleksey, >> >> I think this is excellent work, we are very close to commit this and >> start moving activities to the new toolbars design. >> >> Let me share some thoughts about t

Re: [Sugar-devel] review of the new toolbars API

2009-07-30 Thread Aleksey Lim
On Thu, Jul 30, 2009 at 03:55:44PM +0200, Tomeu Vizoso wrote: > Hi Aleksey, > > I think this is excellent work, we are very close to commit this and > start moving activities to the new toolbars design. > > Let me share some thoughts about the API before reviewing the actual > sugar-toolkit patch

[Sugar-devel] review of the new toolbars API

2009-07-30 Thread Tomeu Vizoso
Hi Aleksey, I think this is excellent work, we are very close to commit this and start moving activities to the new toolbars design. Let me share some thoughts about the API before reviewing the actual sugar-toolkit patch. >        main_toolbar = Toolbar() We already have gtk.Toolbar, which is