Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-20 Thread Christian Schulte
Am 08/19/16 um 17:53 schrieb Curtis Rueden: > Hi Christian, > > This is awesome. > > > == What works == > > With model version 4.0.0, Maven 3.4.0 now behaves exactly as before. And > the property overriding bug no longer occurs, either. This maintains build > reproducibility for my projects, fo

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-19 Thread Curtis Rueden
Hi Christian, This is awesome. == What works == With model version 4.0.0, Maven 3.4.0 now behaves exactly as before. And the property overriding bug no longer occurs, either. This maintains build reproducibility for my projects, for which I am very thankful. With model version 4.1.0, Maven 3.4

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-19 Thread Christian Schulte
Am 08/17/16 um 22:16 schrieb Curtis Rueden: > One question: for POM hierarchies with mixed model versions -- a 4.0.0 POM > which imports or extends a 4.1.0 POM or vice versa -- do you foresee any > complications? Parent and child need to use the same model version. There is no way to support inher

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-18 Thread Stephane Nicoll
On Thu, Aug 18, 2016 at 5:24 PM, Curtis Rueden wrote: > Hi Stephane, > > > In fact, nowhere does it talk about what happens when dependencyManagement > comes in through both the parent and through imports. It does say, however: > I agree that both the doc and the code are missing a piece. I am n

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-18 Thread jieryn
Sorry I am so late to this party. I find that Apache Maven 3.4.0-SNAPSHOT (90f26c279af9738735be8f84f60dcf21b6244e24; 2016-07-22T11:23:04-04:00) prefers .mvn/maven.config options instead of specifically listed parameters. This is surprising to me. I expect the .mvn/maven.config options to be overri

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-18 Thread Curtis Rueden
Hi Stephane, > The problem is that "pom-whiz" extends from "pom-base". You have a > scenario where a "whiz" project extends from "pom-base" and then > import "pom-whiz". Said "pom-whiz", via inheritance, "imports" > "pom-base" again. Yep, you got it. > Independently on the issue described in thi

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-18 Thread Stephane Nicoll
On Tue, Aug 16, 2016 at 11:14 PM, Curtis Rueden wrote: > Hi Stephane, > > Apologies up front for my long reply here. I divided into sections to help > break things up. > > > *== Expected behavior? Or a defect? ==* > > > if you expect the parent to override something you've defined > > in the chil

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-18 Thread Stephane Nicoll
On Wed, Aug 17, 2016 at 10:16 PM, Curtis Rueden wrote: > Hi Christian & Stephane, > > Thanks for your replies. > > Christian Schulte wrote: > > I am thinking about introducing model version "4.1.0" in Maven 3.4. > > I like this idea. Thanks for putting it forward! > > One question: for POM hierar

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-17 Thread Curtis Rueden
Hi Christian & Stephane, Thanks for your replies. Christian Schulte wrote: > I am thinking about introducing model version "4.1.0" in Maven 3.4. I like this idea. Thanks for putting it forward! One question: for POM hierarchies with mixed model versions -- a 4.0.0 POM which imports or extends a

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-17 Thread Stephane Nicoll
On Tue, Aug 16, 2016 at 11:14 PM, Curtis Rueden wrote: > Hi Stephane, > > Apologies up front for my long reply here. I divided into sections to help > break things up. > I appreciate the time you took to reply. I'll focus on the first part for now. > > > *== Expected behavior? Or a defect? ==*

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-16 Thread Christian Schulte
Am 08/17/16 um 04:09 schrieb Mark Derricutt: > On 17 Aug 2016, at 12:32, Christian Schulte wrote: > >> There is an easy way to solve this. Maven validates the model version in >> the POM to match "4.0.0". Based on that version, Maven can decide how to >> behave. I am thinking about introducing mod

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-16 Thread Mark Derricutt
On 17 Aug 2016, at 12:32, Christian Schulte wrote: > There is an easy way to solve this. Maven validates the model version in > the POM to match "4.0.0". Based on that version, Maven can decide how to > behave. I am thinking about introducing model version "4.1.0" in Maven > 3.4. All existing 4.0.

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-16 Thread Christian Schulte
Am 08/16/16 um 23:14 schrieb Curtis Rueden: > properly with Maven 3.4.0. But I am very concerned about the precedent > here: at any point in the future, complex builds which used to work might > stop doing so, even without a major version increment, due to future > changes in the logic of core Mave

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-16 Thread Curtis Rueden
Hi Stephane, Apologies up front for my long reply here. I divided into sections to help break things up. *== Expected behavior? Or a defect? ==* > if you expect the parent to override something you've defined > in the child, that's not the expected behaviour at all. It certainly _has_ been the

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-16 Thread Stephane Nicoll
Hello Curtis, I have no opinion on your project (To be honest, I haven't looked in details yet, quite a large setup) but if you expect the parent to override something you've defined in the child, that's not the expected behaviour at all. That's still a problem for you though, I am not denying tha

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-15 Thread Curtis Rueden
Hi Christian, Thank you for all your time and effort. > Could you please test properties can correctly be overridden again in > the latest 3.4.0-SNAPSHOT In my tests, setting a version property in the POM still does not override the version as it did in 3.3.9: https://gist.github.com/ctruede

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-15 Thread Curtis Rueden
Hi Stephane, Why can't we have the best of both worlds? Backwards compatibility, but with a "stop sucking" flag which enables the new better behavior? As I said previously, unless the previous behavior is preserved, all of my communy's existing releases (hundreds of projects, thousands of tags) w

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-15 Thread Stephane Nicoll
On Sat, Aug 13, 2016 at 12:49 AM, Christian Schulte wrote: > Am 08/13/16 um 00:28 schrieb Christian Schulte: > > reviewing things. So current state of this is: "That's the behaviour > > requested and tested during commiting to MNG-5971. Cannot override > > properties? Really requested behaviour?

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-15 Thread Christian Schulte
Am 08/15/16 um 20:49 schrieb David Hoffer: > I will try to test with 3.2.2 but I can confirm that 3.2.5 does not have > this behavior as that is our official build version for this application. > I am trying to move to latest maven version and discovered this. A project to reproduce this would be

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-15 Thread David Hoffer
I will try to test with 3.2.2 but I can confirm that 3.2.5 does not have this behavior as that is our official build version for this application. I am trying to move to latest maven version and discovered this. Regards, -Dave On Mon, Aug 15, 2016 at 12:40 PM, Christian Schulte wrote: > Am 08/1

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-15 Thread Christian Schulte
Am 08/15/16 um 20:30 schrieb David Hoffer: > I'm testing with build 110 and have found an error with one of our current > builds (it works through 3.3.9). It's a bit of an odd-ball case. > > We have a child parent pom module that has several children if its own. > One of those child modules uses

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-15 Thread David Hoffer
I'm testing with build 110 and have found an error with one of our current builds (it works through 3.3.9). It's a bit of an odd-ball case. We have a child parent pom module that has several children if its own. One of those child modules uses a variable for the module name. E.g. exchange

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-15 Thread Samuel Langlois
On 13/08/2016 01:47, Christian Schulte wrote: > Am 08/12/16 um 15:58 schrieb Samuel Langlois: > > Thanks for your answer Robert. > > It is a bit more complicated than just being unable to override a > property. > > It's more that you can't change a dependencyManagement defined above by > > overridi

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-12 Thread Christian Schulte
Am 08/12/16 um 15:58 schrieb Samuel Langlois: > Thanks for your answer Robert. > It is a bit more complicated than just being unable to override a property. > It's more that you can't change a dependencyManagement defined above by > overriding a property. > Anyway, I think it deserves an issue to

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-12 Thread Christian Schulte
Could you please test properties can correctly be overridden again in the latest 3.4.0-SNAPSHOT available from . It should have been fixed by this commit

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-12 Thread Christian Schulte
The code in question is in class 'DefaultModelBuilder'. Everything is done by those two methods: public ModelBuildingResult build( ModelBuildingRequest request ) public ModelBuildingResult build( ModelBuildingRequest request, ModelBuildingResult result ) Called in that order.

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-12 Thread Christian Schulte
Am 08/13/16 um 00:28 schrieb Christian Schulte: > reviewing things. So current state of this is: "That's the behaviour > requested and tested during commiting to MNG-5971. Cannot override > properties? Really requested behaviour? Maybe incorrect. Need to look at > it again. There was a reason it go

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-12 Thread Christian Schulte
Am 08/12/16 um 20:11 schrieb Curtis Rueden: > Hi Christian, > > Thank you very much for looking at my example, and your speedy reply. > >> Can you please add your objections to MNG-5971 in JIRA. > > Done. I also added the same comments to MNG-6079, which I believe is a > legitimate regression ca

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-12 Thread Curtis Rueden
Hi Christian, Thank you very much for looking at my example, and your speedy reply. > Can you please add your objections to MNG-5971 in JIRA. Done. I also added the same comments to MNG-6079, which I believe is a legitimate regression caused by the fixing of MNG-5971. > > 2) I do not know how t

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-12 Thread Christian Schulte
Am 12.08.2016 um 19:16 schrieb Curtis Rueden: Hi all, Concerned by this thread, I did some tests. And I have to say, the new Maven 3.4.0 dependency resolution rules seem like a step backwards. == REAL-WORLD EXAMPLE == Consider the following project: https://github.com/fiji/fiji/blob/ced9faee1c

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-12 Thread Christian Schulte
Can you please add your objections to MNG-5971 in JIRA. Maybe by copy and pasting your email. Reverting to the old behaviour is problematic and most of the users having taken part in that discussion will disagree with you, I think. The issue has been filed due to real-world problems. There are

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-12 Thread Curtis Rueden
Hi all, Concerned by this thread, I did some tests. And I have to say, the new Maven 3.4.0 dependency resolution rules seem like a step backwards. == REAL-WORLD EXAMPLE == Consider the following project: https://github.com/fiji/fiji/blob/ced9faee1c4fba9997a3d614759fb6e78e359d4f/pom.xml Amongst

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-12 Thread Christian Schulte
Am 08/12/16 um 14:41 schrieb Samuel Langlois: > Hello > > I noticed a change of behaviour in Maven 3.4, which made one of our builds > fail. > It may be a bit of a corner case, so I'll let someone else decide whether > it's a regression or a bug fix... You can read all about it here:

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-12 Thread Samuel Langlois
Thanks for your answer Robert. It is a bit more complicated than just being unable to override a property. It's more that you can't change a dependencyManagement defined above by overriding a property. Anyway, I think it deserves an issue to be looked at properly, so I created https://issues.apach

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-12 Thread Robert Patrick
This should be treated as a bug. Many builds, including ours, relies on being able to override properties defined in the parent hierarchy in a module POM. This change you are describing would break a lot of builds... > On Aug 12, 2016, at 8:41 AM, Samuel Langlois > wrote: > > Hello > > I n

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-08-12 Thread Samuel Langlois
Hello I noticed a change of behaviour in Maven 3.4, which made one of our builds fail. It may be a bit of a corner case, so I'll let someone else decide whether it's a regression or a bug fix... We have a submodule where the "parent" pom contains a dependency with scope=import, but with the versi

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-07-24 Thread Dan Tran
Spring folks agree it is a bug. See StackOverflow link for details -Dan On Sun, Jul 24, 2016 at 11:11 AM, Dan Tran wrote: > > http://stackoverflow.com/questions/38555184/json-simple-marked-as-optional-under-spring-boot-dependencies-intentional > > For my case, i override it at my BOM > > -D > >

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-07-24 Thread Mirko Friedenhagen
Hello, I just published a Docker image at https://hub.docker.com/r/mfriedenhagen/docker-maven/. However, because I often use Maven in a CI environment I replaced the gossip and jansi jars with slf4j-simple. After adapting findbugs-maven-plugin to 3.0.4 my projects run successfully. Regards Mirko -

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-07-24 Thread Dan Tran
http://stackoverflow.com/questions/38555184/json-simple-marked-as-optional-under-spring-boot-dependencies-intentional For my case, i override it at my BOM -D On Sun, Jul 24, 2016 at 10:44 AM, Christian Schulte wrote: > Am 07/24/16 um 19:25 schrieb Dan Tran: > > Yes, I need to override the orig

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-07-24 Thread Christian Schulte
Am 07/24/16 um 19:25 schrieb Dan Tran: > Yes, I need to override the original import with 'optional' set to false. > At the same time, i file a bug with spring to see if it is intentional > This is what I would do as well. If the majority of users will never need that dependency and it is not n

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-07-24 Thread Dan Tran
Yes, I need to override the original import with 'optional' set to false. At the same time, i file a bug with spring to see if it is intentional Thanks -D On Sun, Jul 24, 2016 at 9:54 AM, Christian Schulte wrote: > Am 07/24/16 um 09:32 schrieb Dan Tran: > > yes, found this > > > > > > com

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-07-24 Thread Christian Schulte
Am 07/24/16 um 09:32 schrieb Dan Tran: > yes, found this > > > com.googlecode.json-simple > json-simple > ${simple-json.version} > true > > > at sprint-boot-dependencies-1.2.8's dependencyManagement. This may be a > bug of the BOM. Not sure why it is set as optional and it is the only one > i

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-07-24 Thread Dan Tran
http://central.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/1.3.6.RELEASE/spring-boot-dependencies-1.3.6.RELEASE.pom On Sun, Jul 24, 2016 at 12:32 AM, Dan Tran wrote: > yes, found this > > > com.googlecode.json-simple > json-simple > ${simple-json.version} > true > > >

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-07-24 Thread Dan Tran
yes, found this com.googlecode.json-simple json-simple ${simple-json.version} true at sprint-boot-dependencies-1.2.8's dependencyManagement. This may be a bug of the BOM. Not sure why it is set as optional and it is the only one in that BOM. Thanks -D On Sat, Jul 23, 2016 at 4:12 PM, Chris

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-07-23 Thread Christian Schulte
Am 07/23/16 um 23:41 schrieb Dan Tran: > Looks good on my 170 modules with Takari's smart builder build. Except > one module with one transitive dependency disappears and causes compilation > error. > > Any suggestion how to troubleshoot is very much reproducible build failure? Could be caused

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-07-23 Thread Dan Tran
Looks good on my 170 modules with Takari's smart builder build. Except one module with one transitive dependency disappears and causes compilation error. Any suggestion how to troubleshoot is very much reproducible build failure? Thanks -Dan On Fri, Jul 22, 2016 at 3:14 PM, Mark Derricutt

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-07-22 Thread Mark Derricutt
On Sat, Jul 23, 2016 at 3:27 AM, Karl Heinz Marbaise wrote: > This is only a current state of development (Git hash: > 90f26c279af9738735be8f84f60dcf21b6244e24) to get some feedback from the > community... > Have been using daily HEAD builds as my daily driver for the past few weeks, so far no i

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-07-07 Thread Andreas Sewe
Hi, > If you like to help making the next Maven release better it would be > nice if you could help a little bit. > > Please be aware of this *** This is not an official release *** > > Every kind of feedback is helpful. the good needs is that I found no regressions (testing several large build

Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 3)

2016-07-06 Thread Karl Heinz Marbaise
Hi to all Maven users, If you like to help making the next Maven release better it would be nice if you could help a little bit. Please be aware of this *** This is not an official release *** I have created downloadable packages which are available from here: Windows: https://s.apache.org/q

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-06 Thread Christian Schulte
Am 07/06/16 um 15:08 schrieb Jason van Zyl: > Feature toggles, as the practice has been for many years, has the user being > conscious of what they are doing. The feature may prove to be a problem and > you specifically don’t want to expose it to the whole user population. I > honestly find your

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-06 Thread Jason van Zyl
Feature toggles, as the practice has been for many years, has the user being conscious of what they are doing. The feature may prove to be a problem and you specifically don’t want to expose it to the whole user population. I honestly find your attitude extremely disconcerting. What you think is

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Mark Derricutt
On 3 Jul 2016, at 9:40, Karl Heinz Marbaise wrote: > I'm note sure if IDE is handling .mvn/maven.config correct? Not sure about .mvn/maven.config - but I know IntelliJ sure doesn't seem to use ./mvn/extensions.xml - the MavenServer they run is a single process for the lifetime of the IDE/projec

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Mark Derricutt
On 3 Jul 2016, at 11:39, Karl Heinz Marbaise wrote: > If you started with Maven 2 and now you upgrade to Maven 3.3.9 you will get a > large number of new features and different behaviour compared to Maven 2 > etc...but there are some parts in Maven 3.X+ which are working wronge for a > long tim

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Christian Schulte
Am 07/03/16 um 01:49 schrieb Christian Schulte: > Am 07/03/16 um 01:39 schrieb Karl Heinz Marbaise: >> Hi, >> >> On 7/3/16 1:31 AM, Christian Schulte wrote: >>> Am 07/02/16 um 23:18 schrieb Karl Heinz Marbaise: Hi, On 7/2/16 2:06 PM, Jason van Zyl wrote: >So we need t

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Christian Schulte
Am 07/03/16 um 01:39 schrieb Karl Heinz Marbaise: > Hi, > > On 7/3/16 1:31 AM, Christian Schulte wrote: >> Am 07/02/16 um 23:18 schrieb Karl Heinz Marbaise: >>> Hi, >>> >>> On 7/2/16 2:06 PM, Jason van Zyl wrote: >>> >>> >So we need to figure out a way to deliver the new behavior while >>> p

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Christian Schulte
Am 07/03/16 um 01:42 schrieb Karl Heinz Marbaise: > Hi, > > On 7/3/16 1:34 AM, Christian Schulte wrote: >> Am 07/03/16 um 01:16 schrieb Karl Heinz Marbaise: >>> If we make the decision to make a particular feature the default we can >>> simple remove it from the feature toggle list...Or we can mak

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Karl Heinz Marbaise
Hi, On 7/3/16 1:34 AM, Christian Schulte wrote: Am 07/03/16 um 01:16 schrieb Karl Heinz Marbaise: If we make the decision to make a particular feature the default we can simple remove it from the feature toggle list...Or we can make to produce it warnings etc. And how is that different from j

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Karl Heinz Marbaise
Hi, On 7/3/16 1:31 AM, Christian Schulte wrote: Am 07/02/16 um 23:18 schrieb Karl Heinz Marbaise: Hi, On 7/2/16 2:06 PM, Jason van Zyl wrote: >So we need to figure out a way to deliver the new behavior while preserving >the old for a time being. Maybe a branch, > but I think the best

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Christian Schulte
Am 07/03/16 um 01:16 schrieb Karl Heinz Marbaise: > If we make the decision to make a particular feature the default we can > simple remove it from the feature toggle list...Or we can make to > produce it warnings etc. And how is that different from just shipping that feature active by default r

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Christian Schulte
Am 07/02/16 um 23:18 schrieb Karl Heinz Marbaise: > Hi, > > On 7/2/16 2:06 PM, Jason van Zyl wrote: > > >So we need to figure out a way to deliver the new behavior while > preserving > >the old for a time being. Maybe a branch, > > > > but I think the best way to do it is to have both b

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Karl Heinz Marbaise
Hi, On 7/3/16 12:46 AM, Christian Schulte wrote: Am 07/02/16 um 23:18 schrieb Karl Heinz Marbaise: Hi, On 7/2/16 2:06 PM, Jason van Zyl wrote: >So we need to figure out a way to deliver the new behavior while preserving >the old for a time being. Maybe a branch, > but I think the bes

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Christian Schulte
Am 07/02/16 um 23:18 schrieb Karl Heinz Marbaise: > Hi, > > On 7/2/16 2:06 PM, Jason van Zyl wrote: > > >So we need to figure out a way to deliver the new behavior while > preserving > >the old for a time being. Maybe a branch, > > > > but I think the best way to do it is to have both b

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Christian Schulte
Am 07/02/16 um 23:18 schrieb Karl Heinz Marbaise: > Hi, > > On 7/2/16 2:06 PM, Jason van Zyl wrote: > > >So we need to figure out a way to deliver the new behavior while > preserving > >the old for a time being. Maybe a branch, > > > > but I think the best way to do it is to have both b

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Karl Heinz Marbaise
Hi Mark, POM activation can't be used cause many features/toggles we are talking about here needed to be activated before a pom has been read at all and furthermore starting with Maven 3.3.1 you could use .mvn/maven.config[1] to handle such things. I'm note sure if IDE is handling .mvn/maven

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Mark Derricutt
The features look nice, the only thing I don't really like is (maybe mistaken) it's command line only? Which would mean you have to manual enable it every where, ides, build servers, unless you can enable them with some form of in-pom declaration? >From the hip, on Android... On 3/07/2016 09:19,

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Karl Heinz Marbaise
Hi, On 7/2/16 2:06 PM, Jason van Zyl wrote: >So we need to figure out a way to deliver the new behavior while preserving >the old for a time being. Maybe a branch, > but I think the best way to do it is to have both behaviors exist in the > same codebase and turn on what we considered co

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Christian Schulte
Am 07/02/16 um 15:53 schrieb Jeff Jensen: > Feature toggles +1 FTW > > Agreed, switching the default behavior over time is a good path of change. > Perhaps helping with the awareness of the feature, when the feature is off, > display an info message stating this feature exists and suggest enabling

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Jeff Jensen
Feature toggles +1 FTW Agreed, switching the default behavior over time is a good path of change. Perhaps helping with the awareness of the feature, when the feature is off, display an info message stating this feature exists and suggest enabling it with the toggle, possibly noting future plans of

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Jason van Zyl
The question is not whether to fix them, but how they are fixed in the context of the people using the software. I think you strive for the pure, elegant and correct way of how you think something should work. In most cases I’ve seen your reasoning is sound and in most cases is what should be d

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Christian Schulte
Am 07/02/16 um 12:36 schrieb Oliver B. Fischer: > My suggestions is based on the view of a Maven user who would like to do > it's daily job ;-) > > In our team we have > 20 Maven projects and as a Maven 'User' you need > the chance to fix such issues before the break your build. Everyone > woul

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-07-02 Thread Oliver B. Fischer
My suggestions is based on the view of a Maven user who would like to do it's daily job ;-) In our team we have > 20 Maven projects and as a Maven 'User' you need the chance to fix such issues before the break your build. Everyone would blame Maven for this. We should have the chance to fix th

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-06-20 Thread Christian Schulte
Am 06/20/16 um 22:00 schrieb Oliver B. Fischer: > Yes, I think this would be very helpfull. Otherwise I see a lot of > people complaining about Maven and that is not able to do its work. Such warning messages could only be issued by Aether. That cannot be done in 3.4. We already reverted the thi

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-06-20 Thread Paul Benedict
That is an interesting idea so no one gets blindsided by an important new feature. Baby steps, right? I recommend that you opine in the ticket: https://issues.apache.org/jira/browse/MNG-5935 ...and also write dev@ to pass on your idea. I think your idea has merit. Cheers, Paul On Mon, Jun 20, 2

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-06-20 Thread Oliver B. Fischer
Yes, I think this would be very helpfull. Otherwise I see a lot of people complaining about Maven and that is not able to do its work. The best solution IMHO would be to print out a warning with a detailed hint that no one could ignore. Am 20.06.16 um 21:56 schrieb Paul Benedict: Do you mea

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-06-20 Thread Paul Benedict
Do you mean make it a warning in 3.4 and fix behavior in 3.5? Cheers, Paul On Mon, Jun 20, 2016 at 2:42 PM, Oliver B. Fischer wrote: > Ok, I will fix it. But wouldn't it be an usefull option to print some > warning about this problem before changing the current behaviour? > > > WDYT? > > > Am 1

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-06-20 Thread Oliver B. Fischer
Ok, I will fix it. But wouldn't it be an usefull option to print some warning about this problem before changing the current behaviour? WDYT? Am 12.06.16 um 23:08 schrieb Christian Schulte: Am 06/12/16 um 22:01 schrieb Oliver B. Fischer: With this snapshot I am unable to build jQAssistant.

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 2)

2016-06-14 Thread Anton Tanasenko
Yeah, that could work as well. On Tue, 14 Jun 2016, 21:05 Christian Schulte, wrote: > http://git-wip-us.apache.org/repos/asf/maven/commit/ded1379e > > > - > To unsubscribe, e-mail: users-unsubscr...@maven.apache.org > For additi

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 2)

2016-06-14 Thread Christian Schulte
http://git-wip-us.apache.org/repos/asf/maven/commit/ded1379e - To unsubscribe, e-mail: users-unsubscr...@maven.apache.org For additional commands, e-mail: users-h...@maven.apache.org

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 2)

2016-06-14 Thread Anton Tanasenko
Yes, exactly. To be able to show markers at correct locations in an editor, we need to know if a particular problem is sourced at this particular file. Since early 2.x versions of this source was exactly one path to a file and now it has changed. So it would be really helpful to know what the new

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 2)

2016-06-14 Thread Christian Schulte
Am 06/14/16 um 18:46 schrieb Anton Tanasenko: > Christian? Anyone? > > 2016-06-13 1:19 GMT+03:00 Anton Tanasenko : > >> I've tried running m2eclipse tests with 3.4.0-SNAPSHOT maven. There are >> several failures. >> >> 1. src/x/resources-filtered addition, which we will need to adhere to when >>

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 2)

2016-06-14 Thread Petar Tahchiev
You need to build the snapshot version of maven-findbugs-plugin. 2016-06-14 19:46 GMT+03:00 Anton Tanasenko : > Christian? Anyone? > > 2016-06-13 1:19 GMT+03:00 Anton Tanasenko : > > > I've tried running m2eclipse tests with 3.4.0-SNAPSHOT maven. There are > > several failures. > > > > 1. src/x/r

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 2)

2016-06-14 Thread Anton Tanasenko
Christian? Anyone? 2016-06-13 1:19 GMT+03:00 Anton Tanasenko : > I've tried running m2eclipse tests with 3.4.0-SNAPSHOT maven. There are > several failures. > > 1. src/x/resources-filtered addition, which we will need to adhere to when > 3.4.0 gets released. > > 2. > https://github.com/apache/mav

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 2)

2016-06-14 Thread Oliver B. Fischer
Hi Karl-Heinz, I found another project I can't build with the latest snapshot of Maven. Building it with Maven 3.4.0-SNAPSHOT results in the following message [ERROR] Failed to execute goal org.codehaus.mojo:findbugs-maven-plugin:3.0.1:findbugs (findbugs) on project tamaya-code: Unable to pa

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 2)

2016-06-13 Thread Eddú Meléndez Gonzales
Hi, I have ran the snapshot against sprin-boot open source project and everything is ok. Hope more features. Thanks for the early access :) *Eddú Meléndez Gonzales* *eddu.melen...@gmail.com* *@eddumelendez* On Mon, Jun 13, 2016 at 11:15 PM, Ondřej Světlík wrote: > Dne 12.6.2016 v 22:40 Kar

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 2)

2016-06-13 Thread Ondřej Světlík
Dne 12.6.2016 v 22:40 Karl Heinz Marbaise napsal(a): Hi to all Maven users, based on the issues which have been found with the first one here is another chance to help . It would be nice if those who have found issues to retest their scenarios. Is someone of you willing to do some testing on t

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 2)

2016-06-13 Thread Oliver B. Fischer
I used it today at work without any problem. This snapshot is much better than the previous one. Am 12.06.16 um 22:40 schrieb Karl Heinz Marbaise: Hi to all Maven users, based on the issues which have been found with the first one here is another chance to help . It would be nice if those

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 2)

2016-06-12 Thread Gary Gregory
I've built Log4j 2 and some HttpComponents pieces OK. The only problem is building on top of Java 8 which encounters the BCEL on Java bug problem we all know about. Gary On Sun, Jun 12, 2016 at 1:40 PM, Karl Heinz Marbaise wrote: > Hi to all Maven users, > > based on the issues which have been

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 2)

2016-06-12 Thread Anton Tanasenko
I've tried running m2eclipse tests with 3.4.0-SNAPSHOT maven. There are several failures. 1. src/x/resources-filtered addition, which we will need to adhere to when 3.4.0 gets released. 2. https://github.com/apache/maven/commit/508e16e23d66de09893d1eb52dff6a1c5ca019b3#diff-9cdcbb55d918f0d251c34a5

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-06-12 Thread Christian Schulte
Am 06/12/16 um 23:03 schrieb Mirko Friedenhagen: > So maybe I got all scopes wrong, Yes. And that's the reason those bugfixes in Maven have been reverted latetly. - To unsubscribe, e-mail: users-unsubscr...@maven.apache.org For

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-06-12 Thread Christian Schulte
Am 06/12/16 um 22:01 schrieb Oliver B. Fischer: > With this snapshot I am unable to build jQAssistant. You can fetch it > from g...@github.com:buschmais/jqassistant.git > You need to fix the project. 3.4 adds support for managing the 'optional' flag in dependency management and contains bugfixes

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-06-12 Thread Mirko Friedenhagen
So maybe I got all scopes wrong, however the new version seems basically quite incompatible with 3.3.9. On a side note I like to use org.slf4j.simpleLogger.showDateTime=true during CI runs. With the new logger the build time does not show anymore, the only thing that happens is that there is no col

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-06-12 Thread Anton Tanasenko
It would be great if there was a way to enable/disable color using a separate option or system property. Adding -B could disable color by default, but explicitly enabling it might prove useful in, say, Jenkins with AnsiColor plugin. 2016-06-12 23:39 GMT+03:00 Baptiste Mathus : > Well, as I hadn't

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-06-12 Thread Christian Schulte
Am 06/12/16 um 21:47 schrieb Mirko Friedenhagen: > Hello Christian, > > that I could fix. Although hamcrest is transitive in junit. It is a 'compile' scope dependency of 'junit' and that is transitive and will become 'test' in case of using 'junit' in 'test' scope. If you manage that dependency

Preleminary Maven 3.4.0-SNAPSHOT Testing (Take 2)

2016-06-12 Thread Karl Heinz Marbaise
Hi to all Maven users, based on the issues which have been found with the first one here is another chance to help . It would be nice if those who have found issues to retest their scenarios. Is someone of you willing to do some testing on the current state of development for the upcoming Ma

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-06-12 Thread Baptiste Mathus
Well, as I hadn't tested this version and was just guessing /by intuition/ on what I generally use --batch-mode for, I'd disagree on your last statement :). But agreed it might be interesting to have some words about it in the help. Patches/PR are always welcome. 2016-06-12 22:15 GMT+02:00 Oliver

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-06-12 Thread Oliver B. Fischer
Funny, I wasn't ware of this option. -l does not disables the colorized output. Therefore the generated log file also contains escape sequences. Am 12.06.16 um 22:13 schrieb Robert Scholte: Or when -l/--log-file is used? Robert On Sun, 12 Jun 2016 22:09:43 +0200, Baptiste Mathus wrote:

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-06-12 Thread Oliver B. Fischer
Yes, running with -B disables the colorized output. But at least the description of this option should mention this too because IMHO it is not intuitive that -B disables the colors. WDYT? Am 12.06.16 um 22:09 schrieb Baptiste Mathus: Didn't test it, but using batch mode would seem natural f

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-06-12 Thread Robert Scholte
Or when -l/--log-file is used? Robert On Sun, 12 Jun 2016 22:09:43 +0200, Baptiste Mathus wrote: Didn't test it, but using batch mode would seem natural for that IMO. My 2 cents 2016-06-12 22:04 GMT+02:00 Oliver B. Fischer : The colorized output is very nice, but I would like to have also

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-06-12 Thread Uwe Barthel
Hi Karl Heinz, > Are you asking some PR in particular ? https://issues.apache.org/jira/browse/MNG-3092 - https://github.com/apache/maven/pull/70 -- barthel > On 12 Jun 2016, at 21:52, Karl Heinz Marbaise wrote: > > Hi Uwe, > > On 6/12/16 9:40 PM, Uwe Barthel wrote: >> Hi Karl Heinz, >> >>

Re: Preleminary Maven 3.4.0-SNAPSHOT Testing

2016-06-12 Thread Baptiste Mathus
Didn't test it, but using batch mode would seem natural for that IMO. My 2 cents 2016-06-12 22:04 GMT+02:00 Oliver B. Fischer : > The colorized output is very nice, but I would like to have also a > commandline option to disable it. I often redirect the output of Maven to a > file to check the b

  1   2   >