Updates:
Status: Invalid
Comment #2 on issue 3451 by svenpa...@chromium.org: Declaration of v8.h
class Persistent fails with compiler error 2977 for the MS compiler
http://code.google.com/p/v8/issues/detail?id=3451
(No comment was entered for this change.)
--
You received this
On 2014/07/18 15:50:42, Alexandra Mikhaylova wrote:
Fixed the test, the problem was in GC being called before it was expected
in
the
test.
lgtm.
https://codereview.chromium.org/398513005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Committed patchset #6 manually as r22490 (presubmit successful).
https://codereview.chromium.org/398513005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22490
Author: yang...@chromium.org
Date: Mon Jul 21 08:07:04 2014 UTC
Log: Expose the content of Maps and WeakMaps through MapMirror.
BUG=v8:3291
LOG=N
R=aand...@chromium.org, yang...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=22452
Review URL:
Revision: 22491
Author: machenb...@chromium.org
Date: Mon Jul 21 08:16:09 2014 UTC
Log: Version 3.28.30 (based on bleeding_edge revision r22489)
Performance and stability improvements on all platforms.
http://code.google.com/p/v8/source/detail?r=22491
Modified:
/trunk/ChangeLog
Revision: 22492
Author: machenb...@chromium.org
Date: Mon Jul 21 08:16:22 2014 UTC
Log: Tagging version 3.28.30
http://code.google.com/p/v8/source/detail?r=22492
Added:
/tags/3.28.30
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Reviewers: mathiasb, rossberg,
Message:
TBR because the actual code review already happened here:
https://codereview.appspot.com/13816046/
Description:
Implement String.prototype.codePointAt and String.fromCodePoint.
Contributed by Mathias Bynens mathi...@opera.com.
TBR=mathi...@opera.com,
Yes, I'll plan to restore the convenience cross compiler detection on
standalone builds sometime today. In the meantime, as Henrik mentioned,
adding:
export GYP_DEFINES=target_arch=arm
should work.
Cheers,
Ross
On 19 Jul 2014 12:34, Jakob Kummerow jkumme...@chromium.org wrote:
[+Ross]
Ross,
Committed patchset #1 manually as r22493 (presubmit successful).
https://codereview.chromium.org/406863003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22493
Author: yang...@chromium.org
Date: Mon Jul 21 08:45:32 2014 UTC
Log: Implement String.prototype.codePointAt and String.fromCodePoint.
Contributed by Mathias Bynens mathi...@opera.com.
TBR=mathi...@opera.com, rossb...@chromium.org
BUG=v8:2840
LOG=Y
Review URL:
Reviewers: rossberg,
Description:
Small improvement to String.fromCodePoint.
R=rossb...@chromium.org
Please review this at https://codereview.chromium.org/390173004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -4 lines):
M src/harmony-string.js
lgtm
https://codereview.chromium.org/398053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/07/17 23:34:37, arv wrote:
I haven't uploaded a new snapshot yet. I got stuck on the following:
var length = 2;
var a = [1];
assertEquals(0, Array.prototype.length);
a[Symbol.unscopables] = {length: true};
with (a) {
assertEquals(0, length); // FAILS
}
The problem seems to come
lgtm
https://codereview.chromium.org/390173004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
I'm really not sure we want to do that, esp. if it doesn't buy us anything
performance-wise.
Assigning to danno to decide.
https://codereview.chromium.org/409573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
LGTM
https://codereview.chromium.org/408473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
lgtm
https://codereview.chromium.org/400223002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/07/19 19:52:14, caitp wrote:
So, I was thinking about implementing CreateDataProperty* for this, but
as far
as I'm aware, simply assigning properties to the result object should
have the
same effect, and it makes the code a bit harder to read if it's written
this
way.
Happy to
Reviewers: Yang,
Description:
Fix off-by-one error in Array.concat slow mode check
BUG=chromium:395499
LOG=n
Please review this at https://codereview.chromium.org/399753005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -2 lines):
M src/runtime.cc
Hi Danno,
I addressed your comments and fixed a TODO. Have a look when you get a
chance,
thanks!
--Michael
https://codereview.chromium.org/368263003/diff/80001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/368263003/diff/80001/src/code-stubs.h#newcode756
On 2014/07/21 09:40:08, Jakob wrote:
lgtm.
https://codereview.chromium.org/399753005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 22494
Author: jkumme...@chromium.org
Date: Mon Jul 21 09:42:21 2014 UTC
Log: Fix off-by-one error in Array.concat slow mode check
BUG=chromium:395499
LOG=n
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/399753005
Committed patchset #1 manually as r22494 (presubmit successful).
https://codereview.chromium.org/399753005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
I assume you are removing these because you assume it's safe given the
current
usage (NumberToString only called by full-codegen and the
ElementsTransitionAndStoreStub which itself is only being called from
another
stub?) However, this seems pretty fragile, right? Also, I don't see how it's
lgtm
https://codereview.chromium.org/408463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #4 manually as r22495 (presubmit successful).
https://codereview.chromium.org/382893003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22495
Author: rossb...@chromium.org
Date: Mon Jul 21 09:58:01 2014 UTC
Log: Implement basic code generation for arrow functions
Implements code generation for arrow functions by desugaring them into
a FunctionLiteral. For the moment, a normal FUNCTION_SCOPE is used, so
this
For arm64, we tried to find if some registers were pushed twice. We
generated some traces which showed that a few doubles registers were pushed
twice. The analyze I made showed that, for arm64, it should be safe (with
the current use of these stub) to remove the save of doubles.
As this cl
Revision: 22496
Author: jacob.bram...@arm.com
Date: Mon Jul 21 10:15:08 2014 UTC
Log: ARM: never record safepoint with doubles
R=bmeu...@chromium.org, u...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/408473002
http://code.google.com/p/v8/source/detail?r=22496
Revision: 22497
Author: rossb...@chromium.org
Date: Mon Jul 21 10:20:54 2014 UTC
Log: Remove harmony-typeof
This was an early experiment in the Harmony era that turned out to
not be compatible with the web.
BUG=None
LOG=Y
R=rossb...@chromium.org
Review URL:
Committed patchset #2 manually as r22497 (presubmit successful).
https://codereview.chromium.org/408463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22498
Author: jacob.bram...@arm.com
Date: Mon Jul 21 10:31:23 2014 UTC
Log: ARM64: never record safepoint with doubles
R=bmeu...@chromium.org, u...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/400223002
http://code.google.com/p/v8/source/detail?r=22498
https://codereview.chromium.org/368263003/diff/180001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/368263003/diff/180001/src/runtime.cc#newcode14906
src/runtime.cc:14906: HandleFixedArrayBase
elements(object-elements());
I guess this is function is OK, but it
lgtm
https://codereview.chromium.org/398013003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jarin,
Message:
Committed patchset #3 manually as r22499 (presubmit successful).
Description:
Always sweep precisely.
BUG=
R=ja...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=22499
Please review this at https://codereview.chromium.org/398013003/
SVN Base:
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Rename CurrentMapForDeprecated to TryUpdate, and introduce Map::Update which
potentially deprecates
BUG=
Please review this at https://codereview.chromium.org/401243003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Revision: 22499
Author: hpa...@chromium.org
Date: Mon Jul 21 10:39:10 2014 UTC
Log: Always sweep precisely.
BUG=
R=ja...@chromium.org
Review URL: https://codereview.chromium.org/398013003
http://code.google.com/p/v8/source/detail?r=22499
Modified:
I am not 100% sure that it's safe in all cases, and am in fact pretty sure
that it's not safe in at least one case.
Let's leave it be for now.
The right thing to do, of course, would be to teach the Lithium register
allocator about how to deal with caller/callee saved registers properly.
But
Updates:
Status: Fixed
Comment #6 on issue 2840 by math...@qiwi.be: Implement ES6
`String.fromCodePoint` and `String.prototype.codePointAt`
http://code.google.com/p/v8/issues/detail?id=2840
Committed: https://code.google.com/p/v8/source/detail?r=22493
--
You received this message
Committed patchset #6 manually as r22500.
https://codereview.chromium.org/398053002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
On 2014/07/16 09:52:15, rossberg wrote:
No, no need to block on that. Just use IS_SPEC_FUNCTION for the time
being,
and
add a suitable TODO.
Included a TODO comment (TODO: Implement IsConstructor (ES6 section
7.2.5)). If
everything is correct, I think the patch should be ready to land.
lgtm
https://codereview.chromium.org/402923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Reduce usage of StoreMode.
BUG=
Please review this at https://codereview.chromium.org/409603002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+38, -66 lines):
M src/objects.h
M src/objects.cc
M
Reviewers: Jakob,
Description:
Store both major and minor key on code stubs.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/409613002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+78, -132 lines):
M src/code-stubs.h
M
Reviewers: jarin,
Message:
PTAL
Description:
Fix automatic version update.
This fixes two things:
1. Guarantee that versions are bumped up also when presubmit errors exists.
Those errors originate from other CLs and should not stop the automatic
versioning.
2. Calculate the last bleeding edge
Committed patchset #1 manually as r22501 (tree was closed).
https://codereview.chromium.org/404093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22501
Author: machenb...@chromium.org
Date: Mon Jul 21 12:13:36 2014 UTC
Log: Fix automatic version update.
This fixes two things:
1. Guarantee that versions are bumped up also when presubmit errors exists.
Those errors originate from other CLs and should not stop the
Committed patchset #1 manually as r22502 (tree was closed).
https://codereview.chromium.org/404103002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Michael Achenbach,
Description:
[Auto-roll] Bump up version to 3.28.31.0
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/404103002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/version.cc
Revision: 22502
Author: machenb...@chromium.org
Date: Mon Jul 21 12:14:36 2014 UTC
Log: [Auto-roll] Bump up version to 3.28.31.0
TBR=machenb...@chromium.org
Review URL: https://codereview.chromium.org/404103002
http://code.google.com/p/v8/source/detail?r=22502
Modified:
lgtm with a nit:
https://codereview.chromium.org/409603002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/409603002/diff/1/src/objects.cc#newcode1873
src/objects.cc:1873: PropertyAttributes attributes, StoreMode mode,
The |mode| parameter is not used. Lets
Revision: 22503
Author: rossb...@chromium.org
Date: Mon Jul 21 12:20:05 2014 UTC
Log: Missing runtime test
TBR=svenpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/407943002
http://code.google.com/p/v8/source/detail?r=22503
Added:
Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r22503 (tree was closed).
Description:
Missing runtime test
TBR=svenpa...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=22503
Please review this at https://codereview.chromium.org/407943002/
SVN
LGTM. Nice unification!
https://codereview.chromium.org/409613002/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/409613002/diff/1/src/heap-snapshot-generator.cc#newcode1502
src/heap-snapshot-generator.cc:1502: (%s code),
LGTM. Epic test... :-)
https://codereview.chromium.org/407943002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Reviewers: danno, Jakob,
Message:
On 2014/07/19 11:44:36, Jakob wrote:
You'll need me to land this for you, right?
Yes, please.
https://codereview.chromium.org/403003002/diff/1/src/deoptimizer.cc#newcode3263
src/deoptimizer.cc:3263: #if V8_TARGET_LITTLE_ENDIAN |
| !V8_HOST_ARCH_64_BIT
lgtm
https://codereview.chromium.org/401243003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Yang,
Description:
Fix HSourcePosition when --hydrogen-track-positions is used.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/403373002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M
On Saturday, July 19, 2014 7:55:13 AM UTC-4, Jakob Kummerow wrote:
A few comments:
- for your git cl presubmit issue, try executing make dependencies. It
should pull in the buildtools directory, which contains the checkdeps
python module (among other things).
That completely fixed my
On 2014/07/21 12:52:55, Michael Starzinger wrote:
lgtm.
https://codereview.chromium.org/403373002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22504
Author: mstarzin...@chromium.org
Date: Mon Jul 21 13:09:11 2014 UTC
Log: Fix HSourcePosition when --hydrogen-track-positions is used.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/403373002
http://code.google.com/p/v8/source/detail?r=22504
Committed patchset #1 manually as r22504 (presubmit successful).
https://codereview.chromium.org/403373002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Committed patchset #1 manually as r22505 (presubmit successful).
https://codereview.chromium.org/409613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22505
Author: yang...@chromium.org
Date: Mon Jul 21 13:10:14 2014 UTC
Log: Store both major and minor key on code stubs.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/409613002
http://code.google.com/p/v8/source/detail?r=22505
Modified:
Committed patchset #1 manually as r22506 (presubmit successful).
https://codereview.chromium.org/390173004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22506
Author: yang...@chromium.org
Date: Mon Jul 21 13:18:44 2014 UTC
Log: Small improvement to String.fromCodePoint.
R=rossb...@chromium.org
Review URL: https://codereview.chromium.org/390173004
http://code.google.com/p/v8/source/detail?r=22506
Modified:
Reviewers: Jakob,
Message:
PTAL Jakob, thanks.
Description:
Add CXX cross-compile detection into Makefile after it was removed from gyp.
Please review this at https://codereview.chromium.org/405113002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -1
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Support setting named properties on non-JSObjects.
BUG=
Please review this at https://codereview.chromium.org/407953002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+97, -109 lines):
M include/v8.h
M
Reviewers: Jakob,
Description:
Use 0 instead of undefined for uninitialized stub key.
The CPU profiler looks at uninitialized code objects, which triggers an
assertion.
TBR=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/404113003/
SVN Base:
Committed patchset #1 manually as r22507 (presubmit successful).
https://codereview.chromium.org/404113003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22507
Author: yang...@chromium.org
Date: Mon Jul 21 13:51:42 2014 UTC
Log: Use 0 instead of undefined for uninitialized stub key.
The CPU profiler looks at uninitialized code objects, which triggers an
assertion.
TBR=jkumme...@chromium.org
Review URL:
Reviewers: dcarney, jochen,
Message:
Please take a look.
Description:
Add bailout checks to Message::Get{Start,End}Column()
Also add an initial ON_BAILOUT() check to these two 'bailout enabled'
accessors.
(The need for these was encountered via http://crbug.com/393273)
R=
BUG=
Please review
lgtm
https://codereview.chromium.org/402173003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/07/21 14:08:46, dcarney wrote:
lgtm
Thanks, if a kind committer could propagate this change at some point,
that'd be
good. (There isn't a CQ for me to submit this to, right?)
https://codereview.chromium.org/402173003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: mstarzinger,
Description:
Enable object evacuation verifier. Perform verification of evacuation
candidates
when sweeping is done.
BUG=
Please review this at https://codereview.chromium.org/407893004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files
lgtm
https://codereview.chromium.org/405113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM.
https://codereview.chromium.org/407893004/diff/20001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/407893004/diff/20001/src/mark-compact.cc#newcode174
src/mark-compact.cc:174: heap_object = iterator.Next()) {
nit: Indentation looks off.
https://codereview.chromium.org/407893004/diff/20001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/407893004/diff/20001/src/mark-compact.cc#newcode174
src/mark-compact.cc:174: heap_object = iterator.Next()) {
On 2014/07/21 14:58:55, Michael Starzinger
Committed patchset #2 manually as r22508 (presubmit successful).
https://codereview.chromium.org/407893004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm
https://codereview.chromium.org/404113003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 22508
Author: hpa...@chromium.org
Date: Mon Jul 21 15:12:19 2014 UTC
Log: Enable object evacuation verifier. Perform verification of
evacuation candidates when sweeping is done.
BUG=
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/407893004
Committed patchset #1 manually as r22509 (presubmit successful).
https://codereview.chromium.org/405113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22509
Author: rmcil...@chromium.org
Date: Mon Jul 21 15:25:50 2014 UTC
Log: Add CXX cross-compile detection into Makefile after it was
removed from gyp.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/405113002
On 2014/07/21 at 09:16:15, rossberg wrote:
On 2014/07/17 23:34:37, arv wrote:
I haven't uploaded a new snapshot yet. I got stuck on the following:
var length = 2;
var a = [1];
assertEquals(0, Array.prototype.length);
a[Symbol.unscopables] = {length: true};
with (a) {
assertEquals(0,
Reviewers: rossberg,
Description:
Add constructor for range types.
R=rossb...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/409543004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+146, -9 lines):
M src/types.h
M src/types.cc
This should be fixed as of r22509.
Cheers,
Ross
On 21 July 2014 09:39, Ross McIlroy rmcil...@chromium.org wrote:
Yes, I'll plan to restore the convenience cross compiler detection on
standalone builds sometime today. In the meantime, as Henrik mentioned,
adding:
export
https://codereview.chromium.org/409543004/diff/1/src/types.cc
File src/types.cc (right):
https://codereview.chromium.org/409543004/diff/1/src/types.cc#newcode915
src/types.cc:915: os Range([ this-AsRange()-Min()
Let's print this as
Range(0.5..1.7 : bound)
to avoid too many parentheses.
Committed patchset #1 manually as r22510 (presubmit successful).
https://codereview.chromium.org/401243003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22510
Author: verwa...@chromium.org
Date: Mon Jul 21 15:59:05 2014 UTC
Log: Rename CurrentMapForDeprecated to TryUpdate, and introduce
Map::Update which potentially deprecates
BUG=
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/401243003
Reviewers: mstarzinger,
Description:
Set the state of a swept page after being done with sweeping.
BUG=
Please review this at https://codereview.chromium.org/408843003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+20, -14 lines):
M src/mark-compact.cc
Reviewers: Hannes Payer,
Message:
PTAL
Description:
Track history of events in GCTracer.
- track incremental marking stats directly on GCTracer.
- add simple ring buffer class.
- track last 10 scavenges and mark-compacts in ring buffers on GCTracer.
- various clean-ups.
R=hpa...@chromium.org
Revision: 22511
Author: verwa...@chromium.org
Date: Mon Jul 21 16:01:50 2014 UTC
Log: Reduce usage of StoreMode.
BUG=
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/409603002
http://code.google.com/p/v8/source/detail?r=22511
Modified:
Committed patchset #2 manually as r22511 (presubmit successful).
https://codereview.chromium.org/409603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Can you please merge all the tests into one file?
https://codereview.chromium.org/364853009/diff/60001/src/harmony-array.js
File src/harmony-array.js (right):
https://codereview.chromium.org/364853009/diff/60001/src/harmony-array.js#newcode132
src/harmony-array.js:132: var A = new C(len);
Committed patchset #1 manually as r22512 (presubmit successful).
https://codereview.chromium.org/402923002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 22512
Author: rmcil...@chromium.org
Date: Mon Jul 21 16:20:19 2014 UTC
Log: [Arm]: Assert that movw/movt is only emitted for Armv7 targets
R=joc...@chromium.org
Review URL: https://codereview.chromium.org/402923002
http://code.google.com/p/v8/source/detail?r=22512
On 2014/07/21 15:27:29, arv wrote:
On 2014/07/21 at 09:16:15, rossberg wrote:
On 2014/07/17 23:34:37, arv wrote:
I haven't uploaded a new snapshot yet. I got stuck on the following:
var length = 2;
var a = [1];
assertEquals(0, Array.prototype.length);
a[Symbol.unscopables] =
Reviewers: Yang,
Description:
Unflag symbols
R=yang...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/405803006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+17, -44 lines):
M src/bootstrapper.cc
M src/flag-definitions.h
M
Reviewers: danno, vincent.belliard.arm, paul.l..., gergely.kis.imgtec,
akos.palfi.imgtec, dusmil.imgtec,
Description:
MIPS: Never record safepoint with doubles.
Port r22496 (f9dde0f) and r22498 (7a16d69)
BUG=
Please review this at https://codereview.chromium.org/404143002/
SVN Base:
You should not remove the code-stubs here. The stubs that Dusan added gave
us a
significant reduction in generated code size. The arm32 port does not have
this
issue, due to the load/store-multiple instructions.
So even though we can remove the need to store doubles, the GP-register
1 - 100 of 118 matches
Mail list logo
