Yaniv Bronhaim has posted comments on this change.
Change subject: distribute logrotate libvirtd configuration file with vdsm.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27564/1/lib/vdsm/tool/libvirtd
File
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 5:
(5 comments)
http://gerrit.ovirt.org/#/c/27298/5/lib/vdsm/tool/configurator.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: json-rpc: Protocol detection
..
Patch Set 10: Code-Review-1
(12 comments)
http://gerrit.ovirt.org/#/c/26300/10/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 5:
(10 comments)
http://gerrit.ovirt.org/#/c/27298/5/lib/vdsm/tool/configurator.py
File
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: stats: move vm status detection in a method
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26549
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: distribute logrotate libvirtd configuration file with vdsm.
..
Patch Set 1:
(3 comments)
hi, can we have single patch with all configuration content extracted
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 22:
(2 comments)
http://gerrit.ovirt.org/#/c/26895/22/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: Require iscsi-initiator-utils = 6.2.0.873-21
..
spec: Require iscsi-initiator-utils = 6.2.0.873-21
From version 6.2.0.873-7 up to version
Dan Kenigsberg has posted comments on this change.
Change subject: spec: Require iscsi-initiator-utils = 6.2.0.873-21
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27570
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: sp: setDomainRegularRole is implemented by backend
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/24495
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sp: setDomainRegularRole is implemented by backend
..
sp: setDomainRegularRole is implemented by backend
Commit ab6014b394 factored out metadata
Federico Simoncelli has posted comments on this change.
Change subject: hsm: fix setStoragePoolDescription execution
..
Patch Set 1: Verified+1
Same as master.
--
To view, visit http://gerrit.ovirt.org/27543
To unsubscribe,
Michal Skrivanek has posted comments on this change.
Change subject: agent: Only forward desktopLogin when the agent is responsive
..
Patch Set 1: Code-Review+1
(1 comment)
+1, but enhance the commit message indeed
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: Add command name to args for command
..
Patch Set 2: Code-Review-1
(2 comments)
Partial review of docstring changes.
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Capture migration start time after the semaphore was
accquired
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/27135
To
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Capture migration start time after the semaphore was
accquired
..
Patch Set 1: -Verified
--
To view, visit http://gerrit.ovirt.org/27135
To
Dan Kenigsberg has posted comments on this change.
Change subject: models: Reorder bonding options so the mode is applied first
..
Patch Set 1: Code-Review-1
(3 comments)
Federico Simoncelli has posted comments on this change.
Change subject: misc: Faster version of readspeed
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27553/1/vdsm/storage/misc.py
File vdsm/storage/misc.py:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: models: Reorder bonding options so the mode is applied first
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27572/1/vdsm/network/models.py
File
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/26895/22/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: vm: Automatically add a serial port for a console device
..
Patch Set 5: Code-Review+1
deserves a bug, I'd like to see this in 3.4.z too
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm_hooks/hostusb: Allow multiple usb devices with same vendor
and product id
..
Patch Set 11: Code-Review-1
(1 comment)
Nir Soffer has posted comments on this change.
Change subject: misc: Faster version of readspeed
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27553/1/vdsm/storage/misc.py
File vdsm/storage/misc.py:
Line 231:
Xavi Francisco has uploaded a new change for review.
Change subject: storage: Add custom mount options to NFS SD
..
storage: Add custom mount options to NFS SD
When creating or modifying a NFS Storage Domain a user should be
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hsm: fix setStoragePoolDescription execution
..
hsm: fix setStoragePoolDescription execution
In commit ab6014b the pool metadata operations were moved
Martin Betak has posted comments on this change.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
Patch Set 4:
(7 comments)
http://gerrit.ovirt.org/#/c/27054/4/lib/vdsm/config.py.in
File
Martin Betak has posted comments on this change.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/27054
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 5:
(13 comments)
The way I see things now, I think 'type' belongs on file and not on
a config
Hello Dan Kenigsberg, Allon Mureinik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/27589
to review the following change.
Change subject: sp: setDomainRegularRole is implemented by backend
..
sp:
Nir Soffer has posted comments on this change.
Change subject: sp: setDomainRegularRole is implemented by backend
..
Patch Set 1: Verified+1
Trivial, verified on master.
--
To view, visit http://gerrit.ovirt.org/27589
To
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/5/lib/vdsm/tool/configurator.py
File
Federico Simoncelli has uploaded a new change for review.
Change subject: fileVolume: create file volume with correct mode
..
fileVolume: create file volume with correct mode
This patch removes a race in the volume file
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/22462/7/vdsm/caps.py
File vdsm/caps.py:
Line 325:
Nir Soffer has posted comments on this change.
Change subject: fileVolume: avoid full size truncation for cow
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27544
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: fileVolume: avoid full size truncation for cow
..
Patch Set 2: Verified+1
Verified creating sparse volumes on a file domain RAW/COW.
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: fileVolume: create file volume with correct mode
..
Patch Set 1: Verified+1
Verified: volumes are created with mode 0o660
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: volume: use qemuimg and remove custom createVolume
..
Patch Set 4: Verified+1
Verified:
* create base volumes RAW/COW block/file
* create volumes with
Nir Soffer has posted comments on this change.
Change subject: fileVolume: create file volume with correct mode
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27593
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: agent: Only forward desktopLogin when the agent is responsive
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27147
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: virt: stats: move vm runtime stats in a method
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/26548/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Antoni Segura Puimedon has posted comments on this change.
Change subject: virt: graphdev: handle ticket for multiple devices
..
Patch Set 25:
(2 comments)
http://gerrit.ovirt.org/#/c/26897/25//COMMIT_MSG
Commit Message:
Dan Kenigsberg has posted comments on this change.
Change subject: sp: setDomainRegularRole is implemented by backend
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27589
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sp: setDomainRegularRole is implemented by backend
..
sp: setDomainRegularRole is implemented by backend
Commit ab6014b394 factored out metadata
Francesco Romani has uploaded a new change for review.
Change subject: vm: drop the display params after device creation
..
vm: drop the display params after device creation
Once the devices of a Vm are been created, to keep
Francesco Romani has uploaded a new change for review.
Change subject: vm: reorganize the graphic devices lookup
..
vm: reorganize the graphic devices lookup
this patch extracts a method to gather and
return all the graphic
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 23: Verified+1
Vetrified with http://gerrit.ovirt.org/#/c/27595/ ,
Francesco Romani has posted comments on this change.
Change subject: vm: drop the display params after device creation
..
Patch Set 1: Verified+1
Vetrified with http://gerrit.ovirt.org/#/c/26895/ ,
Francesco Romani has posted comments on this change.
Change subject: vm: reorganize the graphic devices lookup
..
Patch Set 1: Verified+1
Vetrified with http://gerrit.ovirt.org/#/c/26895/ ,
http://gerrit.ovirt.org/#/c/27595/
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 17: Verified+1
Vetrified with http://gerrit.ovirt.org/#/c/26895/ ,
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 17:
verified the multiple graphics device using the functional tests due to lack of
engine
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: reorganize the graphic devices lookup
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27596
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: fileVolume: avoid full size truncation for cow
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/27544/2/vdsm/storage/fileVolume.py
File
Francesco Romani has posted comments on this change.
Change subject: vm: drop the display params after device creation
..
Patch Set 1:
further verification: created a VM on an host running VDSM 4.14.8.1 and
migrated on a
Francesco Romani has posted comments on this change.
Change subject: vm: drop the display params after device creation
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27595/1//COMMIT_MSG
Commit Message:
Line 1:
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/26895/22/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: vm: drop the display params after device creation
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/27595/1//COMMIT_MSG
Commit Message:
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 5: Verified+1
(1 comment)
http://gerrit.ovirt.org/#/c/27298/5/lib/vdsm/tool/configurator.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 17: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27215
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: distribute logrotate libvirtd configuration file with vdsm.
..
Patch Set 1:
(4 comments)
Merging back with previous commit
Dan Kenigsberg has posted comments on this change.
Change subject: virt: graphdev: handle ticket for multiple devices
..
Patch Set 26: Code-Review-1
(3 comments)
two docstring comments
Alon Bar-Lev has posted comments on this change.
Change subject: distribute logrotate libvirtd configuration file with vdsm.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27564/1/lib/vdsm/tool/configurator.py
File
mooli tayer has posted comments on this change.
Change subject: distribute logrotate libvirtd configuration file with vdsm.
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27564/1/lib/vdsm/tool/configurator.py
File
Alon Bar-Lev has posted comments on this change.
Change subject: distribute logrotate libvirtd configuration file with vdsm.
..
Patch Set 1:
dan,
why in case of logrotate we do not provide it in rpm using %config? it is our
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 6:
(1 comment)
nice! I think it is much better than what we had.
Nir Soffer has posted comments on this change.
Change subject: fileVolume: avoid full size truncation for cow
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/27544/2/vdsm/storage/fileVolume.py
File
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/6/lib/vdsm/tool/configurator.py
File
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/6/lib/vdsm/tool/configurator.py
File
Allon Mureinik has posted comments on this change.
Change subject: sp: Remove invalid validation of stale meta data
..
Patch Set 1:
Reiterating myself: Nir, can you please verify so this can be merged?
--
To view, visit
Hello Douglas Schilling Landgraf, Dan Kenigsberg, Allon Mureinik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/27599
to review the following change.
Change subject: spec: Require iscsi-initiator-utils = 6.2.0.873-21
Nir Soffer has posted comments on this change.
Change subject: misc: Decrease cpu usage when executing commands
..
Patch Set 2:
This version minimize the patch and cpu usage, thanks to Federico suggestion.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: gluster: correct GLUSTER_RPM_PACKAGES
..
Patch Set 3: Code-Review+2
Escalating score
--
To view, visit http://gerrit.ovirt.org/26379
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: correct GLUSTER_RPM_PACKAGES
..
gluster: correct GLUSTER_RPM_PACKAGES
The patch makes correct GLUSTER_RPM_PACKAGES
structure for list
Federico Simoncelli has posted comments on this change.
Change subject: oop: Add an option to configure oop implementation
..
Patch Set 9:
It seems to me that ioprocess is not related to _ModuleWrapper and it doesn't
belong
Dan Kenigsberg has posted comments on this change.
Change subject: spec: Require iscsi-initiator-utils = 6.2.0.873-21
..
Patch Set 1: Code-Review+2
I'd like to see it here, too.
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: core: removal of unneeded callback passing
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26760
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: LiveMerge: Remove old merge APIs
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26632
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: Add logging on filesystem altering operations
..
Patch Set 5: Code-Review-1
(4 comments)
Mostly nice, but there are some place which duplicated some
Dan Kenigsberg has posted comments on this change.
Change subject: fileVolume: avoid full size truncation for cow
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/27544/2/vdsm/storage/fileVolume.py
File
Nir Soffer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 6:
(6 comments)
Partial review.
http://gerrit.ovirt.org/#/c/27298/6/lib/vdsm/tool/configurator.py
Vered Volansky has posted comments on this change.
Change subject: Testing storageTest.py as CI job. Do NOT MERGE!
..
Patch Set 35:
This is a debug patch that is still in need.
--
To view, visit http://gerrit.ovirt.org/23343
80 matches
Mail list logo
