gerrit-hooks has posted comments on this change.
Change subject: Remove __init__.py file from lib64 vdsm python directory
..
Patch Set 7:
* #1279167::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279167::OK,
Nir Soffer has uploaded a new change for review.
Change subject: Revert "fileSD: improve error handling in deleteImage"
..
Revert "fileSD: improve error handling in deleteImage"
This patch included by mistake
Nir Soffer has posted comments on this change.
Change subject: Remove __init__.py file from lib64 vdsm python directory
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/50115/8/vdsm.spec.in
File vdsm.spec.in:
Line
Nir Soffer has posted comments on this change.
Change subject: tests: Set status when creating a job
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51269
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Set status when creating a job
..
Patch Set 1: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/51269
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Remove __init__.py file from lib64 vdsm python directory
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50115
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Revert "fileSD: improve error handling in deleteImage"
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51271
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: fileSD: Do not try to remove non-existent lease file
..
Patch Set 2:
* #1291207::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1291207::OK, public
Nir Soffer has posted comments on this change.
Change subject: Remove __init__.py file from lib64 vdsm python directory
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/50115/8/vdsm.spec.in
File vdsm.spec.in:
Line
gerrit-hooks has posted comments on this change.
Change subject: Remove __init__.py file from lib64 vdsm python directory
..
Patch Set 1: Verified-1
* #1279167::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Remove __init__.py file from lib64 vdsm python directory
..
Remove __init__.py file from lib64 vdsm python directory
During upgrade from vdsm-4.14 we restart
Nir Soffer has posted comments on this change.
Change subject: startup: Change system default encoding to utf8
..
Patch Set 1: Verified+1
Verified that we can start now vm with non-ascii name without failing when
logging the
gerrit-hooks has posted comments on this change.
Change subject: Remove __init__.py file from lib64 vdsm python directory
..
Patch Set 6:
* #1279167::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279167::OK,
Nir Soffer has posted comments on this change.
Change subject: tests: Test default Job.progress implementation
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/51213
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove __init__.py file from lib64 vdsm python directory
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/50115
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Remove __init__.py file from lib64 vdsm python directory
..
Patch Set 8:
* #1279167::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279167::OK,
Hello Piotr Kliczewski, Francesco Romani, Milan Zamazal,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/51273
to review the following change.
Change subject: startup: Change system default encoding to utf8
gerrit-hooks has posted comments on this change.
Change subject: startup: Change system default encoding to utf8
..
Patch Set 1:
* #1281940::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1281940::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: jobs: Add Job.__repr__ for easier debugging
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/51217
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: jobs: Replace validation method with a property
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/51216
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Test default Job.progress implementation
..
Patch Set 2: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/51213
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: JSONRPC: make Image.prepare to return info.
..
Patch Set 4:
(7 comments)
https://gerrit.ovirt.org/#/c/51054/4/lib/api/vdsmapi-schema.json
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Revert "fileSD: improve error handling in deleteImage"
..
Patch Set 1: Code-Review+2 Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/51271
Nir Soffer has posted comments on this change.
Change subject: fileSD: Do not try to remove non-existent lease file
..
Patch Set 2: Verified+1
Verified on nfs domain, lease files are removed from data domain and not
removed
gerrit-hooks has posted comments on this change.
Change subject: Revert "fileSD: improve error handling in deleteImage"
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least
gerrit-hooks has posted comments on this change.
Change subject: Revert "fileSD: improve error handling in deleteImage"
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Revert "fileSD: improve error handling in deleteImage"
..
Revert "fileSD: improve error handling in deleteImage"
This patch included by mistake
Marcin Mirecki has abandoned this change.
Change subject: vm: nic hotunplug exception handling - refactoring
..
Abandoned
squashed into: https://gerrit.ovirt.org/#/c/51187/
--
To view, visit https://gerrit.ovirt.org/51190
To
gerrit-hooks has posted comments on this change.
Change subject: vm: nic hotunplug exception handling - refactoring
..
Patch Set 1:
* #1134256::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/51190
To
Edward Haas has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/51164/5/lib/vdsm/netinfo/__init__.py
File
gerrit-hooks has posted comments on this change.
Change subject: vm: restoring correct vm nic device after HotunplugTimeout
..
Patch Set 2:
* #1134256::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1134256::OK,
Nir Soffer has restored this change.
Change subject: monitor: Clarify the semantics of MonitorThread.nextStatus
..
Restored
--
To view, visit https://gerrit.ovirt.org/38041
To unsubscribe, visit
Nir Soffer has restored this change.
Change subject: monitor: Convert valid to read-only property
..
Restored
--
To view, visit https://gerrit.ovirt.org/39088
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: spec: Remove the lib64 vdsm python directory
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/50115/2/vdsm.spec.in
File vdsm.spec.in:
Line 338:
Line
Nir Soffer has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/51164/4/lib/vdsm/netinfo/__init__.py
File
gerrit-hooks has posted comments on this change.
Change subject: JSONRPC: make Image.prepare to return info.
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Shahar Havivi has posted comments on this change.
Change subject: jobs: Add Job.__repr__ for easier debugging
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51217
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: jobs: Remove unused method
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51214
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: tests: Test default Job.progress implementation
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51213
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: jobs: Replace validation method with a property
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51216
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Edward Haas has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/51164
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 4: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/51164/4/lib/vdsm/netinfo/__init__.py
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Remove the lib64 vdsm python directory
..
Patch Set 2:
(1 comment)
Please check my comment in the bugzilla link
gerrit-hooks has posted comments on this change.
Change subject: fileSD: improve error handling in deleteImage
..
Patch Set 1:
* #1292092::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1292092::OK, public bug
*
Idan Shaby has posted comments on this change.
Change subject: fileSD: improve error handling in deleteImage
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51229
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/51164/4/lib/vdsm/netinfo/__init__.py
File
Amit Aviram has posted comments on this change.
Change subject: JSONRPC: make Image.prepare to return info.
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/51054/3/lib/api/vdsmapi-schema.json
File
Edward Haas has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/51164/4/lib/vdsm/netinfo/__init__.py
File
Freddy Rolland has posted comments on this change.
Change subject: storage: Move VOLUME_PERMISSIONS to storage constants
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50631
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Require safelease 1.0-6 for fedora 23 due to wrong build
..
Patch Set 1:
* #1287862::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1287862::OK,
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Require safelease 1.0-6 for fedora 23 due to wrong build
..
Require safelease 1.0-6 for fedora 23 due to wrong build
The spec of safelease 1.0-5 for fedora 23
Yaniv Bronhaim has posted comments on this change.
Change subject: Require safelease 1.0-6 for fedora 23 due to wrong build
..
Patch Set 1:
https://bodhi.fedoraproject.org/updates/FEDORA-2015-7cae850cb8
pushed to stable -
Dan Kenigsberg has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 4: Code-Review+2
Let's unbreak master
--
To view, visit https://gerrit.ovirt.org/51164
To
gerrit-hooks has posted comments on this change.
Change subject: spec: remove leftover directories on host
..
Patch Set 3:
* #1255114::Update tracker: OK
* Set MODIFIED::bug 1255114#1255114IGNORE, not oVirt
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: remove leftover directories on host
..
Patch Set 2: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/49607
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: spec: remove leftover directories on host
..
spec: remove leftover directories on host
Remove vdsm data directory and vdsm python lib
leftover
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: remove leftover directories on host
..
Patch Set 2: Verified+1
installed and removed vdsm -
Transaction test succeeded
Running transaction
Erasing:
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Remove the lib64 vdsm python directory
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/50115/2/vdsm.spec.in
File vdsm.spec.in:
Line 338:
Line
Shahar Havivi has posted comments on this change.
Change subject: jobs: Take lock once when deleting a job
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51215
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: spec: remove leftover directories on host
..
Patch Set 2:
* #1255114::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1255114::OK, public bug
* Check
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: remove leftover directories on host
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49607
To unsubscribe, visit
Idan Shaby has uploaded a new change for review.
Change subject: fileSD: improve error handling in deleteImage
..
fileSD: improve error handling in deleteImage
In FileStorageDomainManifest.deleteImage, we used to log that the
Dan Kenigsberg has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 4: -Code-Review
(2 comments)
gerrit-hooks has posted comments on this change.
Change subject: jobs: Remove unused method
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jobs: Remove unused method
..
jobs: Remove unused method
Nobody is calling Job.validate_done(), and I don't want to add test for
code that we don't
Dan Kenigsberg has posted comments on this change.
Change subject: jobs: Remove unused method
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51214
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove __init__.py file from lib64 vdsm python directory
..
Patch Set 3: Verified+1
output is:
gerrit-hooks has posted comments on this change.
Change subject: Remove __init__.py file from lib64 vdsm python directory
..
Patch Set 3:
* #1279167::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279167::OK,
Nir Soffer has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/51164/5/lib/vdsm/netinfo/__init__.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: vm: nic hotunplug exception handling - refactoring
..
Patch Set 1: Continuous-Integration+1
unrelated error
ERROR: testLoopMount (mountTests.MountTests)
Dan Kenigsberg has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/51164/5/lib/vdsm/netinfo/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: fileSD: improve error handling in deleteImage
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51229
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: nic hotunplug exception handling - refactoring
..
Patch Set 1:
the code seems fine, though I'd prefer squashing it into the previous patch.
--
To view,
Edward Haas has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/51164/4/lib/vdsm/netinfo/__init__.py
File
gerrit-hooks has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Tal Nisan has posted comments on this change.
Change subject: Added the option to scan alignment directly according to a
config value
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40402/5//COMMIT_MSG
Commit
Nir Soffer has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/51164/5/lib/vdsm/netinfo/__init__.py
File
Edward Haas has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/51164/5/lib/vdsm/netinfo/__init__.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51164
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove __init__.py file from lib64 vdsm python directory
..
Patch Set 3:
jenkins failure is not related.
--
To view, visit https://gerrit.ovirt.org/50115
To
Edward Haas has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/51164
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: net: mtu should be reported as a string through caps
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/51164/5/lib/vdsm/netinfo/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: issci: Fix equality and hash when username or password are None
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50939
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: iscsi: Fix credentials initialization when not using CHAP
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50940
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: iscsi: Fix credentials initialization when not using CHAP
..
Patch Set 1:
Verified with and without CHAP:
- discover targets
- create storage domain
-
gerrit-hooks has posted comments on this change.
Change subject: issci: Fix equality and hash when username or password are None
..
Patch Set 2:
* #1279485::Update tracker: OK
* Set MODIFIED::bug 1279485#1279485IGNORE,
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: issci: Fix equality and hash when username or password are None
..
issci: Fix equality and hash when username or password are None
When fetching iscsi
Yaniv Bronhaim has posted comments on this change.
Change subject: iscsi: Fix credentials initialization when not using CHAP
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50940
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: issci: Fix equality and hash when username or password are None
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50939
To unsubscribe,
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: iscsi: Fix credentials initialization when not using CHAP
..
iscsi: Fix credentials initialization when not using CHAP
There was a mismatch between
gerrit-hooks has posted comments on this change.
Change subject: iscsi: Fix credentials initialization when not using CHAP
..
Patch Set 2:
* #1279485::Update tracker: OK
* Set MODIFIED::bug 1279485#1279485OK
--
To
gerrit-hooks has posted comments on this change.
Change subject: jobs: Add Job.__repr__ for easier debugging
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Set status when creating a job
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: tests: Set status when creating a job
..
tests: Set status when creating a job
Instead of setting job private instance variables, set the status when
creating the
gerrit-hooks has posted comments on this change.
Change subject: tests: Test default Job.progress implementation
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: jobs: Replace validation method with a property
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: jobs: Take lock once when deleting a job
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: Remove __init__.py file from lib64 vdsm python directory
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/50115/3/vdsm.spec.in
File vdsm.spec.in:
Line
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: fileSD: improve error handling in deleteImage
..
fileSD: improve error handling in deleteImage
In FileStorageDomainManifest.deleteImage, we used to
1 - 100 of 106 matches
Mail list logo
