Change in vdsm[master]: tests: added NFS support to functional tests

2014-11-04 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: tests: added NFS support to functional tests .. tests: added NFS support to functional tests In this patch, I introduce a new NFS storage context for the

Change in vdsm[master]: tests: added NFS support to functional tests

2014-11-04 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: added NFS support to functional tests .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/32990 To unsubscribe, visit

Change in vdsm[master]: vdsm: refactored new functional tests

2014-11-02 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: vdsm: refactored new functional tests .. Patch Set 1: there's some merit to Nir's comments. Maybe this refactoring should be reverted. -- To view, visit

Change in vdsm[master]: vdsm: documentation for new storage functional tests

2014-10-26 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: vdsm: documentation for new storage functional tests .. vdsm: documentation for new storage functional tests Added a markdown README file that explains the

Change in vdsm[master]: volume: Log the correct error when creating a volume fails

2014-10-06 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: volume: Log the correct error when creating a volume fails .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33301 To unsubscribe,

Change in vdsm[master]: vdsm: require kernel-2.6.32-465 on for NFSv4 fixes

2014-10-05 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: vdsm: require kernel-2.6.32-465 on for NFSv4 fixes .. vdsm: require kernel-2.6.32-465 on for NFSv4 fixes This patch updates vdsm's dependencies to

Change in vdsm[master]: vdsm: require kernel-2.6.32-465 on for NFSv4 fixes

2014-10-05 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: vdsm: require kernel-2.6.32-465 on for NFSv4 fixes .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/33810 To unsubscribe, visit

Change in vdsm[master]: tests: added NFS support to functional tests

2014-09-16 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: tests: added NFS support to functional tests .. tests: added NFS support to functional tests In this patch, I introduce a new NFS storage context for the

Change in vdsm[master]: tests: new functional tests for vdsm storage

2014-09-15 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: new functional tests for vdsm storage .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.ovirt.org/32496 To unsubscribe, visit

Change in vdsm[master]: tests: new functional tests for vdsm storage

2014-09-14 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: new functional tests for vdsm storage .. Patch Set 4: (21 comments) http://gerrit.ovirt.org/#/c/32496/4/tests/functional/testlib/controlvdsm.py File

Change in vdsm[master]: tests: new functional tests for vdsm storage

2014-09-08 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: new functional tests for vdsm storage .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/32496/2/tests/functional/testlib/testcontexts/base.py

Change in vdsm[master]: tests: new functional tests for vdsm storage

2014-09-07 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: new functional tests for vdsm storage .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/32496 To unsubscribe, visit

Change in vdsm[master]: tests: new functional tests for vdsm storage

2014-09-07 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: new functional tests for vdsm storage .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/32496/2//COMMIT_MSG Commit Message: Line 24:

Change in vdsm[master]: iscsi and localfs functional tests integrated

2014-09-04 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: iscsi and localfs functional tests integrated .. iscsi and localfs functional tests integrated Change-Id: I483d57fbab9e3a804b99bb8353f3885ca72ecf38

Change in vdsm[master]: tests: new functional tests for vdsm storage

2014-09-04 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: tests: new functional tests for vdsm storage .. tests: new functional tests for vdsm storage Ultimately, the purpose of this patch is to replace the

Change in vdsm[master]: tests: new functional tests for vdsm storage

2014-09-04 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: new functional tests for vdsm storage .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/32496 To unsubscribe, visit

Change in vdsm[master]: tests: new functional tests for vdsm storage

2014-09-04 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: new functional tests for vdsm storage .. Patch Set 2: (13 comments) http://gerrit.ovirt.org/#/c/32496/2/tests/functional/testlib/controlvdsm.py File

Change in vdsm[master]: beautify and better __exit__ strategy

2014-09-01 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: beautify and better __exit__ strategy .. beautify and better __exit__ strategy 1. cleaned up the code a bit, added external runner script 2. __exit__ now

Change in vdsm[master]: all asserts are present and acounted from

2014-08-31 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: all asserts are present and acounted from .. all asserts are present and acounted from Change-Id: Ib18a71da6d6318f992dcfc17386c9ffc6be822ec Signed-off-by:

Change in vdsm[ovirt-3.5]: spec: Only build x86_64 and ppc64 architectures

2014-08-31 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: spec: Only build x86_64 and ppc64 architectures .. Patch Set 1: Code-Review+1 I'm currently working on extracting arch-dependent aspects of vdsm to a

Change in vdsm[master]: tests: revive camelCase convention

2014-08-26 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: tests: revive camelCase convention .. tests: revive camelCase convention I can't look at those underscores Change-Id:

Change in vdsm[master]: functests: createVolume works for iscsi

2014-08-26 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: functests: createVolume works for iscsi .. functests: createVolume works for iscsi the magic ingredient is sending a string for volume size Change-Id:

Change in vdsm[master]: storage domain creation assertion added

2014-08-26 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: storage domain creation assertion added .. storage domain creation assertion added Change-Id: Ib6b3fe56a5f8186c5a28cef75a128bd806c52894 Signed-off-by: Yoav

Change in vdsm[master]: storagePoolCreated assertion added

2014-08-26 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: storagePoolCreated assertion added .. storagePoolCreated assertion added Change-Id: Ia7e9e6a6d8d1c600df4348833c57e24f49172e98 Signed-off-by: Yoav

Change in vdsm[master]: removed second connectStorageServer

2014-08-26 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: removed second connectStorageServer .. removed second connectStorageServer The test passes without it. The Engine does this, but I don't see how to test for

Change in vdsm[master]: vdsm: extract arch-dependent details

2014-08-10 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: vdsm: extract arch-dependent details .. vdsm: extract arch-dependent details we now use other packages... Change-Id:

Change in vdsm[master]: rpm: make vdsm-python package noarch

2014-08-05 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: rpm: make vdsm-python package noarch .. rpm: make vdsm-python package noarch The vdsm-python package should be noarch. It seems that this was simply

Change in vdsm[master]: rpm: make vdsm-python package noarch

2014-08-05 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: rpm: make vdsm-python package noarch .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/31071 To unsubscribe, visit

Change in vdsm[master]: rpm: make vdsm-python package noarch

2014-08-05 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: rpm: make vdsm-python package noarch .. Patch Set 1: seems to work just fine -- To view, visit http://gerrit.ovirt.org/31071 To unsubscribe, visit

Change in vdsm[master]: domainMonitor: Fix unsafe status handling

2014-08-05 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe status handling .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29014 To unsubscribe, visit

Change in vdsm[master]: tests: fix wrong use of assertions

2014-08-05 Thread ykleinbe
Yoav Kleinberger has abandoned this change. Change subject: tests: fix wrong use of assertions .. Abandoned I will introduce new and much better functional storage tests soon. This is a waste of time. -- To view, visit

Change in vdsm[master]: tests: introducing whitebox tests

2014-07-28 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: introducing whitebox tests .. Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/29745/4/tests/README File tests/README: Line 30:

Change in vdsm[master]: tests: introducing whitebox tests

2014-07-28 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: introducing whitebox tests .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/29745 To unsubscribe, visit

Change in vdsm[master]: tests: introducing whitebox tests

2014-07-28 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: introducing whitebox tests .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/29745/5//COMMIT_MSG Commit Message: Line 18: because they are

Change in vdsm[master]: tests: Add external iscsi-target wrapper

2014-07-28 Thread ykleinbe
Yoav Kleinberger has abandoned this change. Change subject: tests: Add external iscsi-target wrapper .. Abandoned we're rewriting the functional tests entirely, so this is not needed. -- To view, visit

Change in vdsm[master]: tests: introducing whitebox tests

2014-07-27 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: introducing whitebox tests .. Patch Set 3: They are already published. I haven't changed the test itself, just its categorization. -- To view,

Change in vdsm[master]: tests: introducing whitebox tests

2014-07-27 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: introducing whitebox tests .. Patch Set 3: This is how we used the term 'whitebox' at LiveU. From Wikipedia, whitebox is a quite wide-ranging term.

Change in vdsm[master]: tests: introducing whitebox tests

2014-07-27 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: introducing whitebox tests .. Patch Set 4: Verified+1 Added a description in the tests/README for completeness -- To view, visit

Change in vdsm[master]: tests: introducing whitebox tests

2014-07-27 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: introducing whitebox tests .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/29745/4/tests/README File tests/README: Line 35: i.e. they

Change in vdsm[master]: tests: introducing whitebox tests

2014-07-21 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: introducing whitebox tests .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/29745/2//COMMIT_MSG Commit Message: Line 18: because they are

Change in vdsm[master]: tests: introducing whitebox tests

2014-07-21 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: introducing whitebox tests .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/29745/2//COMMIT_MSG Commit Message: Line 18: because they are

Change in vdsm[master]: tests: introducing whitebox tests

2014-07-21 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: introducing whitebox tests .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/29745/2/tests/whitebox/Makefile.am File

Change in vdsm[master]: tests: introducing whitebox tests

2014-07-20 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: introducing whitebox tests .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/29745 To unsubscribe, visit

Change in vdsm[master]: tests: Add a live merge functional test

2014-07-14 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: Add a live merge functional test .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29824/1/tests/functional/utils.py File

Change in vdsm[master]: tests: Add a live merge functional test

2014-07-14 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: Add a live merge functional test .. Patch Set 1: -Code-Review -- To view, visit http://gerrit.ovirt.org/29824 To unsubscribe, visit

Change in vdsm[master]: tests: Separate test runner from test library

2014-07-14 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: Separate test runner from test library .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/30022 To unsubscribe, visit

Change in vdsm[master]: tests: preparing form for another storage type

2014-07-14 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: tests: preparing form for another storage type .. tests: preparing form for another storage type The vision is to have a different vdsm test context for

Change in vdsm[master]: tests: Add a live merge functional test

2014-07-13 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: Add a live merge functional test .. Patch Set 1: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/29824/1/tests/functional/utils.py File

Change in vdsm[master]: tests: Add symlink mount test

2014-07-13 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: Add symlink mount test .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27514 To unsubscribe, visit

Change in vdsm[master]: tests: alignmentScanTests.py is a functional test

2014-07-09 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: tests: alignmentScanTests.py is a functional test .. tests: alignmentScanTests.py is a functional test Since alignmentScanTests invokes actual storage code,

Change in vdsm[master]: tests: improve bounds for iscsi test

2014-07-09 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: tests: improve bounds for iscsi test .. tests: improve bounds for iscsi test the previous bound in testSlow was unnecessarily generous. Change-Id:

Change in vdsm[master]: tests: alignmentScanTests.py is a functional test

2014-07-09 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: alignmentScanTests.py is a functional test .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/29745 To unsubscribe, visit

Change in vdsm[master]: tests: improve bounds for iscsi test

2014-07-09 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: improve bounds for iscsi test .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/29769 To unsubscribe, visit

Change in vdsm[master]: tests: improve bounds for iscsi test

2014-07-09 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: improve bounds for iscsi test .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29769/1/tests/iscsiTests.py File tests/iscsiTests.py: Line 75:

Change in vdsm[master]: tests: improve bounds for iscsi test

2014-07-09 Thread ykleinbe
Yoav Kleinberger has abandoned this change. Change subject: tests: improve bounds for iscsi test .. Abandoned agree with -1 review. -- To view, visit http://gerrit.ovirt.org/29769 To unsubscribe, visit

Change in vdsm[master]: tests: revived forgotten test

2014-07-09 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: tests: revived forgotten test .. tests: revived forgotten test It appears that the original author meant for the writeLargeData to be a test, but forgot the

Change in vdsm[master]: tests: revived forgotten test

2014-07-09 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: revived forgotten test .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/29780 To unsubscribe, visit

Change in vdsm[master]: tests: alignmentScanTests.py is a functional test

2014-07-09 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: alignmentScanTests.py is a functional test .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29745/1//COMMIT_MSG Commit Message: Line 7:

Change in vdsm[master]: domainMonitor: Cleanup imports

2014-07-06 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Cleanup imports .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29015 To unsubscribe, visit

Change in vdsm[master]: domainMonitor: Introduce cancellation points

2014-07-06 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Introduce cancellation points .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28721 To unsubscribe, visit

Change in vdsm[master]: domainMonitor: Refine names

2014-07-06 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Refine names .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29532 To unsubscribe, visit

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

2014-07-06 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28873 To unsubscribe, visit

Change in vdsm[master]: tests: Add symlink mount test

2014-07-06 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: Add symlink mount test .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27514 To unsubscribe, visit

Change in vdsm[master]: domainMonitor: Stop domain monitors concurrently

2014-07-06 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Stop domain monitors concurrently .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27573 To unsubscribe, visit

Change in vdsm[master]: volume: support multi line metadata values

2014-07-06 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: volume: support multi line metadata values .. Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28493/3/vdsm/storage/volume.py File

Change in vdsm[master]: incorporate stop/start logic to functional tests

2014-06-30 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: incorporate stop/start logic to functional tests .. incorporate stop/start logic to functional tests Change-Id: I55b86578a681de2b09ac5ee01ca2e3b9443ed13a

Change in vdsm[master]: multipath: Rescan also FC devices

2014-06-29 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: multipath: Rescan also FC devices .. Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/27122/5/vdsm/storage/hba.py File vdsm/storage/hba.py: Line 29

Change in vdsm[master]: DO NOT MERGE - draft: new functional tests

2014-06-29 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: DO NOT MERGE - draft: new functional tests .. DO NOT MERGE - draft: new functional tests DRAFT - DO NOT MERGE This patch introduces new functional tests.

Change in vdsm[master]: clarify that scsiKey parameter is not passed on

2014-06-23 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: clarify that scsiKey parameter is not passed on .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit

Change in vdsm[master]: logs: improve VDSM logs human-readability

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/28869 To unsubscribe, visit

Change in vdsm[master]: logs: improve VDSM logs human-readability

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 4: Verified+1 (1 comment) http://gerrit.ovirt.org/#/c/28869/4/vdsm/logger.conf.in File

Change in vdsm[master]: domainMonitor: Cleanup imports

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Cleanup imports .. Patch Set 1: Code-Review+1 Excellent -- To view, visit http://gerrit.ovirt.org/29015 To unsubscribe, visit

Change in vdsm[master]: logs: improve VDSM logs human-readability

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28869/1/vdsm/logger.conf.in File vdsm/logger.conf.in:

Change in vdsm[master]: domainMonitor: Fix unsafe status handling

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe status handling .. Patch Set 1: Code-Review-1 (2 comments) just a small thing, see comment inside.

Change in vdsm[master]: domainMonitor: Fix unsafe iteration of domain monitor status

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe iteration of domain monitor status .. Patch Set 1: Code-Review-1 (2 comments)

Change in vdsm[master]: domainMonitor: Fix unsafe iteration of domain monitor status

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe iteration of domain monitor status .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/29009/1/vdsm/storage/domainMonitor.py

Change in vdsm[master]: logs: improve VDSM logs human-readability

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 4: Marina, the flowID is not part of the format of the log - it is generated inside VDSM's code, so

Change in vdsm[master]: domainMonitor: Fix unsafe status handling

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe status handling .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29014/1/vdsm/storage/domainMonitor.py File

Change in vdsm[master]: domainMonitor: Fix unsafe iteration

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe iteration .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29007 To unsubscribe, visit

Change in vdsm[master]: domainMonitor: Fix unsafe status handling

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe status handling .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29014/1/vdsm/storage/domainMonitor.py File

Change in vdsm[master]: domainMonitor: Fix unsafe iteration of domain monitor status

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe iteration of domain monitor status .. Patch Set 1: Code-Review+1 (1 comment)

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 5: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/28873/5/tests/testrunner.py File

Change in vdsm[master]: domainMonitor: Fix unsafe status handling

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Fix unsafe status handling .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/29014/1/vdsm/storage/domainMonitor.py File

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/28873/5/vdsm/storage/clusterlock.py File

Change in vdsm[master]: domainMonitor: Introduce cancellation points

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: domainMonitor: Introduce cancellation points .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/28721/4/vdsm/storage/domainMonitor.py File

Change in vdsm[master]: fencing: Introduce getHostLeaseStatus API

2014-06-22 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: fencing: Introduce getHostLeaseStatus API .. Patch Set 5: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/28873/5/vdsm/storage/clusterlock.py File

Change in vdsm[master]: logs: improve VDSM logs human-readability

2014-06-19 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28869/1/vdsm/logger.conf.in File vdsm/logger.conf.in:

Change in vdsm[master]: logs: improve VDSM logs human-readability

2014-06-18 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28869/1/vdsm/logger.conf.in File vdsm/logger.conf.in:

Change in vdsm[master]: clarify that scsiKey parameter is not passed on

2014-06-17 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: clarify that scsiKey parameter is not passed on .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit

Change in vdsm[master]: clarify that scsiKey parameter is not passed on

2014-06-17 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: clarify that scsiKey parameter is not passed on .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28560/1/vdsm/API.py File vdsm/API.py: Line 983:

Change in vdsm[master]: logs: improve VDSM logs human-readability

2014-06-17 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: logs: improve VDSM logs human-readability .. logs: improve VDSM logs human-readability In this patch I introduce a new formatting for log messages that is

Change in vdsm[master]: logs: improve VDSM logs human-readability

2014-06-17 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: logs: improve VDSM logs human-readability .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/28869 To unsubscribe, visit

Change in vdsm[master]: clarify why scsiKey parameter is not passed on

2014-06-16 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: clarify why scsiKey parameter is not passed on .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28560/1//COMMIT_MSG Commit Message: Line 6: Line

Change in vdsm[master]: clarify why scsiKey parameter is not passed on

2014-06-12 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: clarify why scsiKey parameter is not passed on .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28560/1//COMMIT_MSG Commit Message: Line 6: Line 7:

Change in vdsm[master]: clarify why scsiKey parameter is not passed on

2014-06-10 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: clarify why scsiKey parameter is not passed on .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit

Change in vdsm[master]: resourceManager: Keep resource state if registerResource fails

2014-06-08 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: resourceManager: Keep resource state if registerResource fails .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/25284 To unsubscribe,

Change in vdsm[master]: tests: Add external iscsi-target wrapper

2014-06-03 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: tests: Add external iscsi-target wrapper .. tests: Add external iscsi-target wrapper We will use this to implement an iscsi backend for the functional

Change in vdsm[master]: tests: Add external iscsi-target wrapper

2014-06-03 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: Add external iscsi-target wrapper .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/28311 To unsubscribe, visit

Change in vdsm[master]: tests: fix wrong use of assertions

2014-06-01 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: fix wrong use of assertions .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/28124/5/tests/functional/storageTests.py File

Change in vdsm[master]: tests: fix wrong use of assertions

2014-06-01 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: fix wrong use of assertions .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/28124 To unsubscribe, visit

  1   2   >