> Vivek Titarmare wrote: >> >> Webrev for all the packages are created separately and are uploaded to >> cr.opensolaris.org. The url's are as follows: >> >> http://cr.opensolaris.org/~vivekrt/6816378-mvel/
Just looking at the first one... High level first pass review... usr/src/lib/mvel/METADATA http://dist.codehaus.org/mvel/mvel-1.2.22-java1.5.0.zip What does the java1.5.0 mean? It only runs on java 1.5? usr/src/lib/mvel/sunman/mvel.3 -In the man page and arc case you say you will deliver this: /usr/share/lib/java/mvel-1.2.22.jar -But you deliver this: /usr/share/lib/java/mvel-1.2.22-java1.5.0.jar - which is right? - do you need the "-java1.5.0" in the jar name? What's the reason for delivering old out-of-date versions again? Since you are going to all the trouble of delivering a mvel package. Why don't you also add the current version of the package and have the mvel.jar link point to that? mvel2-2.0.7.jar Cheers, Jim
