Hi Jim,

The zip file is downloaded from the link http://dist.codehaus.org/mvel/ .
This file is required for Drools and the name of the file is appended with
java1.5.0 originally. This package is using the default Java version (which
is the latest in Solaris),this package is NOT using (java 1.5) version. Also
the build.xml which is provided is used and so the jar file name is also
"mvel-1.2.22-java1.5.0.jar".

Let me know if you want me to change the build.xml to change the file name.

Best Regards,
~Vivek R. Titarmare

-----Original Message-----
From: James.Walker at Sun.COM [mailto:[email protected]] 
Sent: Thursday, April 09, 2009 2:57 AM
To: Vivek Titarmare
Cc: sfwnv-discuss at opensolaris.org
Subject: Re: [sfwnv-discuss] Request code review for mvel

> Vivek Titarmare wrote:
>>
>> Webrev for all the packages are created separately and are uploaded to 
>> cr.opensolaris.org. The url's are as follows:
>>
>> http://cr.opensolaris.org/~vivekrt/6816378-mvel/

Just looking at the first one...

High level first pass review...

usr/src/lib/mvel/METADATA
http://dist.codehaus.org/mvel/mvel-1.2.22-java1.5.0.zip

What does the java1.5.0 mean? It only runs on java 1.5?

usr/src/lib/mvel/sunman/mvel.3
-In the man page and arc case you say you will
deliver this:
/usr/share/lib/java/mvel-1.2.22.jar
-But you deliver this:
/usr/share/lib/java/mvel-1.2.22-java1.5.0.jar
- which is right?
- do you need the "-java1.5.0" in the jar name?

What's the reason for delivering old out-of-date
versions again?

Since you are going to all the trouble of delivering
a mvel package. Why don't you also add the current
version of the package and have the mvel.jar link
point to that?

mvel2-2.0.7.jar

Cheers,
Jim


Reply via email to