Enrique Lopez-Pineda wrote:
> Please see http://cr.opensolaris.org/~elpineda/git/webrev/ and provide
> any comments as
> needed if there are any issues which I need to correct.
- usr/src/pkgdefs/SUNWgit/depend
It's been a while since I last built git, but when I did, it also had
dependencies on libexpat, curl, zlib, perl, bash, tcl/tk, python, etc.
All you have here is gzip - are you sure you don't need more? (There
are scripts you can run to help determine your dependency needs if you
don't know them already. If you don't run them now, Install QA will
run them after you integrate, file bugs against you, and make you do
another round of changes to fix them, so it saves you and them time to
do it now.)
- usr/src/cmd/git/Makefile.sfw, usr/src/pkgdefs/SUNWgit/prototype_com & others
Looks like you're using the Linux/BSD man page sections, which need to
be remapped for Solaris - since git isn't a driver, it doesn't go in
section 7, but probably section 5. On Solaris, definitions of file
formats go in section 4, other file info & miscellaneous man pages go
in section 5, so it looks like you need to rename the *.5 files to
*.4, and *.7 to *.5 in the manpage rules in your Makefile.
- usr/src/cmd/Makefile, usr/src/pkgdefs/Makefile
According to the webrev, the only changes to these files are the SCCS id.
Notably, git does not appear to be in them. Merge errors? Webrev generation
error?
--
-Alan Coopersmith- alan.coopersmith at sun.com
Sun Microsystems, Inc. - X Window System Engineering
