Alan, Thank you very much for your review. Please see my responses and actions taken below. If there is anything else, please do let me know.
Thanks, Enrique Alan Coopersmith wrote: > Enrique Lopez-Pineda wrote: > >> Please see http://cr.opensolaris.org/~elpineda/git/webrev/ and provide >> any comments as >> needed if there are any issues which I need to correct. >> > > - usr/src/pkgdefs/SUNWgit/depend > > It's been a while since I last built git, but when I did, it also had > dependencies on libexpat, curl, zlib, perl, bash, tcl/tk, python, etc. > All you have here is gzip - are you sure you don't need more? (There > are scripts you can run to help determine your dependency needs if you > don't know them already. If you don't run them now, Install QA will > run them after you integrate, file bugs against you, and make you do > another round of changes to fix them, so it saves you and them time to > do it now.) > You are correct in that I am missing other dependencies. I ran a script to verify all dependencies which need to be added and I am in the process of adding those dependent packages found to my depend file. > - usr/src/cmd/git/Makefile.sfw, usr/src/pkgdefs/SUNWgit/prototype_com & others > > Looks like you're using the Linux/BSD man page sections, which need to > be remapped for Solaris - since git isn't a driver, it doesn't go in > section 7, but probably section 5. On Solaris, definitions of file > formats go in section 4, other file info & miscellaneous man pages go > in section 5, so it looks like you need to rename the *.5 files to > *.4, and *.7 to *.5 in the manpage rules in your Makefile. > Aside from renaming, I would need to edit the section within the man page itself, correct? I am working on including sed commands to do this work. Will that be right? > - usr/src/cmd/Makefile, usr/src/pkgdefs/Makefile > > According to the webrev, the only changes to these files are the SCCS id. > Notably, git does not appear to be in them. Merge errors? Webrev generation > error? > > I have fixed this problem. Thanks, Enrique -- Enrique Lopez-Pineda Sun Microsystems enrique.lopezpineda at sun.com 651-552-6426 (x44626) -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20080618/d7a8c5f8/attachment.html>
