Hi Todd, See below for comments from my quick skip through ...
Paul On Thu, 2008-06-19 at 18:37, Todd Pisek wrote: > Please see http://cr.opensolaris.org/~trp/ircii/webrev/ and provide any > comments or changes I need to make. > === Start of Comments === 1. usr/src/cmd/Makefile & usr/src/pkgdefs/Makefile needs resyncing with gate otherwise it looks as though you are trying to delete stuff. 2. usr/src/cmd/ircii/Makefile.sfw You are hard coding '--prefix=', you might want to use the predefined value in CONFIGURE_OPTIONS, see http://cr.opensolaris.org/~rayx/erlang/webrev/usr/src/cmd/erlang/Makefile.sfw.html 3. usr/src/cmd/ircii/install-sfw Various assignments are unused, eg, INFODIR=, MAN1DIR=, etc., you should probably remove these. 4. usr/src/pkgdefs/SUNWircii/pkginfo.tmpl Shouldn't the VERSION= line be .. VERSION="SFWVERS,REV=0.0.0" You might want to put the source pkg version on the end of the DESC= line - as some other sfwnv pkgs do. 5. depend How you checked that this pkg doesn't have any dependencies using the check-deps.pl script? 6. Everything else looks okay to me === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
