> A webrev report is now available for the required changes : > http://opensource.shivakumar.info/webrevs/sfw-expect_webrev
I don't think you should spend much time on the code changes until at least the ARC has been completed, as otherwise you will waste time merging with the latest putbacks and incorporating changes required by ARC. That said, here are a few points to consider when you return to this: - the putback comment for each file should be: <Bug Id> <Bug Synopsis> - you should update the Copyright year in each you touch - if you use "wx rm ..." to delete a file, it will correctly show up as being moved to "deleted_files/" - assuming you still retain libexpect5.43.a after ARC, why install it in /usr/lib/expect5.43/, rather than just /usr/lib? - manpages should be run through a sed script to add the Sun stability classification, etc, before being installed (eg see the sunman-stability script in several other dirs) - your prototype_com file is installing everything in /usr/sfw? And not using the ".../demo/" dir? Regards, Dermot
