Hello Mike, The draft ARC request is attached. I have added a 2 line addendum to the ARC request about the files in the public domaind & GPL (was asked to add in an earlier comment).
The code review is available at http://cr.opensolaris.org/~gns/sfw-expect_webrev Responses to the earlier mails/comments below. Please note my response to your comment about GPL2 notice to be added to pkg copyright. regards Shiv On 10/10/07, Mike Sullivan <Mike.Sullivan at sun.com> wrote: > Mike Sullivan wrote: > > So remember this number for your sponsor: 7202. That's the > legal review number which was just approved. > > You do have to add the gpl2 snippit in the package copyright > file though. Not a single GPL script goes into the package. The GPL scripts as noted in an earlier mail are scripts that *can be* used to test the build results. The author has released expect under certain terms and conditions. Changing this to any other license is being wrong. It also misleads the users of the package. On 10/3/07, David.Comay at sun.com <David.Comay at sun.com> wrote: > > Unless there is strong justification for a static library, I would only > deliver a dynamic library under /usr/lib. > My initial proposal was to install it at the location where the users expect it to be present (/usr/lib/expect5.43/). But after checking further, I see that the static lib is not a required item. I have removed the static lib. > - manpages should be run through a sed script to add the Sun > stability classification, etc, before being installed (eg > see the sunman-stability script in several other dirs) I observe that some softwares have hand processed man pages already stored while some others using -M option from install.subr I have chosen the latter. I picked sunman-stability from pcre. Please have a look at the code review link and let me know if the incorporation is proper. -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: ARC_Request_Expect-in-SFW.txt URL: <http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20071010/387ebecf/attachment.txt>
