On 10/2/07, Dermot McCluskey <Dermot.McCluskey at sun.com> wrote: > > A webrev report is now available for the required changes : > > http://opensource.shivakumar.info/webrevs/sfw-expect_webrev > > I don't think you should spend much time on the code changes > until at least the ARC has been completed, as otherwise you > will waste time merging with the latest putbacks and incorporating > changes required by ARC.
Yeah. Shall I now post a ARC request based an the latest changes. Will not make any further changes as of now. Some responses below. > > That said, here are a few points to consider when you return > to this: > > - the putback comment for each file should be: > <Bug Id> <Bug Synopsis> > As far as I know SFW is not under svn/hg as of now. I created a local repository for the sake of creating a webrev. The commit comments cannot be applied as is hence this is not as applicable. > - you should update the Copyright year in each you touch > Will update suitably after legal review > - if you use "wx rm ..." to delete a file, it will correctly > show up as being moved to "deleted_files/" Will check. webrev & related tools need a howto/FAQ ! > - assuming you still retain libexpect5.43.a after ARC, why > install it in /usr/lib/expect5.43/, rather than just /usr/lib? > Will leave it to ARC. The default install location where ppl expect it to be present. > - manpages should be run through a sed script to add the Sun > stability classification, etc, before being installed (eg > see the sunman-stability script in several other dirs) > Will leave it to after ARC. Doesn't CCD need to do this. Expect in CCD doesn't seem to do it. > - your prototype_com file is installing everything in > /usr/sfw? And not using the ".../demo/" dir? > Error while patching a generating a webrev. The 3rd patch of the 3 patches I had provided is not reflected. So all the files under pkgdefs/SUNWexpect were old. Has been rectified. -Shiv
