Yaniv Bronhaim has posted comments on this change. Change subject: supervdsmServer is down after failed operation (#846307) ......................................................................
Patch Set 2: Verified (2 inline comments) I can't add ut for this specific change. This change is not about a specific io error, its about handling crashes of supervdsmServer. If you have good idea for such tests please tell me.. I thought about adding dummy method in supervdsmServer that raises an error, and the ut will call it and verify that supervdsmServer is still alive afterwards.. .................................................... File vdsm/supervdsm.py Line 64: getattr(self._supervdsmProxy._svdsm, self._funcName)(*args, Line 65: **kwargs) Line 66: try: Line 67: return callMethod() Line 68: except (IOError, socket.error, AuthenticationError): The IOError was fixed here: http://gerrit.ovirt.org/#/c/7214/6 . This patch is here to handle such bugs in supervdsmServer without disabling its service Line 69: self._supervdsmProxy._restartSupervdsm() Line 70: Line 71: Line 72: class SuperVdsmProxy(object): Line 65: **kwargs) Line 66: try: Line 67: return callMethod() Line 68: except (IOError, socket.error, AuthenticationError): Line 69: self._supervdsmProxy._restartSupervdsm() We need to handle the error inside supervdsmServer. We can raise an exception in case of a bug (as you said..) , i prefer to add error log and move on. Line 70: Line 71: Line 72: class SuperVdsmProxy(object): Line 73: """ -- To view, visit http://gerrit.ovirt.org/7901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idad4a622b82259b777851d1b0c1b37ec8da2b01e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
