Dan Kenigsberg has posted comments on this change. Change subject: supervdsmServer is down after failed operation ......................................................................
Patch Set 2: (2 inline comments) .................................................... File vdsm/supervdsm.py Line 64: getattr(self._supervdsmProxy._svdsm, self._funcName)(*args, Line 65: **kwargs) Line 66: try: Line 67: return callMethod() Line 68: except (IOError, socket.error, AuthenticationError): this is only one example of one possible exception raised inside supervdsm. this commit should handle all possible errors, and differentiate between those originating in a method to those originating in the framework. payload exceptions should *not* cause supervdsm restart. Line 69: self._supervdsmProxy._restartSupervdsm() Line 70: Line 71: Line 72: class SuperVdsmProxy(object): Line 65: **kwargs) Line 66: try: Line 67: return callMethod() Line 68: except (IOError, socket.error, AuthenticationError): Line 69: self._supervdsmProxy._restartSupervdsm() This cannot be the responsibility of the supervdsm framework. You don't know who calls the method, and what is he going to do with the None you return to it. If there is an error, you raise and exception. Line 70: Line 71: Line 72: class SuperVdsmProxy(object): Line 73: """ -- To view, visit http://gerrit.ovirt.org/7901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idad4a622b82259b777851d1b0c1b37ec8da2b01e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
