Royce Lv has posted comments on this change. Change subject: supervdsmServer is down after failed operation ......................................................................
Patch Set 5: (1 inline comment) .................................................... File vdsm/supervdsm.py Line 88: finally: Line 89: if err != "": Line 90: self._supervdsmProxy._log.error(err) Line 91: self._supervdsmProxy._restartSupervdsm() Line 92: We can raise a specific exception when supervdsmServer functions error, and catch it here and print the stack then ignore this error. But if vdsm proxy can't comunicate with supervdsmServer, proper action should be restart it. Line 93: Line 94: class SuperVdsmProxy(object): Line 95: """ Line 96: A wrapper around all the supervdsm init stuff -- To view, visit http://gerrit.ovirt.org/7901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idad4a622b82259b777851d1b0c1b37ec8da2b01e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
