Dan Kenigsberg has posted comments on this change. Change subject: supervdsmServer is down after failed operation ......................................................................
Patch Set 5: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/supervdsm.py Line 64 Line 65 Line 66 Line 67 Line 68 if you added here _log.error(something, exc_info=True) and replaced the "return" with "raise" you'd have a clearer code - but still not address the bug. We should not restart supervdsm just because an exception happened within one of its functions. You must differentiate between an exception raised by supervdsm function, and framework exceptions. -- To view, visit http://gerrit.ovirt.org/7901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idad4a622b82259b777851d1b0c1b37ec8da2b01e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
