Federico Simoncelli has posted comments on this change.
Change subject: pool: live storage migration implementation
......................................................................
Patch Set 11: (2 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 2215: return
Line 2216: self.log.info('%s = %s/%s error %s phys: %s
alloc: %s',
Line 2217: blockDevAlias, d.domainID,
d.volumeID, err,
Line 2218: physical, alloc)
Line 2219: self._lvExtend(d.name)
self.extendDriveVolume(d)
Line 2220:
Line 2221: def _acpiShutdown(self):
Line 2222:
self._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN)
Line 2223:
....................................................
File vdsm/storage/image.py
Line 654: }
Line 655:
Line 656: # Preliminary checks on the source and destination chain
Line 657: if len(chains['srcChain']) < 2:
Line 658: raise RuntimeError()
Ah I totally forgot about these. Raise an appropriate exception.
Line 659:
Line 660: if len(chains['srcChain']) != len(chains['dstChain']):
Line 661: raise RuntimeError()
Line 662:
--
To view, visit http://gerrit.ovirt.org/5252
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91e641cb1d25feb8a406aa7ad07415587a7ac290
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
