Federico Simoncelli has posted comments on this change.

Change subject: pool: live storage migration implementation
......................................................................


Patch Set 14: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 2115:         if srcDisk != dstDisk:
Line 2116:             self.log.debug("Stopping the disk replication switching 
to the "
Line 2117:                            "destination drive: %s", dstDisk)
Line 2118:             blockJobFlags = libvirt.VIR_DOMAIN_BLOCK_JOB_ABORT_PIVOT
Line 2119:             diskToTeardown = srcDrive.diskReplicate
This should be switched with line 2130.
Line 2120: 
Line 2121:             # We need to stop the stats collection in order to avoid 
spurious
Line 2122:             # errors from the stats threads during the switch from 
the old
Line 2123:             # drive to the new one. This applies only to the case 
where we


--
To view, visit http://gerrit.ovirt.org/5252
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91e641cb1d25feb8a406aa7ad07415587a7ac290
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to