Federico Simoncelli has posted comments on this change.
Change subject: pool: live storage migration implementation
......................................................................
Patch Set 11: (2 inline comments)
....................................................
File vdsm/storage/hsm.py
Line 1355: srcDom = self.validateSdUUID(sdUUID)
Line 1356: dstDom = self.validateSdUUID(dstSdUUID)
Line 1357:
Line 1358: # Do not validate images in Backup domain
Line 1359: if not sdCache.produce(dstSdUUID).isBackup():
Ah right I just came here to get rid of this... because we don't even need this
check.
Line 1360: self.validateImageMove(srcDom, dstDom, imgUUID)
Line 1361:
Line 1362: for dom in sorted((sdUUID, dstSdUUID)):
Line 1363: vars.task.getSharedLock(STORAGE, dom)
....................................................
File vdsm/storage/image.py
Line 673: self._finalizeDestinationImage(dstDom, imgUUID, chains, False)
Line 674:
Line 675: def sync(self, sdUUID, imgUUID, dstSdUUID, operations):
Line 676: srcDom = sdCache.produce(sdUUID)
Line 677: dstDom = sdCache.produce(dstSdUUID)
Mmm worse than a patch that introduced a "produce" for every attribute/method
you touch in a domain object? :-)
Line 678:
Line 679: if operations.get('prepare', False):
Line 680: # NOTE: eventually we could try to consider the
excludeLeaf
Line 681: # option here too. At the time of this writing there are
no
--
To view, visit http://gerrit.ovirt.org/5252
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91e641cb1d25feb8a406aa7ad07415587a7ac290
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
