Ayal Baron has posted comments on this change.
Change subject: pool: live storage migration implementation
......................................................................
Patch Set 13: (1 inline comment)
Please note additional comment in vm.py extendVolume method
....................................................
File vdsm/vm.py
Line 720: self.log.debug('new rtc offset %s', timeOffset)
Line 721: self.conf['timeOffset'] = timeOffset
Line 722:
Line 723: def extendDriveVolume(self, vmDrive, newSize=None):
Line 724: if not vmDrive.blockDev:
what about direct LUN?
Line 725: self.log.error("The device %s is not a block device",
vmDrive.name)
Line 726: return
Line 727:
Line 728: if newSize is None:
--
To view, visit http://gerrit.ovirt.org/5252
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91e641cb1d25feb8a406aa7ad07415587a7ac290
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
