Federico Simoncelli has posted comments on this change.
Change subject: pool: live storage migration implementation
......................................................................
Patch Set 14: (3 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 2019: and device.get("name") == srcDrive.name):
Line 2020: device['diskReplicate'] = dstDisk
Line 2021: break
Line 2022: else:
Line 2023: raise LookupError("No such drive: '%s'" % srcDrive.name)
Rollback the srcDrive.diskReplicate
Line 2024:
Line 2025: self.saveState()
Line 2026:
Line 2027: def isDiskReplicationInProgress(self, srcDrive):
Line 2034: if (device['type'] == vm.DISK_DEVICES
Line 2035: and device.get("name") == srcDrive.name):
Line 2036: del device['diskReplicate']
Line 2037: break
Line 2038: else:
Comment why here we can't rollback.
Line 2039: raise LookupError("No such drive: '%s'" % srcDrive.name)
Line 2040:
Line 2041: self.saveState()
Line 2042:
Line 2064: libvirt.VIR_DOMAIN_BLOCK_REBASE_SHALLOW
Line 2065: ))
Line 2066: except:
Line 2067: self.log.error("Unable to start the replication for %s
to %s",
Line 2068: srcDrive.name, dstDiskCopy, exc_info=True)
Try to teardown dstDiskCopy
Line 2069:
Line 2070: self._delDiskReplica(srcDrive)
Line 2071: return errCode['replicaErr']
Line 2072:
--
To view, visit http://gerrit.ovirt.org/5252
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91e641cb1d25feb8a406aa7ad07415587a7ac290
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
