Federico Simoncelli has posted comments on this change.
Change subject: pool: live storage migration implementation
......................................................................
Patch Set 14: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 1815: baseDrv, tgetDrv = _normSnapDriveParams(drive)
Line 1816:
Line 1817: try:
Line 1818: self._findDriveByUUIDs(tgetDrv)
Line 1819: except LookupError:
Bad logic here. I should use else.
Line 1820: # The snapshot volume is the current one, skipping
Line 1821: self.log.debug("The volume is already in use: %s",
tgetDrv)
Line 1822: continue
Line 1823:
--
To view, visit http://gerrit.ovirt.org/5252
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91e641cb1d25feb8a406aa7ad07415587a7ac290
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
