Federico Simoncelli has posted comments on this change.
Change subject: pool: live storage migration implementation
......................................................................
Patch Set 11: (2 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 1798: for drive in snapDrives:
Line 1799: baseDrv, tgetDrv = _normSnapDriveParams(drive)
Line 1800:
Line 1801: try:
Line 1802: self._findDriveByUUIDs(tgetDrv):
Remove the final ":".
Line 1803: except LookupError:
Line 1804: # The snapshot volume is the current one, skipping
Line 1805: self.log.debug("The volume is already in use: %s",
tgetDrv)
Line 1806: continue
....................................................
File vdsm/storage/hsm.py
Line 1356: dstDom = self.validateSdUUID(dstSdUUID)
Line 1357:
Line 1358: # Do not validate images in Backup domain
Line 1359: if not sdCache.produce(dstSdUUID).isBackup():
Line 1360: self.validateImageMove(srcDom, dstDom, imgUUID)
Fix the validation using validateImageCopy.
Line 1361:
Line 1362: for dom in sorted((sdUUID, dstSdUUID)):
Line 1363: vars.task.getSharedLock(STORAGE, dom)
Line 1364:
--
To view, visit http://gerrit.ovirt.org/5252
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91e641cb1d25feb8a406aa7ad07415587a7ac290
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
