Giuseppe Vallarelli has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ......................................................................
Patch Set 4: (1 inline comment) .................................................... File vdsm/netconf/ifcfg.py Line 63: if self.configWriter: Line 64: self.configWriter = None Line 65: self._libvirtAdded = set() Line 66: Line 67: def configureBridge(self, bridge, network=None, **opts): I saw that you did this design choice, by having an external object which does the configuration (Ifcfg), I don't feel like it's really needed, but probably there are some reasons for that. Line 68: try: Line 69: ipaddr = bridge.ip.inet.address Line 70: netmask = bridge.ip.inet.netmask Line 71: gateway = bridge.ip.inet.gateway -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches