On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
On Tue, 21 May 2024 22:32:21 GMT, Kevin Rushforth wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and
On Sat, 18 May 2024 14:24:49 GMT, Kevin Rushforth wrote:
> Maybe it's worth changing "adds any new" to "adds, removes, or modifies any"?
This looks like a good idea.
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1605798488
On Fri, 17 May 2024 14:58:41 GMT, Nir Lisker wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 20 addi
On Fri, 17 May 2024 14:10:43 GMT, Kevin Rushforth wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth wrote:
> It looks like the list of packages available in the Ubuntu 22.04 GitHub
> Actions test runner no longer includes `gcc-13` as of yesterday. I didn't
> find any documentation to indicate that this was intentional, but now that
> Ubuntu
On Wed, 15 May 2024 20:08:10 GMT, John Hendrikx wrote:
>> or is it? :-)
>
> Isn't this automatic? Seems weird you could integrate without these passing.
> or is it? :-)
Looks to me like it is...
On Wed, 15 May 2024 17:45:56 GMT, Kevin Rushforth wrote:
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing, and integrating
>
Hello,
I see that dependency scanning is supported for Maven pom files, however,
many projects use Gradle as their dependency management tool. Has Gradle
support been considered?
Best,
Nir
On Fri, 26 Apr 2024 07:53:59 GMT, Lukasz Kostyra wrote:
>> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
>> no longer needed.
>>
>> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
>> changed the type to explicitly use
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote:
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are
> no longer needed.
>
> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I
> changed the type to explicitly use `IDirect3DDevice9Ex`.
/javase/21/core/restricted-methods.html
>>
>> But one thing to watch out for with FFM is startup + warm up time.
>> I struggled a lot with that in using FFM for just one library in the
>> java.desktop module.
>>
>> -phil
>>
>> On 4/22/24 9:12 AM, Nir Lisker
Sorry, we bumped to Java 21 in JavaFX 22 I think since we preserve the N-1
rule.
On Mon, Apr 22, 2024 at 6:03 PM Nir Lisker wrote:
> I think that we'll be able to bump to Java 25 in JavaFX 25, like we did
> with 21. I suggested initially to bump to Java 22 exactly for FFM as it's
> ve
I think that we'll be able to bump to Java 25 in JavaFX 25, like we did
with 21. I suggested initially to bump to Java 22 exactly for FFM as it's
very useful for JavaFX, but was told we shouldn't since it's not an LTS
version.
I have no idea how long the work on Wayland will take including the
urn new Size(size, size);
> }
>
>
> 2) Callbacks
>
> @Override
> protected void _invokeLater(Runnable runnable) {
> MemorySegment call = GSourceFunc.allocate(p -> {
> runnable.run();
> return 0;
> }, Arena.ofAuto());
>
> g_idle_add(call, MemorySegm
eed this to hook the events with wl_registry_add_listener, but
> currently the code generation for this is not working.
>
>
>
>
>
> Em dom., 21 de abr. de 2024 às 16:39, Nir Lisker
> escreveu:
>
>> What are wl_ types? jextract only supports c headers.
>>
>> On Sun, Apr 21, 20
What are wl_ types? jextract only supports c headers.
On Sun, Apr 21, 2024 at 10:31 PM Thiago Milczarek Sayão <
thiago.sa...@gmail.com> wrote:
> Hi,
>
> I did a small test app to explore Wayland client and portals (for Robot
> and dialogs such as file open/save).
>
>
I didn't find such memory leaks in my application, though I don't do stage
handling. What I would look at is where the `stage` reference in the lambda
is coming from. You say you have a list of open stages. When you close a
stage, do you remove the references to that stage from all places? What
On Thu, 28 Mar 2024 22:21:32 GMT, drmarmac wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/ControlUtils.java
>> line 166:
>>
>>> 164: sm.startAtomic();
>>> 165:
>>> 166: final List removed = new
>>> ArrayList<>(c.getRemovedSize());
>>
>> I wonder
On Wed, 27 Mar 2024 23:18:43 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/MultipleSelectionModelBase.java
>> line 773:
>>
>>> 771: .collect(Collectors.toList());
>>> 772:
>>> 773:
On Wed, 27 Mar 2024 20:38:58 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added gradle script
Looks li
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Whitespace?
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1387/files
- new: ht
On Wed, 27 Mar 2024 20:38:58 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added gradle script
I
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Added gradle script
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1387/files
- new: ht
On Thu, 21 Mar 2024 21:50:37 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble,
> etc.) and update the copyright year to 2024. Using wildcard for more than 10
> static imports.
>
>
> --
>
> This is a trivial change (though fairly large),
On Wed, 27 Mar 2024 09:11:56 GMT, drmarmac wrote:
>> This PR removes potentially incorrect usages of Stream.peek().
>> The changed code should be covered by the tests that are already present.
>
> drmarmac has updated the pull request incrementally with one additional
> commit since the last
On Wed, 27 Mar 2024 12:23:47 GMT, Marius Hanl wrote:
>> I'd say .forEach() is used correctly here, according to docs, it guarantees
>> execution of the side-effects (add to removed list & clear index), just not
>> in any particular order. This way we avoid multiple iteration.
>
> Another idea
On Wed, 13 Mar 2024 22:32:59 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with five additional
> commits since the last revision:
>
> - Added spacing
> - Renam
On Thu, 21 Mar 2024 18:47:24 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in javafx.controls and update the
> copyright year to 2024. Using wildcard for more than 10 static imports.
>
> This is a trivial change, 1 reviewer is probably enough.
I can, but it will
On Tue, 19 Mar 2024 22:28:54 GMT, Andy Goryachev wrote:
>> tests/system/src/test/java/test/util/Util.java line 383:
>>
>>> 381: runAndWait(() -> {
>>> 382: for (Window w : new ArrayList<>(Window.getWindows())) {
>>> 383: w.hide();
>>
>> I think you can use
On Mon, 18 Mar 2024 22:53:03 GMT, Andy Goryachev wrote:
> Changing `Util.shutdown()` to hide **all** showing Windows and then call
> `Platform.exit()`.
> This simplifies the tests and ensures a clean shutdown.
tests/system/src/test/java/test/util/Util.java line 383:
> 381:
On Tue, 5 Mar 2024 16:44:00 GMT, Ambarish Rapte wrote:
> Executing the LightingSample manually fails with an exception
I think the package names of the main and resources weren't aligned.
> The copyright year new files should be 2024 only. Some new files have more
> than one copyright year.
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with five additional
commits since the last revision:
- Added spacing
- Renamed constant
- Updated benchmark reset message
- Simplified models creation
- Rev
On Tue, 5 Mar 2024 16:49:28 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> copyright headers
>
> tests/performance/3DLighting/src/main/java/lighting3D/Be
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
copyright headers
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1387/files
- new: ht
> Update for the 3D lighting test tool as described in the JBS issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Undo files move
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1387/files
- new: ht
On Sat, 9 Mar 2024 06:48:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
>>
On Mon, 4 Mar 2024 21:04:28 GMT, Andy Goryachev wrote:
> Adds Labeled.truncated property which indicates when the text is visually
> truncated (and the ellipsis string is inserted) in order to fit the available
> width.
>
> The new property reacts to changes in the following properties:
> -
Update for the 3D lighting test tool as described in the JBS issue.
-
Commit messages:
- Whitespaces
- Initial commit
Changes: https://git.openjdk.org/jfx/pull/1387/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=1387=00
Issue: https://bugs.openjdk.org/browse/JDK-8327179
Hi Dirk,
JavaFX has some input validation support in terms of focus control and
rejecting invalid characters. Can you explain what your proposal adds? Are
there JBS issues asking for this?
Thanks,
Nir
On Fri, Mar 1, 2024, 13:50 Dirk Lemmermann wrote:
> Hi everyone,
>
> I updated the
On Wed, 28 Feb 2024 18:48:21 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model
On Thu, 29 Feb 2024 11:46:11 GMT, Nir Lisker wrote:
> This pull request contains a backport of commit
> [d9645730](https://github.com/openjdk/jfx/commit/d9645730f1e76e95e0bb93ceaeb5550390bf95c1)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
This pull request has
This pull request contains a backport of commit
[d9645730](https://github.com/openjdk/jfx/commit/d9645730f1e76e95e0bb93ceaeb5550390bf95c1)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
-
Commit messages:
- Backport d9645730f1e76e95e0bb93ceaeb5550390bf95c1
On Thu, 22 Feb 2024 20:38:00 GMT, Nir Lisker wrote:
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
> `Material`). Except for the introduction, I divided the documentation into 3
> sections: qualitative explanation, mathematical model (I would
aya, UE4 and Unity and tried to mention the comparisons (like bump
> vs. height vs. normal maps, or specular vs. roughness/smoothness).
>
> The examples I chose and some of the schematics are not the best, looking at
> it retroactively, but I want to give enough time for reviewe
On Wed, 28 Feb 2024 18:24:30 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model
aya, UE4 and Unity and tried to mention the comparisons (like bump
> vs. height vs. normal maps, or specular vs. roughness/smoothness).
>
> The examples I chose and some of the schematics are not the best, looking at
> it retroactively, but I want to give enough time for reviewe
On Wed, 28 Feb 2024 14:21:55 GMT, Kevin Rushforth wrote:
> One other thing I noticed is that the file names have spaces in them, which
> is not a best practice and causes problems for scripts. Can you change all
> spaces to _ in the names of the newly-added files?
Yes. What about folders?
aya, UE4 and Unity and tried to mention the comparisons (like bump
> vs. height vs. normal maps, or specular vs. roughness/smoothness).
>
> The examples I chose and some of the schematics are not the best, looking at
> it retroactively, but I want to give enough time for reviewe
On Tue, 27 Feb 2024 12:13:09 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed typo
>
> modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMateri
On Tue, 27 Feb 2024 11:24:08 GMT, Ambarish Rapte wrote:
> PhongMaterial is not suitable for surfaces that reflect or refract the
> incident light.
But it does reflect the incident light as explained in the paragraphs before.
-
PR Review Comment:
On Tue, 27 Feb 2024 11:53:35 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed typo
>
> modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMateri
On Wed, 28 Feb 2024 13:50:38 GMT, Nir Lisker wrote:
>> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
>> `Material`). Except for the introduction, I divided the documentation into 3
>> sections: qualitative explanation, mathematical model
aya, UE4 and Unity and tried to mention the comparisons (like bump
> vs. height vs. normal maps, or specular vs. roughness/smoothness).
>
> The examples I chose and some of the schematics are not the best, looking at
> it retroactively, but I want to give enough time for reviewe
aya, UE4 and Unity and tried to mention the comparisons (like bump
> vs. height vs. normal maps, or specular vs. roughness/smoothness).
>
> The examples I chose and some of the schematics are not the best, looking at
> it retroactively, but I want to give enough time for reviewe
On Sat, 24 Feb 2024 09:53:01 GMT, Nir Lisker wrote:
> Backport of commit
> [b43c4edf](https://github.com/openjdk/jfx/commit/b43c4edf7590429fd051d1b0e2ccb6dd49a10b8b)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
This pull request has now been integrated.
aya, UE4 and Unity and tried to mention the comparisons (like bump
> vs. height vs. normal maps, or specular vs. roughness/smoothness).
>
> The examples I chose and some of the schematics are not the best, looking at
> it retroactively, but I want to give enough time for reviewe
aya, UE4 and Unity and tried to mention the comparisons (like bump
> vs. height vs. normal maps, or specular vs. roughness/smoothness).
>
> The examples I chose and some of the schematics are not the best, looking at
> it retroactively, but I want to give enough time for reviewe
Backport of commit
[b43c4edf](https://github.com/openjdk/jfx/commit/b43c4edf7590429fd051d1b0e2ccb6dd49a10b8b)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
-
Commit messages:
- Backport b43c4edf7590429fd051d1b0e2ccb6dd49a10b8b
Changes:
On Fri, 23 Feb 2024 17:46:20 GMT, Nir Lisker wrote:
> Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs in
> `Node` and `Scene`.
>
> Note that the default value for a `Scene`'s `NodeOrientation` depends on a
> system property, while for `Node` it isn
On Fri, 23 Feb 2024 17:46:20 GMT, Nir Lisker wrote:
> Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs in
> `Node` and `Scene`.
>
> Note that the default value for a `Scene`'s `NodeOrientation` depends on a
> system property, while for `Node` it isn
`Scene`). Not sure if this is intended.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1379/files
- new: https://git.openjdk.org/jfx/pull/1
On Fri, 23 Feb 2024 19:38:20 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/AnchorPane.java
>> line 187:
>>
>>> 185: * Returns the child's bottom anchor constraint, if set.
>>> 186: * @param child the child node of an anchor pane
>>> 187:
On Fri, 23 Feb 2024 19:44:06 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 6272:
>>
>>> 6270: * of text in both worlds.
>>> 6271: *
>>> 6272: * @defaultValue if the system property {@code
>>> javafx.scene.nodeOrientation.RTL} is
Hi all,
I don't use RT controls, so I can't comment about the specifics of this or
other implementations. However, people raised some good points that I would
like to be more specific about.
1. Can the "components" of the RTA be separated out so that other controls
can use them? For example,
Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs in
`Node` and `Scene`.
Note that the default value for a `Scene`'s `NodeOrientation` depends on a
system property, while for `Node` it isn't (which means `SubScene` will be
different from `Scene`). Not sure if this is
On Thu, 22 Feb 2024 23:07:21 GMT, Kevin Rushforth wrote:
>> Perhaps the contribution guidelines should mention what resources can be
>> included. In all other open source projects I worked on it was enough that
>> the resource wasn't licensed (or had something like
>>
On Thu, 22 Feb 2024 22:50:06 GMT, Andy Goryachev wrote:
>>> also, the first `+` is unnecessary
>>
>> I think it was done for uniformity with the other properties. I would use a
>> `StringJoiner` these days for such a task anyway.
>
> StringJoiner seems to provide little benefit for maps or
On Thu, 22 Feb 2024 22:42:18 GMT, Andy Goryachev wrote:
>> OK, it will be after the weekend when I can come back to this. Reviewers can
>> assume that only the background will change.
>
> sorry, Nir. ;-)
Perhaps the contribution guidelines should mention what resources can be
included. In
On Thu, 22 Feb 2024 22:20:56 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/paint/PhongMaterial.java
>> line 848:
>>
>>> 846: + ", specularPower=" + getSpecularPower() + ",
>>> diffus
On Thu, 22 Feb 2024 22:36:06 GMT, Kevin Rushforth wrote:
>> Do I only need to switch the ones in the introduction that show the
>> multiplication of the color and the map, or all of the new images that use
>> it as a background? The latter will be a lot of work.
>
> All of them, since they
On Thu, 22 Feb 2024 22:21:49 GMT, Kevin Rushforth wrote:
>> What would an approval require?
>
> To add to this, such approval would be unlikely, and I am not in favor of
> making the request. Perhaps you can find suitable images already in the repo?
> Here is one that might work:
>
>
aya, UE4 and Unity and tried to mention the comparisons (like bump
> vs. height vs. normal maps, or specular vs. roughness/smoothness).
>
> The examples I chose and some of the schematics are not the best, looking at
> it retroactively, but I want to give enough time for reviewe
On Thu, 22 Feb 2024 22:18:38 GMT, Andy Goryachev wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update copyright year
>
> modules/javafx.graphics/src/main/java/javafx/scene/paint/
On Thu, 22 Feb 2024 22:13:33 GMT, Kevin Rushforth wrote:
>> No, it's a standard in image processing: https://en.wikipedia.org/wiki/Lenna.
>
> But it's still third-party content and cannot go in without approval.
What would an approval require?
-
PR Review Comment:
On Thu, 22 Feb 2024 20:49:20 GMT, Andy Goryachev wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update copyright year
>
> modules/javafx.graphics/src/main/docs/javafx/scene/paint/doc-
aya, UE4 and Unity and tried to mention the comparisons (like bump
> vs. height vs. normal maps, or specular vs. roughness/smoothness).
>
> The examples I chose and some of the schematics are not the best, looking at
> it retroactively, but I want to give enough time for reviewe
On Thu, 22 Feb 2024 20:38:00 GMT, Nir Lisker wrote:
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
> `Material`). Except for the introduction, I divided the documentation into 3
> sections: qualitative explanation, mathematical model (I would
Overhaul to the `PhongMaterial` documentation (and a bit to its superclass
`Material`). Except for the introduction, I divided the documentation into 3
sections: qualitative explanation, mathematical model (I wouldn't think it
necessary, but the current doc explains it), and examples.
The
+1
On Sat, Feb 17, 2024, 15:37 John Hendrikx wrote:
> +1
>
> On 16/02/2024 23:11, Kevin Rushforth wrote:
> > All,
> >
> > Even though we build JavaFX binaries with JDK 21 as the boot JDK, the
> > latest version of JavaFX still runs with JDK 17, although it isn't
> > tested with older JDK
Hi,
I have a question after reading https://bugs.openjdk.org/browse/JDK-8294195.
If I have a class Chronus.java with a heading in its class javadoc:
Time
then an anchor Chronus.html#time-heading is auto-generated. How do I link
to this anchor from within the class using @see and @link? I have
You're thinking about the docs of the note in the bounds properties I think:
https://openjfx.io/javadoc/21/javafx.graphics/javafx/scene/Node.html#boundsInLocalProperty()
https://openjfx.io/javadoc/21/javafx.graphics/javafx/scene/Node.html#boundsInParentProperty()
On Fri, Feb 9, 2024, 03:28 John
On Fri, 9 Jun 2023 12:00:06 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
to
say that)?
Perhaps Kevin can weigh in.
The question of how to do it is simpler, and can be done with or without
breaking changes to StyleOrigin.
On Thu, Feb 1, 2024 at 2:27 AM John Hendrikx
wrote:
> Hi Nir,
>
> On 31/01/2024 22:36, Nir Lisker wrote:
> >
> > I would wait w
>
> Specialized methods will be added to `BooleanProperty`,
> `DoubleProperty`, `FloatProperty`, `IntegerProperty`, and
> `LongProperty`, each with one of the preexisting constant wrappers
> that are already in the framework.
> Some wrappers can be deduplicated (we only ever need two wrapper
>
Hi Armin,
If I go to https://gluonhq.com/products/javafx/ and filter to linux
aarch64, I see both SDK and JMODS for JavaFX 22-ea+16 (latest version,
which is early access). If you're talking about commercial support, I don't
know. Different companies choose what they support.
- Nir
On Tue, Jan
22+ea maven release, which is now almost
> 3 months old, does not contain the platform preferences API and also does
> not contain the kinda important css performance regression fixes.
> On 1/30/2024 1:33 PM, Nir Lisker wrote:
>
> Hi Christopher,
>
> Looking at Maven Central,
On Tue, 30 Jan 2024 12:08:41 GMT, Nir Lisker wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [c5ab220b](https://github.com/openjdk/jfx/commit/c5ab220bbc885f2aa99d8c1d5ed8f1753e39251f)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
Hi Christopher,
Looking at Maven Central,
https://mvnrepository.com/artifact/org.openjfx/javafx, JavaFX releases ea
builds there, which I sometimes use myself from Maven/Gradle. Version 21
had 6 ea versions, and 22 has 3. The release cycle is 6 months per final
version (aligned with OpenJDK).
-
Hi all,
This pull request contains a backport of commit
[c5ab220b](https://github.com/openjdk/jfx/commit/c5ab220bbc885f2aa99d8c1d5ed8f1753e39251f)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
The commit being backported was authored by Nir Lisker on 30 Jan 2024
On Fri, 26 Jan 2024 23:59:50 GMT, Nir Lisker wrote:
> Added a utility method to run code on the FX thread if it's not already, and
> changed the animation methods to use it.
This pull request has now been integrated.
Changeset: c5ab220b
Author: Nir Lisker
URL:
> Added a utility method to run code on the FX thread if it's not already, and
> changed the animation methods to use it.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Update tests
-
Changes:
- all:
On Mon, 29 Jan 2024 22:13:25 GMT, Kevin Rushforth wrote:
>> I don't think the executor service catches the exception because if it did
>> then the `AnimationTimer` test would also always pass. I do get the AIOOB
>> exceptions from the background thread caught in the handler (which fails the
On Mon, 29 Jan 2024 19:00:46 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update tests
>
> tests/system/src/test/java/test/com/sun/javafx/animation/Synch
> Added a utility method to run code on the FX thread if it's not already, and
> changed the animation methods to use it.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Use AtomicReferences
-
Changes:
- all:
On Mon, 29 Jan 2024 19:05:46 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update tests
>
> tests/system/src/test/java/test/com/sun/javafx/animation/Synch
> Added a utility method to run code on the FX thread if it's not already, and
> changed the animation methods to use it.
Nir Lisker has updated the pull request incrementally with two additional
commits since the last revision:
- Fix removed methods
- Correct methods i
1 - 100 of 1502 matches
Mail list logo
