On Fri, Aug 28, 2009 at 10:43 PM, Richard S. Hall <he...@ungoverned.org>wrote:
> On 8/28/09 16:30, Felix Meschberger wrote: > >> Hi Sten, >> >> Looks bascially good (files as appropriate have the license headers, MD5 >> checksum matches). >> >> Just two remarks: >> >> * The pom.xml should also have the license headers >> (this can probably be fixed when we import into SVN) >> >> * there is a runner folder containing scripts and the >> pax runner library. >> This should probably not be included, right ? >> (again, I think we can start the process and just omit >> this directory when importing into SVN) >> >> As part of the IP-process we also need an ICLA of you, Sten, on file. I >> see there is one for Sten Roger Sanvik with email s...@xbm.com. Am I >> correct to assume, that this is your ICLA ? >> >> Thanks again for your submission, I will now start the process of >> getting this into Felix SVN. >> >> > > Which will require Sten to fill out a Software Grant, which may need to > come from his employer if it is actually the employer who is contributing > the code. No, it does not need to be from my employer. Been coding this in my spare time. It has been used at Enonic (my current workplace) in form of some binaries. So a grant from Enonic is not neccessary. But will be happy to provide one if you really need it. > > > -> richard > > > Regards >> Felix >> >> >> Sten Roger Sandvik schrieb: >> >> >>> Attached the source in the jira task ( >>> https://issues.apache.org/jira/browse/FELIX-1456). Not sure on what >>> format >>> that the attachement should be, but created a tar.gz file. Attached a md5 >>> checksum for the package. >>> >>> On Fri, Aug 28, 2009 at 7:29 PM, Sten Roger Sandvik<s...@x3m.com> wrote: >>> >>> >>> >>>> On Fri, Aug 28, 2009 at 4:05 PM, Richard S. Hall<he...@ungoverned.org >>>> >wrote: >>>> >>>> >>>> >>>>> On 8/28/09 4:36, Felix Meschberger wrote: >>>>> >>>>> >>>>> >>>>>> Hi, >>>>>> >>>>>> Rob Walker schrieb: >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>> What do we need to do make this happen guys? >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> The next steps are IIRC the following: >>>>>> >>>>>> * Sten packages the source and attaches the package to >>>>>> the issue and publishes a package checksum. >>>>>> >>>>>> >>>>>> >>>>>> >>>>> I will add to this, removes any existing header/copyright notices from >>>>> the >>>>> files and adds the standard Apache header (see any Felix Java file). >>>>> Package >>>>> renaming is not necessary at this point. >>>>> >>>>> >>>>> >>>> Have added apache (2.0) on top of all files. Will now create a tarball >>>> and >>>> add it to the JIRA task. I'm also interested in getting committer rights >>>> so >>>> that I can still maintain the code. Will that be handled in a seperate >>>> vote? >>>> >>>> >>>> >>>> >>>>> * We vote on accepting this submission >>>>> >>>>> >>>>>> * We do the IP-clearance (filling out a form, >>>>>> sending a mail to incubator@ and wait for 72h) >>>>>> * Add the code into the SVN >>>>>> >>>>>> I think, we also need someone from the PMC to drive this process. >>>>>> >>>>>> Any volunteers (I could do it) ? >>>>>> >>>>>> >>>>>> >>>>>> >>>>> I am happy to have you do it. :-) >>>>> >>>>> Of course, I can help if needed. >>>>> >>>>> -> richard >>>>> >>>>> >>>>> Regards >>>>> >>>>> >>>>>> Felix >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>>> Sten - sounds like you've done a great job, kudos. >>>>>>> >>>>>>> Felix/Marcel - sounds like you guys are happy with the approach and >>>>>>> code >>>>>>> >>>>>>> >>>>>>> >>>>>>>> From our side, we can certainly run some "real world" compatibility >>>>>>>> >>>>>>>> >>>>>>> tests - which isn't to say in fact that Sten's new service would be >>>>>>> wrong and the current one right, just whether thenew version breaks >>>>>>> anything present in the exisiting service. If it does, I'm sure it'll >>>>>>> either be fixable, or something that's actually not correct in the >>>>>>> current service - so not a major issue. It'll be useful though to be >>>>>>> able to advise other Felix guys of anything that might differ and >>>>>>> need >>>>>>> application changes. I'm happy to make time to look at this next >>>>>>> week. >>>>>>> >>>>>>> After that - do we just call a vote? I'm guessing Sten, we also need >>>>>>> to >>>>>>> propose you as a committter for maintenance? >>>>>>> >>>>>>> Great progress though - the current Http service has served us pretty >>>>>>> well, but it's always been on the list to have cleaner and fuller >>>>>>> solution >>>>>>> >>>>>>> -- Rob >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>> >>> >>
